adrian

Getting OT, but does anyone know why $field doesn't have an addRole method, but $template does: https://processwire.com/api/ref/template/add-role/ Do we think this is a bug that needs reporting?

I went with the JS approach only to start with because I wanted the user to be able to see what the name is in realtime when they change the title of an already existing page - the same as we can when creating a new page. There are also other options like locking the name from being changed etc which I wanted to include in the module which also work best via JS. I only added the saveReady hook later when I realized that I also need to support title changes via the API (and also when the settings tab is hidden and the name isn't added to the content tab). As far as supporting EasySlugger, I think it can be done, but probably differently - maybe I just need to add a check to see if that module is installed and then also use the saveReady hook option rather than the JS one. Or maybe the EasySlugger module can just do that anyway, even after this module has done its thing? Not sure, but let me know what you need and I am happy to support it.

I'd be happy to, but I think the problem will be that this module mostly works with JS in realtime as the title is changed. The renameOnSave method that includes that line you referenced is only called by API changes to a page's title. So I guess I would also need to make sure renameOnSave is also called when the new EasySlugger module is installed and activated. Or are you thinking of some other approach to this that I am missing?

Yeah, I completely agree - it seems that VentureWeb always adds jQuery to their sites, but I rarely do. Let me check with them and see if they'd be willing to work with a non-jquery version. I have commit access to the Drupal version's repo, so if you or someone else would like to convert the PW version, I'd happily port those changes back to Drupal so things are easier going forward.

A little bit to make sure nothing appeared to be broken, but not thoroughly. You probably noticed from the JS that this module is very focused on GoogleTagManager, although you can still use it without GTM.

You know what - given that I am not really the author of this logic, I think it's just an easy for you to take a look yourself (in the js file) as it is for me to explain it ? Sorry if that seems lazy, but I don't really have time to maintain this module beyond bug fixes etc - I just want to make sure the PW community has access to it.

Looks good here:

A significant update: 1) new auto-accept mode 2) fixes an issue when in EU only mode but the user is outside the EU - GTM tracking beacon is now properly sent 3) tweaks to support older versions of jQuery. Please note that these changes are basically just a port of recent changes to the original Drupal version of the module so let me know if you notice any problems.

One branch is any page you choose and all its children, grandchildren, etc. It does not allow for giving a user access to multiple separate branches.

I'd say it will be a moderate amount of work to convert that PageTable>Repeater action to a Repeater>PageTable action. I don't have time to do this, but would be happy to accept a PR if you or someone else wants to do it.

The hard part is getting OPs to actually close issues when they are fixed and there is no ongoing discussion - if we could do that, then things would look quite a bit leaner in the Issues repo.

https://github.com/ryancramerdesign/LoginRegister/issues/10

I think that would be ok so long as it only happens if the thread is also quiet for those two weeks and also if it doesn't prevent the OP from re-opening. I think there are quite a few examples where there is ongoing discussion about further refinements to an issue even after that tag has been added.

Hey @bernhard - the issue with the num of children is still there, but it doesn't affect the ARB module because it only shows the one branch that the user is allowed to see. I don't think ARB is hacky - I think it's a good solution if it works for your use case. Some of the gists linked to in that post above however are a bit hacky - they don't handle lots of things (like search results) and also have the num children issue and also the problem of hiding a parent of a child that the user might actually have rights to.

Are you running the latest version of the PW Upgrades module? It looks like it is pointing to the old ryancramerdesign github repo.

AdminRestrictBranch (https://processwire.com/talk/topic/11499-admin-restrict-branch/) might actually suit your needs as it takes care of the page tree, search results - everything really.

Hi @netcarver - I very much appreciate where you are headed with this, but I am not sure I agree with automatically closing issues 3+months old (even those tagged with not a bug, or fixed) because there is often further discussion after tagging which I think warrants further input/consideration from Ryan. One example is: https://github.com/processwire/processwire-issues/issues/494 - others have chimed in with their agreement and I still consider it a bug because it's possible to set the description and notes for a fieldset. If Ryan doesn't think it's a bug, then I don't think it should be possible to set these in the first place, because it's current confusing and inconsistent behaviour. While I don't expect this will ever be high enough on his priorities to be fixed I still don't think it should be closed because I am convinced it's still something that needs attention, one way or the other. I think the best approach is to encourage issue OPs to be more diligent in closing fixed issues because with so many building up it becomes even harder for Ryan to reconsider some of these other ones which still have some validity. I hope that makes sense and doesn't seem obstructionist in moving forward with an improvement to the current situation which is obviously getting out of hand and not sustainable.

Thanks for your thoughts @wbmnfktr - not sure what I am going to do with it just yet, but if you feel like testing that branch in my fork, I think it's probably best to report issues on Github.

FYI - I just merged the 3.0 branch to master - be warned that this is a breaking change because of the new data_country db field so please don't update existing installs unless you're prepared to do some DB manipulation - if you want to and can't figure out the required SQL commands, let me know and I can post something here.

New version just committed that adds support for turning off autoloading of css and js assets files. It also fixes the strange issues that @wbmnfktr was having on some pages. It also adds a "pwcmb-active" class to the body of the page when the banner is displayed.

Just add the period in: echo "<option value='.".$sanitizer->alpha($subject->title, Sanitizer::translate)."'>{$subject->title}</option>"; This will result in: <option value='.mapsampgeo'>Maps &amp; Geo</option> Is this what you are looking for?

I think the issue is likely php 5.3 - is that the version you are using? Any chance you can upgrade? If not, let me know and I can make an adjustment to support 5.3

Thanks Ryan! While I think this is a great idea in principle, I can't honestly see any of my clients wanting to use this. I guess at least protecting superuser accounts will be a nice improvement. Does anyone else think this will be a hard sell to clients, or do you think they will be really keen to use it? Maybe I need different clients ?

Not sure if this is the issue or not, but in your selector for the Page Reference field please try adding: access=0

Honestly I haven't looked into it at all. As I mentioned in my first post, this module is converted from a Drupal one and so that JS file is almost unchanged from the Drupal version. Just taking a quick look now and I agree that it all looks like a pretty straight-forward conversion and given that I hardly ever use jQuery on my sites, I would welcome the change. That said, I don't have an immediate need for it at the moment so it won't be high on my list - do you feel like putting together a PR ? ? I am happy to implement this if it helps. I am curious though what scenario this is useful for - why do you prefer to manually inject them?