Jump to content

Ivan Gretsky

Members
  • Posts

    1,523
  • Joined

  • Last visited

  • Days Won

    16

Everything posted by Ivan Gretsky

  1. I am using Bookstack too for some docs. But I really do not think it should be used for community maintained docs for an open source project. Those should be open for commits from everyone. I think that VitePress or Docusaurus or Mkdocs or even some php static site generator. The docs are markdown in the repo and contributing is just a PR.
  2. Not so fluent with composer. So consulted the docs. Seems like composer update --with-all-dependencies will do it.
  3. What a twist!!!
  4. I have not tested the module with PR merged. Just seen it in the last moment before creating an issue in github repo about compatibility. I am waiting for @robert to share his thoughts on this. Maybe he is already in the process of working with your PR. Will ping him on github too.
  5. Good day, @robert! We have been using your module for a long time. Thank you for making it! We have even extended you classes for our own modules: a form on edit page to configure how the page has to be translated on save; a Lister action for mass transtlation. Now I have updated Fluency to a newer version (211). @FireWire has made a major rework. And you module no longer works. I have not examined the new Fluency's features. Maybe they already do all the things you wonderful module does... I see that the incompatibility has already been reported and @FireWire even created a PR (which seems to have issues and needs some work to be merged). Could you please look into this and update the module? If you find some time... 🙏
  6. Could you please explain why is this important and how do you use it?
  7. Good day @teppo and everybody ! This module is great! Is there a way to add a save button on the top of the slideover, not just in the end of the content. Just like in regular edit page?
  8. Seems to be a great module, @psy. Just maybe a video or some screenshots could make it easier to understand what exactly it does without installing?
  9. Good day everybody! I am trying to use wire404() in ready.php. The function throws an exception, but it is not caught with PW the standard way. The 404 page is not displayed but an error page is displayed instead. I guess that the hook to catch the exception is defined later in the request handling lifecycle. Am I right or is it something else? Can I somehow make PW catch this exception in ready.php? (in fact it doesn't work in template prepend file like _init.php either, but I need it earlier) If 2 cannot be achieved, what is a proper way to work this around and return a 404 page with 404 http code manually? Thanks in advance! P.S. The 4th of April was not so long ago so this might relate)))
  10. Sounds interesting! Can you share the hannacode? But I still need this module as I have projects with may too much content to fix)
  11. It seems like aspect ration auto-determination doesn't work. Created an issue. Can anyone confirm the bug? P.S. I started to doubt... Was it ever a feature? I was sure it was...
  12. Partials' overrides didn't work because of a typo. I think this PR fixes that.
  13. Big thanks for this, @teppo! This was supposed to be a New Year present judging by the date. I was away and could not receive it. Luckily we have an Old New Year here in Russia, so the present is still very much on time)))) I have quickly checked this new feature. Seems exactly what I was describing as the first option. It works great for template views. It didn't for Component views, but it seems I could fix it with this PR. I am not sure partials work ok yet. Will check later. What else should I check? I would love to have an option to configure Wireframe to not use default view files are used in case a prefixed version doesn't exist. This way it would be easier to find out what else should be overridden when creating themes. I guess the best thing would be to have 3 options here: Use default view files are used in case a prefixed version doesn't exist. Through an error in case a prefixed version doesn't exist. Output nothing in case a prefixed version doesn't exist. It would be great to have the second option from my OP one day, but this solves my current demands 100%. Really cool! Again, big thanks for this! I love the way you improve Wireframe taking our input into account. And it really amazing how we all can create the software together these days) We often take this for granted, but it is really a miracle looking at it from back in the days))
  14. @teppo, just in case you are in doubt what is that what you can gift to the world this New Year, I am quite sure the world will be delighted with the new Wireframe version with themes support)) Well, maybe not the whole world, but certainly some minor parts of it))) I do not know how do to say "happy upcoming New Year" in English or Suomi, so I'll put it here in Russian: "С наступающим!"
  15. The only one that comes to my mind is User Activity of ProDevTools suite. This is of course a Pro module, but it is the only one of the kind that I have worked with. I hope I understood right what you have been asking about)
  16. I have done this. Hope it will get some more deserved attention to PW. And this post is supposed to bring this pinned topic up in the recently updated list for those who, like myself, read the news there. And to get some more ⭐⭐⭐⭐⭐ for us on github)
  17. Good day, @kongondo! Have you managed to get it to work? P.S. I have managed to make it work both for web and cli. The only thing that I still cannot figure out is how to launch a specific php file (see an example without ddev below). Still can't find out how to start it not with php but with ddev exec php. { "name": "Launch test.php", "type": "php", "request": "launch", "program": "${workspaceFolder}/test.php", "cwd": "${workspaceFolder}", "port": 0, "runtimeArgs": [ "-dxdebug.start_with_request=yes" ], "env": { "XDEBUG_MODE": "debug,develop", "XDEBUG_CONFIG": "client_port=${port}" } } I have tries adding "runtimeExecutable": "ddev exec php", but it didn't work for some reason: Error: spawn ddev exec php ENOENT at ChildProcess._handle.onexit (node:internal/child_process:285:19) at onErrorNT (node:internal/child_process:483:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { errno: -2, code: 'ENOENT', syscall: 'spawn ddev exec php', path: 'ddev exec php', spawnargs: [ '-dxdebug.start_with_request=yes', '...', '...' ] }
  18. Thanks for an interesting perspective and for the commendation @Alexander! As you already mentioned your new open source thing, expand on it for everybody. We are in the Pub anyway))
  19. Ok. Now I got it better, I think. Now I have _init.php prepending wireframe.php that generates settings array, that I then pass to wireframe->render(). Some absolutely general settings I pass down with setting() function. If we had composers, we could move all my code in _init.php and wireframe.php to a dedicated class. Where would these composers be in places if file structure? How would we access data from them in views?
  20. (Deleted)
  21. Great! Looking forward to see it in Wireframe! Thanks for your work and talent!
  22. Yes. But I think there could be an option to either use parent's features or to indicate that this one is yet to be implemented in a theme (through an error or warning).
  23. I mean pull request in the module repo - https://github.com/kongondo/MenuBuilder/pulls Thanks for the code! I've seen it. But didn't try yet. A github pull request is just an easier way to deal with code change proposals.
  24. Great! Did you create a PR, so we can like it and make it easier for @kongondo to fix this for all of us?
  25. Good day @teppo! Another question from me) I am building a solution based on PW and Wireframe, that needs the theming functionality. That is switching theme (default views) for all the views and components. Layouts and partials probably too. Is there an easy way to achieve this with current code? Maybe a couple of hooks? I can see two ways how it could work. Put `alternative-default.php` everywhere the `default.php` files are and somehow tell Wireframe to use those prefixed files. If there is another view except the default one, the prefix should work as well. Like `alternative-json.php`. Probably an option should be available whether to fallback to defaults without the prefix or not. Create an overrides or theme folder somewhere and have somehow point Wireframe to use views from there. For my personal need the 1st approach seems to be a better one. But just maybe it is easy enough to provide possibility for both? Thanks!
×
×
  • Create New...