Map Marker Map

[BFD Calendar]

I would like the markers on my map link to the event page that features the location instead of the location page itself. The location is related to the event by the field 'bfd_events_places_id_list'. Tried this but it doesn't work....

	$features = $pages->find("parent=/events/ | /the-eyes/, bfd_month.name=$month, bfd_day.name=$day, sort=bfd_day, sort=bfd_year, sort=name");
	$markers = new PageArray();
	foreach($features as $feature) {
	$markers->add($feature->bfd_events_places_id_list); 
	}
	if ($markers && $feature->bfd_day) {
	$map = $modules->get('MarkupGoogleMap'); 
	$options = array('width' => '100%', 'height' => '500px', 'markerLinkField' => '$feature->url', 'markerTitleField' => '$feature->title');
	echo $map->render($markers, 'MapMarker', $options);
	}
	else {
	echo "";
	};

[lpa]

Thanks Soma! That is another problem that I had noticed but not tried to fix yet. My problem is still the one I wrote about in #156. The map doesn't resize and Ryan's example JS code doesn't fix it properly. Maybe it's something to do with loading the  content of the Foundation Reveal Modal with Ajax. 

I have still this problem. As I wrote, I use Foundation Reveal Modal with Ajax loading:

<a href='{$k->concertplace->url}' data-reveal-id='kpModal' data-reveal-ajax='true'>PLACE</a>
<div id='kpModal' class='reveal-modal large' data-reveal >
  <a class='close-reveal-modal'>×</a>
</div>

In concertplace.php I have:

$map->render($page, 'map')

And in main.js I have:

	$(document).on('opened', '[data-reveal]', function () {
	  setTimeout(function() {
	    google.maps.event.trigger(mgmap1, 'resize'); 
	    mgmap1.map.setCenter(mgmap1.options.center);
	  }, 350);  
	}); 	

The map still doesn't load properly. The other content of the Reveal Modal is ok. What should I test next?

[Martijn Geerts]

First of all I didn't use this module alot, last time I used it maybe a year ago.

What is the CSS position used in the modal when initialising the map ? If that's position absolute, it could be an issue that the map doesn't get a height or width from the container and thus not render properly. 

[Soma]

I would like the markers on my map link to the event page that features the location instead of the location page itself. The location is related to the event by the field 'bfd_events_places_id_list'. Tried this but it doesn't work....

$features = $pages->find("parent=/events/ | /the-eyes/, bfd_month.name=$month, bfd_day.name=$day, sort=bfd_day, sort=bfd_year, sort=name");	$markers = new PageArray();	foreach($features as $feature) {	$markers->add($feature->bfd_events_places_id_list); 	}	if ($markers && $feature->bfd_day) {	$map = $modules->get('MarkupGoogleMap'); 	$options = array('width' => '100%', 'height' => '500px', 'markerLinkField' => '$feature->url', 'markerTitleField' => '$feature->title');	echo $map->render($markers, 'MapMarker', $options);	}	else {	echo "";	};

What is bfd_events_places_id_list exactly? PageArray add doesn't work with ids it would have to be a page or PageArray. Also this && $feature->bfd_day in the if is strange as it would be the last from the previous foreach. So is the $feature->url in the $options...

[BFD Calendar]

Soma, 'bfd_events_places_id_list' is a field that relates to the page-id of a 'places' page. The 'places' page has fields for name, street, district, city, state, country and mapMarker. One 'place' can be related to several 'events'.

$placepage = $pages->get("template=bfd_places, id=$page->bfd_events_places_id_list");
echo "in {$placepage->bfd_places_name}, {$placepage->bfd_places_street}, {$placepage->bfd_places_city->title}, {$placepage->bfd_places_state->title}, {$placepage->bfd_places_country->title}."

The markers are also added to the map via the 'bfd_events_places_id_list' reference. They show up fine, the link however goes to the 'place' page. It would be better if the link goes to the 'event' page.

Where '&& $feature->bfd_day' comes from, uhm I don't remember....

I presumed '$feature->url' would be the url of the '$pages->find()' results, in the same way as the markers are added to the map.

[Soma]

Have hard time understanding your namings and relations and some of the code doesnt make sense to me imediately.

I dont know google maps marker module as i never used it yet but looking at the description of the markup module i think you have to specify the fields name in the option array and not a value like you do with $feature->url ... It would have to be the name of the field like 'url'. See https://github.com/ryancramerdesign/FieldtypeMapMarker/blob/master/MarkupGoogleMap.module#L73 you seem to misunderstand this, same as with the rss feed markup module.

As you dont give a field name the but a the url of the last item in your foreach loop i can imagine the markup module doesnt find it and gives url of the page.

Since i think you dont want the url of the page that you give to the markers via your page array but from one of your relation to another page, you would need a simple property hook to set that url to a new property (=field) for each page, that you can then give the name to the options array. Or since you already loop and add your pages to the markers page array you could set it right there.

So bfd_events_places_id_list is now what exactly? A page field? If its a single page field... The id in the name is confusing to me as it would be a Page object actually and not an id. Anyway. If it is a page field you could try using it to add a url to it on the fly.

$myentry = $feature->bfd_events_places_id_list;

$myentry->markerUrl = $feature->url; // or whatever url

$markers->add($myentry);

Then use that 'markerUrl' we added to the marker page in the options array...

'markerLinkField' = 'markerUrl'

[BFD Calendar]

Soma, I'm aware that my code is probably not conventional. A mashup of old html, snippets found on this forum and php according to the manual. Usually trial and error make it work, or not....

'bfd_events_places_id_list' is a single page field used on several 'events' page templates. The selectable pages are 'places' with several fields. The 'id' is a remainer of my database past where you needed a unique matching id to relate one table to another. In ProcessWire the id of the page is what I use to relate the information in the 'places' pages to an 'event' page.

"$markers->add($feature->bfd_events_places_id_list);" adds the markers alright. With an array of four events, there are four markers on the map and they point to the right location (markerLinkField and markerTitleField). This is what Ryan told me in this post. Since '$feature->bfd_events_places_id_list' adds the marker I'd think '$feature-url' would be the url of the 'event' page that holds the 'bfd_events_places_id_list' field, the page I want the marker to link to, and the page I want it's title to show up as markerTitleField.

But thank god your '$myentry' addition did the trick! The 'simple property hook' is something I still don't really get.... but a working sample should help me on the right path, thanks.

[Soma]

Don't be afraid of PW and its modules, hooks etc. They're worth learning and not really complicated if you grasp the concept, really. Compared to other systems this is fairly simple. I showed you an example of a property hook in the RSS markup thread remember? Also there's some infos on the forum or other resources that would help you understand (I think teppo's write up here is also good). And of course the HelloWorld.module that comes with default install shows exactly those simple hooks. Play around with it and be in awe!

[adrian]

Just wanted to point out to others that if you are using this (and the Map Markup module) along with zurb foundation (I am still testing, not convinced it's worth the bloat) and you come across an issue with the zoom controls looking not right, it is due to:

img {  max-width: 100%; }

I just added this to my site's css to override this and it seems fine again:

.gm-style img {   max-width: none; }

Hope that helps someone else out.

[lpa]

I have still this problem. As I wrote, I use Foundation Reveal Modal with Ajax loading:

<a href='{$k->concertplace->url}' data-reveal-id='kpModal' data-reveal-ajax='true'>PLACE</a>
<div id='kpModal' class='reveal-modal large' data-reveal >
  <a class='close-reveal-modal'>×</a>
</div>

In concertplace.php I have:

$map->render($page, 'map')

And in main.js I have:

	$(document).on('opened', '[data-reveal]', function () {
	  setTimeout(function() {
	    google.maps.event.trigger(mgmap1, 'resize'); 
	    mgmap1.map.setCenter(mgmap1.options.center);
	  }, 350);  
	}); 	

The map still doesn't load properly. The other content of the Reveal Modal is ok. What should I test next?

Finally I found a solution which kind of works: 

.reveal-modal {
    display:block !important;
}

[gebeer]

Hello all,

The map display used to work on my site, but now it is broken. You can see it here.

In Firebug I get: SyntaxError: unterminated string literal.

In my template I'm calling the map like this:

	$map = $modules->get('MarkupGoogleMap'); 
	echo $map->render($page, 'map', array('markerTitleField' => 'fulltext',
					      'height' => '400px',
					      'useHoverBox' => false,
					      'useMarkerSettings' => true,
					      'markerLinkField' => ''));

Looks like the string that comes from fulltext field causes the problem. This is a TinyMCE textarea field.

The rendered code looks like this:

<script type='text/javascript' src='/site/modules/FieldtypeMapMarker/MarkupGoogleMap.js'></script><div id='mgmap1' class='MarkupGoogleMap' style='width: 100%; height: 400px;'></div><script type='text/javascript'>if(typeof google === 'undefined' || typeof google.maps === 'undefined') { alert('MarkupGoogleMap Error: Please add the maps.googleapis.com script in your document head.'); } else { var mgmap1 = new MarkupGoogleMap(); mgmap1.setOption('zoom', 12); mgmap1.setOption('mapTypeId', google.maps.MapTypeId.ROADMAP); mgmap1.init('mgmap1', 49.926418, 10.875330); mgmap1.addMarker(49.926418, 10.875330, '', '<p><strong>Zahnarztpraxis</strong><br />
<strong>Dr. med. Gabriele Wunschik</strong></p>

<p>Bamberger Straße 33<br />
96103 Hallstadt</p>

<p>T: 0951/71 797<br />
F: 0951/97 10 438</p>

<p><a href="GOSPAM:ed.kihcsnuw-sixarptzranhaz@ofni"><span style="unicode-bidi:bidi-override; direction: rtl;" class="email-obfuscator-unreverse">ed.kihcsnuw-sixarptzranhaz@ofni</span></a></p>', ''); }</script>

The line breaks in the string seem to cause the problem. Javascript strings can't break across newlines without an escape (\)?

I have added this code to MarkupGoogleMap.js so I can display an Info Bubble:

        var infoBubbleContent = '<div class="infoBubble">' + title + '<br><a href="https://maps.google.com/maps?hq=dr.+gabriele+wunschik+zahnarzt+hallstadt&daddr=Bamberger+Stra%C3%9Fe+33,+96103+Hallstadt,+Germany&panel=1&f=d&fb=1&geocode=0,49.926427,10.875077&cid=17504796733665686542" target="_blank">Routenplaner<\/a>' + '</div>';

        var infoBubble = new InfoBubble({
          minWidth: 250,
          minHeight: 250,
          map: this.map,
          content: infoBubbleContent,
          position: latLng,
          shadowStyle: 1,
          padding: 10,
          backgroundColor: 'rgb(255,255,255)',
          borderRadius: 4,
          arrowSize: 50,
          borderWidth: 1,
          borderColor: '#cccccc',
          disableAutoPan: true,
          hideCloseButton: false,
          arrowPosition: 30,
          backgroundClassName: 'phoney',
          arrowStyle: 2
        });

        infoBubble.open(this.map, marker);

        google.maps.event.addListener(marker, 'click', function(e) {
            infoBubble.open(this.map, marker);
        });

How can I add the escape character to or remove the line breaks from the string in "title" variable in MarkupGoogleMap.js?

Any help would be much appreciated.

Gerhard

EDIT: OK, got it.

I first tried this in MarkupGoogleMap.js:

var infoBubbleContent = '<div class="infoBubble">' + title.replace(/\r?\n|\r/g,"") +...' + '</div>';

Wouldn't work.

Then I changed original line 204 in MarkupGoogleMap.module from

$title = $options['markerTitleField'] ? $page->get($options['markerTitleField']) : ''; 

to

$title = $options['markerTitleField'] ? preg_replace( "/\r|\n/", "", $page->get($options['markerTitleField']) ) : ''; 

This did it.

Is there any PW API method that I could use instead, like wire('sanitizer')?

[adrian]

Glad you got this sorted out! Just a thought - you might find: 

nl2br($page->get($options['markerTitleField'])

 better if you want to preserve those line breaks in the output.

[gebeer]

@adrian

thanks for the suggestion.

My string is coming from a TinyMCE textarea field, so it already has the required <br> and <p> tags. And I don't need to preserve the line breaks in my source code.

[alec]

Thanks to nghi's post in http://processwire.com/talk/topic/690-map-marker-fieldtype/page-9#entry50956  I have made Google map info window with image inside.I have changed Nghi's (and Ryans's, or Ryans's and Nghi's ) code in MarkupGoogleMap module like this:

	foreach($pageArray as $page) {
$marker = $page->get($fieldName); 
if(!$marker instanceof MapMarker) continue; 
if(!$marker->lat) continue; 
$url = $options['markerLinkField'] ? $page->get($options['markerLinkField']) : '';
$title = $options['markerTitleField'] ? $page->get($options['markerTitleField']) : ''; 
$images = $page->images->first->url ? $page->images->first->url  : '';
$phone_number = $page->phone_number ? $page->phone_number  : '';
$out .= "$id.addMarker($marker->lat, $marker->lng, '$url', '$title', '','$images','$phone_number'); ";
}

Where $page->images->first->url.... takes your first image from page where you have map field.

Second code that I changed is in MarkupGoogleMap.js, where I have add info window:

on line 96 I have add map_image to marker, which represent $images field.

this.addMarker = function(lat, lng, url, title, icon,  map_image, map_number) 

after, from line 122 i have comment, or you can delete this part of code. This part of code when marker is clicked directly goes to page. We dont need that for infobox, cause when marker is clicked infowindow needs to open.  

/**
		if(marker.linkURL.length > 0) {
			google.maps.event.addListener(marker, 'click', function(e) {
				window.location.href = marker.linkURL; 
			}); 
		}  */

next is infowindow code. I have add this part of code near line 130

// info window
		var contentString = '<div class=\"chapter-bubble\">' + 
                    '<div class=\"chapter-bubble-title\">' + title + '</div>' +
                    
					'<img width="200" src="' + map_image + '"/>' +
                    '<div class=\"chapter-bubble-number\">' + map_number + "</div>" +
                    '<div class=\"chapter-bubble-url\">' + '<a href=\"' + url + '\">Visit Chapter Site</a></div>';
      var infowindow = new google.maps.InfoWindow({ content: contentString });
      google.maps.event.addListener(marker, 'click', function() { infowindow.open(this.map,marker); }); 

it creates info window with our fields, here I have add image width 200px, "map_image" of course is our first image from page, that will be shown in infowindow.

This is minor change of Ryan's code, but it can be very useful, I have used it in my project, for infowindow. Of course, this can be implement in Info box also. 

Next thing that I need is custom icons for markers.  So if someone knows solution for marker icons please write here. 

P.S. Thanks Ryan and all comunity for this amazing CMF and quick response for all my questions I have asked.

[ZalnarT]

Hi there!

first of all, this is a great module Nevertheless, i was missing one little thing, and that was the possibility to style your map with a style from snazzy maps. So i tried to get it in there... 

I don't know if that's the right way, but it works:

in MarkupGoogleMap.module:

		$MapStyle = $options['mapStyle'];  // adding a field 'mapStyle'...
		
		$id = $options['id'];
		$out = '';

		if($n === 1) $out .= "<script type='text/javascript' src='{$this->config->urls->MarkupGoogleMap}MarkupGoogleMap.js'></script>";

		$out .= "<div id='$id' class='$options[class]'$style></div>";

		$out .= "<script type='text/javascript'>" .
			"if(typeof google === 'undefined' || typeof google.maps === 'undefined') { " . 
			"alert('MarkupGoogleMap Error: Please add the maps.googleapis.com script in your document head.'); " . 
			"} else { " . 
			"var $id = new MarkupGoogleMap(); " . 
			"$id.setOption('zoom', $zoom); " . 
			"$id.setOption('styles', $MapStyle); " .  // and outputting it here to the js.
			"$id.setOption('mapTypeId', google.maps.MapTypeId.$type); " . 
			($options['icon'] ? "$id.setIcon('$options[icon]'); " : "") . 
			($options['useHoverBox'] ? "$id.setHoverBox('" . str_replace("'", '"', $options['hoverBoxMarkup']) . "');" : "") . 
			"$id.init('$id', $lat, $lng); "; 

As i said, it works, but i'm not too sure if it's right. Also, i'd like to add the option to the admin panel, but i'm not too sure how...

[bwakad]

Just want to know if the map on a template file can fetch field values.

Example fields:

select_province

select_city

street

address from module becomes either:

A: select_province

B: select_province, select_city

C: select_province, select_city, street

Obviously this should then output the map.

[adrian]

Currently this isn't possible by default, but I like the idea of not having to populate address fields in two places. I have taken the other approach and parsed the address from the map's address field into the components I want for displaying on the site, but this has problems depending on how the address was entered if it's not consistent.

Thinking quickly, you could hook into page save and grab the contents of those address fields and use them to populate the map's address field. The problem is that the geocoding happens on blur of the address field, so that would need to be triggered in some other way in your module.

Something to think about anyway.

[bwakad]

fields: select_province, select_city

This code seems to work for the markers of pages, where address was filled in:

$items = $pages->find("template=basic-page, location_map!='', sort=title");

$map = $modules->get('MarkupGoogleMap');
echo $map->render($items, 'location_map');
 

Should there not be something for : $items = $page->get("???=select_province, location_map!='', sort=title");

Yes, I know it's wrong, just thinking out loud...

[bwakad]

I noticed in a topic on seblod, (gebeer) about this module - this code which should create a override in the template for the location, but how would this work for processwire. I am guessing that $cck would be $page, since it retrieves from the current page. There would probably also be some xml file present?

//from seblod topic
$strasse = $cck->get( 'yourstreetfield' )->value;
$plz = $cck->get( 'yourplzfield' )->value;
$ort = $cck->get( 'city' )->value;
$bundesland = $cck->get( 'province' )->value;
$land = $cck->get( 'impressum_land' )->value;
$address = $strasse.' '.$plz.' '.$ort;
$address = urlencode($address);
$request_url = "http://maps.googleapis.com/maps/api/geocode/xml?address=".$address."&sensor=true";
$xml = simplexml_load_file($request_url) or die("url not loading");
$status = $xml->status;
if ($status=="OK") {
$Lat = $xml->result->geometry->location->lat;
$Lon = $xml->result->geometry->location->lng;
$LatLng = "$Lat,$Lon";
echo $LatLng;
}

[Martijn Geerts]

@bwaked: Why are you  guessing that $cck would be $page ?

Go ahead, and go try for your self. ( This way you won't let other people work, and the result is: You learn a lot more. )

[bwakad]

Because $cck resides from seblod and $page (in template) is current page viewed.

I find the api a litle hard (learning php and PW), e.g. if I look at some code (even with a default install):

$page->get->fieldname

$page->fieldname

$str = wire('sanitizer')->selectorValue($page->title);

$out = "\n<ul class='skyscraper_images'>";

sometimes I see ->fieldname, and other times ('fieldname')

p.s.

Learning is asking, and get respons which helps -

Now, It's like getting a direction to school, but inside there are no teachers - and as such, no-one will learn.

[Martijn Geerts]

Sometimes students need homework, thats belongs to the lessons to.

[bwakad]

thats funny, but no homework without lessons - no lessons without teachers.

[Martijn Geerts]

Here's the homework

[antknight]

I am currently using the RCD map class by Ryan (see post 18 of this thread) which happily accepts anchor tags for the marker URL like so:

$js .= "\nRCDMap.addMarker('{$marker->title} ({$marker->parent->title})', '#{$marker->parent->title} {$marker->title}', {$marker->map_marker->lat}, {$marker->map_marker->lng});";

How do I achieve the same with MarkupGoogleMap as the markerLinkField only accepts a page field?

Thanks!

UPDATE: Managed to do it using http://modules.processwire.com/modules/fieldtype-concat/

Edited April 8, 2014 by antknight