Jump to content
adrian

Restrict Tab View

Recommended Posts

Hey @valan - sorry about that - it was a bug in Hide mode. I just committed a new version that should fix things for you.

  • Like 3

Share this post


Link to post
Share on other sites

@arjen: why don't just hide them using custom css and admincustomfiles module?

Hey Nico, sorry for responding late. Been on a long, long holiday. This is off course another option which I've used in the past too. Thanks for adding.

Share this post


Link to post
Share on other sites

@arjen: FYI and possible fix - since upgrade to PW 2.6.10 in some cases module throws error "Call to a member function attr() on a non-object (line 245 of /var/www/pw/wire/core/InputfieldWrapper.php)". Playing with settings I've mentioned that it happens when I check tab-children-hide for user that gets this error. There were major permission system updates in PW 2.6.10 so I guess new core may conflict with module somehow.

EDIT: Continued experiments and found that tab-settings-hide causes this error when trying to edit user page. Also tab-delete-hide does not function at user page. E.g. clearly there are some conflicts btw PW 2.6.10 and this module.

Share this post


Link to post
Share on other sites

@arjen: FYI and possible fix - since upgrade to PW 2.6.10 in some cases module throws error "Call to a member function attr() on a non-object (line 245 of /var/www/pw/wire/core/InputfieldWrapper.php)". Playing with settings I've mentioned that it happens when I check tab-children-hide for user that gets this error. There were major permission system updates in PW 2.6.10 so I guess new core may conflict with module somehow.

I assume this was directed at me, and not @arjen?

I am trying to replicate your issue here but can't at the moment. Just quickly, I am wondering if that might be a bug in InputfieldWrapper.php

Could you please try to replace that line 245:

} if($this->getChildByName($item->attr('name')) && $item->parent) {

with:

} elseif($this->getChildByName($item->attr('name')) && $item->parent) {

I am not sure this is the problem, but it's weird to me the styling Ryan has with the "if" starting on the same line as the closing curly brace, so I think it might be meant to be an "elseif".

Anyway, let me know if that fixes things - if not can you narrow down a particular setup that results in the new error.

Share this post


Link to post
Share on other sites

@adrian, ups, yes this is directed to you.)

Replaced, but it does not fix a problem.(

Particular setup:

- module is installed with checked Hide "children, settings, delete" in settings

- there is user X with role "content-editor".

- when role "content-editor" has only "tab-settings-hide" and "tab-delete-hide" permissions - everything is OK, e.g. no any tabs in the page (btw children tab is also hidden)

- when role "content-editor" has also "tab-children-hide" permission => error above

 
Again, this happened in PW 2.6.10 dev - could be either result of permission system changes or simply dev bugs... Anyway, looks like this code may not setup $fieldset in some cases:
 
        if($tab == "Settings" || $tab == "Children") {
            $fieldset = $form->find("id=ProcessPageEdit".$tab)->first();
        }
        else {
            $fieldset = $form->find("id=ProcessPageEdit".$tab);
        }

P.S. The same error is thrown in another scenario - when editing "user" page by different user/role. But now issue is with "tab-settings-hide" only...

P.S. Just idea - may be some tabs in some cases can't be found with $form->find? E.g. for example when user does not have access to add children (restricted at template level) then Children tab is not displayed. 

EDIT: Temporarily made quickfix after if-else block above: if (!is_object($fieldset)) return;

It prevents errors - module works as expected at all pages. Except "user" page - here "delete" tab does not disappear (while "tab-delete-hide is ON"), but "children" tab disappears ("tab-children-hide" is ON too).

  • Like 1

Share this post


Link to post
Share on other sites

@valan - thank you for helping to figure this out. I added your is_object check and also fixed the issue with the Delete tab not being hidden. 

Could you please try the new version and let me know if everything is working as expected?

Share this post


Link to post
Share on other sites

@adrian - this is to confirm that now it works as expected. Thank you for this module!

  • Like 1

Share this post


Link to post
Share on other sites

Module should add additional permissions automatically.

For most modules, I would agree with you, but this one potentially has 8 custom permissions. I think most users will probably only want the "tab-settings-view" or "tab-settings-hide" permission. I'd rather not pollute the permissions list with 7 additional unnecessary permissions if you are planning on only using one.

Do you see my point?

  • Like 3

Share this post


Link to post
Share on other sites

Maybe the "new" permission suggestion screen, which ryan implemented for the various optional core permissions, could also hold optional module permissions.

  • Like 3

Share this post


Link to post
Share on other sites

Not sure if this one is connected with the module directly, but still...

Is there an easy way to hide the Content tab if all the other tabs are disabled with permissions?

Share this post


Link to post
Share on other sites
1 hour ago, Ivan Gretsky said:

Not sure if this one is connected with the module directly, but still...

Is there an easy way to hide the Content tab if all the other tabs are disabled with permissions?

Hi Ivan - not sure I am understanding - do you want to hide all tabs, or do you have some custom fieldsettabs that would still be displayed? I could perhaps implement, but if it's a case of just not wanting a tab named "Content", don't forget that you can actually rename this.

Does that help, or am I not understanding your scenario?

Share this post


Link to post
Share on other sites

I got all tabs but Content turned off. So the lonely Content Tab seems unnecessary and confusing. I thought that it would be better to see no tabs at all when only one is present. I know I can rename it, but that hardly makes it look any better. I surely can live with this tab, just wanted to know if there is an easy workaround.

Share this post


Link to post
Share on other sites

So you want the fields from the content tab to still be there, just not the tab "button" (for want of a better description)?

That sounds more like a job for CustomAdminFiles or maybe a feature request for AOS?

This module hides entire tabs, including their content.

Am I on the right track now?

 

  • Like 1

Share this post


Link to post
Share on other sites
1 minute ago, PWaddict said:

I've just installed the module. Isn't possible to hide the children tab ONLY on a specific template?

Currently no, the module is designed for site-wide use, but you could extend it to have a template selector in the module config, or just steal the relevant code from the module and add it as a hook in your /site/ready.php file.

  • Like 1

Share this post


Link to post
Share on other sites
58 minutes ago, adrian said:

Currently no, the module is designed for site-wide use, but you could extend it to have a template selector in the module config, or just steal the relevant code from the module and add it as a hook in your /site/ready.php file.

Ok I hide the children tab on the template I wanted but now the order of tabs is changed on the other templates. It shows them in this order: Content, Settings, Delete, View, Children instead of Content, Children, Settings, Delete, View. I'm not sure how can I fix that.

Share this post


Link to post
Share on other sites
2 minutes ago, PWaddict said:

Ok I hide the children tab on the template I wanted but now the order of tabs is changed on the other templates. It shows them in this order: Content, Settings, Delete, View, Children instead of Content, Children, Settings, Delete, View. I'm not sure how can I fix that.

Can't really help without knowing exactly how you did the hiding :)

Share this post


Link to post
Share on other sites
2 minutes ago, adrian said:

Can't really help without knowing exactly how you did the hiding :)

Sorry you're right :)

I've edited the function removeTabs:

    public function removeTabs ($tab, $event) {

        $form = $event->return;
        $p = $event->object->getPage();

        if($p->template->name == 'mytemplatename' && $tab == "Children") {
            $fieldset = $form->find("id=ProcessPageEdit".$tab)->first();
        }
        else {
            $fieldset = $form->find("id=ProcessPageEdit".$tab);
        }

        $form->remove($fieldset);
        $event->object->removeTab("ProcessPageEdit".$tab);
    }

 

Share this post


Link to post
Share on other sites

I figured it out. I changed this function:

    public function afterBuildForm(HookEvent $event){

        if($this->user->isSuperuser()) return;

        $form = $event->return;

        foreach($this->data['viewTabs'] as $tab) {
            if(!$this->user->hasPermission("tab-".strtolower($tab)."-view")) {
                $this->removeTabs($tab, $event);
            }
        }

        foreach($this->data['hideTabs'] as $tab) {
            if($this->user->hasPermission("tab-".strtolower($tab)."-hide")) {
                $this->removeTabs($tab, $event);
            }
        }

        $event->return = $form;
    }

to this:

    public function afterBuildForm(HookEvent $event){

        if($this->user->isSuperuser()) return;

        $form = $event->return;
        $p = $event->object->getPage();

        foreach($this->data['viewTabs'] as $tab) {
            if(!$this->user->hasPermission("tab-".strtolower($tab)."-view")) {
                $this->removeTabs($tab, $event);
            }
        }

        foreach($this->data['hideTabs'] as $tab) {
            if($this->user->hasPermission("tab-".strtolower($tab)."-hide") && $p->template->name == 'mytemplatename') {
                $this->removeTabs($tab, $event);
            }
        }

        $event->return = $form;
    }

 

  • Like 1

Share this post


Link to post
Share on other sites

Nice work :)

Or you could try out the new version of the module which adds support in the config settings for restricting by template(s)

Screen Shot 2017-01-31 at 1.15.22 PM.png

  • Like 2

Share this post


Link to post
Share on other sites
5 minutes ago, adrian said:

Nice work :)

Or you could try out the new version of the module which adds support in the config settings for restricting by template(s)

Screen Shot 2017-01-31 at 1.15.22 PM.png

PERFECT :)

Share this post


Link to post
Share on other sites
2 hours ago, adrian said:

Currently no, the module is designed for site-wide use, but you could extend it to have a template selector...

Just wait for about an hour, and @adrian will extend it too :P 

Thank you, BTW!

  • Like 2

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Robin S
      A community member raised a question and I thought a new sanitizer method for the purpose would be useful, hence...
      Sanitizer Transliterate
      Adds a transliterate method to $sanitizer that performs character replacements as defined in the module config. The default character replacements are based on the defaults from InputfieldPageName, but with uppercase characters included too.
      Usage
      Install the Sanitizer Transliterate module.
      Customise the character replacements in the module config as needed.
      Use the sanitizer on strings like so:
      $transliterated_string = $sanitizer->transliterate($string);
       
      https://github.com/Toutouwai/SanitizerTransliterate
      https://modules.processwire.com/modules/sanitizer-transliterate/
       
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version to 2.10, add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "http://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


    • By thomasaull
      I created a little helper module to trigger a CI pipeline when your website has been changed. It's quite simple and works like this: As soon as you save a page the module sets a Boolean via a pages save after hook. Once a day via LazyCron the module checks if the Boolean is set and sends a POST Request to a configurable Webhook URL.
      Some ideas to extend this:
      make request type configurable (GET, POST) make the module trigger at a specified time (probably only possible with a server cronjob) trigger manually Anything else? If there's interest, I might put in some more functionality. Let me know what you're interested in. Until then, maybe it is useful for a couple of people 🙂
      Github Repo: https://github.com/thomasaull/CiTrigger
    • By Robin S
      I created this module a while ago and never got around to publicising it, but it has been outed in the latest PW Weekly so here goes the support thread...
      Unique Image Variations
      Ensures that all ImageSizer options and focus settings affect image variation filenames.

      Background
      When using methods that produce image variations such as Pageimage::size(), ProcessWire includes some of the ImageSizer settings (height, width, cropping location, etc) in the variation filename. This is useful so that if you change these settings in your size() call a new variation is generated and you see this variation on the front-end.
      However, ProcessWire does not include several of the other ImageSizer settings in the variation filename:
      upscaling cropping, when set to false or a blank string interlace sharpening quality hidpi quality focus (whether any saved focus area for an image should affect cropping) focus data (the top/left/zoom data for the focus area) This means that if you change any of these settings, either in $config->imageSizerOptions or in an $options array passed to a method like size(), and you already have variations at the requested size/crop, then ProcessWire will not create new variations and will continue to serve the old variations. In other words you won't see the effect of your changed ImageSizer options on the front-end until you delete the old variations.
      Features
      The Unique Image Variations module ensures that any changes to ImageSizer options and any changes to the focus area made in Page Edit are reflected in the variation filename, so new variations will always be generated and displayed on the front-end.
      Installation
      Install the Unique Image Variations module.
      In the module config, set the ImageSizer options that you want to include in image variation filenames.
      Warnings
      Installing the module (and keeping one or more of the options selected in the module config) will cause all existing image variations to be regenerated the next time they are requested. If you have an existing website with a large number of images you may not want the performance impact of that. The module is perhaps best suited to new sites where image variations have not yet been generated.
      Similarly, if you change the module config settings on an existing site then all image variations will be regenerated the next time they are requested.
      If you think you might want to change an ImageSizer option in the future (I'm thinking here primarily of options such as interlace that are typically set in $config->imageSizerOptions) and would not want that change to cause existing image variations to be regenerated then best to not include that option in the module config after you first install the module.
       
      https://github.com/Toutouwai/UniqueImageVariations
      https://modules.processwire.com/modules/unique-image-variations/
    • By Sebi
      I've created a small module which lets you define a timestamp after which a page should be accessible. In addition you can define a timestamp when the release should end and the page should not be accessable any more.
      ProcessWire-Module: http://modules.processwire.com/modules/page-access-releasetime/
      Github: https://github.com/Sebiworld/PageAccessReleasetime
      Usage
      PageAccessReleasetime can be installed like every other module in ProcessWire. Check the following guide for detailed information: How-To Install or Uninstall Modules
      After that, you will find checkboxes for activating the releasetime-fields at the settings-tab of each page. You don't need to add the fields to your templates manually.
      Check e.g. the checkbox "Activate Releasetime from?" and fill in a date in the future. The page will not be accessable for your users until the given date is reached.
      If you have $config->pagefileSecure = true, the module will protect files of unreleased pages as well.
      How it works
      This module hooks into Page::viewable to prevent users to access unreleased pages:
      public function hookPageViewable($event) { $page = $event->object; $viewable = $event->return; if($viewable){ // If the page would be viewable, additionally check Releasetime and User-Permission $viewable = $this->canUserSee($page); } $event->return = $viewable; } To prevent access to the files of unreleased pages, we hook into Page::isPublic and ProcessPageView::sendFile.
      public function hookPageIsPublic($e) { $page = $e->object; if($e->return && $this->isReleaseTimeSet($page)) { $e->return = false; } } The site/assets/files/ directory of pages, which isPublic() returns false, will get a '-' as prefix. This indicates ProcessWire (with activated $config->pagefileSecure) to check the file's permissions via PHP before delivering it to the client.
      The check wether a not-public file should be accessable happens in ProcessPageView::sendFile. We throw an 404 Exception if the current user must not see the file.
      public function hookProcessPageViewSendFile($e) { $page = $e->arguments[0]; if(!$this->canUserSee($page)) { throw new Wire404Exception('File not found'); } } Additionally we hook into ProcessPageEdit::buildForm to add the PageAccessReleasetime fields to each page and move them to the settings tab.
      Limitations
      In the current version, releasetime-protected pages will appear in wire('pages')->find() queries. If you want to display a list of pages, where pages could be releasetime-protected, you should double-check with $page->viewable() wether the page can be accessed. $page->viewable() returns false, if the page is not released yet.
      If you have an idea how unreleased pages can be filtered out of ProcessWire selector queries, feel free to write an issue, comment or make a pull request!
×
×
  • Create New...