module Jumplinks

[teppo]

2 hours ago, coxharrison said:

Since the launch I've been monitoring 404s in Google Analytics and we appear to getting quite a few (around 40 per week). What's odd is that the affected URLs all have jumplinks in places, and when I test them the redirects work perfectly fine. 

I can't see why Analytics would be picking these up but I'm quite concerned- if anyone as any insight it would be greatly appreciated.

This is very much a shot in the dark, but you don't happen to have anything in place that would skip PHP entirely? Jumplinks relies on a hook to the 404 request, so some sort of caching could be causing this.

Additionally I'd make sure that these requests actually land on the correct site. If you have the old site running somewhere, it could be a result of cached DNS entries or something along those lines.

[coxharrison]

Thanks for your reply Teppo. I passed this on to the project developer, and he has checked/ruled out what you suggested.  Please let me know if you have any other ideas?  We also enabled the Jumplinks 404 monitor and found that it isn't picking up the 404s that Analytics is recording... I can't think why there would be an inconsistency here.

[Mike Rockett]

@teppo - sure thing, will sort this out for you ?

Edited July 28, 2019 by Mike Rockett
Double posting (broken editor)

[Mike Rockett]

Aside: Is it me, or is this text editor broken? I've been battling to navigate using the arrow keys, it's double posting as adding replies on a the second last page doesn't take me to the last page, and deleting mentions and emojis is not working properly. Tested on FF and Chrome on Mac... Weird.

[Mike Rockett]

@coxharrison - Not entirely sure what's going on here. Would have thought it to be a caching issue as well… Second guess is a header problem (incorrect status code for some reason), but that doesn't make sense as the module hooks into the 404 event and throws a 301/302 if a jump is needed. Given that it's been half a month since your last post, is this still happening?

[Mike Rockett]

@teppo I've published Jumplinks on Packagist – please let me know if all's good :)

[Mike Rockett]

Oh, it's under rockett/jumplinks. Will update the opening post and readme as well.

[teppo]

Thanks @Mike Rockett, looks great so far – will test properly later ?

The editor has indeed been having some issues lately. Pete has been digging into this, and we're keeping an eye out in case an update is released that would take care of this.

[Mike Rockett]

You're welcome @teppo :)

Ah, good to know, thanks :)

[entschleunigung]

Thank you so much for the module. 

i'm just trying to get it to work and wonder if i missed something. i want to redirect pages from an existing installation (windows server, jumplinks 1.5.53) that have been moved in the tree.

example:

old url:
/en/product/teabag/

new url:
/en/brand/teabag/

(for the new url I chose the page id)

if i now create these jumplinks, i always end up on the home page. isn't that possible?
sorry, if the question has already been answered, i didn't find anything on the fast one.

thx

 

[Mike Rockett]

@entschleunigung To make sure that jumplinks is working, go into the module settings and turn on debug mode. When you hit the old URL, you should see a log from the module, showing what it's doing. Feel free to post that log here so we can take a look :)

[entschleunigung]

On 8/2/2019 at 6:31 PM, Mike Rockett said:

To make sure that jumplinks is working, go into the module settings and turn on debug mode. When you hit the old URL, you should see a log from the module, showing what it's doing. Feel free to post that log here so we can take a look ?

thank you very much for your reply. 
I don't think it was apparent from my previous post. in the meantime i read that this version does not supports a multilanguage setup. is that still correct?

thx 

[Mike Rockett]

@entschleunigung That's correct - it doesn't give consideration to multi language. That said, /en/old/page should throw a 404, and so the redirect should still take place...

[apeisa]

Hi @Mike Rockett

We are using this module on few client sites and it works great. There is one issue though: varchar 255 is too small for referrer field, we do get occasional: 

SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'referrer' at row 1 (in /site/assets/cache/FileCompiler/site/modules/ProcessJumplinks/ProcessJumplinks.module.php line 532

Any hope to get this fixed? (we will most probably update local databases to text).

[Mike Rockett]

Thanks @apeisa

I'll need to add in a schema update to change the column to text.

Really wish I could find the time to continue work on v2 – the minute I find a gap, something comes up. :|

[Mike Rockett]

I've pushed up to the master branch but won't release until I have an opportunity to test later this afternoon (SAST). :)

[Mike Rockett]

1.5.55 is released :)

[apeisa]

Thanks Mike!

unfortunately we jut found another issue like this:

Data too long for column 'request_uri' at row 1

So there is similar issue at least with request_uri also (not sure about other fields). Any possibility to get this fixed as well?

[teppo]

15 hours ago, apeisa said:

Thanks Mike!

unfortunately we jut found another issue like this:

Data too long for column 'request_uri' at row 1

So there is similar issue at least with request_uri also (not sure about other fields). Any possibility to get this fixed as well?

One more: I'm also seeing this error for the 'user_agent' column.

[Mike Rockett]

These columns are sorted in 1.5.56. However, instead of text, I've gone with varchar(512), which should be more than long enough. :)

[Mike Rockett]

@teppo - in regards to Jumplinks 2 and composer support: the module utilises several composer packages, which at present are kept in the vendor directory of the module, part of source control. Just to be 100% sure, if I were to drop this from source control, this would force users to install via composer? If so, I'd need to leave it in there, unless you know of another way ?

@all - I'm putting some time aside today to continue working on Jumplinks 2 – specifically frontend stuff. I'm cool with sticking to the usage of jQuery for the time being, though I imagine at some point I would move over to something like Svelte. No point in doing it now though, as pretty much all of the functionality I need (excluding bulk actions) has already been implemented.

On the topic of dependencies, I'm feeling inclined to push the minimum PHP version to the one that still has active security support, which at this point is PHP 7.1. In my experience, it's always been best to only support maintained versions of PHP. This also allows me to bump illuminate/database from 5.4 to 5.8 (I imagine there are a bunch of fixes). I don't know what the implications of this are in terms of the various hosting providers people use, but I'd be quite shocked if providers were only supporting unmaintained versions of PHP.

[Mike Rockett]

I'd also like to drop support for ProcessWire 2.8. Any objections?

[wbmnfktr]

4 minutes ago, Mike Rockett said:

this would force users to install via composer

Ooooh... That wouldn't work on about 99% of my client's hosting plans and even my hosting plans are limited in this point.

 

[Mike Rockett]

@wbmnfktr - Hence why I'm needing some more info – not sure if any additional composer support has been added. Would be great if I could trigger an install during module install from the UI. ?

[wbmnfktr]

Sure... but my composer knowledge is quite limited. All I know is how to install something with it. ? 
I guess @teppo has more knowledge here and maybe there is a solution or something.