Jump to content

Module: Image Extra


justb3a

Recommended Posts

@tekno: Like any other value: $image->orientation
 
For example:

$sidebar = "<img src='$image->url' alt='$image->description' class='$image->orientation' />";

outputs:

<img src="/site/assets/files/1/bigger-terminal.400x0.jpg" alt="We're gonna need a bigger terminal." class="left">
Link to comment
Share on other sites

It also works for just one image. If you allow more than one image in field settings you have to get the first image, iterate over or get one randomly. 

// $image = $page->images->getRandom();
// foreach ($page->images as $image) { ... }
$image = $page->images->first();

$sidebar = "<img src='$image->url' alt='$image->description' class='$image->orientation' />";
  • Like 1
Link to comment
Share on other sites

Thanks very much @justb3a for this module, a valuable addition to PW and looks ideal for solving a usability + presentation requirement I have :)

I can see from your blog page how to access the additional attributes via the API and have that working AOK in a template but for an image inserted in a textarea field that uses CkEditor do you know how I can get CkEditor or PW to output the extra attribute I have added? Thanks in advance for any pointers or help :)

Link to comment
Share on other sites

@justb3a

Sorry I never want to output extra attributes in CkEditor or similar. If you find a solution, please let me know.   :)

Thanks, I'm glad to know this facility is not something I missed :)

I will certainly let you know if I find a solution.

Link to comment
Share on other sites

  • 2 weeks later...

Great module, worked fine for me! But since a couple of days, for any reason, it doubles my costum image fields. Updated it to Version 0.0.3 but still the same problem. I dont know what happened. Maybe i did anything wrong? I didn't install any other module in the past days, as far as I know :D.

Here are some screenshots to show you what I mean:

http://www.directupload.net/file/d/4071/vtafnu3t_jpg.htm
http://www.directupload.net/file/d/4071/n592lj7s_jpg.htm  

        

Any ideas what could be wrong?

Thank you!

  • Like 1
Link to comment
Share on other sites

Great module, worked fine for me! But since a couple of days, for any reason, it doubles my costum image fields. Updated it to Version 0.0.3 but still the same problem. I dont know what happened. Maybe i did anything wrong? I didn't install any other module in the past days, as far as I know :D.

Here are some screenshots to show you what I mean:

http://www.directupload.net/file/d/4071/vtafnu3t_jpg.htm

http://www.directupload.net/file/d/4071/n592lj7s_jpg.htm  

        

Any ideas what could be wrong?

Thank you!

Okay, somehow there seems to be a problem with LanguageSupport and the german package, I uninstalled it and its working perfectly now. Could be a bug or I did anything wrong.

Link to comment
Share on other sites

  • 2 months later...

Hi @justb3a,

Just noticed a bit of a critical bug. If you remove one of the "Add other text input fields" the field/column is not removed from the DB. This results in a fatal error and the images uploaded to the field are lost. You have to manually edit the DB table to remove the fields to get things working again.

As a wishlist item, I'd love to see the ability to add select, radio, and checkbox fields as well as plain text :)

Link to comment
Share on other sites

Hi @adrian,

initially I decided to keep the fields/columns after removing so if you need them again your data/entries are still available. I tested it again right now without any problems. 

Scenario: image field containing 4 image extra text fields, adding some images, removing one text field, editing/adding/deleting images... everything works as expected. Any ideas? (ProcessWire 2.6.22, PHP 5.6.14)

Link to comment
Share on other sites

  • 2 weeks later...

Sorry for the delay in getting back to you regarding the error - I still need to look at this again, but for now I have a new problem for you :)

It looks like the Page Link option isn't working properly - it just shows a text input with "0" as the value.

post-985-0-74699000-1447329625_thumb.png

If I load "InputfieldPageListSelect.min.js" in the module, then it works as expected.

post-985-0-28869900-1447329642_thumb.png

Link to comment
Share on other sites

Another critical issue - when using an image extra field within a PageTable, the extra fields show up under the image and appear to be editable. You can make changes to the content of these fields, but of course they don't get saved when saving the main page which is very confusing for the user.

post-985-0-68439200-1447627272_thumb.png

  • Like 1
Link to comment
Share on other sites

Hi @adrian,

initially I decided to keep the fields/columns after removing so if you need them again your data/entries are still available. I tested it again right now without any problems. 

Scenario: image field containing 4 image extra text fields, adding some images, removing one text field, editing/adding/deleting images... everything works as expected. Any ideas? (ProcessWire 2.6.22, PHP 5.6.14)

Some more info on that error:

post-985-0-72466900-1447628132_thumb.png

The error is coming from PW itself because it looks like every DB field needs a value for the entry to be successfully saved. You should be able to replicate by removing one of the fields from the comma separated list of extra fields, or by simply uninstalling image extra and then trying to upload an image.

Link to comment
Share on other sites

Some more info on that error:

attachicon.gifScreen Shot 2015-11-16 at 8.54.52 AM.png

The error is coming from PW itself because it looks like every DB field needs a value for the entry to be successfully saved. You should be able to replicate by removing one of the fields from the comma separated list of extra fields, or by simply uninstalling image extra and then trying to upload an image.

I'm not able to reproduce this behaviour, I'll let the pictures speak for themselves:

  1. added 5 Image Extra fields, added images, filled content, saved
  2. removed 2 Image Extra fields
  3. added one more image
  4. saved page
  5. deinstalled module Image Extra
  6. edit page
  7. added another image, fill description
  8. save page

post-2759-0-64981300-1448018514_thumb.pn

Link to comment
Share on other sites

I don't know what to say about the issue with removing extra fields - I am continuing to get that error on different PW installs.
 
But now I have another issue for you. With ImageExtra installed and Maximum Files Allowed set to "1" when I go to upload a second image, the editor actually shows both images. After save, the first one disappears, but without ImageExtra, the second one instantly overwrites the first one. This has been confusing for our users - they think a second image has been uploaded rather than overwriting the first one. I hope you can reproduce at your end.
 
I wonder if it's a simple matter of incorporating some of the new code in: 
https://github.com/ryancramerdesign/ProcessWire/blob/980ce4f0be2054dfbad4a7b334d35bdca42da7da/wire/modules/Inputfield/InputfieldFile/InputfieldFile.module#L438

into your module at:

https://github.com/justonestep/processwire-imageextra/blob/master/ImageExtra.module#L540

 
Thanks!

Link to comment
Share on other sites

Sorry, I am on a bit of a roll - I really do love this module :)

I don't really understand the "Select the inputfields where the extra fields should be attached." option in the config settings. It lists all the different inputfield types, but the module only works with image field types. I actually tried to see if it works with InputfieldFile, but it didn't even work there. Am I missing something about this setting?

I think a more useful setting would be to control which image fields (the actual fields, not field types) that imageextra is attached to. At the moment the "Image Extra Fields" fieldset is added to the Input tab of all image fields, which I expect most developers don't need - they probably only want them for certain image fields. Does that make sense and sound like a good idea?

Thanks again :)

Link to comment
Share on other sites

@adrian: Could you please open an issue for each topic on Github?

The select field in module settings allows you to add these extra fields to other ImageFields (for example CroppableImage). I've never tested it with InputfieldFile but I think this should be supported as well.

There could be an additional select list to choose the fields (only list the fields with FieldTypes selected above) but I don't know if this is really necessary. Imagine you add another image field where you want to add extra fields, you had to go to module settings again and select the newly added field. If you don't need it for an image field, just don't touch the settings.  

  • Like 1
Link to comment
Share on other sites

  • 2 months later...

Hello,

How do you add "InputfieldPageListSelect.min.js" to the module to fix the 0 issue with the link field? 

Ive tried hooking into the "InputfieldPageListSelect::render" but couldnt get it to work.

  • Like 1
Link to comment
Share on other sites

Hello,

How do you add "InputfieldPageListSelect.min.js" to the module to fix the 0 issue with the link field? 

Ive tried hooking into the "InputfieldPageListSelect::render" but couldnt get it to work.

I think I just modified the ImageExtra module to add it there. Have a go and if you are still having trouble I'll take a closer look.

  • Like 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...