Jump to content
apeisa

Fredi - friendly frontend editing

Recommended Posts

@apeisa This module is fantastic!!  It makes editing so much easier.  Thank you.

I've been playing around with the various configuration options and have come across a problem, possibly because of the way my site is built.  I can get fredi working on pages that call in a header and footer but can't get it to work on my content blocks.  

For setup I have a page with header and footer that pulls in children as content blocks like so:

<?php foreach($page->children as $child) echo $child->render(); ?> 

I tried targeting the child pages using $pages->get in the template file but it doesn't seem to work.  I'm not sure if this is because the blocks have no header and footer or if it's because fredi can't find them.  

Is it possible to use fredi in this way or maybe to target the block template itself?

Share this post


Link to post
Share on other sites

@photoman I'm not sure if this is what you want, but here goes:

<?php

foreach($page->children as $child) {
    echo $fredi->render("all|the|fields|you|want", $child);
    echo $child->render();
}

?> 
  • Like 1

Share this post


Link to post
Share on other sites

Thanks diogo.  I tried your solution but I still can't get it to work.  When I add your code to the parent template file and view the result the page renders fine but there are no fredi links.  Here's the code I entered.

<?php
foreach($page->children as $child) {
    echo $fredi->render("body", $child);
    echo $child->render();
}
?> 

What I'd expect to happen is all the children that have a body field would be rendered with an edit link.  I tried various multiple field combinations but no joy.  I'm not quite sure why it's not working.  

For simplicity sake let's say one of the child templates was just this:


<div class="span4">
<?=$page->body?>
</div> 

What's the best way to work with fredi using the example above.  Does it need to be called from the parent page template or can it be initialised in the child template itself?

Share this post


Link to post
Share on other sites

$fredi should work from both, but it might be you need to load $fredi again ($fredi = $modules->get("Fredi")) in your child template.

<?php
$fredi = $modules->get("Fredi");
foreach($page->children as $child) {
    echo $fredi->render("body", $child);
    echo $child->render();
}

Code snippet above doesn't show edit links even for superuser? How about changing it to $fredi->body($child)?

  • Like 1

Share this post


Link to post
Share on other sites

Aha! That did it.  In the end I didn't need to write the code as above, all that's required is $fredi at the head of the child template like so:

<?php $fredi = $modules->get("Fredi");?>

Then just call as normal using 

$fredi->render("heading|body|etc");

Many thanks for your help apesia and for writing such a cool module  :)  

Share this post


Link to post
Share on other sites

@apesia I've been happily playing around with Fredi and have a small suggestion.  The echo $fredi->renderScript(); call is only required when the user is logged in but at the moment it's printed in the header regardless of whether the user is logged in or not.  

I know this won't have a massive impact on page load speed but it adds another 2 http requests which aren't really necessary.  Just a thought.

On a slightly different note I noticed that the admin field column widths are not reflected on the front end.  I'm not sure if this was on purpose to keep things responsive?

Here's what's missing:

class="InputfieldColumnWidth InputfieldColumnWidthFirst"   (These styles are in UI.css)

and also the inline style that defines the width in the backend eg "width:20%".    

Share this post


Link to post
Share on other sites

You can add some checking whether to load script & css yourself. I don't want to add that check there since that method is just a shortcut anyway.

There is some discussion about column widths earlier in this topic. In short: yes, they are intentionally left out just because ideally just few fields are used and original widths probably don't work in that case.

Oh, and thanks trying Fredi and thanks for your feedback! Highly appreciated.

Share this post


Link to post
Share on other sites

Thanks apeisa I didn't think of that.  For anyone else who's interested just add this to your header instead of the usual call.  Nice and simple. 

<?php $fredi = $modules->get("Fredi");
   if ($user->isLoggedin()) {
   echo $fredi->renderScript();
   };?>

Totally understand your reasons for making the column widths 100% as the original concept was about editing on a field by field basis.  My sites are built in blocks and I find myself grouping fields on a block by block basis as it's quicker for the client to edit and means I can output less edit links.  

It would be great to have the markup available to target with css even if it's not used in your default css file but either way I'm very happy.  So good to have fredi.

  • Like 1

Share this post


Link to post
Share on other sites

Just add ProcessFredi.css to your module folder and add any custom css you need.

Share this post


Link to post
Share on other sites

Hi apeisa.

Thank you for this plugin, works a treat. How hard do you think it would be to adapt CKEditors inline editing feature so we could literally just edit the page there and then and see exactly how the page would look in real time?

Regards,

Share this post


Link to post
Share on other sites

Thanks for the feedback madmax. I am not planning to take this into that direction. I think it would be better to have separate module for that.

Share this post


Link to post
Share on other sites

I found pretty rare bug from Fredi and I couldn't think of clear fix for it: https://github.com/apeisa/Fredi/issues/4

 

Page fields doesn't work, if custom php code used to find selectable pages

Problem seems to be with $page variable - it somehow doesn't respect it, it believes the $page is the modal Fredi Edit Process page instead of the context page.

How to replicate: edit page field and open "input" tab. Open "Custom PHP code to find selectable pages" and add something that uses $page. Like "return $page->parent->children;"


Now when you edit that field through Fredi you get totally different results than you would expect.

To be honest I don't have a clue why $page works when using normal ProcessPageEdit but not when using FrediProcess. Any help?

Share this post


Link to post
Share on other sites

Ah, I finally found it. This is why custom selector stuff fails on FrediProcess: https://github.com/ryancramerdesign/ProcessWire/blob/master/wire/modules/Inputfield/InputfieldPage/InputfieldPage.module#L141

I think cleanest option would be if getSelectablePages() method would be hookable. Any hopes to get three underscores there Ryan?

  • Like 2

Share this post


Link to post
Share on other sites

I have new version coming that introduces ability to create new pages. I would be extremely happy to get some feedback about the methods and arguments I am planning. Currently it works like this:

$fredi->newPage("templatename", "title|summary|body");

or

$fredi->newPage("templatename", "title|summary|body", $parentPage);

That would open new modal with title, summary and body fields. By default it creates new pages under the current page, but you can define alternative parent page there also.

I have also created ability to set fieldWidths, just add =XX to fieldname and it gives the width. Those can be used both in edit and new page modals. Like this:

$fredi->render("title|author=50|summary=50")

I want to take this further: defining required fields and also for new pages prevalues and possible hidden fields. This means that simple string based fields definition doesn't fly that far, or it needs some super nice syntax. Ideas?

  • Like 6

Share this post


Link to post
Share on other sites

I have new version coming that introduces ability to create new pages.

Fantastic! Can't wait to try it out. Do you plan to release it to GitHub in the next days?

Share this post


Link to post
Share on other sites

Not sure about next few days, but in week or two at least. Want to test it more here.

But so far - it seems to provide super nice editing interface.

  • Like 2

Share this post


Link to post
Share on other sites

Hi apeisa,

Fredi is fantastic! Thanks for sharing this. I've been using it with Chrome. I can't seem to get it to display the form in Safari though...(v6.0.4 on OS X).  

The modal shows up, and expands to the right size, but no form shows up - just the spinner. The form is there in the source code (within the iframe), but it isn't displayed. Maybe it could it be the z-index or maybe a source-order issue with the modal?

Thanks again!

Edit: forgot to mention - no javascript errors appear in the console

Share this post


Link to post
Share on other sites

Try updating the chrome. It was a bug with chrome version 25 and below I believe.

Share this post


Link to post
Share on other sites

Ah, sorry I read your message in hurry. I guess it's a bug with earlier webkit then. I'll take a look at it.

Share this post


Link to post
Share on other sites

I've come across an error which is stopping fredi working with images in repeater fields.  I'm not quite sure why it's happening but this seems to be on all my templates with repeaters that contain image upload fields.

As an example I have a carousel as a repeater (code below).  If the carousel is filled with images from the backend it works perfectly.  When I try to fill it with images using fredi on the frontend the edit modal pops up as expected and the "choose file" button for the field brings up my file explorer.  When I choose an image you can see that the image is trying to load but nothing happens.  

The strange thing is this only happens with images.  I have other repeaters that contain both images and text and the text can be edited with fredi, just not the images.

Is this a bug or do you have any suggestions to fix the error?

Here's an example of my setup:

Call fredi at the top of the template:

<?php $fredi = $modules->get("Fredi");?> 

Example of an image repeater I'm using:

<?php 
    foreach($page->sliders as $k => $slider) {		
    $active = ($k == 0) ? " active" : "";		
    $image = $slider->image_single->size(660,220);
    echo  "<div class='item {$active}'>
    <img class='photo' src='{$image->url}' alt='{$image->description}' />
    </div>";
}?> 

Call the fredi edit link at the bottom of the template:

<?php echo $fredi->render("sliders");?> 

Share this post


Link to post
Share on other sites

I think it is definitely fixable, although I have tried many things already. I might need Ryan's help there to find it out.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Process refunds and send customer notifications from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory (alpha version only available via GitHub) SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.60
      Composer: rockett/jumplinks
      ⚠️ NOTICE: 1.5.60 is an important security patch-release for an XSS vulnerability discovered by @phlp. It's HIGHLY RECOMMENDED that all Jumplinks users update to the latest version as soon as possible.
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! 🙂
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
×
×
  • Create New...