Jump to content


  • Content Count

  • Joined

  • Last visited

Community Reputation

93 Excellent

About titanium

  • Rank
    Sr. Member

Recent Profile Visitors

3,836 profile views
  1. Do you have to deal with animated image file formats that much? Google's WebP file size is on average25%-34% smaller compared to JPEG, see https://developers.google.com/speed/webp/docs/webp_study. But that doesn't mean it's always the format of choice. If GIF or APNG works better in some cases, nobody forces us to use WebP.
  2. Nice find! But I think it just cures the syndrome and to be honest, it's kind of dependency nightmare to create a generic css-file which patch problems of a certain module. The real pain is: ImageExtra does not pay attention to the new UIkit classes completely. I suggest the following: replace the $out in the method renderLinkItemField with: $out = '<div class="InputfieldImageEdit__additional--' . $name . '">' . '<label class="uk-form-label detail" for="' . $fieldName . '">' . $field->label . '</label>' . '<div class="InputfieldContent uk-form-controls" style="padding:0;">' . $field->render() . ' </div>' . '</div>'; Overall I think ImageExtra from @justb3a is still a great module, but it is somewhat dated and needs some love.
  3. This issue is solved, because the PR I submitted has now been accepted by @justb3a.
  4. I tried the latest version of this wonderful module today: I activated the module's config setting "Restrict from search results". After that, I logged in with a user who is restricted to a certain branch and tried to find some pages outside the restricted branch. I used the search box in the upper right corner of the PW admin and was surprised to see that results are found outside the restricted branch. The quoted sentence above is related to a search by Lister, I guess?
  5. Oh, I see, I wasn't precise enough. Sorry, I didn't think of that. I meant "Tracy with Force superusers into DEVELOPMENT mode activated instead of just "Tracy enabled". It's Tracy right out of the box (fresh install) with just "Force superusers into DEVELOPMENT mode" setting activated. The slowdown is more or less noticeable on all admin pages, "modules" was just a concrete example. But I do have to say I have some custom modules included in this project, so I will report back after I have done a vanilla install elsewhere and tested again. Thank you.
  6. I've written that already - with "Force superusers into DEVELOPMENT mode" activated, it takes nearly 6x times longer to load the modules page than without Tracy.
  7. Is it just me or has Tracy (current version) become very sloooow recently with the "Force superusers into DEVELOPMENT mode" setting activated? Benchmark - loading of the "modules" page: Tracy enabled: Loed 6.9 s Tracy disabled: Load 1.2 s Measured with Google Chrome Dev Tools. I don't remember noticing that before... 🤔
  8. @Zeka, thanks for the hint. I gave it a shot some minutes ago and it does not work either. I dived deeper now. /wire/core/Page.php contains a method $page->set($key, $value): case 'parent': case 'parent_id': if(is_object($value) && $value instanceof Page) { // ok $this->setParent($value); } else if($value && !$this->_parent && ($key == 'parent_id' || is_int($value) || (is_string($value) && ctype_digit("$value")))) { // store only parent ID so that parent is lazy loaded, // but only if parent hasn't already been previously loaded $this->_parent_id = (int) $value; } else if($value && (is_string($value) || is_int($value))) { $value = $this->_pages('get', $value); $this->setParent($value); } break; So there is definitely support for $page->set('parent', $id) here. Proof: the following works: $page->set('parent', 3); $page->save(); In the head of /wire/core/Page.php is a definition of $settings: /** * Page-specific settings which are either saved in pages table, or generated at runtime. * * @var array * */ protected $settings = array( 'id' => 0, 'name' => '', 'status' => 1, 'numChildren' => 0, 'sort' => -1, 'sortfield' => 'sort', 'modified_users_id' => 0, 'created_users_id' => 0, 'created' => 0, 'modified' => 0, 'published' => 0, ); I think 'parent' is missing here. I added it and tried again - now this works: $page->setAndSave('parent', 3); So I guess it's a bug.
  9. Thanks, @adrian. I always did what you described, but recently I wondered why $page->setAndSave('sort', 3); works, but $page->setAndSave('parent', 3); does not - both are native properties of the page. This seems somewhat equivalent to me, so they should behave the same, shouldn't they? But I'm not sure if I fully understand it. What I originally tried to achieve was to save the page with a maximum of performance, because I have to deal with a cron job which imports/changes thousands of pages. I guess I have to experiment with $page->save(['noFields' => true]). Any hints for optimized performance of page manipulation are welcome.
  10. I noticed that $page->setAndSave('parent', 1000); does not work. Reason is, that $page->save('parent') does not work either. In /wire/core/Page.php: public function save($field = null, array $options = array()) { if(is_array($field) && empty($options)) { $options = $field; $field = null; } if(!is_null($field)) { if($this->hasField($field)) { return $this->wire('pages')->saveField($this, $field, $options); } else if(is_string($field) && (isset($this->settings[$field]) || parent::get($field) !== null)) { $options['noFields'] = true; return $this->wire('pages')->save($this, $options); } else { return false; } } return $this->wire('pages')->save($this, $options); } "parent" is no field and no key in $this->settings[$field], so the functions must return false for $page->save('parent'). Possible keys in $this->settings[$field] seem to be: ["id"] ["name"] ["status"] ["numChildren"] ["sort"] ["sortfield"] ["modified_users_id"] ["created_users_id"] ["created"] ["modified"] ["published"] Why is parent missing here?
  11. Hi folks, I'm currently struggling with a client request. The client has created a lot of pages with employee profiles. Each profile has one or more email addresses assigned (currently this is accomplished by the ProFields Mutliplier module). Furthermore, there are content pages, which have a Repeater Matrix field. One repeater item is a page field which selects the employee profile. This works so far, but now the problem is: how can one of the email addresses of the profile be picked within the page field resp. repeater item? Only the email address which are assigned to the profile should be selectable. I haven't found an approach how to do this on the admin side yet and I'm grateful for any hints.
  12. You could try this setting in config.php: $config->defaultAdminTheme = 'AdminThemeUikit';
  13. Is there a property to set a "Return-Path:" which differentiates from the "From:" setting? At a first glance, I have found a method call $this->emailMessage->SetHeader('Return-Path', $address); inside WireMailSmtpAdaptor.php - I guess this can't be overridden individually?
  14. What you notice is the default behavior. I've never heard one of my users complain, but I think you have a point here. It would be better if this (just visually) "move" wouldn't take place. It's quite irritating and somewhat annoying one must reload the browser to be sure. I guess it's hard to fix, because the drag and drop move is made by JS, which isn't aware at that moment that some permissions shouldn't allow this.Maybe @ryan can re-think about it? I would be glad if you could fill in an issue report.
  • Create New...