Fredi - friendly frontend editing

[photoman355]

@apeisa This module is fantastic!!  It makes editing so much easier.  Thank you.

I've been playing around with the various configuration options and have come across a problem, possibly because of the way my site is built.  I can get fredi working on pages that call in a header and footer but can't get it to work on my content blocks.  

For setup I have a page with header and footer that pulls in children as content blocks like so:

<?php foreach($page->children as $child) echo $child->render(); ?> 

I tried targeting the child pages using $pages->get in the template file but it doesn't seem to work.  I'm not sure if this is because the blocks have no header and footer or if it's because fredi can't find them.  

Is it possible to use fredi in this way or maybe to target the block template itself?

[diogo]

@photoman I'm not sure if this is what you want, but here goes:

<?php

foreach($page->children as $child) {
    echo $fredi->render("all|the|fields|you|want", $child);
    echo $child->render();
}

?> 

[photoman355]

Thanks diogo.  I tried your solution but I still can't get it to work.  When I add your code to the parent template file and view the result the page renders fine but there are no fredi links.  Here's the code I entered.

<?php
foreach($page->children as $child) {
    echo $fredi->render("body", $child);
    echo $child->render();
}
?> 

What I'd expect to happen is all the children that have a body field would be rendered with an edit link.  I tried various multiple field combinations but no joy.  I'm not quite sure why it's not working.  

For simplicity sake let's say one of the child templates was just this:

<div class="span4">
<?=$page->body?>
</div> 

What's the best way to work with fredi using the example above.  Does it need to be called from the parent page template or can it be initialised in the child template itself?

[apeisa]

$fredi should work from both, but it might be you need to load $fredi again ($fredi = $modules->get("Fredi")) in your child template.

<?php
$fredi = $modules->get("Fredi");
foreach($page->children as $child) {
    echo $fredi->render("body", $child);
    echo $child->render();
}

Code snippet above doesn't show edit links even for superuser? How about changing it to $fredi->body($child)?

[photoman355]

Aha! That did it.  In the end I didn't need to write the code as above, all that's required is $fredi at the head of the child template like so:

<?php $fredi = $modules->get("Fredi");?>

Then just call as normal using 

$fredi->render("heading|body|etc");

Many thanks for your help apesia and for writing such a cool module    

[photoman355]

@apesia I've been happily playing around with Fredi and have a small suggestion.  The echo $fredi->renderScript(); call is only required when the user is logged in but at the moment it's printed in the header regardless of whether the user is logged in or not.  

I know this won't have a massive impact on page load speed but it adds another 2 http requests which aren't really necessary.  Just a thought.

On a slightly different note I noticed that the admin field column widths are not reflected on the front end.  I'm not sure if this was on purpose to keep things responsive?

Here's what's missing:

class="InputfieldColumnWidth InputfieldColumnWidthFirst"   (These styles are in UI.css)

and also the inline style that defines the width in the backend eg "width:20%".    

[apeisa]

You can add some checking whether to load script & css yourself. I don't want to add that check there since that method is just a shortcut anyway.

There is some discussion about column widths earlier in this topic. In short: yes, they are intentionally left out just because ideally just few fields are used and original widths probably don't work in that case.

Oh, and thanks trying Fredi and thanks for your feedback! Highly appreciated.

[photoman355]

Thanks apeisa I didn't think of that.  For anyone else who's interested just add this to your header instead of the usual call.  Nice and simple. 

<?php $fredi = $modules->get("Fredi");
   if ($user->isLoggedin()) {
   echo $fredi->renderScript();
   };?>

Totally understand your reasons for making the column widths 100% as the original concept was about editing on a field by field basis.  My sites are built in blocks and I find myself grouping fields on a block by block basis as it's quicker for the client to edit and means I can output less edit links.  

It would be great to have the markup available to target with css even if it's not used in your default css file but either way I'm very happy.  So good to have fredi.

[apeisa]

Just add ProcessFredi.css to your module folder and add any custom css you need.

[Sinmok]

Hi apeisa.

Thank you for this plugin, works a treat. How hard do you think it would be to adapt CKEditors inline editing feature so we could literally just edit the page there and then and see exactly how the page would look in real time?

Regards,

[apeisa]

Thanks for the feedback madmax. I am not planning to take this into that direction. I think it would be better to have separate module for that.

[apeisa]

I found pretty rare bug from Fredi and I couldn't think of clear fix for it: https://github.com/apeisa/Fredi/issues/4

 

Page fields doesn't work, if custom php code used to find selectable pages

Problem seems to be with $page variable - it somehow doesn't respect it, it believes the $page is the modal Fredi Edit Process page instead of the context page.

How to replicate: edit page field and open "input" tab. Open "Custom PHP code to find selectable pages" and add something that uses $page. Like "return $page->parent->children;"

Now when you edit that field through Fredi you get totally different results than you would expect.

To be honest I don't have a clue why $page works when using normal ProcessPageEdit but not when using FrediProcess. Any help?

[apeisa]

Ah, I finally found it. This is why custom selector stuff fails on FrediProcess: https://github.com/ryancramerdesign/ProcessWire/blob/master/wire/modules/Inputfield/InputfieldPage/InputfieldPage.module#L141

I think cleanest option would be if getSelectablePages() method would be hookable. Any hopes to get three underscores there Ryan?

[apeisa]

I see there are pretty big changes on that part coming on dev, and it is actually broken on normal page edit too. This addition fixes it on both (Fredi and PW admin): https://github.com/ryancramerdesign/ProcessWire/commit/fbe7c27e0b5f622ebe72b0f7dd05568a7685615c#L17R154

[apeisa]

I have new version coming that introduces ability to create new pages. I would be extremely happy to get some feedback about the methods and arguments I am planning. Currently it works like this:

$fredi->newPage("templatename", "title|summary|body");

or

$fredi->newPage("templatename", "title|summary|body", $parentPage);

That would open new modal with title, summary and body fields. By default it creates new pages under the current page, but you can define alternative parent page there also.

I have also created ability to set fieldWidths, just add =XX to fieldname and it gives the width. Those can be used both in edit and new page modals. Like this:

$fredi->render("title|author=50|summary=50")

I want to take this further: defining required fields and also for new pages prevalues and possible hidden fields. This means that simple string based fields definition doesn't fly that far, or it needs some super nice syntax. Ideas?

[titanium]

I have new version coming that introduces ability to create new pages.

Fantastic! Can't wait to try it out. Do you plan to release it to GitHub in the next days?

[apeisa]

Not sure about next few days, but in week or two at least. Want to test it more here.

But so far - it seems to provide super nice editing interface.

[bcartier]

Hi apeisa,

Fredi is fantastic! Thanks for sharing this. I've been using it with Chrome. I can't seem to get it to display the form in Safari though...(v6.0.4 on OS X).  

The modal shows up, and expands to the right size, but no form shows up - just the spinner. The form is there in the source code (within the iframe), but it isn't displayed. Maybe it could it be the z-index or maybe a source-order issue with the modal?

Thanks again!

Edit: forgot to mention - no javascript errors appear in the console

[apeisa]

Try updating the chrome. It was a bug with chrome version 25 and below I believe.

[bcartier]

It's actually Safari I'm having trouble with - Chrome is fine.

[apeisa]

Ah, sorry I read your message in hurry. I guess it's a bug with earlier webkit then. I'll take a look at it.

[photoman355]

I've come across an error which is stopping fredi working with images in repeater fields.  I'm not quite sure why it's happening but this seems to be on all my templates with repeaters that contain image upload fields.

As an example I have a carousel as a repeater (code below).  If the carousel is filled with images from the backend it works perfectly.  When I try to fill it with images using fredi on the frontend the edit modal pops up as expected and the "choose file" button for the field brings up my file explorer.  When I choose an image you can see that the image is trying to load but nothing happens.  

The strange thing is this only happens with images.  I have other repeaters that contain both images and text and the text can be edited with fredi, just not the images.

Is this a bug or do you have any suggestions to fix the error?

Here's an example of my setup:

Call fredi at the top of the template:

<?php $fredi = $modules->get("Fredi");?> 

Example of an image repeater I'm using:

<?php 
    foreach($page->sliders as $k => $slider) {		
    $active = ($k == 0) ? " active" : "";		
    $image = $slider->image_single->size(660,220);
    echo  "<div class='item {$active}'>
    <img class='photo' src='{$image->url}' alt='{$image->description}' />
    </div>";
}?> 

Call the fredi edit link at the bottom of the template:

<?php echo $fredi->render("sliders");?> 

[apeisa]

It's a known issue of Fredi. Sorry.

[photoman355]

Thanks apeisa.  I'm guessing it's quite a complicated issue.  Any plans to fix in a future update?

[apeisa]

I think it is definitely fixable, although I have tried many things already. I might need Ryan's help there to find it out.