Jump to content
horst

Croppable Image 3

Recommended Posts

3 hours ago, horst said:

@PWaddict

I may seem a little impatient now, but I still don't understand what you want after all your posts. Please just write down 2 or three variation names where I can see what is and what should be. Otherwise I cannot deal with it any further. (I have three deadlines this week!)

Ok on the Crop Settings of a "Croppable Image 3" field I have "thumbnail,1200,600" so when I upload an image to that field I'm getting the following files inside site/assets/files folder:

myimage.jpg (original)
myimage.0x260.jpg (original variation)

myimage.-thumbnail.jpg (crop)
myimage.-thumbnail.0x48n.jpg (crop variation)

All I want is the cropped images with the ".-thumbnail" to include a timestamp of their modification time (mtime) so the site/assets/files folder should contain ONLY the following files:

myimage.jpg (original)
myimage.0x260.jpg (original variation)

myimage.-thumbnail-1543078585.jpg (crop)
myimage.-thumbnail-1543078585.0x48n.jpg (crop variation)

Everytime the crop is modified the timestamp on the filename should renamed with the new one.

I hope you understand now.

Share this post


Link to post
Share on other sites

If you want to cache-busting the image, you may add the following to ready.php

$wire->addHookAfter('Pagefile::url', 'addTimeStamp');
$wire->addHookAfter('Pagefile::httpUrl', 'addTimeStamp');

function addTimeStamp($event){
	if($event->page->template == 'admin') return;

	$modified = $event->object->modified;
	$event->return = $event->return . "?v=$modified";

}

 

Share this post


Link to post
Share on other sites
56 minutes ago, Karl_T said:

If you want to cache-busting the image, you may add the following to ready.php

Query strings are no longer work on Facebook. Page url or filename must be renamed in order for Facebook to fetch the new image.

Share this post


Link to post
Share on other sites

@horst problem solved on renaming images by using "Custom Upload Names" module which does really good job with timestamps and also giving automatically better names in general.

Now about "Croppable Image 3" module today I noticed a "hidden" error on the cropping page if you have debug mode on and the image is inside repeater:

Quote

Notice: Only variables should be passed by reference in C:\xampp\htdocs\mysite\site\modules\CroppableImage3\ProcessCroppableImage3\ProcessCroppableImage3.module on line 67

Here is the screenshot with the "hidden" error:

issue.thumb.jpg.de2bd63ade54c0dcc48874f7d18f1b4d.jpg

  • Like 1

Share this post


Link to post
Share on other sites

@PWaddict

Good to hear that you solved together with adrian the timestamp issue, and thanks for reporting the Notice.
Please can you try if the following code solves it?
 

// replace the old lines 66 - 69 with this lines:
66        if(preg_match("/_repeater[0-9]+$/", $field)) {
67            $explodeArray = explode("_repeater", $field); 
68            $pages_id = intval(end($explodeArray));
69            $field = str_replace("_repeater{$pages_id}", '', $field);
70        } else {

 

Share this post


Link to post
Share on other sites
2 hours ago, horst said:

@PWaddict

Good to hear that you solved together with adrian the timestamp issue, and thanks for reporting the Notice.
Please can you try if the following code solves it?
 


// replace the old lines 66 - 69 with this lines:
66        if(preg_match("/_repeater[0-9]+$/", $field)) {
67            $explodeArray = explode("_repeater", $field); 
68            $pages_id = intval(end($explodeArray));
69            $field = str_replace("_repeater{$pages_id}", '', $field);
70        } else {

 

I'm getting "The process returned no content." with the error:

Quote

Notice: Undefined variable: fieldName in C:\xampp\htdocs\mysite\site\modules\CroppableImage3\ProcessCroppableImage3\ProcessCroppableImage3.module on line 99

 

  • Like 1

Share this post


Link to post
Share on other sites

Ok thanks for trying. It was a shot into the blue. I will setup a repeater field locally and debug it. (Maybe tomorrow) 

  • Like 1

Share this post


Link to post
Share on other sites

Hello, 

I have problem with this plugin. I did every step in intro (new filed with Croppable3, field assigned to template project, 4 crop settings with no template restrictions). When I try it on frontend I got

"Exception: There is no crop setting for the template 'project' called 'portrait'"

When I debug $inputFieldInstance->cropSetting on 202line of plugin, I got NULL. What is more interesting, in admin section debug outputs right settings (landscape,900,600 portrait .. etc). I am really desperate, maybe I am missing something? 

ProcessWire 3.0.62 - it's existing project..

I will grateful for any help! Thanks in advance 🙂

Share this post


Link to post
Share on other sites

Have you done a quick test with adding the templatename to the portrait-cropsetting? Does this behave different?

portrait,300,500,project

?

Share this post


Link to post
Share on other sites

I installed Croppable Image 3 yesterday and am currently trying to configure and install it in the template.

I have just on the page where directly the images are deposited this message.

Fatal error: Uncaught Error: Call to a member function getCrop() on boolean in /home/frawanbd/estate.frawal.net/site/templates/_main.php:92 Stack trace: #0 /home/frawanbd/estate.frawal.net/wire/core/TemplateFile.php(297): require() #1 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(380): ProcessWire\TemplateFile->___render() #2 /home/frawanbd/estate.frawal.net/wire/core/WireHooks.php(723): ProcessWire\Wire->_callMethod('___render', Array) #3 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(442): ProcessWire\WireHooks->runHooks(Object(ProcessWire\TemplateFile), 'render', Array) #4 /home/frawanbd/estate.frawal.net/wire/modules/PageRender.module(514): ProcessWire\Wire->__call('render', Array) #5 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(383): ProcessWire\PageRender->___renderPage(Object(ProcessWire\HookEvent)) #6 /home/frawanbd/estate.frawal.net/wire/core/WireHooks.php(723): ProcessWire\Wire->_callMethod('___renderPage', Array) #7 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(442): ProcessWire\WireHook in /home/frawanbd/estate.frawal.net/site/templates/_main.php on line 92

Schwerwiegender Fehler: Uncaught Error: Call to a member function getCrop() on boolean in /home/frawanbd/estate.frawal.net/site/templates/_main.php:92
Stack trace:
#0 /home/frawanbd/estate.frawal.net/wire/core/TemplateFile.php(297): require()
#1 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(380): ProcessWire\TemplateFile->___render()
#2 /home/frawanbd/estate.frawal.net/wire/core/WireHooks.php(723): ProcessWire\Wire->_callMethod('___render', Array)
#3 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(442): ProcessWire\WireHooks->runHooks(Object(ProcessWire\TemplateFile), 'render', Array)
#4 /home/frawanbd/estate.frawal.net/wire/modules/PageRender.module(514): ProcessWire\Wire->__call('render', Array)
#5 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(383): ProcessWire\PageRender->___renderPage(Object(ProcessWire\HookEvent))
#6 /home/frawanbd/estate.frawal.net/wire/core/WireHooks.php(723): ProcessWire\Wire->_callMethod('___renderPage', Array)
#7 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(442): ProcessWire\WireHook (Zeile 92 in /home/frawanbd/estate.frawal.net/site/templates/_main.php)

Diese Fehlermeldung wurde angezeigt wegen: Site ist im Debug-Modus. ($config->debug = true; => /site/config.php). Fehler wurde protokolliert.

On the start page I tried to install the pictures and there comes this message

Fehler: Exception: There is no crop setting for the template 'home' called 'square' (in /home/frawanbd/estate.frawal.net/site/modules/CroppableImage3/FieldtypeCroppableImage3/FieldtypeCroppableImage3.module line 209)

#0 /home/frawanbd/estate.frawal.net/wire/core/WireHooks.php(822): ProcessWire\FieldtypeCroppableImage3->getCrop(Object(ProcessWire\HookEvent))
#1 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(442): ProcessWire\WireHooks->runHooks(Object(ProcessWire\Pageimage), 'getCrop', Array)
#2 /home/frawanbd/estate.frawal.net/site/templates/_main.php(92): ProcessWire\Wire->__call('getCrop', Array)
#3 /home/frawanbd/estate.frawal.net/wire/core/TemplateFile.php(297): require('/home/frawanbd/...')
#4 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(380): ProcessWire\TemplateFile->___render()
#5 /home/frawanbd/estate.frawal.net/wire/core/WireHooks.php(723): ProcessWire\Wire->_callMethod('___render', Array)
#6 /home/frawanbd/estate.frawal.net/wire/core/Wire.php(442): ProcessWire\WireHooks->ru

Diese Fehlermeldung wurde angezeigt wegen: Site ist im Debug-Modus. ($config->debug = true; => /site/config.php). Fehler wurde protokolliert.

I currently have only one _main.php and I have taken the code from EXAMPLE there.

 

					<div class="gallery">
						<?php
							// get the first image instance of crop setting 'portrait'
							$image = $page->images->first()->getCrop('square');
							echo "<img src='{$image->url}' alt='{$image->description}' />";
						?>
					</div>

Config from Fieldtype:
image.png.e49efb23694a7a81041600ce190fcaf2.png

Share this post


Link to post
Share on other sites
3 hours ago, csaeum said:

Call to a member function getCrop() on boolean

in

3 hours ago, csaeum said:

/site/templates/_main.php:92

Here you call it on a var that is not a pageimage but a boolean! First check if you REALLY have an image, before you call ->getCrop() on it.

 

And which PW version and module version you are using?

Share this post


Link to post
Share on other sites

ProcessWire Core (Master)     ProcessWire master     3.0.123
Croppable Image 3 (Wrapper-Module)     CroppableImage3     1.1.16

Ok my mistake is solved.

My CPI3 Field was gallery and not images, this was the standard field in the PW demo

 

  • Like 1

Share this post


Link to post
Share on other sites

@horst, as mentioned here, it looks like your module is not compatible with the new WebP support added in 3.0.132. Or am I doing it wrong?

Share this post


Link to post
Share on other sites

When I try it, I get something like: 

Notice: Undefined index: _width in \wire\core\Pageimage.php on line 1936

Notice: Undefined index: _height in \wire\core\Pageimage.php on line 1937

These are the new additions from Ryan that I'm currently have not checked how it works, but definetly, if width and height isn't known, the engines cannot create a new variation.
I get this for image objects derived from CAI3 and with the original image too!

Possibly a bug in the new pageimage additions, or a different use case that currently is not covered.

  • Like 1

Share this post


Link to post
Share on other sites
Posted (edited)

Here is a first try with webp support: github webp-dev

!! ATTENTION: DO NOT USE ON PRODUCTION SITES !!

Maybe the cleaning up for unused variations is broken now. Haven't tested!

Also the naming scheme of CAI3->getCrop("suffix") has changed from 
    basename.-suffix.ext
to 
    basename.{width}x{height}-suffix.ext

Would be fine if some of you have time to test and report back in regard of:

  • removing no longer used variations,
  • changing values of already defined crop settings, (and if previously used variations get deleted, etc)
  • ...

Currently there has to be defined true in site/config.php for $config->imageSizerOptions("webpAdd", true);

Then you can use it like with core images:

    $image = $page->images->first->getCrop("suffix");
    echo "<img src='{$image->url}' /> <img src='{$image->webp->url}' />";

 

Edited by horst

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By teppo
      This module tracks changes, additions, removals etc. of public (as in "not under admin") pages of your site. Like it's name says, it doesn't attempt to be a version control system or anything like that - just a log of what's happened.
      At the moment it's still a work in progress and will most likely be a victim of many ruthless this-won't-work-let's-try-that-instead cycles, but I believe I've nailed basic functionality well enough to post it here.. so, once again, I'll be happy to hear any comments you folks can provide
      https://modules.processwire.com/modules/process-changelog/
      https://github.com/teppokoivula/ProcessChangelog
      How does it work?
      Exactly like it's (sort of) predecessor, Process Changelog actually consists of two modules: Process Changelog and Process Changelog Hooks. Hooks module exists only to serve main module by hooking into various functions within Pages class, collecting data of performed operations, refining it and keeping up a log of events in it's own custom database table (process_changelog.) Visible part is managed by Process Changelog, which provides users a (relatively) pretty view of the contents of said log table.
      How do you use it?
      When installed this module adds new page called Changelog under Admin > Setup which provides you with a table view of collected data and basic filtering tools See attached screenshots to get a general idea about what that page should look like after a while.
      For detailed installation instructions etc. see README.md.
       


    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2019-08-08
      2019-06-15
      2019-06-02
      2019-05-25
      If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      (please have a look at the screenshots to get an idea what I'm talking about)
       




    • By apeisa
      Update 31.7.2019: AdminBar is now maintained by @teppo. Modules directory entry has been updated, as well as the "grab the code" link below.
      ***
      Latest screencast: http://www.screencas...73-ab3ba1fea30c
      Grab the code: https://github.com/teppokoivula/AdminBar
      ***
      I put this Adminbar thingy (from here: http://processwire.c...topic,50.0.html) to modules section and to it's own topic.
      I recorded quick and messy screencast (really, my first screencast ever) to show what I have made so far. You can see it from here: http://www.screencas...18-1bc0d49841b4
      When the modal goes off, I click on the "dark side". I make it so fast on screencast, so it might seem a little bit confusing. Current way is, that you can edit, go back to see the site (without saving anything), continue editing and save. After that you still have the edit window, but if you click "dark side" after saving, then the whole page will be reloaded and you see new edits live.
      I am not sure if that is best way: there are some strengths in this thinking, but it is probably better that after saving there shouldn't be a possibility to continue editing. It might confuse because then if you make edits, click on dark side -> *page refresh* -> You lose your edits.
      ***
      When I get my "starting module" from Ryan, I will turn this into real module. Now I had to make some little tweaks to ProcessPageEdit.module (to keep modal after form submits). These probably won't hurt anything:
      if($this->redirectUrl) $this->session->redirect($this->redirectUrl); if(!empty($_GET['modal'])) $this->session->redirect("./?id={$this->page->id}&modal=true"); // NEW LINE else $this->session->redirect("./?id={$this->page->id}");   and...
      if(!empty($_GET['modal'])) { $form->attr('action', './?id=' . $this->id . '&modal=true'); } else { $form->attr('action', './?id=' . $this->id); // OLD LINE }  
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.54
      Composer: rockett/jumplinks
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! :)
×
×
  • Create New...