Jump to content

Recommended Posts

I am trying to implement Jumplinks on a new site but not sure what is happening, the 404 template is not even being fired. I dont think this is a bug with Jumplinks or ProcessWire to be honest, but wondering if any light could be shed on this.

If I go to /example.php, I get a page which just says 'File not found.' and nothing else. If I go to /example then the 404 template is fired. I have setup Jumplinks to try and change /example.php to go to /new-example but it is not kicking in.

Server configuration do you think?

A request to example.php should be caught by Jumplinks if the file or page doesn't exist. My dev installation is doing that. As such, there must be something wrong with your configuration.

How did you add the rule for redirecting example.php, with the leading slash?

From the description:

@Mike Rockett

Just used this module for the first time, it's great!! Thanks for your work :)

Cheers

Jumplinks automatically removes the leading slash. :)

And very glad you like it. Will be updating to 1.5 with a few new features soon.

Share this post


Link to post
Share on other sites

After several git conflicts (hey, I'm learning), 1.5 has been merged into master - I believe it is stable for production.

If you notice any bugs (or other like-minded creatures), please either mention here or submit an issue.

:D

  • Like 1

Share this post


Link to post
Share on other sites

Hey, Mike!

I am not sure if this is related to some other things we talked about before, but anyway... With jumplinks site.com/index.php gerts redirected to site.com. But site.com/index.php/something gets redirected to site.com/index.php.pwpj/something with 301 answer code.

Is there a way to make it throw 404 instead?

Share this post


Link to post
Share on other sites

Hey, Mike!

I am not sure if this is related to some other things we talked about before, but anyway... With jumplinks site.com/index.php gerts redirected to site.com. But site.com/index.php/something gets redirected to site.com/index.php.pwpj/something with 301 answer code.

Is there a way to make it throw 404 instead?

Jumplinks is designed to remove the index.php from URLs. As such, when you request /index.php, you'll be redirected to the root of the site. Additionally, it's designed to work with redirects like /index.php/MyOldPage.html by swapping out index.php for index.php.pwpj so it can check. If it doesn't do this, then developers wanting to strip index.php out of their old URLs would not be possible.

That said, this does appear to be a bug (well, more of an oversight on my part), which I will look into as soon as I get the chance. Requests like the one you've made should remain as-is, so that PW may throw a 404.

Thanks for picking that up! :)

  • Like 1

Share this post


Link to post
Share on other sites

Heads up: Per this post, I'm going to be moving the Jumplinks and SimpleForms repos over to their new home on Github. You'll notice there's also a new repo for Jumplinks' documentation - that's because I'm moving it out of the current wiki and into the new site, which will automatically sync with the repo to ensure all is up to date.

This will all happen within the next few hours, once I've figured out all the nitty-gritty's.

:)

Share this post


Link to post
Share on other sites

Hey, Mike!

I am not sure if this is related to some other things we talked about before, but anyway... With jumplinks site.com/index.php gerts redirected to site.com. But site.com/index.php/something gets redirected to site.com/index.php.pwpj/something with 301 answer code.

Is there a way to make it throw 404 instead?

Hey Ivan,

You are quite right about the previous discussion. Requests to /index.php/something will be seen as requests to the home page by processWire, unfortunately.

As such, the only solution I have for this is to create a new setting in the module's configuration that tells Jumplinks to not redirect /index.php requests to the root and not redirect /index.php/* requests to /index.php.pwpj/*.

Sound good to you?

  • Like 1

Share this post


Link to post
Share on other sites

I have gone ahead and add this to the dev branch. There's a new setting in the configuration called "Disable index.php matching", which you can enable to prevent these redirects.

Please review before I merge with master as 1.5.1. Thanks.

Share this post


Link to post
Share on other sites

It's a really nice documentation site - much appreciated.

  • Like 2

Share this post


Link to post
Share on other sites

It's a really nice documentation site - much appreciated.

I'll second that. Nice work on the new .pw domain :)

  • Like 1

Share this post


Link to post
Share on other sites

It's a really nice documentation site - much appreciated.

I'll second that. Nice work on the new .pw domain :)

Thanks guys. :) Yeah, figured I'd make use of the domain - at $2, it feels like a gift. ;)

  • Like 1

Share this post


Link to post
Share on other sites

Actually giving this index.php thing a bit of extra thought. Sites that used such routing were simply not configured to use htaccess, which is default in PW anyway. Surely all index.php/* requests should be stripped of index.php? Right now, the module only redirects index.php with or without the trailing slash. Whereas, if I tell it to strip the index.php out of all requests, such as /index.php/hello -> /hello, then a 404 would be thrown if the resulting destination isn't found.

To me, this makes more sense...

Feedback?

Edit: Also consider the fact that when you request index.php/hello, PW shows the home page... So no automatic 404 there anyway.

Share this post


Link to post
Share on other sites

As I understood you are proposing:

  1. First redirect urls like /index.php/hello to /hello,
  2. Then either let PW manage the routing (if /hallo exists, then just show it)...
  3. ...or rewdirect it with Jumplinks.

So in the module we will have to check option to strip out index.php and then create redirects like /hello -> /new-hallo. Am I getting you right?

Share this post


Link to post
Share on other sites

As I understood you are proposing:

  1. First redirect urls like /index.php/hello to /hello,
  2. Then either let PW manage the routing (if /hallo exists, then just show it)...
  3. ...or rewdirect it with Jumplinks.

So in the module we will have to check option to strip out index.php and then create redirects like /hello -> /new-hallo. Am I getting you right?

Well, I don't actually think there should be an option for it - should just happen automatically, because requesting index.php/hello does not throw a 404 by default. So yes, if you were to request index.php/hello, Jumplinks would redirect it to /hello, which would then be redirected to /new-hello if a jumplink was registered for it.

Share this post


Link to post
Share on other sites

Has anyone using Jumplinks experienced any issues with timestamps when using MySQL 5.7? I use MariaDB, and presently don't have access to MySQL 5.7, and so cannot test. As I understand it, strict mode is enabled by default in 5.7, and strict mode does not allow for zero-based timestamps.

This issue came up in Laravel recently, and the solution was to use the previously disallowed NULL timestamps.

On my end, with MariaDB 10.1.9, all appears to be working quite fine. For those running MySQL 5.7, please do let me know if you encounter any issues. If you do, we'll have to work on a schema update to figure out the best way to target all platforms.

Edit: I see that 5.7.8 reverts changes to be compatible with 5.6 (strict mode on). As 5.7.9 is a general availability release, I don't really see this being a problem. For those that do experience issues, the best bet is to allow zero dates or turn strict mode off (whichever comes first - not entirely sure on how the config there would work).

Share this post


Link to post
Share on other sites

Well, I don't actually think there should be an option for it - should just happen automatically, because requesting index.php/hello does not throw a 404 by default. So yes, if you were to request index.php/hello, Jumplinks would redirect it to /hello, which would then be redirected to /new-hello if a jumplink was registered for it.

Going to go ahead and implement this - I don't see any problems with it. If any come up, we can look at those when they do.

Share this post


Link to post
Share on other sites

Git is starting to irritate me. Something changed when they release Github Desktop, which replaced the old Github for Windows. Before, I could simply merge the dev branch with master, and everything would sync up perfectly. Now, when I do it with Desktop, it creates a new commit called "Merge remote-tracking branch 'refs/remotes/origin/dev'", which means that the dev branch will always be one commit behind master. I made the mistake of merging master back to dev, and it's gone and added another commit, leaving master one commit behind dev.

What on earth? Any way I can undo this mess? Delete dev and re-branch?

Share this post


Link to post
Share on other sites

Merges do (or at least should) always create an commit, but if there's nothing to merge (just new additions) the master branch can be fast-forwarded to the dev branch state without an commit. But most git apps I've used by now do fast-forward automatically if possible.

Share this post


Link to post
Share on other sites

Merges do (or at least should) always create an commit, but if there's nothing to merge (just new additions) the master branch can be fast-forwarded to the dev branch state without an commit. But most git apps I've used by now do fast-forward automatically if possible.

Thought I'd seen that term somewhere. Thing is, Github Desktop no longer fast-forwards, it creates a new commit. I do prefer the fast-forward method, and believe was actually doing it with Git GUI.

I take it there's no way I can revert this?

(Btw: I see that a fast-forward cannot be achieved if master has diverged from dev in a separate commit. However, that doesn't seem to be the case for me. It was an issue at one point, but then I had everything synced up so there was no divergence.)

(And forgive me; I'm not a git guru, so some things obviously baffle me... Getting to the point, however, where I just want to delete the repo and push a fresh one without history.)

Share this post


Link to post
Share on other sites

Hi, I just installed the latest version 1.5.1 on PW devns 3.0.3 (fresh install) and I got this warning

Failed to init module: ProcessJumplinks - SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'last_hit'

Share this post


Link to post
Share on other sites

Hi, I just installed the latest version 1.5.1 on PW devns 3.0.3 (fresh install) and I got this warning

Failed to init module: ProcessJumplinks - SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'last_hit'

Strange... I've just tried the same, and got no errors or warnings. Let me check the schema quickly.

Update: Schema appears to be correct. It first installs the tables, and then performs schema updates to those tables. last_hit is only added once. So, unable to reproduce here.

Share this post


Link to post
Share on other sites

Just a note to everyone, Jumplinks doesn't appear to be compatible with 3.0.3. I had it working on 3.0.1 and 3.0.2, but did not test with 3.0.3.

In the meantime, I'm dropping the PW3 compatibility tag until I am 100% certain everything works.

Scratch that. It is actually working. It was an error that appeared only once, and then disappeared. I believe it has something to do with namespacing or file compilation. Can't be sure as yet.

So support for current devns is there, just prepare yourself for the odd warning or error here and there (though, I don't think there will be many).

Edited by Mike Rockett
  • Like 1

Share this post


Link to post
Share on other sites

Yes I confirm, I uninstalled the module and reinstalled again and the error gone, sorry for that.

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By BitPoet
      As threatened in Ryan's announcement for 3.0.139, I built a little module for sliding toggles as a replacement for checkboxes. Styling of the input is CSS3 only (with all the usual caveats about older browsers), no JS necessary, and may still be a bit "rough around the edges", so to speak, since I didn't have much time for testing on different devices or brushing things up enough so I'd feel comfortable pushing it to the module directory. But here's the link to the GitHub repo for now:
      InputfieldSlideToggle
      Fieldtype and Inputfield that implements smartphone-style toggles as replacement for checkbox inputs. The visualization is CSS-only, no additional JS necessary.
      Status
      Still very alpha, use with caution!
      Features / Field Settings
      Size
      You can render the toggles in four different sizes: small, medium, large and extra large.
      Off Color
      Currently, "unchecked" toggles can be displayed either in grey (default) or red.
      On Color
      "Checked" toggles can be rendered in one of these colors: blue (default), black, green, grey, orange or red.
      Screenshots

      Some examples with checkbox label


      View all Size and Color Combinations
      Small toggles Medium toggles Big toggles Extra big toggles  









    • By Orkun
      Hi Guys
      I needed to add extended functionalities for the InputfieldDatetime Module (module is from processwire version 2.7.3) because of a Request of Customer.
      So I duplicated the module and placed it under /site/modules/.
      I have added 3 new Settings to the InputfieldDatetime Module.
      1. Day Restriction - Restrict different days based on weekdays selection (e.g. saturday, sunday) - WORKING

       
      2. Time Slots - Define Time slots based on custom Integer Value (max is 60 for 1 hour) - WORKING

       
      3. Time Range Rules per Weekday - Define a minTime and MaxTime per Weekday (e.g. Opening Hours of a Restaurant) - NOT WORKING PROPERLY

       
      The Problem
      Time Slots and Day Restriction working fine so far. But the Time Range Rules per Weekday doesn't work right.
      What should happen is, that when you click on a date, it should update the minTime and maxTime of the Time Select.
      But the change on the select only happens if you select a date 2 times or when you select a date 1 time and then close the datepicker and reopen it again.
      The time select doesn't get change when you select a date 1 time and don't close the picker.
      Here is the whole extended InputfieldDatetime Module.
      The Files that I have changed:
      InputfieldDatetime.module InputfieldDatetime.js jquery-ui-timepicker-addon.js (https://trentrichardson.com/examples/timepicker/) - updated it to the newest version, because minTime and maxTime Option was only available in the new version  
      Thats the Part of the JS that is not working correctly:
      if(datetimerules && datetimerules.length){ options.onSelect = function(date, inst) { var day = $(this).datetimepicker("getDate").getDay(); day = day.toString(); var mintime = $(this).attr('data-weekday'+day+'-mintime'); var maxtime = $(this).attr('data-weekday'+day+'-maxtime'); console.log("weekday: "+day); console.log("minTime: "+mintime); console.log("maxTime: "+maxtime); var optionsAll = $(this).datetimepicker( "option", "all" ); optionsAll.minTime = mintime; optionsAll.maxTime = maxtime; $(this).datetimepicker('destroy'); $(this).datetimepicker(optionsAll); $(this).datetimepicker('refresh'); //$.datepicker._selectDate($(this).attr("id"),date); //$.datepicker._base_getDateDatepicker(); // var inst = $.datepicker._getInst($(this)); // $.datepicker._updateDatepicker(inst); /*$(this).datetimepicker('destroy'); InputfieldDatetimeDatepicker($(this), mintime, maxtime); $(this).datetimepicker('refresh'); */ // $(this).datetimepicker('option', {minTime: mintime, maxTime: maxtime}); } } Can you have a look and find out what the Problem is?
      InputfieldDatetime.zip
       
      Kind Regards
      Orkun
    • By teppo
      This module tracks changes, additions, removals etc. of public (as in "not under admin") pages of your site. Like it's name says, it doesn't attempt to be a version control system or anything like that - just a log of what's happened.
      At the moment it's still a work in progress and will most likely be a victim of many ruthless this-won't-work-let's-try-that-instead cycles, but I believe I've nailed basic functionality well enough to post it here.. so, once again, I'll be happy to hear any comments you folks can provide
      https://modules.processwire.com/modules/process-changelog/
      https://github.com/teppokoivula/ProcessChangelog
      How does it work?
      Exactly like it's (sort of) predecessor, Process Changelog actually consists of two modules: Process Changelog and Process Changelog Hooks. Hooks module exists only to serve main module by hooking into various functions within Pages class, collecting data of performed operations, refining it and keeping up a log of events in it's own custom database table (process_changelog.) Visible part is managed by Process Changelog, which provides users a (relatively) pretty view of the contents of said log table.
      How do you use it?
      When installed this module adds new page called Changelog under Admin > Setup which provides you with a table view of collected data and basic filtering tools See attached screenshots to get a general idea about what that page should look like after a while.
      For detailed installation instructions etc. see README.md.
       


    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2019-08-08
      2019-06-15
      2019-06-02
      2019-05-25
      If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      (please have a look at the screenshots to get an idea what I'm talking about)
       




    • By apeisa
      Update 31.7.2019: AdminBar is now maintained by @teppo. Modules directory entry has been updated, as well as the "grab the code" link below.
      ***
      Latest screencast: http://www.screencas...73-ab3ba1fea30c
      Grab the code: https://github.com/teppokoivula/AdminBar
      ***
      I put this Adminbar thingy (from here: http://processwire.c...topic,50.0.html) to modules section and to it's own topic.
      I recorded quick and messy screencast (really, my first screencast ever) to show what I have made so far. You can see it from here: http://www.screencas...18-1bc0d49841b4
      When the modal goes off, I click on the "dark side". I make it so fast on screencast, so it might seem a little bit confusing. Current way is, that you can edit, go back to see the site (without saving anything), continue editing and save. After that you still have the edit window, but if you click "dark side" after saving, then the whole page will be reloaded and you see new edits live.
      I am not sure if that is best way: there are some strengths in this thinking, but it is probably better that after saving there shouldn't be a possibility to continue editing. It might confuse because then if you make edits, click on dark side -> *page refresh* -> You lose your edits.
      ***
      When I get my "starting module" from Ryan, I will turn this into real module. Now I had to make some little tweaks to ProcessPageEdit.module (to keep modal after form submits). These probably won't hurt anything:
      if($this->redirectUrl) $this->session->redirect($this->redirectUrl); if(!empty($_GET['modal'])) $this->session->redirect("./?id={$this->page->id}&modal=true"); // NEW LINE else $this->session->redirect("./?id={$this->page->id}");   and...
      if(!empty($_GET['modal'])) { $form->attr('action', './?id=' . $this->id . '&modal=true'); } else { $form->attr('action', './?id=' . $this->id); // OLD LINE }  
×
×
  • Create New...