Module: FieldtypeTime & InputfieldTime

[Zahari M.]

Selamat Pagi. Khabar baik tuan Steve!

Thanks for the reply!

Look forward to you figuring it out whenever your free next.

Till then...

Cheers!

 

[netcarver]

2 hours ago, Zahari Majini said:

Khabar baik tuan Steve!

Tuan? Saya?   Terimah Kasih, tetapi "Steve" cukup baik. 

</offtopic>

[netcarver]

@Zahari Majini Could you let me know...

1. which time format you are using for your input? (From the details tab of your time field.)
2. if you have the picker inhibited? (Look on the input tab of your time field.)

  

 

Thank you!

[Zahari M.]

Hi Steve

Time format is Hours (0-24) & minutes (00-59)

Picker is unchecked or not inhibited. Works fine on a regular page. Just not in a repeater matrix.

Terima kasih!

[netcarver]

@Zahari Majini

It appears to be the same issue as reported here. For now, you can work around it by changing the settings for your repeater matrix to the following...

Not the most satisfactory of results. Note, doesn't work well enough if you simply switch the Ajax option to off as the picker appears on all the fields as soon as you open the owning entry.

[Zahari M.]

Hi Steve!

Thanks so much for all the effort you have put into this!

I will check out the thread you linked to to learn more.

Many thanks again!

 

 

 

[netcarver]

@Zahari Majini

I've partially solved this on my local machine - but not 100% there yet. Will update the module once I have it working.

[netcarver]

@Zahari Majini

Could you give the code from the new dev branch a try, please. Just replace the existing files in your installation directory and include the new file: InputfieldTime.trigger.js

Thanks!

[Zahari M.]

Hi Steve

Thanks so much again for looking into this. Unfortunately after trying the dev version, i think it's made things worse. At least for me. The clock picker has now stopped working on both a "normal simple" page and within a repeater matrix. Replacing it with the previous main one restored back the clock picker on the "normal" page....

[netcarver]

@Zahari Majini

Ok, that's unexpected. My local install (3.0.36) has it working in normal contexts as well as repeater-matrix contexts. Did you overwrite the InputfieldTime.module file with the new one?

Any chance you can PM me login details to allow me to try and trace what is happening on your installation?

Regards, Steve

[Zahari M.]

Hi Steve

Actually the site is on local host in MAMP Pro.

I will upload it to a live site over the weekend and pass you the login details so you can have a dig!

But now that you mention it mine is 3.0.38. Hmmm. Will rollback too and see!

 

Cheers!

[Zahari M.]

Hi Steve

Have messaged you the details you asked for.

Many thanks mate!

[netcarver]

I just pushed fixes for the issue identified by @Zahari Majini

Please update to v0.2.0 or later if you want to use this field in repeaters.

[Zahari M.]

Thanks Steve!!

Fabulous module indeed!

Curious now... what were the jobs or the needs you had that made you make it?

[netcarver]

@Zahari Majini It was originally written as part of a scheduling system for a local Trampoline Club.

[FlorianA]

On 16.6.2015 at 0:18 AM, netcarver said:

@Beluga, @Juergen

Thanks for pressing me on this. I've just been testing this in PhpMyAdmin and there seems to be a problem with trying to set a blank value to MySQL time fields; MySQL itself sees the blank as an invalid time and sets it to '00:00:00'. There is some more detail about this in the MySQL Time type manual page. Here's a quote from the linked manual page...

You could setup your own test table with a TIME field and try it yourself. Please let me know if you find a workable solution and I'll try and work it into the module. At this point in time I'm not sure how to prevent PW from trying to save a blank value into the DB if nothing is entered in the Inputfield.

Why don't you insert a NULL value for the time if it's left blank? This should work perfectly with MySQL.

Apart from that, thanks a lot for the module, but the blank problem is also essential for me, so I really would appreciate a solution 

[FlorianA]

I've just extended FieldtypeTime and InputFieldTime by support for blank values   

Failed to add a push request to https://github.com/netcarver/PW-FieldtypeTime, so please find my patch attached ...

Works fine at me.

PW-FieldtypeTime-Empty-times.patch

[netcarver]

@FlorianA Sorry for the delay on this. I've been away from the keyboard over the summer holidays and must have missed the notification email from the forum about your post here.

Looking at this now.

[netcarver]

I've now merged FlorianA's patch into the allow-blanks branch. Please test and let me know if it works for you.

[ICF Church]

Hi @netcarver great module! Something I'm not sure how to do or if I missed the option: With date time fields from PW you get the option to format the output based on the language. Is this also possible with your plugin? Seems I can't find the option…

[Juergen]

On 28.9.2017 at 3:53 PM, netcarver said:

I've now merged FlorianA's patch into the allow-blanks branch. Please test and let me know if it works for you.

I am using it too and I have not detected any problems since then.

[adrian]

Hey @netcarver - using this for the first time - very handy, thank you!

Just wondering if the field should be blank by default, rather than 00:00:00 ? I want to check to see if a time has been entered, but the way things are, it doesn't seem possible. I am doing the check against 00:00:00 but of course that is a valid time (fortunately not one that anyone would enter in my case, but in some others in certainly would be).

Thanks.

EDIT: Oops, looks like @FlorianA is already on this  Anyway, looking forward to seeing that merged!

[adrian]

Actually, what do you guys @netcarver @FlorianA @bernhard think about putting 00:00:00 in the placeholder attribute - that way editors know what format to enter, but the value is still blank.

[netcarver]

@adrian

Thanks for the feedback - I like the idea. It needs a take account of the chosen time format (that's just one of the ones on offer), but this should be possible. Will see what I can do.

[cb2004]

Would be a welcome addition.