Jump to content

Email New User

adrian

By adrian,
in Modules/Plugins

 Share

Recommended Posts

adrian Hero Member

adrian

Posted
  • Author
Posted
Just now, jmartsch said:

Yes, I removed that line, but email is still not being sent.

I even set autoload to true in the settings file, but that changes nothing.

Don't know why the email is not sent

Is this site online? Can I take a look?

Link to comment
Share on other sites
dotnetic Hero Member

dotnetic

Posted
Posted

Hey Adrian, I spotted another bug.

If you go to the modules settings and check the "Generate Password" option, then after saving an error occurs: "Session: You need to have digits and at least one of the letter options checked."

Link to comment
Share on other sites
adrian Hero Member

adrian

Posted
  • Author
Posted
5 minutes ago, jmartsch said:

Hey Adrian, I spotted another bug.

If you go to the modules settings and check the "Generate Password" option, then after saving an error occurs: "Session: You need to have digits and at least one of the letter options checked."

Sorry about that - I wasn't seeing that because I had an older, updated install that already had those options stored in the settings database.

New version just committed fixes it.

Thanks again!

  • Like 2
Link to comment
Share on other sites
  • 1 month later...
szabesz Hero Member

szabesz

Posted
Posted

Hi Adrian, I have a question :) 

I implemented login via link base on @Ivan Gretsky's code snippet: https://processwire.com/talk/topic/13708-login-with-a-link-is-it-called-magic-link/?do=findComment&comment=155465

I'm also using your module so that the site manager creating the users in the admin does not have to send the very first email to the user manually. The module sends the email successfully but I have a two issues:

  • While http://example.com/?user={id}&token={login_token} is turned into the proper "link", hardcoding the protocol+domain is not a good idea and {adminUrl} is not what I need.
  • I also implemented a simple form asking for an email only. When submitted,  the login token is regenerated for the user (associated with that email) and an email is sent with the new login link in it. It would be great to be able to base these two emails (mail sent by this module and mail sent by my form) on the same template, meaning they should be identical without me implementing them twice.

My function to send the new link via email is dead simple: 

<?php
function site_email_user_login_info($login_user) {
    createLoginToken($login_user);
    $login_link = createLoginLink($login_user);
    $mail = wireMail();
    $mail->to($login_user->email);
    $mail->from('contact@example.com');
    $mail->subject('How to login...');
    $mail->bodyHTML("<html><body>
                        <h2>Some dummy header</h2>
                        <p>Some placeholder text. Blah-blah. Please click to login:</p>
                        <a href='{$login_link}'>{$login_link}</a>
                     </body></html>");
    $mail->send();
}

It is bodyHTML and the module's Email Massage which should be populated from the same source. Could you please give me some guidance on how to achieve this? Is it possible?

 

Link to comment
Share on other sites
adrian Hero Member

adrian

Posted
  • Author
Posted

Hi @szabesz - if I understand correctly, I think you could make use of this module instead of your custom site_email_user_login_info() function.

Via the API you can use: 

$u->sendEmail = true;

If you need to adjust the body of the email (both via admin and frontent/API), you can hook into: EmailNewUser:: parseBody - you could add your own logic for dynamically building the http://example.com/?user={id}&token={login_token} link without hardcoding anything.

https://processwire.com/talk/topic/7051-email-new-user/?do=findComment&comment=136252

Let me know how you go.

  • Like 1
Link to comment
Share on other sites
szabesz Hero Member

szabesz

Posted
Posted
3 hours ago, adrian said:

EmailNewUser:: parseBody

Thank you Adrian, this is what I need. I've long forgotten about it even though I did read your post.

I've just refactored my code to take advantage of it and everything works as expected, great module as always!

As for $u->sendEmail = true; I do not need it because my frontend form is not for creating new users but for sending an email to existing users. Why sending the same email? Because already registered users might have long forgotten how to login to the system so I want to send the same instructions no matter what. I will probably introduce a slight difference based on some simple logic but most part of the email body will be the same. For this reason I use the hook to completely overwrite $htmlBody which I find easier to implement than using str_replace and such to change something created in the RTE.

  • Like 1
Link to comment
Share on other sites
  • 4 months later...
Robin S Hero Member

Robin S

Posted
Posted

Hi @adrian,

My first time using this lovely module. A question and a couple of requests...

When editing/saving a user in admin, under what circumstances is an email sent if the "Automatic Email Send" option is checked? For existing users (who may have already been sent their welcome message) will an email be sent if nothing is changed but the user just saved? Silly me, I was trying to work it out from the code rather than just trying it out. I see now that the interface changes to "Re-send welcome message" after the first user save.

Request 1: It would be cool if there was an option in the module config to select key fields in the user template, where if any of those fields have changed the user is automatically sent an email. The obvious fields to trigger this would be "name" and "pass", but it would be nice to include custom fields too because in my case users log in with their email address. If other fields are changed no email would be sent. As I type this another thought occurs to me - maybe there could be different email templates for "new user" (password old value is blank) versus "modified user" (key field has changed)?

Request 2: How about a module config option for not showing the "Send welcome message" checkbox and the "Email message" CKEditor field in Edit User? In my scenario there are several different roles with different user-admin privileges. I'd rather take the decisions out of their hands whether or not to send an email and what the message will be.

  • Like 1
Link to comment
Share on other sites
adrian Hero Member

adrian

Posted
  • Author
Posted

Hi @Robin S

All the "Automatic Email Send" option does is check the "Send welcome message" option when creating a new user. It doesn't have any impact on existing users, but there is an option to "Resend Welcome Message" to an existing user. This will re-generate a new password if that option is selected.

As for your requests, unfortunately I just don't have time at the moment as those look relatively substantial, but they sound useful. I think "2" especially sounds like a good idea. I am not sure about "1" - it sounds like it might be beyond the scope of "Email New User", but I am happy to be convinced that it's a worthwhile addition.

There's realistically no chance of me getting to this until late May, but of course PRs are always greatly appreciated :) Sorry I can't help out in a reasonable timeframe on this one!

 

  • Like 1
Link to comment
Share on other sites
Robin S Hero Member

Robin S

Posted
Posted

Thanks @adrian, no worries. The needs of my current project are fairly specific/unique so I'm not sure yet whether I'll modify the Email New User module or make a new custom module. I'm sure your module will be a big help in either case, and if I do make some additions to Email New User that could be useful to others I'll certainly share them here.

  • Like 1
Link to comment
Share on other sites
teppo Hero Member

teppo

Posted
Posted
6 hours ago, Robin S said:

Request 1: It would be cool if there was an option in the module config to select key fields in the user template, where if any of those fields have changed the user is automatically sent an email.

Just chiming in to point out that this sounds like something that might be better solved by the Field Change Notifier module. I'm not sure what the state of said module is, and it doesn't currently seem to support selecting notified user based on the page being edited either, but perhaps it would be easier to adapt to this need? :)

  • Like 2
Link to comment
Share on other sites
Robin S Hero Member

Robin S

Posted
Posted

Hi @adrian, just a heads up:

I was again experiencing this issue that you raised in the PW issues repo a while ago: https://github.com/processwire/processwire-issues/issues/432

It was a bit puzzling but I traced it back to the Email New User module which I was testing out. Due to this commit the module is undoing the fix that was applied in the PW core.

  • Like 2
Link to comment
Share on other sites
Robin S Hero Member

Robin S

Posted
Posted
6 minutes ago, adrian said:

can you please explain exactly what is required to reproduce

The issue is exactly as you described it in the GitHub issue I linked to above. It is related to the browser autofilling the password field, so it depends on the form history that is saved in your browser. It's not the kind of thing that will always cause a problem, more one that can (but shouldn't) cause a problem. The fix that Ryan pushed to the core was to avoid that.

  • Like 1
Link to comment
Share on other sites
Robin S Hero Member

Robin S

Posted
Posted (edited)

@adrian, looking at the commit that introduced the issue, it looks like removing the autocomplete attribute is an attempt to defeat this piece of InputfieldPassword.js.

That piece of JS is a fairly old (and hacky) response to a browser-specific (Firefox) issue that probably no longer applies. The recent autofill fixes in InputfieldPassword and updates/bug-fixes to Firefox should have solved it without the need for that JS workaround (I tested quickly in the latest Firefox and couldn't see any issue with the JS removed). So you could raise a GitHub issue/request to see if Ryan will remove that JS.

In the custom module I made for a project recently I took a different approach to auto-generated passwords. Rather than populate the core password field I manipulated the ProcessUser form to...

1. Hide the password field with CSS

2. Add a markup field to show the user the auto-generated password

3. Add a hidden field containing the auto-generated password

Then in a before hook to InputfieldPassword::processInput I copy the password value from the hidden field to the password field in $input.

That may not be an approach you'd want to take with your module, but just to show there might be other ways to tackle things if Ryan doesn't want to remove that problematic JS.

Edited by Robin S
Corrected hook method to InputfieldPassword::processInput
  • Like 2
Link to comment
Share on other sites
adrian Hero Member

adrian

Posted
  • Author
Posted

Thanks for looking into this @Robin S - what actually caused @Torsten Baldes to make that recent change is this recent commit by Ryan: https://github.com/processwire/processwire/commit/ba21b28b4ec6cf4651a618561f8faa149497f7e4#diff-b49b5256779b14f5ffbe105307aa2be2

Everything in this module was working fine until that change in the PW core! Unfortunately I don't see Ryan removing that code because the change was to help fix a recently reported bug. Perhaps I can convince him to add an additional check though. What I have come up with that seems to work is to replace:

https://github.com/processwire/processwire/blob/184059b5d66a6ed8c739594d6b51d8d11f17d62d/wire/modules/Inputfield/InputfieldPassword/InputfieldPassword.js#L175 

if($(this).val().length < 1) return;

with: 

if($(this).val().length < 1 || $(this).attr('value').length > 0) return;

I am sure it's obvious, but what I am doing is checking the actual value attribute of the field at page load (rather than what is currently entered in the field). Now, if it's already populated (like Email New User does), it won't remove the password. This change means I can actually remove this hooked method entirely:

https://github.com/adrianbj/EmailNewUser/blob/a93ea9d73ef523f1abd19135516edd80ac4ebf37/EmailNewUser.module#L63-L65

Would you mind checking at your end to see if everything works as expected. If it does, I'll see if I can get Ryan to make that change.

@Torsten Baldes - could you please try this approach too please - I really need to revert your recent change ASAP as it's breaking things. Thanks!

  • Like 2
Link to comment
Share on other sites
Robin S Hero Member

Robin S

Posted
Posted
5 hours ago, adrian said:

This change means I can actually remove this hooked method entirely:

https://github.com/adrianbj/EmailNewUser/blob/a93ea9d73ef523f1abd19135516edd80ac4ebf37/EmailNewUser.module#L63-L65

Would you mind checking at your end to see if everything works as expected.

If the hook is removed then it will fix the issue I was seeing, because with the autocomplete attribute being on the password fields those fields aren't autofilled by Chrome.

So if the extra condition you added to the JS prevents your generated password from being cleared and you can therefore remove the hook then it will be all good from my end. I guess if/when Firefox autofills the password field it doesn't affect the value attribute? I can't test it here because I can't get Firefox to autofill the password field anyway (or I just don't know what steps are required to reproduce the issue on that browser).

  • Like 2
Link to comment
Share on other sites
adrian Hero Member

adrian

Posted
  • Author
Posted
3 hours ago, Robin S said:

I guess if/when Firefox autofills the password field it doesn't affect the value attribute?

From what I can see, the value attribute is not populated by autocomplete in any browser. Keep in mind that val() and attr('value') are very different things. 

Hopefully Ryan will see this: https://github.com/processwire/processwire-issues/issues/537#issuecomment-383411262 and be happy to implement.

  • Like 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share
Go to topic listing
×
×
  • Create New...