bernhard Posted May 23, 2019 Author Share Posted May 23, 2019 Important security update! Hi RockGrid users, I'm very sorry for that, but I have to announce a security update. If you are using RockGrid on a public site please upgrade to v0.0.22 (Fieldtype) immediately. It is a simple but important update: https://github.com/BernhardBaumrock/FieldtypeRockGrid/commit/0be2086139c84f775937246ed2985ac4c4a3e9c3; The proplem exists on all RockGrid fields with AJAX turned ON. In this case it was theoretically possible to expose the field data to a user that should not be allowed to see this data (in the worst case even a guest user) if the user knew how to do it and he also knew the name of the rockgrid field. The update now restricts access for AJAX field data to superusers only. You can easily adjust that via simple hooks: // rockgrid access control $wire->addHookAfter("InputfieldRockGrid::access", function(HookEvent $event) { // all grid data is accessible for all logged in users $event->return = $this->user->isLoggedin(); }); Or more granular via the fieldname: // rockgrid access control $wire->addHookAfter("InputfieldRockGrid::access", function(HookEvent $event) { $field = $event->arguments(0); $user = $this->user; $access = $event->return; switch($field) { case 'field1': case 'field2': case 'field3': $access = $user->isLoggedin(); break; case 'field4': $access = ($user->name == 'foo'); break; } $event->return = $access; }); Field 1-3 is allowed for logged in users, field4 only for user foo and all other fields only for superusers (default rule). I'm not totally happy any more with several aspects of RockFinder and RockGrid, but it is the best option I have so far (until I can build something totally new, maybe with tabulator if tests work well). Special thx to @Zeka for bringing this issue to my attention by coincidence in the other topic! 6 2 Link to comment Share on other sites More sharing options...
Beluga Posted May 25, 2019 Share Posted May 25, 2019 I am trying to figure out how to join pages from two templates into a grid. I will attach a picture of an incorrect result just as a talking point: The goal would be to plonk the data from unive into the grid, with rows filled only when code and number match the ones in the main (A-T) grid. The incorrectly repeating result in the screenshot was reached with this: $finder1 = new RockFinder('template=A-T', ['code', 'nb', 'variation', 'name']); $finder2 = new RockFinder('template=unive3', ['code', 'nb', 'proverbtype']); // join finder $finder1->join($finder2, 'unive', ['code' => 'code']); $this->setData($finder1); So how can I match by two fields to get what I want? Link to comment Share on other sites More sharing options...
bernhard Posted May 25, 2019 Author Share Posted May 25, 2019 Hi Beluga, is this a tabulator grid? Is it a custom module or the rockgrid extension you've linked some time ago? Regarding your join: I think in that case it would be the easiest to join them via plain sql; Something like $foo = $finder1->getSQL(); $bar = $finder2->getSQL(); $sql = "SELECT * FROM ($foo) AS foo LEFT JOIN ($bar) as bar ON (foo.col1 = bar.col1 AND foo.col2 = bar.col2)"; $this->setData($sql); PS: Be careful when joining / listing tables that have same name columns! This can lead to different results in the grid than in the resulting sql table. Compare the results to a regular SQL client by copying the resulting sql and executing it in Adminer and similar... 1 1 Link to comment Share on other sites More sharing options...
Beluga Posted May 25, 2019 Share Posted May 25, 2019 Woooaw - with your query and renaming the fields of the other template, I got a perfect result!! (You were right that the column names have to be different) Thanks a lot. This is using my old hacky Tabulator grid ? 2 Link to comment Share on other sites More sharing options...
bernhard Posted May 25, 2019 Author Share Posted May 25, 2019 Glad it worked ? Yeah, it's good old SQL and RockFinder taking away the complexity of getting all fields related to a page/template and taking into account PW statuses. Though one has to be careful about access control related to fields, related pages, referenced page statuses etc... Link to comment Share on other sites More sharing options...
gottberg Posted June 4, 2019 Share Posted June 4, 2019 Should the page refresh when using the view, edit, delete if i would delete the page through RockGrid? col = RockGrid.colDefs.rowActions(col); col.pinned = 'left'; col.width = 120; For now it just spins and if i refresh the page it shows that the deletion worked. My console: [{action: "trash", payload: ["1949"], response: "Trashed 1 pages"}] Link to comment Share on other sites More sharing options...
bernhard Posted June 4, 2019 Author Share Posted June 4, 2019 1 hour ago, gottberg said: Should the page refresh when using the view, edit, delete if i would delete the page through RockGrid? view+edit: no (not by default) delete: yes Link to comment Share on other sites More sharing options...
gottberg Posted June 4, 2019 Share Posted June 4, 2019 8 minutes ago, bernhard said: view+edit: no (not by default) delete: yes Okey, but if i delete it does not do that. I just spins and when i refresh the page it is deleted. Any ideas? Link to comment Share on other sites More sharing options...
bernhard Posted June 4, 2019 Author Share Posted June 4, 2019 36 minutes ago, gottberg said: Any ideas? Sorry, no - otherwise I would of course have posted them above. Please debug it, check the console for errors, try different browsers etc.; It is working here on all my installations. Link to comment Share on other sites More sharing options...
gottberg Posted June 4, 2019 Share Posted June 4, 2019 Sorry, didnt think that through ? I get the same errors i Firefox: JqueryCore.js?v=1545420649:2 POST http://localhost/celsa/pw/celsacalc/?RockGrid=1&field=Transportzoner net::ERR_CONTENT_DECODING_FAILED 200 (OK) Could i have some issues with the Module? Also shows undefiend: 25 Edit: Trashcan also shows as undefined. Link to comment Share on other sites More sharing options...
bernhard Posted June 4, 2019 Author Share Posted June 4, 2019 On 6/30/2018 at 5:38 PM, bernhard said: Support: Please note that this module might not be as easy and plug&play as many other modules. It needs a good understanding of agGrid (and JavaScript in general) and it likely needs some looks into the code to get all the options. Please understand that I can not provide free support for every request here in the forum. I try to answer all questions that might also help others or that might improve the module but for individual requests I offer paid support for 60€ per hour (excl vat). I'm sorry but I can't help you further than I did with this one. If you want me to have a look at your setup you can contact me via email/PM. Link to comment Share on other sites More sharing options...
flydev Posted June 4, 2019 Share Posted June 4, 2019 (edited) 8 hours ago, gottberg said: Could i have some issues with the Module? Looking at the error you got, you could fix it by enabling zlib.output_compression in your php.ini. ps: to be clear, you have a server issue. Edited June 4, 2019 by flydev ps Link to comment Share on other sites More sharing options...
gottberg Posted June 12, 2019 Share Posted June 12, 2019 On 6/4/2019 at 11:48 AM, bernhard said: I'm sorry but I can't help you further than I did with this one. If you want me to have a look at your setup you can contact me via email/PM. Thank you so much for the help you gave! Bernhard helped me through Skype and TeamViewer and solved the issue. I have and had some issues with MAMP. He also gave me some pointers of how to use RockGrid and best practises etc. Worth every €!!! I recommend to use RockGrid if you need to list and edit data. I also recommend to contact Bernhard and buy some support if you want to quickly learn how to use RockGrid! ? 1 1 Link to comment Share on other sites More sharing options...
gottberg Posted June 12, 2019 Share Posted June 12, 2019 On 6/4/2019 at 8:13 PM, flydev said: Looking at the error you got, you could fix it by enabling zlib.output_compression in your php.ini. ps: to be clear, you have a server issue. Thanks for the tip! Tried that but i doesn't help.. ? Link to comment Share on other sites More sharing options...
bernhard Posted June 12, 2019 Author Share Posted June 12, 2019 Thx @gottberg, glad we could find a sulution even though we couldn't find the reason for the issue ? 1 Link to comment Share on other sites More sharing options...
Beluga Posted June 16, 2019 Share Posted June 16, 2019 I am wondering how to optimise a query. It is taking 23 seconds on a server with 4GB of memory. It is live here: https://mattikuusiproverbtypology.fi/references/ I have considered moving to static JS data as the data in the db does not change very often. The query is: $finder1 = new RockFinder('template=A-T', ['code', 'nb', 'variation', 'name', 'page1', 'page2', 'page3', 'runningnb', 'additnb', 'abbrevat']); $finder2 = new RockFinder('template=M6books', ['abbrev', 'author_editor', 'booktitle']); $at = $finder1->getSQL(); $m6books = $finder2->getSQL(); $sql = "SELECT * FROM ($at) AS at LEFT JOIN ($m6books) as m6books ON (at.abbrevat = m6books.abbrev)"; $this->setData($sql); I temporarily enabled slow_query_log like so in my.cnf: long_query_time=1 slow_query_log=1 slow_query_log_file=/var/log/mysql/slow-query.log (with /var/log/mysql owned by mysql user) Below is the slow query log - for some reason it contains two identical queries, each taking over 9 seconds. I wonder why that is? Due to ajax? Does this happen to others? Spoiler /usr/bin/mysqld, Version: 10.3.15-MariaDB-log (Source distribution). started with: Tcp port: 0 Unix socket: /run/mysqld/mysqld.sock Time Id Command Argument # Time: 190616 9:07:29 # User@Host: root[root] @ localhost [] # Thread_id: 9 Schema: x QC_hit: No # Query_time: 9.433453 Lock_time: 0.009225 Rows_sent: 36276 Rows_examined: 515142 # Rows_affected: 0 Bytes_sent: 5495003 use x; SET timestamp=1560665249; SELECT * FROM (SELECT `rockfinder`.* FROM /* original pw query */ (SELECT pages.id FROM `pages` LEFT JOIN pages_access ON (pages_access.pages_id=pages.id AND pages_access.templates_id IN(2,3)) WHERE (pages.templates_id=43) AND (pages.status<1024) AND pages.templates_id NOT IN(2,3) AND pages_access.pages_id IS NULL GROUP BY pages.id ) as `pwfinder` /* rockfinder */ LEFT JOIN ( SELECT `pages`.`id` AS `id`, `code`.`code` AS `code`, `nb`.`nb` AS `nb`, `variation`.`variation` AS `variation`, `name`.`name` AS `name`, `page1`.`page1` AS `page1`, `page2`.`page2` AS `page2`, `page3`.`page3` AS `page3`, `runningnb`.`runningnb` AS `runningnb`, `additnb`.`additnb` AS `additnb`, `abbrevat`.`abbrevat` AS `abbrevat` FROM `pages` /* --- join code --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `code`.`data` AS `code` FROM `field_code` AS `code`) AS `code` ON `code`.`pageid` = `pages`.`id` /* --- end code --- */ /* --- join nb --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `nb`.`data` AS `nb` FROM `field_nb` AS `nb`) AS `nb` ON `nb`.`pageid` = `pages`.`id` /* --- end nb --- */ /* --- join variation --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `variation`.`data` AS `variation` FROM `field_variation` AS `variation`) AS `variation` ON `variation`.`pageid` = `pages`.`id` /* --- end variation --- */ /* --- join name --- */ LEFT JOIN (SELECT `id` AS `pageid`, `name` FROM `pages` AS `name`) AS `name` ON `name`.`pageid` = `pages`.`id` /* --- end name --- */ /* --- join page1 --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `page1`.`data` AS `page1` FROM `field_page1` AS `page1`) AS `page1` ON `page1`.`pageid` = `pages`.`id` /* --- end page1 --- */ /* --- join page2 --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `page2`.`data` AS `page2` FROM `field_page2` AS `page2`) AS `page2` ON `page2`.`pageid` = `pages`.`id` /* --- end page2 --- */ /* --- join page3 --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `page3`.`data` AS `page3` FROM `field_page3` AS `page3`) AS `page3` ON `page3`.`pageid` = `pages`.`id` /* --- end page3 --- */ /* --- join runningnb --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `runningnb`.`data` AS `runningnb` FROM `field_runningnb` AS `runningnb`) AS `runningnb` ON `runningnb`.`pageid` = `pages`.`id` /* --- end runningnb --- */ /* --- join additnb --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `additnb`.`data` AS `additnb` FROM `field_additnb` AS `additnb`) AS `additnb` ON `additnb`.`pageid` = `pages`.`id` /* --- end additnb --- */ /* --- join abbrevat --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `abbrevat`.`data` AS `abbrevat` FROM `field_abbrevat` AS `abbrevat`) AS `abbrevat` ON `abbrevat`.`pageid` = `pages`.`id` /* --- end abbrevat --- */ ) AS `rockfinder` ON `pwfinder`.`id` = `rockfinder`.`id` /* end rockfinder */) AS at LEFT JOIN (SELECT `rockfinder`.* FROM /* original pw query */ (SELECT pages.id FROM `pages` LEFT JOIN pages_access ON (pages_access.pages_id=pages.id AND pages_access.templates_id IN(2,3)) WHERE (pages.templates_id=45) AND (pages.status<1024) AND pages.templates_id NOT IN(2,3) AND pages_access.pages_id IS NULL GROUP BY pages.id ) as `pwfinder` /* rockfinder */ LEFT JOIN ( SELECT `pages`.`id` AS `id`, `abbrev`.`abbrev` AS `abbrev`, `author_editor`.`author_editor` AS `author_editor`, `booktitle`.`booktitle` AS `booktitle` FROM `pages` /* --- join abbrev --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `abbrev`.`data` AS `abbrev` FROM `field_abbrev` AS `abbrev`) AS `abbrev` ON `abbrev`.`pageid` = `pages`.`id` /* --- end abbrev --- */ /* --- join author_editor --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `author_editor`.`data` AS `author_editor` FROM `field_author_editor` AS `author_editor`) AS `author_editor` ON `author_editor`.`pageid` = `pages`.`id` /* --- end author_editor --- */ /* --- join booktitle --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `booktitle`.`data` AS `booktitle` FROM `field_booktitle` AS `booktitle`) AS `booktitle` ON `booktitle`.`pageid` = `pages`.`id` /* --- end booktitle --- */ ) AS `rockfinder` ON `pwfinder`.`id` = `rockfinder`.`id` /* end rockfinder */) as m6books ON (at.abbrevat = m6books.abbrev); # Time: 190616 9:07:39 # User@Host: root[root] @ localhost [] # Thread_id: 10 Schema: x QC_hit: No # Query_time: 9.203892 Lock_time: 0.001161 Rows_sent: 36276 Rows_examined: 515142 # Rows_affected: 0 Bytes_sent: 5495003 SET timestamp=1560665259; SELECT * FROM (SELECT `rockfinder`.* FROM /* original pw query */ (SELECT pages.id FROM `pages` LEFT JOIN pages_access ON (pages_access.pages_id=pages.id AND pages_access.templates_id IN(2,3)) WHERE (pages.templates_id=43) AND (pages.status<1024) AND pages_access.pages_id IS NULL AND pages.templates_id NOT IN(2,3) GROUP BY pages.id ) as `pwfinder` /* rockfinder */ LEFT JOIN ( SELECT `pages`.`id` AS `id`, `code`.`code` AS `code`, `nb`.`nb` AS `nb`, `variation`.`variation` AS `variation`, `name`.`name` AS `name`, `page1`.`page1` AS `page1`, `page2`.`page2` AS `page2`, `page3`.`page3` AS `page3`, `runningnb`.`runningnb` AS `runningnb`, `additnb`.`additnb` AS `additnb`, `abbrevat`.`abbrevat` AS `abbrevat` FROM `pages` /* --- join code --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `code`.`data` AS `code` FROM `field_code` AS `code`) AS `code` ON `code`.`pageid` = `pages`.`id` /* --- end code --- */ /* --- join nb --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `nb`.`data` AS `nb` FROM `field_nb` AS `nb`) AS `nb` ON `nb`.`pageid` = `pages`.`id` /* --- end nb --- */ /* --- join variation --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `variation`.`data` AS `variation` FROM `field_variation` AS `variation`) AS `variation` ON `variation`.`pageid` = `pages`.`id` /* --- end variation --- */ /* --- join name --- */ LEFT JOIN (SELECT `id` AS `pageid`, `name` FROM `pages` AS `name`) AS `name` ON `name`.`pageid` = `pages`.`id` /* --- end name --- */ /* --- join page1 --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `page1`.`data` AS `page1` FROM `field_page1` AS `page1`) AS `page1` ON `page1`.`pageid` = `pages`.`id` /* --- end page1 --- */ /* --- join page2 --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `page2`.`data` AS `page2` FROM `field_page2` AS `page2`) AS `page2` ON `page2`.`pageid` = `pages`.`id` /* --- end page2 --- */ /* --- join page3 --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `page3`.`data` AS `page3` FROM `field_page3` AS `page3`) AS `page3` ON `page3`.`pageid` = `pages`.`id` /* --- end page3 --- */ /* --- join runningnb --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `runningnb`.`data` AS `runningnb` FROM `field_runningnb` AS `runningnb`) AS `runningnb` ON `runningnb`.`pageid` = `pages`.`id` /* --- end runningnb --- */ /* --- join additnb --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `additnb`.`data` AS `additnb` FROM `field_additnb` AS `additnb`) AS `additnb` ON `additnb`.`pageid` = `pages`.`id` /* --- end additnb --- */ /* --- join abbrevat --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `abbrevat`.`data` AS `abbrevat` FROM `field_abbrevat` AS `abbrevat`) AS `abbrevat` ON `abbrevat`.`pageid` = `pages`.`id` /* --- end abbrevat --- */ ) AS `rockfinder` ON `pwfinder`.`id` = `rockfinder`.`id` /* end rockfinder */) AS at LEFT JOIN (SELECT `rockfinder`.* FROM /* original pw query */ (SELECT pages.id FROM `pages` LEFT JOIN pages_access ON (pages_access.pages_id=pages.id AND pages_access.templates_id IN(2,3)) WHERE (pages.templates_id=45) AND (pages.status<1024) AND pages.templates_id NOT IN(2,3) AND pages_access.pages_id IS NULL GROUP BY pages.id ) as `pwfinder` /* rockfinder */ LEFT JOIN ( SELECT `pages`.`id` AS `id`, `abbrev`.`abbrev` AS `abbrev`, `author_editor`.`author_editor` AS `author_editor`, `booktitle`.`booktitle` AS `booktitle` FROM `pages` /* --- join abbrev --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `abbrev`.`data` AS `abbrev` FROM `field_abbrev` AS `abbrev`) AS `abbrev` ON `abbrev`.`pageid` = `pages`.`id` /* --- end abbrev --- */ /* --- join author_editor --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `author_editor`.`data` AS `author_editor` FROM `field_author_editor` AS `author_editor`) AS `author_editor` ON `author_editor`.`pageid` = `pages`.`id` /* --- end author_editor --- */ /* --- join booktitle --- */ LEFT JOIN (SELECT `pages_id` AS `pageid`, `booktitle`.`data` AS `booktitle` FROM `field_booktitle` AS `booktitle`) AS `booktitle` ON `booktitle`.`pageid` = `pages`.`id` /* --- end booktitle --- */ ) AS `rockfinder` ON `pwfinder`.`id` = `rockfinder`.`id` /* end rockfinder */) as m6books ON (at.abbrevat = m6books.abbrev); My MySQL settings on the server are: Spoiler [mysqld] port = 3306 socket = /run/mysqld/mysqld.sock skip-external-locking key_buffer_size = 32M max_allowed_packet = 256M table_open_cache = 2048 sort_buffer_size = 8M net_buffer_length = 8K read_buffer_size = 2M read_rnd_buffer_size = 16M myisam_sort_buffer_size = 128M init_connect = 'SET collation_connection = utf8mb4_unicode_ci,NAMES utf8mb4' collation_server = utf8mb4_unicode_ci character_set_client = utf8mb4 character_set_server = utf8mb4 performance_schema = on query_cache_size = 0 innodb_data_file_path = ibdata1:10M:autoextend innodb_buffer_pool_size = 2G innodb_log_file_size = 256M innodb_log_buffer_size = 8M innodb_flush_log_at_trx_commit = 1 innodb_lock_wait_timeout = 120 innodb_stats_on_metadata = 0 innodb_buffer_pool_instances = 2 innodb_flush_method = O_DIRECT Results from mysqltuner: Spoiler -------- Storage Engine Statistics ----------------------------------------------------------------- [--] Status: +Aria +CSV +InnoDB +MEMORY +MRG_MyISAM +MyISAM +PERFORMANCE_SCHEMA +SEQUENCE [--] Data in InnoDB tables: 55.1M (Tables: 92) [--] Data in MyISAM tables: 981.2K (Tables: 31) [OK] Total fragmented tables: 0 -------- Analysis Performance Metrics -------------------------------------------------------------- [--] innodb_stats_on_metadata: OFF [OK] No stat updates during querying INFORMATION_SCHEMA. -------- Security Recommendations ------------------------------------------------------------------ [OK] There are no anonymous accounts for any database users [OK] All database users have passwords assigned [!!] There is no basic password file list! -------- CVE Security Recommendations -------------------------------------------------------------- [--] Skipped due to --cvefile option undefined -------- Performance Metrics ----------------------------------------------------------------------- [--] Up for: 19s (10 q [0.526 qps], 15 conn, TX: 57K, RX: 1K) [--] Reads / Writes: 100% / 0% [--] Binary logging is enabled (GTID MODE: OFF) [--] Physical Memory : 3.8G [--] Max MySQL memory : 6.2G [--] Other process memory: 0B [--] Total buffers: 2.2G global + 26.5M per thread (151 max threads) [--] P_S Max memory usage: 104M [--] Galera GCache Max memory usage: 0B [OK] Maximum reached memory usage: 2.3G (60.37% of installed RAM) [!!] Maximum possible memory usage: 6.2G (162.06% of installed RAM) [!!] Overall possible memory usage with other process exceeded memory [OK] Slow queries: 0% (0/10) [OK] Highest usage of available connections: 0% (1/151) [!!] Aborted connections: 6.67% (1/15) [--] Skipped name resolution test due to skip_networking=ON in system variables. [OK] Query cache is disabled by default due to mutex contention on multiprocessor machines. [OK] No Sort requiring temporary tables [OK] No joins without indexes [OK] Temporary tables created on disk: 0% (0 on disk / 4 total) [OK] Thread cache hit rate: 93% (1 created / 15 connections) [OK] Table cache hit rate: 64% (11 open / 17 opened) [OK] Open file limit used: 0% (26/4K) [OK] Table locks acquired immediately: 100% (18 immediate / 18 locks) [OK] Binlog cache memory access: 0% (0 Memory / 0 Total) -------- Performance schema ------------------------------------------------------------------------ [--] Memory used by P_S: 104.0M [--] Sys schema is installed. -------- ThreadPool Metrics ------------------------------------------------------------------------ [--] ThreadPool stat is enabled. [--] Thread Pool Size: 4 thread(s). [--] Using default value is good enough for your version (10.3.15-MariaDB-log) -------- MyISAM Metrics ---------------------------------------------------------------------------- [!!] Key buffer used: 18.3% (6M used / 33M cache) [OK] Key buffer size / total MyISAM indexes: 32.0M/502.0K -------- InnoDB Metrics ---------------------------------------------------------------------------- [--] InnoDB is enabled. [--] InnoDB Thread Concurrency: 0 [OK] InnoDB File per table is activated [OK] InnoDB buffer pool / data size: 2.0G/55.1M [OK] Ratio InnoDB log file size / InnoDB Buffer pool size: 256.0M * 2/2.0G should be equal to 25% [OK] InnoDB buffer pool instances: 2 [--] Number of InnoDB Buffer Pool Chunk : 16 for 2 Buffer Pool Instance(s) [OK] Innodb_buffer_pool_size aligned with Innodb_buffer_pool_chunk_size & Innodb_buffer_pool_instances [!!] InnoDB Read buffer efficiency: 60.52% (9061 hits/ 14972 total) [!!] InnoDB Write Log efficiency: 0% (1 hits/ 0 total) [OK] InnoDB log waits: 0.00% (0 waits / 1 writes) -------- AriaDB Metrics ---------------------------------------------------------------------------- [--] AriaDB is enabled. [OK] Aria pagecache size / total Aria indexes: 128.0M/1B -------- TokuDB Metrics ---------------------------------------------------------------------------- [--] TokuDB is disabled. -------- XtraDB Metrics ---------------------------------------------------------------------------- [--] XtraDB is disabled. -------- Galera Metrics ---------------------------------------------------------------------------- [--] Galera is disabled. -------- Replication Metrics ----------------------------------------------------------------------- [--] Galera Synchronous replication: NO [--] No replication slave(s) for this server. [--] Binlog format: MIXED [--] XA support enabled: ON [--] Semi synchronous replication Master: OFF [--] Semi synchronous replication Slave: OFF [--] This is a standalone server -------- Recommendations --------------------------------------------------------------------------- General recommendations: MySQL was started within the last 24 hours - recommendations may be inaccurate Reduce your overall MySQL memory footprint for system stability Dedicate this server to your database for highest performance. Reduce or eliminate unclosed connections and network issues Link to comment Share on other sites More sharing options...
bernhard Posted June 17, 2019 Author Share Posted June 17, 2019 20 hours ago, Beluga said: I have considered moving to static JS data as the data in the db does not change very often. So would caching be an (easy) option? 20 hours ago, Beluga said: Below is the slow query log - for some reason it contains two identical queries, each taking over 9 seconds. I wonder why that is? Due to ajax? Does this happen to others? At the moment this is how RockGrid works: It makes one query to get one row (so the query should have limit=0,1) so that it knows which columns to setup for the grid. Then the second request is to get all data (and this is also used for all subsequent requests when reloading the grid). This is not the best solution, but I have no plans to change that for RockGrid. I start working on RockTabulator today where it will load all the data at the first request and display it instantly ? 4 Link to comment Share on other sites More sharing options...
Beluga Posted June 17, 2019 Share Posted June 17, 2019 2 hours ago, bernhard said: So would caching be an (easy) option? At the moment this is how RockGrid works: It makes one query to get one row (so the query should have limit=0,1) so that it knows which columns to setup for the grid. Then the second request is to get all data (and this is also used for all subsequent requests when reloading the grid). This is not the best solution, but I have no plans to change that for RockGrid. I start working on RockTabulator today where it will load all the data at the first request and display it instantly ? Yep, caching might be nice going forward. Anyway, I can solve this right now with the static JS (well, in theory - have not tried yet what the effect on load time is). It is great to hear you have a plan for RockTabulator regarding this! Link to comment Share on other sites More sharing options...
netcarver Posted June 17, 2019 Share Posted June 17, 2019 14 hours ago, bernhard said: I start working on RockTabulator today Yay! ? 1 Link to comment Share on other sites More sharing options...
bernhard Posted August 19, 2019 Author Share Posted August 19, 2019 The newest version of RockGrid now supports RockFinder2 as data source ? $finder = new RockFinder2(); $finder->find('template=basic-page'); $finder->addColumns([ 'title', 'body' ]); $this->setData($finder); Data is available on the JS side via the RockFinder2 property in the GridItem object: 5 Link to comment Share on other sites More sharing options...
bernhard Posted August 22, 2019 Author Share Posted August 22, 2019 Another little helpful update: Added support for colDef callbacks. Before: col = grid.getColDef('id'); col = RockGrid.colDefs.rowActions(col); col = grid.getColDef('created'); col.headerName = 'Datum'; col = RockGrid.colDefs.date(col); After: grid.getColDef('id', function(col) { col = RockGrid.colDefs.rowActions(col); }); grid.getColDef('created', function(col) { col.headerName = 'Datum'; col = RockGrid.colDefs.date(col); }); The benefit is that before if the column did not exist for whatever reason (eg the column is hidden for some users) the JS broke and stopped execution because "col" was undefined and setting options on an undefined column definition doesn't work. 1 Link to comment Share on other sites More sharing options...
psy Posted September 6, 2019 Share Posted September 6, 2019 My first attempt at RockFinder & RockGrid and truly impressed. Well done @bernhard! Have already created my dataset using joins, changing column headings and the tip for Select Options in my custom php file to display the option's title rather than the value in a column. All good. Problem arises with the filter for the Select Options field, column is project_status, with column header changed to 'Status'. I've no idea how to change the filter from the PW assigned index value to the text value of the field. See examples: 1. Full data set 2. Using a text entry in the filter, eg starting to type 'draft' 3. Entering the PW assigned select options index for 'draft' I'm guessing it needs a custom filter and would appreciate help and guidance. TIA psy Link to comment Share on other sites More sharing options...
bernhard Posted September 6, 2019 Author Share Posted September 6, 2019 Hi Psy, In aggrid you have two concepts: valueGetters (https://www.ag-grid.com/javascript-grid-value-getters/) and cellRenderers (https://www.ag-grid.com/javascript-grid-cell-rendering-components/) The filter filters the RAW VALUE of the cell, not the rendered value. You can either change the valueGetter of the cell or do another "workaround". But that's something conceptional when you are working with aggrid and you have to decide when to take which approach. Have you tried double-clicking the cell, then it should filter for the value of the cell automatically. A triple click removes the filter from that column. Link to comment Share on other sites More sharing options...
bernhard Posted September 6, 2019 Author Share Posted September 6, 2019 11 minutes ago, psy said: My first attempt at RockFinder & RockGrid and truly impressed. Well done @bernhard! Thx, one can do a of great stuff with those tools and I think not many know about that... ? But RockTabulator and RockFinder2 will make things a lot easier (if everything goes well). 1 Link to comment Share on other sites More sharing options...
psy Posted September 6, 2019 Share Posted September 6, 2019 7 minutes ago, bernhard said: Have you tried double-clicking the cell, then it should filter for the value of the cell automatically. A triple click removes the filter from that column. Well that worked, thanks! Not very user friendly though. The general public wont get it ? Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now