Jump to content
Robin S

HannaCodeDialog

Recommended Posts

@Macrura, glad you got it working eventually.

I intend to work on an upgrade to this module sometime soon. Hope to add a feature allowing all dialog options to be configured from within a single hook, which will make things easier (for those comfortable writing code anyway). Will also look at adding some clarification that an attribute must first be declared before adding any of the "double underscore" enhancements.

  • Like 3

Share this post


Link to post
Share on other sites

Hey @Robin S - using this for the first time and finding it awesome. Couple of quick questions:

Is there any easy way to prevent codes from being truncated in the dropdown?

Also, what's the best way to change the name of "Insert Hanna tag" - I see that they are translatable (via separate js files), but what's the suggestion for avoiding having changes overridden with module updates?

Thanks!

Share this post


Link to post
Share on other sites

Hi @adrian,

I just pushed an update that makes those strings translatable within the module file.

As for the other issue, if your tag name is long it can overflow the standard width that CKEditor applies to combo panels (I don't set any explicit width in this module). I could make a config field for panel width but I'd rather not because I think the default width is suitable in most cases and to get a dynamic value from PHP it would mean putting the CSS inline which is kinda ugly. Maybe you could just set your own width for the panel in some custom admin CSS?

.cke_combopanel__hannadropdown { width:300px !important; }

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks @Robin S - I sorted out the width with the Admin CSS feature of AOS. 

As for the translatable string - I'm a little unsure how to work with the recent change - I see you went from js language files to using PW's:

$this->_(

but wouldn't that mean I would need multi-language support installed to translate that? It's not a ML site, so that seems like an inefficient solution for me, but I am very tired, so might well be missing something here :)

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

but wouldn't that mean I would need multi-language support installed to translate that?

You would need to install the LanguageSupport module but I don't think there's any inefficiency in doing that. You don't need to actually create any additional languages - you just edit the default language to override whatever strings you want. I believe that's the standard PW way for customising strings so I wouldn't want to reinvent the wheel and create configurable fields for every string.

  • Like 2

Share this post


Link to post
Share on other sites
1 minute ago, Robin S said:

you just edit the default language to override whatever strings you want

Yeah, you're probably right - I just haven't ever translated strings from a module before, but it sounds like it's easy - thanks!

Share this post


Link to post
Share on other sites

@adrian, I just pushed another update in v0.1.5 that will allow the dropdown label in the toolbar to adapt its width to the length of the text (in the case that it is translated).

  • Like 1

Share this post


Link to post
Share on other sites

Hey @Robin S - I am seeing something weird where if I insert more than one code into a block of text. It all looks good until I save the page and then it reloads, and then all the text between the first and last code is highlighted in blue and connected so that's it no longer editable. Can you reproduce?

Thanks!

  • Like 1

Share this post


Link to post
Share on other sites

Also wondering what you might think of an option to disable the dialog popup. For the needs of my current project I just want the dropdown for inserting the tags, but none of the tags have editable attributes so I think it would be preferable to not add the double-click handler on the inserted tags.

Share this post


Link to post
Share on other sites

Hi @adrian, I regularly use multiple Hanna tags within a single field and haven't seen that issue before.

It sounds like the closing delimiter of the first tag isn't being detected for some reason. I'm thinking that there must be some content in your tag that interferes with the detection of the closing delimiter. Does changing to a different Hanna tag delimiter fix it?

To debug you could try logging the "name" data attribute here, which should be the hanna tag contents without the delimiters.

Edit: actually, if it isn't matching the closing delimiter when the page reloads then it's probably related to the regex here. But it looks correct to me.

  • Like 1

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

Also wondering what you might think of an option to disable the dialog popup.

I'm not aware of any way to do that. This module uses the widget component of CKEditor, and the dialog for that is defined once for all widgets in the CKEditor instance.

  • Like 1

Share this post


Link to post
Share on other sites
6 minutes ago, Robin S said:

To debug you could try logging the "name" data attribute here, which should be the hanna tag contents without the delimiters.

So this is what is being returned:

user_name]]. This is blah [[central_name

so it's removing the opening delimiters from the first tag. I have tried a few different delimiters with no luck so far. Any other thoughts?

Share this post


Link to post
Share on other sites

@adrian, sorry for the interlude - there was a power cut here. :o

Not sure if you saw the edit to my earlier post: if the widgets are correct when you close the dialog but incorrect when you reload the page then it's an issue with this regex. But it looks correct to me - the pattern should match any number of characters after an opening delimiter up until a closing delimiter. You probably know more about regex than me though - does the pattern look right to you?

  • Like 1

Share this post


Link to post
Share on other sites

Hey @Robin S - no worries - I hear things are a bit backwards in your part of the world :) BTW, I am a displaced Aussie - hope we can still be friends :)

Thanks for pointing me in the right direction. The issue is that regex is greedy.

You can see the problem here: https://regex101.com/r/ynCWrf/1 

Here is a non-greedy that works fine: https://regex101.com/r/1Qta6X/1

Thanks again for a great module.

  • Like 2

Share this post


Link to post
Share on other sites

@adrian, thanks for the regex fix! Applied in v0.1.6.

32 minutes ago, adrian said:

I hear things are a bit backwards in your part of the world

When I moved to the deep south I soon found out that a UPS is an essential piece of kit. And the irony is I'm only a short hop from the largest hydroelectric power station in NZ.

37 minutes ago, adrian said:

BTW, I am a displaced Aussie - hope we can still be friends

Why, of course :-). If you're feeling at all homesick, check out the trailer for this documentary I heard about yesterday:

A different kind of backwards...:-)

  • Like 1

Share this post


Link to post
Share on other sites
14 hours ago, Robin S said:

If you're feeling at all homesick, check out the trailer for this documentary I heard about yesterday:

Wow - that's a depressing start to the day! The nasty side of Aussie culture - fortunately we're not all like that.

  • Like 1

Share this post


Link to post
Share on other sites
4 hours ago, adrian said:

fortunately we're not all like that

Not at all. My partner and I had three weeks exploring NT's top end last winter and had nothing but good experiences. The Aussie grey nomad idea is genius - that's how I want to spend my retirement.

  • Like 1

Share this post


Link to post
Share on other sites
7 minutes ago, Robin S said:

Not at all. My partner and I had three weeks exploring NT's top end last winter and had nothing but good experiences. The Aussie grey nomad idea is genius - that's how I want to spend my retirement.

Hopefully we are still considered too young to be grey nomads, but we actually did that in May/June of last year, although we were roughing it in the back of a 4wd - no RV for us :) 

Great adventure through some amazing country!

  • Like 1

Share this post


Link to post
Share on other sites
1 minute ago, adrian said:

we were roughing it in the back of a 4wd - no RV for us

Oh man, I want the best of both worlds - some of those pimped out Aussie 4WD campers are insane! Kiwis love their off-roading but I've never seen such amazing 4WDs until we went to the top end. Some folks have dropped some serious money on those. Proper go-anywhere Landcruisers with every conceivable mod-con built in. Love it.

  • Like 1

Share this post


Link to post
Share on other sites

This is about as far away from what we had as you can get, but this would be brilliant. He has a great series of videos!

 

 

  • Like 1

Share this post


Link to post
Share on other sites

Hey there,

anyone has an idea how to get the HannaDropdown running within a ProFields Table field?

I've got a reference to a FieldtypeTextarea with CKEditor where everything is working absolutely perfect, but the HannaDropdown won't show within the inline Editor of the table field.

Any clue? 🙂

Thanks,
Niko

Share this post


Link to post
Share on other sites
1 hour ago, noodles said:

anyone has an idea how to get the HannaDropdown running within a ProFields Table field?

I've added support for CKEditor within a Table field in v0.1.10.

  • Like 2

Share this post


Link to post
Share on other sites
8 hours ago, Robin S said:

I've added support for CKEditor within a Table field in v0.1.10.

Holy shit! That was fast. Thank you very much, Robin!

  • Like 2

Share this post


Link to post
Share on other sites

Hey all, I've asked the question in Hanna Code module, but am a bit confused which one would make more sense to ask, so just to ask here as well. I've tested HC Dialogues and it worked like a charm for a complex new block with tabs, 2 types of posts etc. It is all done now, and I started adding some checks to see how the module would behave if some values are left empty. So my question is - is there any way to add an attribute requirement so that if it is set let's say as *required*, then you just can't leave the attribute with empty value or else. Presently to complete the functionality with no errors, I had to insert a few checks in the markup for empty "categories", empty values etc. If I could set (like I did with the attribute options) some requirements (can't be empty, cant be more than XXX words etc.) than the dialogue would just show some error and let you fill the data before it is pushed to CKEditor.

Any ideas how to achieve that or if it already exists, how to apply it?

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By eelkenet
      Hi! I've created a small Inputfield module called InputfieldFloatRange which allows you to use an HTML5 <input type="range" ../> slider as an InputField. I needed something like this for a project where the client needs to be able to tweak this value more based on 'a feeling' than just entering a boring old number. Maybe more people can use this so I'm hereby releasing it into the wild.  
       
      What is it?
      The missing range slider Inputfield for Processwire. 
      What does it do?
      This module extends InputfieldFloat and allows you to use HTML5 range sliders for number fields in your templates.
      It includes a visible and editable value field, to override/tweak the value if required.  
      Features
      Min/max values Precision (number of decimals) Steps (Read more) Manual override of the selected value (will still adhere to the rules above) Usage
      Clone / zip repo Install FieldtypeFloatRange, this automatically installs the Inputfield Create new field of type `Float (range)` or convert an existing `Float`, `Integer` or `Text` field. To render the field's value simply echo `$page->field` Demo
      A field with Min=0, Max=1, Step=0.2, Precision=2

      Field with settings Min=0, Max=200, Step=0.25, Precision=2

       
      Todo
      Make the display-field's size configurable (will use the Input Size field setting)  Hopefully become redundant If it's usable for others I'll add it to the Modules list  
      Changelog
      v002
      - Fix issue where setting the step value to an empty value created problem with validation
      - Make the display-field optional 
      v001
      - Initial release
       
      Thanks!
       
       
    • By Robin S
      Another little admin helper module...
      Template Field Widths
      Adds a "Field widths" field to Edit Template that allows you to quickly set the widths of inputfields in the template.

      Why?
      When setting up a new template or trying out different field layouts I find it a bit slow and tedious to have to open each field individually in a modal just to set the width. This module speeds up the process.
      Installation
      Install the Template Field Widths module.
      Config options
      You can set the default presentation of the "Field widths" field to collapsed or open. Field widths entered into the Template Field Widths inputfield are only applied if the Edit Template form is submitted with the Template Field Widths inputfield in an opened state. "Collapsed" is the recommended setting if you think you might also use core inputs for setting field widths in a template context. You can choose Name or Label as the primary identifier shown for the field. The unchosen alternative will become the title attribute shown on hover. You can choose to show the original field width next to the template context field width.  
      https://github.com/Toutouwai/TemplateFieldWidths
      https://modules.processwire.com/modules/template-field-widths/
    • By adrian
      Tracy Debugger for ProcessWire
      The ultimate “swiss army knife” debugging and development tool for the ProcessWire CMF/CMS

       
      Integrates and extends Nette's Tracy debugging tool and adds 35+ custom tools designed for effective ProcessWire debugging and lightning fast development
      The most comprehensive set of instructions and examples is available at: https://adrianbj.github.io/TracyDebugger
      Modules Directory: http://modules.processwire.com/modules/tracy-debugger/
      Github: https://github.com/adrianbj/TracyDebugger
      A big thanks to @tpr for introducing me to Tracy and for the idea for this module and for significant feedback, testing, and feature suggestions.
    • By adrian
      This module allows you to automatically rename file (including image) uploads according to a configurable format
      This module lets you define as many rules as you need to determine how uploaded files will be named and you can have different rules for different pages, templates, fields, and file extensions, or one rule for all uploads. Renaming works for files uploaded via the admin interface and also via the API, including images added from remote URLs.   Github: https://github.com/adrianbj/CustomUploadNames
      Modules Directory: http://modules.processwire.com/modules/process-custom-upload-names/
      Renaming Rules
      The module config allows you to set an unlimited number of Rename Rules. You can define rules to specific fields, templates, pages, and file extensions. If a rule option is left blank, the rule with be applied to all fields/templates/pages/extensions. Leave Filename Format blank to prevent renaming for a specific field/template/page combo, overriding a more general rule. Rules are processed in order, so put more specific rules before more general ones. You can drag to change the order of rules as needed. The following variables can be used in the filename format: $page, $template, $field, and $file. For some of these (eg. $field->description), if they haven't been filled out and saved prior to uploading the image, renaming won't occur on upload, but will happen on page save (could be an issue if image has already been inserted into RTE/HTML field before page save). Some examples: $page->title mysite-{$template->name}-images $field->label $file->description {$page->name}-{$file->filesize}-kb prefix-[Y-m-d_H-i-s]-suffix (anything inside square brackets is is considered to be a PHP date format for the current date/time) randstring[n] (where n is the number of characters you want in the string) ### (custom number mask, eg. 001 if more than one image with same name on a page. This is an enhanced version of the automatic addition of numbers if required) If 'Rename on Save' is checked files will be renamed again each time a page is saved (admin or front-end via API). WARNING: this setting will break any direct links to the old filename, which is particularly relevant for images inserted into RTE/HTML fields. The Filename Format can be defined using plain text and PW $page variable, for example: mysite-{$page->path} You can preserve the uploaded filename for certain rules. This will allow you to set a general renaming rule for your entire site, but then add a rule for a specific page/template/field that does not rename the uploaded file. Just simply build the rule, but leave the Filename Format field empty. You can specify an optional character limit (to nearest whole word) for the length of the filename - useful if you are using $page->path, $path->name etc and have very long page names - eg. news articles, publication titles etc. NOTE - if you are using ProcessWire's webp features, be sure to use the useSrcExt because if you have jpg and png files on the same page and your rename rules result in the same name, you need to maintain the src extension so they are kept as separate files.
      $config->webpOptions = array(     'useSrcExt' => false, // Use source file extension in webp filename? (file.jpg.webp rather than file.webp) ); Acknowledgments
      The module config settings make use of code from Pete's EmailToPage module and the renaming function is based on this code from Ryan: http://processwire.com/talk/topic/3299-ability-to-define-convention-for-image-and-file-upload-names/?p=32623 (also see this post for his thoughts on file renaming and why it is the lazy way out - worth a read before deciding to use this module). 
       
       
      NOTE:
      This should not be needed on most sites, but I work with lots of sites that host PDFs and photos/vectors that are available for download and I have always renamed the files on upload because clients will often upload files with horrible meaningless filenames like:
      Final ReportV6 web version for John Feb 23.PDF

×
×
  • Create New...