Jump to content

Module: Video embed for YouTube/Vimeo (TextformatterVideoEmbed)


ryan

Recommended Posts

Antti, I was able to reproduce that and have fixed it. Thanks for finding it. The last pull request broke the preg_match index association and I didn't catch it. :)

Hi Ryan, when did you update the module to fix the repeating vid problem? I downloaded this module at 11:30 am EST and I'm having the same problem as Apeisa. If you updated it seconds after my DL finished I can re download. Weird coincidence on the timing.

Link to comment
Share on other sites

@digitex, update hasn't been pushed to GitHub yet -- I should know, since it was my pull request that broke this before, terribly sorry for that!

Just opened a pull request with a fix for this problem, just in case. If you need to make the fix locally you can review required changes here:

https://github.com/ryancramerdesign/TextformatterVideoEmbed/pull/2/files

Link to comment
Share on other sites

I know that I pushed this update yesterday right when I wrote my message. But look what was waiting for me in my shell window when I just now checked:

[rytower]$ git push origin master

Username:

I typed in the push and just assumed it went through yesterday, as it always does. Then moved onto the next thing. For some reason GitHub is prompting me for a username (didn't expect that). Anyway, I just typed it in now so hopefully it should be online finally. :)

  • Like 1
Link to comment
Share on other sites

I have a video embedded a youtube with this module. At the end of the video youtube displays related videos. Can this be changed? The customer just wants to stop the video, without displaying any related videos.

Normally you can add "rel=0" to the embed url, but I don't know how to change this in the module.

Link to comment
Share on other sites

I have a video embedded a youtube with this module. At the end of the video youtube displays related videos. Can this be changed? The customer just wants to stop the video, without displaying any related videos.

Normally you can add "rel=0" to the embed url, but I don't know how to change this in the module.

Good point. I second this. I tried adding ?rel=0 to the embed url and it breaks it and just displays the link as text. Currently at the end of the vids it shows some pretty unrelated and annoying, so called "related" items.

Link to comment
Share on other sites

I've been experimenting with this by including the "rel=0" in the oEmbed call, but apparently YouTube ignores it. It looks to me like they don't support specification of this option with oEmbed, though if anyone can figure out how to do it I'll be happy to integrate it.

Link to comment
Share on other sites

What does it add the rel=0 to? The URL in the iframe tag I'm assuming, but thought I'd tried this... Anyway, if this works, we might want to support other options too. What other worthwhile GET variables can be specified to youtube?

Link to comment
Share on other sites

This is the embed code from youtube:

<iframe width="560" height="315" src="https://www.youtube.com/embed/YsCpDaSooWA?rel=0" frameborder="0" allowfullscreen></iframe>

So it does go into url in iFrame tag.

I think only other relevant option might be privacy mode. This is the embed code for privacy mode and no for related videos combined:

<iframe width="560" height="315" src="https://www.youtube-nocookie.com/embed/YsCpDaSooWA?rel=0" frameborder="0" allowfullscreen></iframe>
  • Like 1
Link to comment
Share on other sites

I've pushed an update to this module so that it now recognizes any youtube query string variable. So you can use rel=0 or whatever you want from the link that Diogo posted. To use it, just append them to your youtube in your body copy, i.e.

https://www.youtube.com/watch?v=Wl4XiYadV_k&rel=0

Note the extra "rel=0" at the end. Of course, you can also specify multiple things too:

https://www.youtube.com/watch?v=Wl4XiYadV_k&rel=0&controls=0
Link to comment
Share on other sites

Diogo, that's a good one to know about, thanks. That one should work too as it's not detecting specific options but rather pulling the entire query string out of the URL and then packaging it back up into the iframe embed code that youtube provides. Once I saw all the options on the page you linked, I figured that was the only way to go.

Link to comment
Share on other sites

Ok. What am I doing wrong? I downloaded the new update, replaced it on the server and now all I get is the link as text on the page. I uninstalled everything so that I could reinstall from scratch and it's still not working.

I went back to the previous version I got originally (v 1.0.1) and it started working again. So I tried to upgrade again with the updated version and it broke. I don't know what's causing it.

Link to comment
Share on other sites

Digitex, I think I found the issue. Please try the latest update and it should work now.

Sorry Ryan. I hate to be a pain but the new update fixes the video embed...until I add the ?rel=0 to the link. That breaks it again. If it's now working for interrobang then maybe the problem is something else particular to my server configuration.

Link to comment
Share on other sites

For YouTube, you would actually be adding "&rel=0", not "?rel=0", i.e.

https://www.youtube.com/watch?v=Wl4XiYadV_k&rel=0

This works here. Is it possible that you used '?' rather than '&' ? If not, please post the exact URL that doesn't work.

Link to comment
Share on other sites

For YouTube, you would actually be adding "&rel=0", not "?rel=0", i.e.

https://www.youtube.com/watch?v=Wl4XiYadV_k&rel=0

This works here. Is it possible that you used '?' rather than '&' ? If not, please post the exact URL that doesn't work.

Turns out that is the case. I was going by the youtube embed code from the site which would use a URL that looks like this:

https://www.youtube.com/embed/Wl4XiYadV_k?rel=0

But using &rel=0 is correct and works. Thanks for the correction.

  • Like 1
Link to comment
Share on other sites

  • 4 weeks later...

The TextformatterVideoEmbed module has been updated to support responsive embed codes. To enable, grab the latest version (v1.0.4) go to the module configuration screen and check the responsive box. Now when your videos are embedded, they will be output in a width-flexible format that adjusts to the container.

  • Like 3
Link to comment
Share on other sites

  • 2 weeks later...

I had a bizarre report today from someone using this module. She copied and pasted the embed code into the body field, like I showed her how to do, and it rendered as a link. In other words the anchor tag was added automatically turning

https://www.youtube.com/watch?v=j-AMV7yAiAo&rel=0

into

<a href="https://www.youtube.com/watch?v=j-AMV7yAiAo&rel=0">https://www.youtube.com/watch?v=j-AMV7yAiAo&rel=0</a>

When her husband tried using Safari on a mac, no problem, but when she does it on, I think, Vista or XP using IE7 (I know I know some people just don't like to upgrade) she gets the above.

Anyone else ever see this happen?

Link to comment
Share on other sites

Are there any other textformatters enabled on this 'body' field?

Where was it copied/pasted from? If you copy and paste something that is an HTML link from one window and paste it into a TinyMCE field, then the link will be retained. It's possible that IE7 inserts the <a> tag around an URL copied from its address bar? If that's the case, she could either click the 'remove link' icon after pasting it on, or paste the link into Notepad, and then copy it out of there before pasting into TinyMCE (which should render it plain text).

Link to comment
Share on other sites

She emailed me her process which is the same approach I took and the same as her husband:

Opened up the desired video on Youtube.

Clicked "share".

selected and copied the URL that showed up directly below.

Logged in to my editing page.

Selected "video"

Selected "edit"

Scrolled down past "title", "headline", "summary", to "body"

Put my cursor at the end of the previous line of text

hit return

hit Ctrl v to paste

She then reported her husband tried again using the same method and it worked fine just as it did for him the first time he tried. She knows that it's something on her computer/browser. Clicking "remove link" is something i didn't think to tell her but that's good advice.

Just curious if anyone else has seen this and can confirm it's the browser doing it. Frankly I don't think it's a good idea to backwards engineer a module to be compatible with a browser as old and s****y as IE7, far better to encourage people to upgrade. If that's the problem.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...