Jump to content

netcarver

PW-Moderators
 View Profile  See their activity

  • Posts

    2,233

  • Joined

  • Last visited

  • Days Won

    47

 Content Type 

Everything posted by netcarver

  1. netcarver
    Do you know if the client is using the DomainServer Basic package. The FAQ pages say that htaccess files aren't even allowed for sites hosted on that service. It might be worth emailing the support folks at the host and asking the question direct to them.
  2. netcarver
    Well, I still want to extend the breaking change search to apply to the text of commit messages. Currently the search is only applied to the changelog (if any.) I think extending the search for breaking changes and simply highlighting where a breaking change phrase occurs is probably enough.
  3. netcarver
    @horst There's a pull request on your module that should update the formatting of the Changelog to allow it to be parsed by the existing code in my module. I've also fixed a couple of issues with the Markdown in the readme file as well. I hope this helps. As long as the changelog markdown is of the following format, markers should be correctly inserted... # Changelog // this line is optional - not needed, but if it is present it is sliced off and presented left justified above the versions. ## {version string} {optional information, usually the release date} // H2 - github will style this with a bottom border - Change 1 - Change 2 - or - ### {version string} {optional information, usually the release date} // H3 - github will style this without a bottom border - Change 1 - Change 2 @tpr There was a bug in the way I was comparing versions. You should be able to stick with whatever formatting you prefer. That said, I think there is more flexibility with string versioning than using integers. With string versioning you should be able to have deep version if you'd like - "0.7.8.1" or "1.5.2dev" are all possible. I'll be moving my modules over to string versions as and when I update them from now on.
  4. netcarver
    @adrian I'll see what I can do over the weekend to try and get things working for TOCs in the readme files. Release Notes displays any files that start with "readme" - so you can split different topics into different readme files if that helps.
  5. netcarver
    I think you might be using the screen wrong. I tried that a long time ago and found it didn't really work. Edited to add: These new-fashioned LCD screens don't have quite the same kick as the old CRT monitors.
  6. netcarver
    RIght, I see what you mean about the format. Hmm. Let me have a ponder about this - I'm not sure I want to support every possible format of changelog, yet if I simplify the regex too much, we may end up with false markup insertions. Anyway, it's not a particularly big problem on the galactic scale of things
  7. netcarver
    Yep, it wasn't. Please could you try 0.10.3 - I think it should be OK now.
  8. netcarver
    Hi @adrian That would depend which page you are viewing it from. If you are just looking at the changelog from the module information page - without doing an upgrade or install, then it looks like it should based on the underlying markdown. If you are seeing this from an upgrade/install page, then I would expect version markers in there. Perhaps I've missed something though, what do you think is wrong with it? Right, I've removed the call in the next version. Thanks for the catch. I've stuck with using the verbose version of the call as I had trouble with getting the abbreviated calls to work in an earlier (much earlier) version of TD.
  9. netcarver
    Hi @adrian on mobile at the moment, I will look into these reports as soon as possible - which will probably be tomorrow evening. Thanks!
  10. netcarver
    Thank you for this very nice template Kai. If having your own original art in there is an issue, have you considered just replacing those images with some from unsplash.com or other such source? Regardless of the answer to the above, it's very kind of you to release it publicly. Thanks again.
  11. netcarver
    Just pushed version 2.1.0. By default, the module will set up the current page as the 'page' context and the page's parent as the 'parent' context. This allows you to access any field of the current page or the parent of the current page by default.
  12. netcarver
    Nice find, thank you @adrian
  13. netcarver
    Just updated to fix a side-effect of using the PHP Dom manipulation library - which was wrapping the content with an unwanted DOCTYPE and HTML start and end tags. This is a breaking change - so the version has been updated to 1.0.0.
  14. netcarver
    Version 0.10.0 is in the module repository. This has a major behind-the-scenes refactoring to allow for remote repository adaptors (with result caching). Github is supported fully, and I've made a start on the BitBucket adaptor... This version also fixes a couple of issues that have been reported by @adrian and @matjazp.
  15. netcarver
    Hmm, thing is, that is the latest available. In this case, it is an accurate description. The changelog could remove the ambiguity with an edit to list things in date order. I suppose it would be possible to detect the dates for each entry and re-order chronologically - but that would mean enforcing a date standard + edge case code for dates as well, it's not a place I want to go.
  16. netcarver
    If possible, I would like to make it visually clear which version of the module the user will be getting once they "push the button". If I leave the label off, that won't happen.
  17. netcarver
    @adrian, Thanks for posting this. It's an interesting case. Here's the markdown content of the changelog for that module... # Changelog ### 1.6.71 (2017-11-14) - prevNextLinks: keep page sort order ### 1.6.7.2 (2017-11-19) - ctrl+s save fix by Robin S ### 1.6.7 (2017-11-13) - new tweak 'prevNextLinks' to Misc, based on Macrura's 'PrevNextTabs' module (thanks!) ### 1.6.6 (2017-11-07) - UikitTweaks: login page sticky... You can see that I'm just honouring the changelog as it has been published. ModuleReleaseNotes simply marks up the installed version and the latest available version (which is 1.6.7.2) according to what the PW module repo reports as the latest available for the module being looked at, and what the modules code in PW reports as the installed version. I'm OK with marking up the changelog - but not with re-ordering. BTW, if anyone has a more advanced version of a module installed locally than has been publicly published via the module's repo, you'll also see a situation like the above. I guess I could change the label shown in this case from "Latest" to "Latest Published" or something like that. Opinions welcome.
  18. netcarver
    Although the "What's Changed" section can't be currently displayed unless there is a remote git host to query, the module's support files are readable in the module's config page post-installation as they are all pulled form the local installation, not the remote host.
  19. netcarver
    Is there another module that installs PulsawayPush? If that other module is an autoload, admin module then you might expect that. Ah, it's for every module - scratch that idea.
  20. netcarver
    This is now up to version 0.9.1 and I've moved the module's status from Alpha to Beta. New features include showing git tag points in the commit logs... ...better detection+handling of out-of-order versions in changelogs (plus some improved styles thanks to @matjazp) and the display of the remote repository-host's API read depletion condition.
  21. netcarver

    Old Jquery

    netcarver replied to matjazp's topic in Security

    @matjazp Out of interest, which scanner do you use?
  22. netcarver
    I've seen something similar to this on a client site when this textformatter was added to a CKEditor'd textarea field. It turned out that I was pasting in links to the video, not just the plaintext of the video address and this was causing the formatter to fail to match and then embed it. If you look at the source of the page where the video doesn't work, look to see if the text you pasted is actually a link, and if so, simply break the link, save the page and revisit it on the front-end. I hope that is what's happening here - but there's no guarantee it is.
  23. netcarver
    Version 0.7.6 is now available with the first round of reported problems fixed. Please note, the changelog for the version of the module includes the term "Breaking Changes" so if you go through the module upgrade path for this module, you'll see breaking change highlighting in action. In this case, it's OK to proceed. Update: version 0.8.0 is available. Adds support for code highlighting in support files thanks to Abdus' TextformatterPrism module (if it happens to be installed.)
  24. netcarver
    @webhoes Can you try changing to the following and see if that sorts it out... // from this... $marker_options['markerColour'] = $page->subspecie->population_color_name; // to this... $marker_options['markerColor'] = $page->subspecie->population_color_name;
  25. netcarver
    First post-release display bug report in and fixed - thanks!
×
×
  • Create New...