Reno Theme

[renobird]

I haven't looked at the styles there in a bit, perhaps a quick update to something like this?

[LostKobrakai]

I just find the gap to be to less noticeable. It doesn't necessarily have to be a gap, it could also be a bar of color, which indicates the current drop position. As the drag&drop seems sometimes a bit touchy I feel it's important to at least show clearly the place where the image will get dropped. 

[Juergen]

Here it is what the grid looks like in my backend.

There is CSS problem at the description of the image field in the grid system. The description floats next to the images so a description clearing maybe would solve the problem.

Best regards

[LostKobrakai]

The descriptions are working here. Also I'm not sure why your description is after the images. It should be before the grid.

[renobird]

Juergen,

I can't recreate that one either. What browser/version?

@Tom

found some small issues with translations: https://github.com/ryancramerdesign/ProcessWire/issues/1291

I missed this earlier, I'll check into it now.

[Juergen]

Hello Renobird,

you are right - it depends on the browser.

I use the Firefox 39. If I use the latest IE the description is above as LostKobrakai said. It seems that Firefox has more problems at the moment. I have also a problem with browser resize and responsive images. This is also a well known bug in the latest version.   

 

[Juergen]

Hello Renobird,

is it possible to add target="_blank" to the custom links in the top nav?

I have tried to do this like that in the admin.php:

"target" => "_blank"

But this doesn`t work!

Best regards Jürgen

[renobird]

@Juergen, 

You are correct, that doesn't work (yet). Pete requested this for the superuser quicklinks, and I didn't get around to adding it until now.

I'll submit this and a bunch of other little updates to Ryan today.

This won't work until these changes are added to the dev branch, but you can now define link attributes like so:

$newItem[] = array(
    "class" => "my-class",
    "label" => "<i class='fa fa-asterisk'></i>",
    "link" => $config->urls->root,
    "attrs" => "target='_blank' rel='foo'", // whatever attributes you would like to set here, other than class.
    
    "children" => array(
        // The key/value for the children now accepts an array for the value.
        // if the value is an array, the first item is considered the link, any other items are considered attributes.
        "Google" => array('http://google.com', 'target="_blank"', 'rel="foo"'),
        "Github" => array('http://github.com', 'target="_blank"', 'rel="foo"'),
        "ProcessWire" => "http://www.processwire.com" // non-array value works as well.
    )
);

[tpr]

No biggie, but a 404 error occurs when using "Admin Theme Reno Roboto Colours" and allowing CSS maps in the Inspector (default setting is on I guess).

The problem is that the notification system reports it every time when the Inspector is open:

"404 occurred: /site/modules/AdminTheme/AdminThemeReno/styles/blue-robot.css.map"

Removing the last lines from the roboto colours css files works but perhaps it shouldn't work this way by default.

[Peter Knight]

I have something real weird happening with my RenoTheme.

If I log in, the entire theme rotates 360 degrees.

When I expand a tree the sub-pages also rotate 360 degrees.

 On PE 2.6.8 and Chrome  43.0.2357.132 (64-bit).

[justb3a]

Hi, maybe I'm doing something wrong. I selected an image field  in module settings which is assigned to the user system template. But no avatar image appears.

Looking into the code it turns out that in AdminThemeRenoHelpers.php line 81 the property avatar_field has to be renamed to avatar_field_user. After changing that line the image appears. ProcessWire 2.6.8 dev. Table modules column data looks like this: {"colors":"kfi-robot","avatar_field_user":"blog_images","userFields_user":"name",...} (changing the name of the input field should fix this as well).

+   $adminTheme->avatar_field_user != '' ?  $imgField = $user->get($adminTheme->avatar_field_user) : $imgField = '';
-   $adminTheme->avatar_field != '' ?  $imgField = $user->get($adminTheme->avatar_field) : $imgField = '';

[Macrura]

@justb3a's fix worked for me

[renobird]

@justB3a, @Macrura,

Thanks, that issue is the same one that Juergen reported.

It's been fixed in the upcoming update (hopefully later today). It will override the fix you have, but glad you have it working for now.

@Peter, Wow, that is a weird issue. I'll see if I can recreate it.

[renobird]

@peter,

I can't recreate that one. PW 2.6.9 and Chrome 43.0.2357.134

[Peter Knight]

@renobird

Here's a Vimeo recording from the moment after I click Login.

Do not adjust your sets!

[renobird]

Whoa. Ummm....well — that is bizarre. Anyone else seeing that with Chrome? I've tried on a Mac and a PC, and I can't recreate it.

Do you have any other custom css/js files being added with the admin custom files module?

[Juergen]

Yeah, user image will be displayed since the last update - Thanks Renobird

[renobird]

I just sent Ryan several other updates, which should include the target attribute stuff and all the image CSS changes from the screenshots on the previous page.

[Juergen]

The image grid in Firefox 39 is also displayed correctly since the update. The description is now above. Well done!

[tpr]

Dat rotation!

Try to locate the cause using the Inspector, it's probably a CSS transform / keyframe animation collision.

[Peter Knight]

Dat rotation!

Try to locate the cause using the Inspector, it's probably a CSS transform / keyframe animation collision.

Could be something related to

.fa-spin {
  -webkit-animation: fa-spin 2s infinite linear;
  animation: fa-spin 2s infinite linear;
}

 located in wire/templates-admin/styles/font-awesome/font-awesome.min.css or one of lines following it which handle some rotation.

Commenting it out removed the problem. 

Do you have any other custom css/js files being added with the admin custom files module?

No, nothing.

I'm pretty sure it's only happening on this site. Definitely an edge case and noone else seems affected.

[Pete]

That's awesome Peter - shame it's not intentional.

[justb3a]

The user image is now displayed correctly. Thanks 

I also tried to reproduce that bizarre rotation (same Chrome version, PW 2.6.8 as well as 2.6.9, Mac). But everything works as expected.

One more little thing: I changed the user display name field in module settings and used the build in "title" field. This field is of type FieldtypePageTitle and won't be displayed. Could you add this to the allowed text field types please?

AdminThemeRenoHelpers.php

- if($field instanceof Field && ($field->type == "FieldtypeText" || $field->type == "FieldtypeConcat")){
+ if($field instanceof Field && in_array($field->type, array('FieldtypeText', 'FieldtypeConcat', 'FieldtypePageTitle'))){

[renobird]

Thanks @justb3a

I made that change. I'll see if I can get it in to Ryan before he adds the other updates I sent last week. Otherwise, it will be in the update after that.

[Peter Knight]

That's awesome Peter - shame it's not intentional.

Reminds me of the old Scooby Doo cartoons and their cut-in sequences