Jump to content

Recommended Posts

Ok, now that files are flying like flies (heh heh), I think I will focus to next version of AdminBar, but will also try to implement Aloha Editor module.

I will start from Ryan's code and concept above. Idea is that Aloha Editor would play nice with or without AdminBar. If you have AB installed, then it would use the same UI.

Share this post


Link to post
Share on other sites

Current dev version of AdminBar gives a nasty js alert on IE9 (not sure about earlier ones): "Load jQuery first!". It happens occasionally when clicking "Edit page" link. Not everytime, but about 50% of times.

It comes from tiny_mce.js file. I changed that part from:

return alert("Load jQuery first!");

to

return false;

and everything seems to be running smoothly. I assume that jQuery is needed for those link & image modals? If so, then silent fail here should be ok, since it won't take long that jQuery gets loaded (those works in my tests even when I get the alert). IE9 seems to have many bugs related to how it loads javascript files, and this is probably just one of those. Whatever the reason is, it seems that occasionally in IE9 and using Adminbar, tinymce gets loaded before jQuery.

In the other news: for some reason removing pages from AdminBar works now (I haven't done anything, and it didn't work in 2.0). It redirects to /processwire/ after deleting (I think that is good solution here).

Share this post


Link to post
Share on other sites

mmm...i'm trying to use this adminbar but when editing a page i get this error:

Template '/home/processw/public_html/site/templates/' is not allowed

If i edit the page via admin it works.  :-\

Share this post


Link to post
Share on other sites

Ryan, I took your code and started taking it further. It is very good start and not much to do really. I have Aloha editor floating around my content already and I am starting to implement the saving.

<?php

    public function format(&$str) {
        if(!$this->page->editable()) return;
        $str = "<div id='fieldname' class='aloha-editable'>$str</div>";        
    }

Is there any easy way to get that id='fieldname' to textformatter? So does the textformatter know what is the field name that uses it? Fieldname is something that I wanna know, when I save the edited content, isn't it?

PS: testing this made me think that there probably will be some issues using Aloha on front and TinyMCE on the back. Not sure though? If they both provide clean enough output, then it will work. Need to test this well after this is ready.

PPS: http://drupal.org/node/1018352 (it seems to be much harder to implement on drupal - not a surprise though, but interesting read)

Share this post


Link to post
Share on other sites

Played more with Aloha:

  • Since Aloha makes only one instance for multiple editables (which is great for performance), it makes this harder to implement. We need to strip functionality based on what kind of field is edited (textarea or just text). We don't want to allow adding headers inside of header etc. There probably are methods on Aloha API that let us do that. If not, then we have to live with it or just use very bare bones version of Aloha (inline elements only).
  • Editing feels very fast and natural. Now I want to also drop images to the website :)
  • I already implemented this to play nicely with AdminBar - it adds new button to Adminbar, if you have it installed (Quick Edit). And after you start editing content, there appears second new button: "Save Aloha" which gives you a nice little alert with all the editable content.

Share this post


Link to post
Share on other sites
Is there any easy way to get that id='fieldname' to textformatter? So does the textformatter know what is the field name that uses it? Fieldname is something that I wanna know, when I save the edited content, isn't it?

I've just depreciated the Textformatter::format($str) function in favor of Textformatter::formatValue(Page $page, Field $field, $value). I guess I didn't consider the things we'd be using Textformatter for in the future. :) But it should be ready to go now. Just grab the latest commit and implement the 'formatValue' version rather than the 'format' version in your Textformatter module. You can now get the field name from $field->name.

Since Aloha makes only one instance for multiple editables (which is great for performance), it makes this harder to implement. We need to strip functionality based on what kind of field is edited (textarea or just text). We don't want to allow adding headers inside of header etc. There probably are methods on Aloha API that let us do that. If not, then we have to live with it or just use very bare bones version of Aloha (inline elements only).

I see what you mean, though am surprised they don't provide built in capability to deal with single-line (titles) vs multi-line (textareas) markup. We could always strip paragraph and heading tags from the single line fields.

PS: testing this made me think that there probably will be some issues using Aloha on front and TinyMCE on the back. Not sure though? If they both provide clean enough output, then it will work. Need to test this well after this is ready.

So long as they are both dealing with the same kind of markup tags, I think we'll be fine here. Though not positive.:)

I'm excited to see how this goes!

Thanks,

Ryan

Share this post


Link to post
Share on other sites
Title fields - I was too pessimistic, even one of their examples have different options for title

Not sure I understand? Looks like this is one giant field to cover the entire page. :) Pretty impressive with the 3 columns actually. That's not something I'm used to seeing in HTML. Definitely not something I've seen in TinyMCE. This 1-giant-field for the entire page is probably not something you'd see much of in the real world, beyond a demo.

Aloha seems pretty useful even if just used for multiline fields. Though it'd be great if it had some option to place limits on the markup a user can use, for single line fields at least. But I don't see anything like that, looking through their site. We can always just strip the block-level stuff.

Share this post


Link to post
Share on other sites

If you click the big "Moby Dick" header, then you can only add links, not change formatting at all. Exactly what we want to do with headers (probably many times want to disable links too...).

The 3 columns is simple stuff, using vendor specific css:

-webkit-column-width: 300px;
-webkit-column-gap: 30px;
-moz-column-width: 300px;
-moz-column-gap: 30px;
width: 960px;

Share this post


Link to post
Share on other sites
If you click the big "Moby Dick" header, then you can only add links, not change formatting at all. Exactly what we want to do with headers (probably many times want to disable links too...).

Pretty cool!  Somehow I completely missed that, thinking it was a background image or something.

The 3 columns is simple stuff, using vendor specific css:

Nice, I've not experimented with the multi-column stuff... looks interesting.

Share this post


Link to post
Share on other sites

Just realized that aloha.js is almost 1 meg javascript minified... it has jquery build in, but also ExtJS. That does complicates things (I had this first loading in admin also, and earlier version (I assume) of jQuery was messing things up...). It would be real problem on front end to make sure that your site jQuery or ExtJS (if you use either one) is always the same version than Aloha requires... There was aloha-nodeps.js included, but need to add ExtJS and jQuery separately then. It just feels damn bloated for such a "small" functionality (I really want to have quick edits and save).

This made me thinking of building super simple editor by myself (there is nice html5 API for that too). Or might add some other light weight editor (I don't consider aloha a light weight anymore)... Not sure though and will definitely take Aloha further and test it more (make it save stuff).

What do you guys think? What are the features you are expecting from "quick editing"? Just editing text & save? Strong, italics? Headers? Links? Images?

Share this post


Link to post
Share on other sites

Just realized that aloha.js is almost 1 meg javascript minified... it has jquery build in, but also ExtJS. That does complicates things (I had this first loading in admin also, and earlier version (I assume) of jQuery was messing things up...). It would be real problem on front end to make sure that your site jQuery or ExtJS (if you use either one) is always the same version than Aloha requires... There was aloha-nodeps.js included, but need to add ExtJS and jQuery separately then. It just feels damn bloated for such a "small" functionality (I really want to have quick edits and save).

I also was shocked about the 1meg. Quite a bummer. ExtJS alone is beyond imaginable, and that just for quick edits. Let alone the complications that can occur. Well it would be possible to run your site jQuery in a seperate namespace and make sure your JQ loads before Aloha ones... headache granted – Well in first place I was also thinking about doing something simple self brewn, that fits into PW. Just discovered Aloha few days ago. I thought it may usable but also sensed it may overkill and too akward to implement, use. Not to mention depend on it.

This made me thinking of building super simple editor by myself (there is nice html5 API for that too). Or might add some other light weight editor (I don't consider aloha a light weight anymore)... Not sure though and will definitely take Aloha further and test it more (make it save stuff).

What do you guys think? What are the features you are expecting from "quick editing"? Just editing text & save? Strong, italics? Headers? Links? Images?

Yeah images would be extasic.

Lists? Small? Paragraph?

Are you planning writing a wysiwyg in this case? Or using tinymce?

Also what are you seeing will be the way to define what fields are editable on page? Something that's controlled in by the template file would be cool.

BTW: I already hear a "Oooooh! my text is screwed, I copied from Word into the page!"

Share this post


Link to post
Share on other sites

I spend few hours last night to read about contenteditable and how to implement simple js rich text editor. It sounds simple (browsers have it built in, since IE 5.5 - then reverse engineered from there to other browsers). But (and pretty big but) - the implementation is very messy. Gotta respect TinyMCE & Co more, that is actually super messy stuff that different browsers provide (I tested just chrome, ff and opera) and amazed that there has been so little progress on that area. This being said I don't think I have time (or skills) to build solid rt-editor from scratch.

I started to look if there is any library that can clean the html (I found some stuff to clean word pasting) that different browsers provide and make them similar in each, but no luck there. Maybe I could loan some parts from other projects (if their licencing allows) if it possible. Not sure though.

If someone finds simple editor, that provides about the same markup and can be added to any element (not just textarea), that would be great. If not, I probably continue with Aloha and try to do my best with multiple jQuery versions.

Share this post


Link to post
Share on other sites
Just realized that aloha.js is almost 1 meg javascript minified... it has jquery build in, but also ExtJS.

Wow that's surprising... rather bloated for what it does. On the other hand, every one of their demos has loaded fast and I would have never guessed about the file size. So maybe it's not the issue that it appears to be at first, given that it's for admin rather than public users. I'm just thankful for browser JS caching.

When it gets down to it, all web-based rich text editors seem problematic for one reason or another. It's always a compromise… just the nature of the beast I guess.

Share this post


Link to post
Share on other sites

Yep. After reading more about how contentEditable/designMode work (most of the editors use designMode - textarea goes into iframe) and how buggy the support is, then it is not surprise that there are so much issues. Add in tons of features, many different use cases (copy from word, from another website, undo button etc), normal browser rendering differencies, then it will be clear that it's not a simple case. And aloha-editor does use contentEditable instead of designMode, which seems to be even more buggier.

But it seems that Aloha is the best (only inline editor?) there is currently so I will continue with that.

Share this post


Link to post
Share on other sites

It does look interesting–good find. I couldn't get their demo to work (in the latest Chrome, other than the nav bar at the top), but am curious about it. Have you tried it out or had any luck getting it to work?

Share this post


Link to post
Share on other sites

It does work. Not the whole page is editable, only left sidebar and bottom at the middle column. Editable areas have blue outlines.

Share this post


Link to post
Share on other sites

Strangely I couldn't get it to work before (must have been something up with my browser). It works great now. Seems like quite a nice solution they've got here. What's your opinion of this vs. Aloha?

Share this post


Link to post
Share on other sites

Not sure yet. After playing a while with Aloha the floating bar starts to annoy a little. The more I use the more I wish it wouldn't float. It's true that you can lock the aloha position, but you would do that always depending on the placement. "Always on top" feels more solid and it is what we (and our clients) have used to. Word doesn't have anything floating around.

This is just a gut feeling, but Mercury also feels like better coded, and better documented (not much, but there is nice annotated source: http://jejacks0n.github.com/mercury/annotated_source/mercury.html) it has cleaner licencing and uses only jQuery (where aloha uses jQuery & ExtJS). So far it feels like Mercury would be better, but it is more just a feeling than anything. I really need to dive deeper to know which one suits better.

Share this post


Link to post
Share on other sites

I'm on the same wavelength. I already after 1 minute of aloha, thought the floating thing is annoying... I really like the top bar of mercury. I would chose it. Just my 2 cents.

Share this post


Link to post
Share on other sites

I agree. I think Aloha is being marketed better, but Mercury seems like the better product based on my relatively brief experience with them. Though Aloha's massive size weighs heavily on my impression too. :)

Share this post


Link to post
Share on other sites

Few minor additions to AdminBarNew (I will soon switch that as a master and leave 2.0 adminbar as a legacy branch):

  • Only show add page button when adding pages is allowed (thanks Soma!)
  • Show lock icon with description text when editing is not allowed or page is locked - instead of hiding the bar totally
  • Added js files to bottom instead of head - will work even if you load your jQuery at bottom (and you might wanna do that for performance reasons)

Share this post


Link to post
Share on other sites

Added "adminbar" permission (other roles than superuser needs that, otherwise they won't see adminbar).

If anyone got the last version, you might wanna update. Just realized that it probably did show adminbar for everyone (guests too).

This (AdminBarNew branch) feels pretty stable now, but please report any issues to GitHub or here. I wanna keep this as slim as possible. Probably only new feature that I will add is logout-button that Soma suggested at GitHub. While testing aloha editor I realized that it is super simple to extend adminbar from additional modules, so that is the way I take with new ideas (and hopely others want to extend AdminBar too).

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Process refunds and send customer notifications from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory (alpha version only available via GitHub) SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.60
      Composer: rockett/jumplinks
      ⚠️ NOTICE: 1.5.60 is an important security patch-release for an XSS vulnerability discovered by @phlp. It's HIGHLY RECOMMENDED that all Jumplinks users update to the latest version as soon as possible.
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! 🙂
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
×
×
  • Create New...