-
Posts
11,266 -
Joined
-
Last visited
-
Days Won
374
Everything posted by adrian
-
-
Hey @bernhard - sorry for the delay on this - had family in town. Please try the latest version - it prevents all siblings from being loaded by the prev/next links in the Request Info panel (which was a bug I hadn't noticed). This should actually make a huge different to anyone using Tracy on a page with a lot of siblings - can't believe I didn't come across this till now - thanks for bringing it to my attention. One caveat - if you are running AOS with the "Add links to edit previous and next pages" feature enabled you might still have problems, although it shouldn't affect page load speed. I have made a note here:
-
Looks like the "Add links to edit previous and next pages" feature results in all sibling pages being loaded - this can be problematic if there are lots of siblings. As soon as I disable that feature it drops down to ~100 pages loaded.
-
As a followup @bernhard - I notice that when editing a child with thousands of siblings, all the siblings get loaded, but this doesn't seem to be a Tracy issue - take a look at the PW core Debug Mode panel. I wonder if that's a bug?
-
@bernhard - could you please let me know how it goes when you disable the "Pages Loaded" section in the Debug Mode panel. This seems to be the main issue at my end.
-
Looks to be great - thank you!
-
Can you post a screenshot of the contents of the Field List & Value section? Or maybe you can send me a test version of the module so I can take a look?
-
My guess is that it's the Field List & Values section of the Request Info panel. Can you try disabling just that section and let me know?
-
I hadn't really thought about it, but if you think that's better, that's fine. The main thing is that I have a LOT of extra fields in my user template on one of the sites I am working on and I am missing that functionality.
-
Hey @tpr - would you mind enabling field edit links for the user template please? I expect it's just a matter of adding ProcessUser instead of just ProcessPageEdit Thank you!
-
Ability to define convention for image and file upload names
adrian replied to adrian's topic in Wishlist & Roadmap
Hi @szabesz - sorry I only have a minute at the moment, but I see that you are using an after hook, but in CustomUploadNames I use a before hook: https://github.com/adrianbj/CustomUploadNames/blob/master/ProcessCustomUploadNames.module#L98 Does that help? -
Actually, I got that wrong - the problem is that you need the trailing slash after the urlsegment for it to work, which doesn't seem right to me since it can be optional.
-
Just noticed that using: $input->url(true) to get urlsegments doesn't work, you need: $input->httpUrl(true) Does this sound like a bug to you guys? According to the docs (https://processwire.com/api/ref/input/url/) it should work.
-
Or if you prefer you could turn on the functions API: https://processwire.com/blog/posts/processwire-3.0.39-core-updates/#new-functions-api and do this: $homepage = pages('/'); PS Welcome to the forums!
-
MarkupSEO - The all-in-one SEO solution for ProcessWire.
adrian replied to Nico Knoll's topic in Modules/Plugins
In my fork (linked above), the field is an images field (for the page specific SEO tab, not the default image). -
New ways to look at content management: ProcessWire http://www.davidkissinger.com/processwire/
-
I just added new options for putting component labels in field placeholder and adding a custom class to each component input (eg. uk-input).
-
Alternate Select Multiple It refers to this (https://code.google.com/archive/p/jquery-asmselect/) developed by Ryan outside of PW, but included as an inputfield type for use with Page reference fields.
-
Sounds to me like it should - I don't think module authors should have to worry about this. Are you interested in raising this with Ryan?
-
Thank you for pointing this out! Sorry for not checking and making an incorrect assumption. What about module authors who use Markdown links on the config settings page of their module, or in the ReadMe or Documentation (and you have @netcarver's ModuleReleaseNotes installed). I can't seem to find any issue on adding noreferrer etc to Markdown links. Any thoughts on what we should do on this front, if anything?
-
Oops - sorry, I committed the tag and release for 4.9.32 but not the actual code Try again now!
-
Hey Robin - sorry for the delay on this, but it should now be fixed - please let me know if it works for you.
-
Interesting discussion here I agree that the PW really needs to track module installs / uninstalls to give module authors some idea of module usage. I feel like it should be as simple as a call from the install() and uninstall() methods. These numbers should be displayed in modules directory - easy and transparent! As for the approach that @bernhard has taken. I have to admit that I thought about the same approach a little while ago, but thought it might illicit a response like @Robin S's. I am certain that in Bernhard's case it's all above board, but I guess you never know what module authors could potentially start tracking. Something to think about is that the PW core unintentionally does something vaguely similar already - take the links to Page, PageArray and NullPage (when editing a Page Reference field) as just one example. These links are to processwire.com which means that if you click on these from your site, the google analytics for processwire.com will show the domain of your site in the "Acquisition" section. This will include local dev domains, staging domains, etc, all because of http_referer. I realize that in this example you have to actively click on a link to trigger the call, but it's something to be aware of if you're really concerned about keeping a domain name private. Cheers!
-
That's not actually true - it's the class name that has to match the file name.