adrian

Sounds to me like it should - I don't think module authors should have to worry about this. Are you interested in raising this with Ryan?

Thank you for pointing this out! Sorry for not checking and making an incorrect assumption. What about module authors who use Markdown links on the config settings page of their module, or in the ReadMe or Documentation (and you have @netcarver's ModuleReleaseNotes installed). I can't seem to find any issue on adding noreferrer etc to Markdown links. Any thoughts on what we should do on this front, if anything?

Oops - sorry, I committed the tag and release for 4.9.32 but not the actual code Try again now!

Hey Robin - sorry for the delay on this, but it should now be fixed - please let me know if it works for you.

Interesting discussion here I agree that the PW really needs to track module installs / uninstalls to give module authors some idea of module usage. I feel like it should be as simple as a call from the install() and uninstall() methods. These numbers should be displayed in modules directory - easy and transparent! As for the approach that @bernhard has taken. I have to admit that I thought about the same approach a little while ago, but thought it might illicit a response like @Robin S's. I am certain that in Bernhard's case it's all above board, but I guess you never know what module authors could potentially start tracking. Something to think about is that the PW core unintentionally does something vaguely similar already - take the links to Page, PageArray and NullPage (when editing a Page Reference field) as just one example. These links are to processwire.com which means that if you click on these from your site, the google analytics for processwire.com will show the domain of your site in the "Acquisition" section. This will include local dev domains, staging domains, etc, all because of http_referer. I realize that in this example you have to actively click on a link to trigger the call, but it's something to be aware of if you're really concerned about keeping a domain name private. Cheers!

That's not actually true - it's the class name that has to match the file name.

Hi @neosin - thanks for reporting - looks like it was a multi-language site bug that crept in at some point. Can you please try the latest version and let me know if everything looks ok now? Thanks!

Thanks for looking into this - right now I am going to have to either build up the JSON, or wait for you to implement an API method. I think the API method is essential because I am sure others will also need to import dates from existing sites. I'd appreciate knowing whether you might have time to implement this relatively quickly, or if you think it might take some time to get to - not pressuring, just needing to know if I need to take the JSON approach to meet my deadlines. Thanks for your time!

Hey @joshuag - not sure if I am just missing it, but is there a method for adding new dates via the API? I have a LOT of events to import. Or, do I have to manually build up the JSON eg: {"startDate":1518778800,"endDate":1518940740,"allDay":false,"timeEnd":"12:00 pm","dates":["W7/16/Fri/Feb/2018","W7/17/Sat/Feb/2018"],"excluded":[],"active":true,"showResults":true,"rrule":"WKST=MO;FREQ=DAILY;DTSTART=20180216T030000Z;INTERVAL=1;UNTIL=20180217T235900Z"} and populate with $page->event->date = $jsonStr; Thanks!

Thanks @Robin S - I am seeing it too - the solution however I am not seeing I'll try to take another look tomorrow. Hi @neosin - this is not related to Tracy. Have a read:

Hey @flydev - I was debugging some Notices in my code and had Tracy in strict mode (via the Panel Selector) and came across this. Let me know if you need any help reproducing.

http://modules.processwire.com/modules/admin-restrict-page-tree/

@neosin - not sure how ML imports work with this module, but thanks to sponsorship by @bbeer BatchChilldEditor supports it, although it work differently to the way you described - you need one CSV file per language.

There is now $config->tracyDisabled = true;

Actually something interesting to note is how slow the Debug Panel actually is: 262ms. Typically mine shows somewhere between 15 and 35ms. Not sure if that's a contributor on your site, or indicative of the problem.

Sorry @kongondo - me again I am noticing that the renderMarkup() method is called many times on the currently edited page and it's also called on page reference fields on the page being edited. This makes for a lot of calls to this method that don't seem necessary as far as I can tell. Do you think this can be improved? As an example, I put: bd($page->id); at the top of that method and saw this: I am currently editing page 1100, but there are a few page reference fields which are also showing up in that list. Thanks for taking a look!

I still think it's nice to have even for short snippets, but maybe that's just me? If nothing else it lets you actually use the tab key to indent which you can't do in a normal textarea.

It would also be good to have: $f->rows = 20; or even make it configurable. One other thing - because InputfieldAceExtended is not in inline mode, you need <?php to force code highlighting, but your module doesn't allow this. Would you mind stripping out any <?php that is added so that this works? This should do it: $str = eval(str_replace('<?php', '', $this->runtimeFields)); $str = eval(str_replace('<?php', '', $field->runtimeFields)); One each for FieldtypeRuntimMarkup and InputfieldRuntimeMarkup. Thanks!

Hey @kongondo - would you consider adding this to the module please? $f = $this->modules->isInstalled('InputfieldAceExtended') ? $this->modules->get('InputfieldAceExtended') : $this->modules->get('InputfieldTextarea'); in the ___getConfigInputfields method? Thanks!

Hey @flydev - did you manage to look into the issue I had with Google Drive not adding more backups after the defined max limit was reached? Thank you!

Hey @kixe - curious if there is a reason you chose to fix this rather than switch to jumplinks? http://modules.processwire.com/modules/process-jumplinks/ Is there something you prefer about this module, or just that you didn't know about the new one?

Just came across this need for the SEO module as well. I have posted this request: https://github.com/processwire/processwire-requests/issues/170 Until there is some progress on that, here is my hacky solution. I am sure it could be improved, but it works for now. $this->addHookBefore('ProcessModule::executeEdit', function($event) { if(!$this->wire('user')->isSuperuser() && $this->wire('input')->get->name !== 'MarkupSEO') { throw new WirePermissionException('You do not have permission to configure this module.'); } }); $this->addHookAfter('ProcessModule::executeNavJSON', function($event) { if(!$this->wire('user')->isSuperuser()) { if($this->wire('input')->get->site === '1') { // note \/admin\/module\/ - if your site admin is at /processwire/, then use: \/processwire\/module\/ $event->return = '{"url":"\/admin\/module\/","label":"Modules","icon":"plug","list":[{"url":"edit?name=MarkupSEO","label":"MarkupSEO","icon":"gear"}]}'; } else { $event->return = null; } } }); That results in this - Modules > Site contains just the SEO link and all the others are empty. Thanks @Robin S for the headstart on this!

Thanks @neosin - it should be fixed in the latest version. Let me know if you find any issues.

Hey @teppo - no idea why, but logins are now showing fine in Chrome. It's weird because yesterday it wasn't just my login attempts that were showing JS disabled and no flash info. I'll keep an eye on it. Sorry to bother you!

Yeah it really is an incredible improvement when you don't need all the stuff associated with a full PW page object.