-
Posts
10,909 -
Joined
-
Last visited
-
Days Won
349
Everything posted by adrian
-
Hey @teppo - I haven't used this module in a long time, but I am playing around with v2.0 at the moment and I see that there is no repeater/repeatermatrix support at all. I understand the old/master version does have some repeater support though. Are you planning on support? Any possible timeframe? Thanks!
-
The entries in the Network tab aren't due to Tracy, but I was curious about the Tracy header which I don't believe should be there. Oh well, something for another time I guess.
-
The UiKit theme collapses notifications by default which is much nicer.
-
Hey @bernhard - thanks for this - I decided to give it a go in one of my current projects. I usually build from scratch using the PW form API, but thought it was time to give this a go given how good most Nette products are. So far really enjoying using it A few thoughts: 1) Any reason you are loading netteForms.js instead of netteForms.min.js ? 2) Any chance you'd consider making the RockFormsBranding div optional? It might be ok on some projects, but on others I really don't think I could have it displayed. Not trying to take credit away, but hopefully you understand. 3) I find the alert dialog really annoying and very 90's. I know it's part of Nette and not something you added (https://github.com/nette/forms/blob/849b672612b709227371f0e0c7d4ee9110206ddc/src/assets/netteForms.js#L304) but I would love to see it gone without hacking that file. I am tempted to make a request to David at Nette, or maybe you could if you agree? Or is there a way to disable this that I am not seeing? Thanks!
-
Hi @rick Those come from the Notifications module (PW core but not installed by default). Personally I really dislike that module and never use it. I don't see a reason to poll the server every 20 seconds for notifications. Tracy should not be loaded with those calls though - I exclude them here: https://github.com/adrianbj/TracyDebugger/blob/204db7e404312dc24e8ca39db445e7cfcc9ddd1a/TracyDebugger.module#L309 but I am wondering if maybe the if(isset($_SERVER['REQUEST_URI'])) { or one of the other conditions just above is not working as expected on your system. This doesn't prevent those annoying entries in the browser dev console, but it should prevent Tracy from being loaded on each request. The x-tracy-ajax header you are seeing makes me wonder if those checks aren't working for you. Could you please take a look and let me know what is happening in the block of code?
-
Hi @noelboss - as @bernhard noted Tracy isn't loaded yet. I try to load everything as early as possible but I don't have any control over the order in which modules are loaded, so when you make a dump call in init() it's a matter of luck really. Usually I find it works, but occasionally not. Also, if you are debugging in a method like that, you will most likely want bd() / barDump(), rather than d() / dump() so that the output is to the debug bar, rather than inline.
-
Sorry you had a battle There is a template settings - under the URLS tab for changing whether URLs end in a slash or not This thread is worth a read: https://processwire.com/talk/topic/16930-options-for-trailing-slashes-and-seo/ - it includes some links on slash vs no slash. Also, just an FYI - variables in a URL are GET, not POST
-
Just because initially I had to set this with JS which uses zIndex, rather than z-index. I have just changed it locally and it will appear in the next commit.
-
You can always set the panel z-index value in the Tracy settings to something higher than 100060, but I would like to know still if those header elements need to be that high in the Reno sticky header.
-
Is there any reason the nav items in Reno have such a high z-index: @media only screen and (min-width: 960px) html.AdminThemeReno.headSticky:not(.modal) #masthead { width: 100%; z-index: 100060; } If I put that (and some others) below 100 the Tracy panels seem fine - am I missing something?
-
But sticky headers are working fine with Tracy panels in the default and UiKit themes. Is there something different about the reno sticky header that you can't change to be like the other two?
-
Hey @szabesz - I can reproduce, but it's fine with the default and Uikit themes with sticky headers so I think it's something that @tpr might need to fix. I know he made some recent changes on this front so maybe those changes need to be applied to the reno sticky header as well?
-
Selector arrays with page reference fields with AND, not OR
adrian replied to adrian's topic in API & Templates
@noelboss - I think the issue that you might be missing is that I am using the selector array approach: https://processwire.com/blog/posts/processwire-3.0.13-selector-upgrades-and-new-form-builder-version/#selector-engine-array-support There is no issue doing what you are suggesting with the regular selector string approach, but the array approach is quite nice when you're building up a complex selector from user input. -
Selector arrays with page reference fields with AND, not OR
adrian replied to adrian's topic in API & Templates
Thanks @noelboss but not sure how that would work with an associative array because you need to reproduce "amenities.titles" for each value which would just override the previous one. But maybe I am misunderstanding your point? -
Hey @Robin S - I think Request 2 would be pretty quick to implement, so might take a look at that when I am procrastinating from work.
-
Hi @Robin S All the "Automatic Email Send" option does is check the "Send welcome message" option when creating a new user. It doesn't have any impact on existing users, but there is an option to "Resend Welcome Message" to an existing user. This will re-generate a new password if that option is selected. As for your requests, unfortunately I just don't have time at the moment as those look relatively substantial, but they sound useful. I think "2" especially sounds like a good idea. I am not sure about "1" - it sounds like it might be beyond the scope of "Email New User", but I am happy to be convinced that it's a worthwhile addition. There's realistically no chance of me getting to this until late May, but of course PRs are always greatly appreciated Sorry I can't help out in a reasonable timeframe on this one!
-
module Recurme – Processwire Recurring Dates Field & Custom Calendar Module.
adrian replied to joshuag's topic in Modules/Plugins
Hi @joshuag - sorry to bump this, but wondering if you've had any thoughts on any of my questions above? -
https://github.com/nette/tracy/issues/292
-
@bernhard - I have a temporary solution for you. Replace https://github.com/adrianbj/TracyDebugger/blob/93fe130026244fe727e5553b82183a85b78e2c9f/tracy-master/src/Tracy/Dumper.php#L460 with: return count((array) $obj->__debugInfo()) ? $obj->__debugInfo() : (array) $obj; There are other ways this could be achieved, but since this is modifying the Tracy core, I am going to ask them what they think is the best approach. Let me know if it works as expected for you.
-
Maybe - I'll see what can be done, but to make it a little easier, can you let me know what variable in RockSqlFinder you are dumping, and where?
-
Hey @bernhard - I think it should already work that way: So I am wondering if it's due to your class extending a PW class that does implement __debugInfo() Could you please let me know what you trying to dump in your module so I can reproduce what you are seeing.
-
https://jeevanism.wordpress.com/2018/03/24/processwire-cms-a-review/ On a WP.com blog no less
-
I would definitely recommend installing: http://modules.processwire.com/modules/module-release-notes/ so you can see what's changed when using the PW Upgrade module: http://modules.processwire.com/modules/process-wire-upgrade/
-
Try Tracy in Strict Mode (you can toggle from the Panel Selector). If nothing shows up there, be sure to look at the Network Response tab in the browser dev console and make sure you check Disable Cache: https://processwire.com/talk/topic/17089-images-disapear-after-uploading-and-saving/?do=findComment&comment=150139