New post: New PW website ready

[teppo]

Hey @ryan. I'm wondering if it would be possible to set up a repository for the new site, so that we could submit pull requests and report issues there?

Personally I'd still like to suggest some usability / accessibility related changes and fixes, but currently that's a bit difficult to do – and it basically requires me reporting the issue, and then you having to figure out how to fix it for the site. If there was a repository, we could a) reliably keep track of issues that have been fixed or closed for other reasons (avoiding duplicate reports), b) submit changes so that you don't have to do everything yourself, and c) experiment with the site with ease.

If the site has features that can't be made public, a repository containing partial site profile would of course do, but the best solution would imho be a full site that we can install locally, makes changes to, build, test for regressions, and so on. Or perhaps you could only share access on a case-by-case basis, since even GitHub now supports private repositories? ?

Thanks for considering this!

[Robin S]

Hi @ryan, could you please add some more detailed documentation for the $page->render() method to the API docs? Currently the details are quite minimal (the method doesn't have it's own page but just a short entry on the $page documentation) and doesn't cover all the options that you describe in this post:

I guess the docs for $page->render() need to somehow pull in the PhpDoc comments from PageRender::renderPage().

[Robin S]

The "hookable" icon in the API methods listing is almost invisible - I think it's missing a width rule:

Besides the size glitch, I think it would be helpful to make the meaning of this icon a bit more obvious - the single note at the top about it's meaning probably is not enough. Some ideas:

• Add a label for the column in the table header
• Add a title tooltip that explains the meaning of the icon on hover
• Use a different icon than the thunderbolt - didn't the old site have a "hook" icon in this place?

[arjen]

On 2/2/2019 at 2:39 PM, teppo said:

I'm wondering if it would be possible to set up a repository for the new site, so that we could submit pull requests and report issues there?

Any updates on this? I've been occupied lately, but spotted some details too. A seperate repo would be awesome. I've referenced the Ember kind-of-way before (including their awesome RFC process), but I also like their approach to a volunteer based website on github. Also checkout the README with other public repositories too. All community / PR merge request based.

[thetuningspoon]

On 1/19/2019 at 7:25 PM, Robin S said:

I might have this wrong, but isn't the important thing that output formatting be off when you get and set values? It's not enough that it simply be off at the moment the page is saved.

Doing the following doesn't solve the "problem" of output formatting...

$page->foo = $page->bar . ' baz';
$page->of(false);
$page->save();

...and so likewise some feature that automatically turned off output formatting within the save() method wouldn't be a solution either. Output formatting has to be turned off earlier in the process of getting and setting values and PW can't automatically know when to do that, so it has be done manually by the developer.

Edit: to clarify regarding getting values - output formatting only needs to be off if you are going use that value in a field you are setting.

I find that the need to set the value of one field to another field is so rare in practice that it cannot possibly outweigh the time, frustration and possible security flaws that dealing with turning off and on output formatting has caused me over the years. It is not hard to use $page->getUnformatted('field') in the rare instance when that is what I actually want to do. At least if I am unintentionally saving formatted values to other fields, it is just a mistake and not a potential security concern like outputting fields to the page that are not entity encoded is. And it certainly doesn't seem like it should be an application-terminating error.

One example I recently ran into was calling a function to send an email while in the midst of editing a page via the api. In such a case you need to remember to turn off output formatting and back on again before calling the email function (and then back off again before doing your save), or your email will be outputting unformatted fields. it took me ages to figure out why the dates in my emails were sometimes coming out as timestamps.  I use setAndSave() now wherever I can, but I do wish I could use the regular object setting syntax sometimes.

I think this is why people say that "global mutable state" is dangerous.

[Autofahrn]

Am I the first to notice that some screenshots in the shop are gone?

https://processwire.com/store/pro-fields/repeater-matrix/

[wbmnfktr]

There are screenshots... but I don't know if those are the same as before.

[Autofahrn]

1 hour ago, wbmnfktr said:

There are screenshots...

Interesting, when I looked before, there were none. Now some are broken:

Maybe something happens right now behind the scenes... ?

[wbmnfktr]

Those two are indeed missing.

I guess @ryan is testing us. ? 

[AndZyk]

Hello @ryan,

when I am using the search function of the ProcessWire website and hit enter after the autocomplete suggestions are shown, I get to the search results page with all results shown as JSON.

When I reload the search results page, the results are displayed normal.

Regards, Andreas

[bernhard]

Hey @AndZyk I can not reproduce this. Could you share more detailed instructions (step by step)?

[AndZyk]

Hey @bernhard,

here is a little screencast in Firefox: 

1. Visit processwire.com
2. Open the search field
3. Enter a search term
4. Wait for the autocomplete results
5. Hit enter to get to the search results page

I get this in Chrome, Opera, Edge and Firefox.
Safari has no issue.

[bernhard]

Interesting. I can reproduce in FireFox, but not in Chrome.

Update: Ok, now I also get this in Chrome. When testing in my regular chrome window it worked without an issue, but when using an incognito window it shows the json.

[Jan Romero]

This seems to be because the XHR request that gets the live results as JSON requests the same URL and headers as a normal visit to the search page, so the browser gives you its cached version.

You can also observe it the other way around: If you head to https://processwire.com/search/?q=hello and then use the search box for the same keyword, the browser console will show a JSON parse error because the live search got the full page instead of JSON.

I imagine this could be fixed by sending the ol’ X-Requested-With: XMLHttpRequest header. Or by using the appropriate content negotiation header (I think “Accept: application/json”?).

Edited October 21 by Jan Romero

[matjazp]

https://github.com/processwire/processwire-issues/issues/1516

https://github.com/processwire/processwire-issues/issues/1823