<a> tag causing Internal Server Error

[ngrmm]

there is a pagination (next|prex) at the end of the page
i want to hide next on the last page of the siblings and hide prev on the first

<?php
if($page != $pages->get(1019)->children->first()) {
  echo "<a class='link prev' href="$page->prev->url">";

    foreach($page->prev->image as $image) {
        $thumb = $image->height(60);
        echo "<div><img src='$thumb->url'/></div>"; 
        }
    $test = $page->prev;
    echo "<span> $test->title </span>";
    echo "<span class='date' > $test->teaser_date </span>";
    }
    
  echo '</a>'

if($page != $pages->get(1019)->children->last()) {
  echo "<a class='link next' href="$page->next->url">";
    
    foreach($page->next->image as $image) {
        $thumb = $image->height(60);
        echo "<div><img src='$thumb->url'/></div>"; 
        }
    $test = $page->next;
    echo "<span> $test->title </span>";
    echo "<span class='date' > $test->teaser_date </span>";
    }
    
  echo "</a>";
  
?>

line 3: echo "<a class='link prev' href="$page->prev->url">"; is causing the error but i don't know why

[Martijn Geerts]

It's a syntax error.

// This is without the syntax error (note the dots and the single quotes)
echo "<a class='link prev' href='" . $page->prev->url . "'>";

BTW:

// Potential memory hog
$pages->get(1019)->children->first()

// This doesn't need to preload all children. The property boolean `true` is to count only the visible.
$pages->get(1019)->numChildren(true)

[ngrmm]

thanks Marttijn

i edited the code but still getting Internal Error

there are always at least 3 children of that page (1019). and all of them aren't hidden.

 

	<div class="pagination">
	<?php
	$prevPage = $page->prev;
	$nextPage = $page->next; 

	if($page != $pages->get(1019)->children->first()) {
 				
		echo "<a class='link prev' href='" . $prevPage->url . "' >"
		
 			foreach($prevPage->image as $image) {
				$thumb = $image->height(60);			
	    		        echo "<div><img src='" . $thumb->url . "'/></div>"; 
    		                }
		
			echo "<span>".  $prevPage->title ."</span>";
			echo "<span class='date' >".  $prevPage->teaser_date ."</span>";
   		
   		echo "</a>"
   		
   		}

	if($page != $pages->get(1019)->children->last()) {		
		echo "<a class='link next' href='" . $nextPage->url . "' >"
		
	 		foreach($nextPage->image as $image) {
				$thumb = $image->height(60);	 		
		    	        echo "<div><img src='" . $thumb->url . "'/></div>"; 
   		 	        }
		
			echo "<span>". $nextPage->title ."</span>";
			echo "<span class='date' >". $nextPage->teaser_date ."</span>";
		
		echo "</a>"
   		}
   		?>
   		
	</div>

[teppo]

@ngrmm: take a closer look at the code Martijn posted and note the semicolon. Looks like your code is still missing that.

While developing a site, you should run it in debug mode. This will output errors on screen and make it a lot easier to spot the source of issues like these.

[ngrmm]

@teppo thanks

here the final code:

 

	<div class="pagination">
	<?php
	$prevPage = $page->prev;
	$nextPage = $page->next; 
	if($page != $pages->get(1019)->children->first()) {
		echo "<a class='link next' href='" . $prevPage->url . "' >";		
 			foreach($prevPage->image as $image) {
				$thumb = $image->height(60);			
	    		        echo "<div><img src='" . $thumb->url . "'/></div>"; 
    			        }
			echo "<span>". $prevPage->title ."</span>";
			echo "<span class='date' >". $prevPage->teaser_date ."</span>";
   		echo "</a>";
   		}
	if($page != $pages->get(1019)->children->last()) {		
		echo "<a class='link prev' href='" . $prevPage->url . "' >";
	 		foreach($nextPage->image as $image) {
				$thumb = $image->height(60);	 		
		    	        echo "<div><img src='" . $thumb->url . "'/></div>"; 
   		 		}		
			echo "<span>". $nextPage->title ."</span>";
			echo "<span class='date' >". $nextPage->teaser_date ."</span>";
		echo "</a>";
   		}
   		?>
	</div>

[bernhard]

hi ngrmm,

you can also make it dynamic to not rely on the id 1019 like this:

$page->parent->children->first()

// instead of
$pages->get(1019)->children->first()

[Martijn Geerts]

Bernhard is right about that ID. When somebody deletes that page your code is broken.

Another thing:

// needs to load all children
$pages->get(1019)->children->first()

// better
$pages->get(1019)->child