Jump to content

adrian

PW-Moderators
  • Posts

    10,902
  • Joined

  • Last visited

  • Days Won

    349

Everything posted by adrian

  1. Take a look at: http://modules.processwire.com/modules/process-redirect-ids/ It may work as is for your needs, or you can take a look at the approach used as it also hooks into ProcessPageView::pageNotFound
  2. adrian

    Innobloom

    Fantastic writeup and insight into the development process and the speed gains from Latte and Procache! Just one quick comment - the image in the banner is suffering from some JPEG pixilation around the person. Weird thing is that photo is actually of where I am currently hiking/climbing
  3. Hi @RobinS - thanks for the report - I am still away from the office and don't have a chance to test properly right now so not sure if I am on the right track, but would you mind testing the attached version of ProcesswireLogsPanel.inc (attachment removed as it is now available as part of the Github repo) - based on the error message I think it should fix things, but you mention the error is in all panels, however I think the error is likely just propagating through and is really on coming from this file. Let me know if this works - if it doesn't, I sort it out properly when I am back in the 8th of June. Thanks!
  4. Before I go, here's a preview of a php console that will be released when I am back. Enter code which runs in the background via ajax, with the results displayed below. It will also support ACE editor for code highlighting and other cool things. 10/4, over and out!
  5. Just heading out the door - honest , but just wanted to say that I am definitely keen on the functionality being discussed and am keen to build it - I am also not sure if it belongs as part of Tracy, but I do like the idea of having one toolbar that can handle all my needs. As it is, I often also use horst's ALIF for the user switching functionality. I am not sure I would want a third toolbar for viewing TODOs, and posting/reviewing issues/bug tracking. I think that potentially Tracy could morph into something that is all encompassing because I think with the Panel Selector panel you have a very easy way of enabling/disabling tools quickly as needed. I am interested to hear how the discussion has progressed when I am back, that's for sure.
  6. Yeah, I fixed that a while back - Tracy is now at 1.7.7 Btw - thanks very much to both you and @szabesz for all your thoughts on the notes/issue tracker panel. I am packing to leave shortly, so haven't liked/responded yet, but some great ideas/discussion which I'll respond to properly when I am back in two weeks.
  7. Thanks - if you (or anyone else) get the time that would be great, but don't stress about it
  8. I like where you are headed @szabesz - I think issue tracking displayed within the context of the page it refers to could be an excellent tool for giving and receiving feedback to/from clients. I am pretty excited about this because I have a hard time getting clients to interact with trello - maybe having this right on the website will make it more usable for them. I am going on vacation for the next two weeks starting tomorrow, but I would like to look into this when I am back. It would be great to get more thoughts from others before I start coding it, so feel free to continue the conversation while I am gone. Anyone feel like mocking up the UI so we can plan the implementation well? Back to the issue of the core Tracy master branch - that still hasn't been fixed so I have rolled the included code back to the version of the core before the problem showed up. I think that is the best compromise until it's fixed - at least this way you can get most of the improvements of the new version. Be sure to clear your browser cache if you find issues after rolling back - there were some CSS changes that caused the panels to be a bit buggy when I first rolled back. See you all in a couple of weeks.
  9. Hey Soma and Charles, Sorry about the issue with the master/dev version of the Tracy core - this is a recent problem that started 3 days ago: https://github.com/nette/tracy/issues/185 - I was hoping I would get a response that would help me get it going again, but still no luck, but hopefully it will be up and running again soon. Soma - I think the panel positioning/moving issues have all been fixed in the master/dev version. I was contemplating backporting to stable, but the master version has been tagged as RC1, so I think it will be released as stable pretty shortly. In summary, depending on your server you will probably need Stable for the moment - I'll update here as soon as master is reliable again because there are some great improvements in the new version.
  10. I think you might need to do that via an API call
  11. Quick FYI - I just committed support for using the Validator behind htaccess protected sites. There are new config settings for entering the username and password to be sent with the request. @tpr has just tested for me and it's working great for him, but because I am using wireHttp->get first, and then falling back to file_get_contents, I am not sure if it will work for everyone as is. Not enough time right now to test thoroughly, so let me know if anyone using htaccess protection has any problems with this new one. To quote @tpr - "I can no more hide behind htpasswd and say that "Everything is valid, trust me" :)"
  12. I think it would definitely be worth posting this as an issue on Github. Thanks!
  13. Great - thanks for testing and letting me know! Back to the authorization issue - it is possible to send the username and password so it's possible to actually get the html of the page so it can be sent to the validator - let me know if you think that would be a worthwhile addition. Speaking of new functionality, I have just had an idea for a "Notes" panel. The content would be unique to each page and the idea is that it would be a place to store notes about changes that are still needed for the page. I would store the info either in a dedicated sql table, or perhaps in JSON in a text file that can be parsed on load. I know most of us make use of services like trello or similar for keeping track of tasks during development, but I am wondering if this might also be useful because the notes are available in the context of the viewed page. I am also working on a TODO panel which parses out //TODO, //FIXME etc from your php scripts. Not sure if there is too much overlap between these two panels. I know that when I use //TODO in my code it's usually about code improvements/refactoring etc, whereas I think the Notes panel would be more about content/layout/functionality changes. Anyway, I'd really appreciate hearing everyone's thoughts on whether they would find either of these useful and what the ideal approach for your workflow might be.
  14. Interesting - I was just dealing with something similar with AdminRestrictBranch but solved it a different way by hooking into executeNavJSON Here's the approach just it's helpful for you or someone else: https://github.com/adrianbj/AdminRestrictBranch/blob/master/AdminRestrictBranch.module#L110 PS - I am certainly not suggesting mine is better in anyway - just a different approach to share
  15. @tpr - some of that was intentional, but some was a result of the last change. The latest version now cleans this up better and should look like this: or: Please confirm that it looks the same for you now too - thanks!
  16. No problem at all - sorry it's causing you problems The line you point to is to clean up the returned results for display - the results start with <ol> for both the standard and html5 validators so I am not sure why, but I have committed a new version which has a much cleaner approach to extracting the contents of the <ol> - hopefully this will mean that $this->result won't end up blank for you, which is what must be happening to cause that error which is triggered here: https://github.com/adrianbj/TracyDebugger/blob/master/ValidatorPanel.inc#L510 Please let me know if the new version helps.
  17. I have had similar issues as well Steve, just last week actually - it's not just your Cloudfront node
  18. @tpr - do you have apache authorization required for the website? I am trying to figure out that authorization error and that seems like the likely culprit. EDIT: http://www.hashbangcode.com/blog/using-authentication-and-filegetcontents - seems to be the cause, but maybe it's something else unrelated!
  19. Sorry about that Charles - I reverted a commit from last night that turned out to be a bit buggy, but I forgot to revert the version number in the modules directory. I have just recommitted a fixed version with that new version number, so hopefully your update should now work. The new version uses a <select> for choosing from available alternate template files. I think this makes it easier. It now also remembers different dev versions for different templates. Obviously you need to create the file in the templates directory first before it will be available from the select dropdown. You can now also reset just this template, or all templates on the site. @tpr - thanks for those great mockups - I haven't had time to incorporate your ideas yet, but will do hopefully shortly. The error you are getting is specifically with the validation panel - I am not completely sure why file_get_contents is giving that authorization required error. I am using wireHttp first and falling back to file_get_contents. I will look into this soon also, but in the meantime, disabling the Validator will gets things going for you. The latest version also includes some core Tracy updates which introduced lazy rendering of panel contents - this should speed up initial rendering of the debugger bar significantly.
  20. That makes such a huge difference - I have a query (that I was obviously caching) which was taking around 4-5 minutes, that now happens in 45seconds! Obviously I still need to optimize some other components, but this is a huge improvement - thanks to everyone involved in this!
  21. Hey @tpr - thanks for your thoughts on this. Perhaps the styling of those buttons could be improved to make it more obvious what is selected. In the PanelSelector Panel I add an icon next to each panel to indicate it is is loaded "Once" which I think works, but perhaps it could be improved by having a selected/pushed state added to it. Anyone else have any thoughts on this? A design mockup sounds like it could be helpful, but please don't go to too much trouble - I think I understand what you are wanting.
  22. Definitely weird - if $i->filename is definitely returning the full server path to the file, and PHP's filesize() isn't working on it, then I am baffled Apparently some hosts disable filesize(), but you mention that it works on the frontend, so that would rule out that possibility.
  23. Another really cool (at least I think so ) panel. Template Path allows you to temporarily change the template file of the page. By default, it adds "-dev" suffix to the filename, eg. home-dev.php, but you can change this on-the-fly to whatever suffix you want, allowing you to easily test different versions. Like the selector panel, you can make the change "Once", or "Sticky" for the session. Sticking with the "alert" approach to icon colors, if the template icon is green, then it is loading the default template file. If it is red, then it is loading your temporary template file. Hopefully you'll all find this very useful when debugging live sites - no excuses now to ever make changes to a live file without testing first Please let me know if you have any suggestions for enhancing this feature - we all work differently, so there might be some cool approach that I could support that I haven't yet thought of.
  24. Out of curiosity, does this work: filesize($file->filename); Hang on a second - you say that: $file->title works - but this is not properties of files What exactly is $file referencing?
×
×
  • Create New...