Jump to content

gmclelland

Members
  • Posts

    565
  • Joined

  • Last visited

  • Days Won

    6

Everything posted by gmclelland

  1. Would you also consider adding more contrast/weight to the active link to help show your current position/location in the sidebar navigation? Maybe something like this?
  2. Hi Ryan, can you make all the text left justified instead of centered when viewing the site on mobile? I find it hard to read when the text is ragged. I'm referring to the blog posts and the blue footer text (twitter posts, forum postings, Latest news, etc.) I also noticed after typing in the search field on the site, every time you hit the down arrow key to try to select one of the autocomplete suggestions a spinner shows like it is searching again.
  3. For what is worth... Here are my notes that I've gathered from the forums and other places. Maybe something like this can be used somewhere? from @kongondo and others **************************************** When coding inside of modules you cannot directly access the PW API variables like $pages, $session, $input etc.. Those are available at $this->pages or wire('pages'). If you have static method(s) in your modules then you need wire('pages') there - so if you want to play it safe always use that (it works on command line scripts also) **Outside a function and class. Ex. in templates $page; $pages; $sanitizer; $input; $modules; $templates; $fields; $user; $users; $log; $session; $config; __('Translate me baby'); **Inside a function or classes not extending WireData wire('page'); wire('pages'); wire('sanitizer'); wire('input'); wire('modules'); wire('templates'); wire('fields'); wire('user'); wire('users'); wire('log'); wire('session'); wire('config'); **Inside classes extending WireData $this->pages->find('something'); **Inside a class not extending WireData $this->wire('page');// also $this->page; $this->wire('pages');// -ditto- $this->wire('sanitizer');// -ditto- $this->wire('input');// -ditto- $this->wire('modules');// -ditto- $this->wire('templates');// -ditto- $this->wire('fields');// -ditto- $this->wire('user');// -ditto- $this->wire('users');// -ditto- $this->wire('log');// -ditto- $this->wire('session');// -ditto- $this->wire('config');// -ditto- $this->_('Your string to translate’); $title = wire()->fields('title'); // in a regular function outside of an object $title = $this->wire()->fields('title'); // in a Wire-derived object $title = $this->fields('title'); // in a Wire-derived object (alternate syntax) from here /** * Global function, therefore does work everywhere, * but will always refer to the first pw instance * in case of multi instance usage. * Because of that it's discouraged to use this in * modules. */ wire("apivar") /** * Safest way to get the api variable in wire derived * classes like modules. */ $this->wire("apivar") /** * Does work as well, but some (core) classes have that * type of access disabled. It also prevents you from * using a custom paramater $apivar in your class. */ $this->apivar From here In hooks use $event->wire() instead of wire() because it is multisite instance aware ****************************************
  4. @Craig A Rodway - I'm not seeing the horizontal scrollbars anymore unless I resize the text to 120% at that point the Docs menu is off. At the standard 100% the menus open correctly for me in Chrome / Firefox Mac. Ryan, on the latest blog posting https://processwire.com/blog/posts/rebuilding-the-pw-site-5/ I still see 2 "Prev" links which seems confusing. If it is the latest blog posting, I would think it should only show 1 "Prev" posting instead of two previous postings? Other blog posts look correct like on https://processwire.com/blog/posts/pw-3.0.123-master/ Thank you for all the work that you have put into this!
  5. @Chris Bennett - is right. The .blog-posts rule negative margin-left and margin-right on the home page are causing the horizontal scrollbars. It happens when the blogposts go edge to edge at less than 1599px width. Here is how I found out. From https://css-tricks.com/findingfixing-unintended-body-overflow/ In chrome's dev console, run the following when you see the horizontal scrollbars. The console will print which html element causes the overflow. Right click on it and choose "Reveal in Elements Panel" to see the offending element. Another way to try to find this using the following css: * { outline: 1px red solid !important; } and look for the elements that have excessive width. Here are some other items causing the horizontal scrollbar. The .footer and the header the .pw-plug>div rule with width: 4%; is causing an overflow when viewing the site on small mobile viewports (444px width). In the Processwire Showcase carousel left/right arrows using the .uk-slidenav rule with padding: 5px 10px is causing the right arrow to overflow the page at smaller breakpoints 908px. In the Processwire Showcase carousel dots menu using the .uk-dotnav rule with margin-left: -12px; might cause a horizontal scrollbar. .uk-slidenav rule with padding: 5px 10px; at 699px width might cause a horizontal scrollbar. You probably could get around all these issues with overflow-x:hidden; rule on the html/body element, but it might be better to find out and fix what is causing the scrollbars so that it doesn't causes other bugs? The overflowing elements might be the cause of the dropdown menus not positioning correctly. Hope that helps
  6. Couple of bugs: Broken Link - "Oliver's ProcessLanguages" https://processwire.com/newsite/docs/multi-language-support/multi-language-fields/ Broken Link - "See these examples of how multi-language fields can be used to produce a multi-language website." https://processwire.com/newsite/docs/multi-language-support/multi-language-fields/ Old admin theme images displayed - https://processwire.com/newsite/docs/multi-language-support/multi-language-urls/ Some videos show an older version of processwire. Maybe add a caption underneath the videos that indicates that the video's content is using an older version but is still relevant? On https://processwire.com/newsite/docs/start/install/upgrade/ Maybe mention @adrian ModuleToolkit module for bulk module upgrades?
  7. I see it because I had my Chrome browser zoomed to 110%. I think it might be caused by the overflow issue that @Jonathan Lahijani mentioned at
  8. @Robin S - haven't tried these, but maybe https://sitemod.io/ or https://userstyles.org/ or https://www.styleurl.app/ or https://www.canvasflip.com/visual-inspector/?
  9. Looking good Ryan. One thing I noticed is the last dropdown menu "Docs" should open the same direction/way as the "Download" menu item but it doesn't. It opens off screen causing horizontal scrollbars. When viewing on Chrome. Edit: it looks like jmartsch beat me to it. Please consider giving the light grey and other muted text more contrast for accessibility. See https://contrastrebellion.com/ for humor. #666 for body copy gives AA, but #565656 gives AAA for example. Chrome's inspector now includes a contrast accessibility checker when you click on the color swatch/square. The curved line represents what passes the AA or AAA rating. After reading the API examples, I want to know more about it. I think we need a link or outlined button below the examples "Get started with the API" or "Learn more" so they can continue reading. Now that I look at it more, maybe each homepage section needs it own call to action button below. At first it wasn't entirely obvious that the headers on the homepage were links. Ex. Blog posts - might need a button below that say's "View all" or something similar. Same for the Processwire Showcase and Shop. - This might actually motivate new users to join the forums as well. Those are just a few of the first things that come to mind when viewing the site. Hope that helps
  10. Do you have a "Portfolio" page with "Project" pages below it? What does you setup look like? Maybe you describe what your template is trying to do?
  11. Perhaps it should be: $portfolio_pages = $pages->get('/portfolio/')->projects;
  12. $pages->get->projects; That looks strange to me. Maybe you can look at the examples on https://processwire.com/api/variables/pages/ ? I'm not sure why it worked before?
  13. See this post. It has some good code comments: and Also check the module's source code. That helped me. https://github.com/processwire/processwire/blob/dev/wire/modules/Markup/MarkupAdminDataTable/MarkupAdminDataTable.module Hope that helps you
  14. It looks like you might have already considered and built this type of functionality https://github.com/mtwebit/DataSet/wiki/Import-rules#data-conversion-during-import
  15. Thanks for sharing your modules @mtwebit! This looks like it could be really useful. Is there any way you could include a place to add a url to the file instead of an upload? For example, I store staff's contact information in a Google Spreadsheet. This spreadsheets gets updated all the time. It would be cool to just add the url to csv file instead of having to download the file and upload it into Processwire. The input could also remember it's previous value so I can run the import over and over again as needed. Maybe it also could be somehow automated to run the same import everyday? If not, no worries. Thanks again.
  16. For those who wonder how they can have a module with the third party PHP library managed by Composer, see https://processwire.com/blog/posts/composer-google-calendars-and-processwire/ Also, here is the issue that talks about making Composer's vendor directory location configurable and possibly blocking the vendor/ folder via .htaccess: https://github.com/processwire/processwire-requests/issues/191
  17. I also just tested on another fresh site. If I try to install fieldtype-leaflet-map-marker via Modules > Install > Add New, it installs 2.8.1 instead of 3.0.3 on my Processwire 3.0.120 site. I'm not sure why?
  18. @Mats - something strange is happening when I upgrade the module from 3.0.2 to 3.0.3 using Processwire's Upgrade module. When I try to upgrade the module, it goes from 3.0.2 to 2.8.1 instead of 3.03. I wonder if you need to update the module's version or branch on processwire.com modules directory? If I manually download the github version on the PW3 branch, I get 3.0.3 which is the correct version. @houseofdeadleg - Maybe you could try geocoding that same address on the site that is working to make sure it isn't something wrong with the address itself? I would recommend upgrading those sites that are on 3.0.61 and 62. There has been many changes and bugs fixed since then. Using the Processwire Upgrade module makes it easy to upgrade. Sorry, I'm not sure what else the problem could be?
  19. For the PW 3.0.61 site, make sure you use the PW3 branch on github. Maybe that is why it isn't working properly? I believe the console error you are getting about the source map missing has been fixed in Processwire. Upgrade Processwire to the latest dev release and that error should go away.
  20. Hi @spackmat, welcome to the forums. Some fields have basic validations that can be configured in the field's settings. In more advanced cases like you mentioned, it would be better to handle those with hooks to add your own validation.
  21. Thanks bernard, great writeup! In case it helps someone else, here's the guides I use(which are very similar) https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/ https://akrabat.com/the-beginners-guide-to-rebasing-your-pr/ - the followup
  22. I wonder if adding this to your site's /site/config.php file will work? // I receive a warning when visiting the admin area // Warning: your server locale is undefined and may cause issues. Please add this // to /site/config.php file (adjust “en_US.UTF-8” as needed): setlocale(LC_ALL,'en_US.UTF-8'); setlocale(LC_ALL,'en_US.UTF-8');
  23. That fixed it. Thanks for the quick fix.
  24. Hi Adrian, just wanted to let you know that I just upgraded to latest TracyDebugger and received the following error on the API Explorer Panel: Error: Call to a member function convertNamesToUrls() on null in /Users/glenn/websites/pwmlec/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ApiExplorerPanel.php:205 Stack trace: #0 /Users/glenn/websites/pwmlec/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/panels/ApiExplorerPanel.php(108): ApiExplorerPanel->buildTable('adminTheme', Array) #1 /Users/glenn/websites/pwmlec/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(161): ApiExplorerPanel->getPanel() #2 /Users/glenn/websites/pwmlec/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Bar.php(110): Tracy\Bar->renderPanels() #3 /Users/glenn/websites/pwmlec/wwwroot/site/assets/cache/FileCompiler/site/modules/TracyDebugger/tracy-master/src/Tracy/Debugger.php(294): Tracy\Bar->render() #4 [internal function]: Tracy\Debugger::shutdownHandler() #5 {main} Thanks for the all the improvements! They look really helpful.
  25. Not sure, I fully understand you. In your page field change the input to "Page List Select."
×
×
  • Create New...