72 replies to this topic

[Pete]

I missed the XML sitemap generator that I used in a previous CMS so I built my own module to achieve the same functionality.

This module outputs an XML sitemap of your site that is readable by Google Webmaster Tools etc. I've generally found that it reduces the time it takes for new sites and pages to be listed in search engines using one in combination with Webmaster Tools etc (since you're specifically telling the service that a new site/new pages exist) so thought I may as well create a module for it.

The module ignores any hidden pages and their children, assuming that since you don't want these to be visible on the site then you don't want them to be found via search engines either.

It also adds a field called sitemap_ignore that you can add to your templates and exclude specific pages on a per-page basis. Again, this assumes that you wish to ignore that page's children as well.

The sitemap is accessible at yoursite.com/sitemap.xml - the module checks to see whether this URL has been called and outputs the sitemap, then does a hard exit before PW gets a chance to output a 404 page. If there's a more elegant way of doing this I'll happily change the code to suit.

Feedback and suggestions welcome

On a slightly different note, I wanted to call the file XMLSitemap originally so as to be clearer about what it does in the filename, but if you have a module that begins with more than one uppercase letter then a warning containing only the module name is displayed on the Modules page, so I changed it to Sitemap instead which is fine as the description still says what it does.

File can be downloaded via GitHub here: https://github.com/N.../zipball/master

[Pete]

Here's a list of services you can submit your sitemap to:

Google Webmaster Tools
Bing Webmaster Tools

There used to be a service for Yahoo called Site Explorer that was similar in functionality to the above two services, but it appears that this has now been replaced with Bing's offering. On the bright side it's one less service to sign up to

You can also submit to Ask using the following URL (replacing the relevant part with the full URL to your sitemap):

http://submissions.ask.com/ping?sitemap=http://www.the URL of your sitemap here.xml

Generally I find Google and Bing to be sufficient though, as the other search services seem to trawl their content reasonably quickly and find out about new sites that way sometimes I think.

[formmailer]

It is also recommended to add the following to your robots.txt file (create one if you don't have one):

Sitemap: http://www.your-domain.com/sitemap.xml

This allows search engines to find your sitemap.xml, even if you didn't submit it to that specific search engine.

Regarding this module, until now I've always used a sitemap.xml template. When I created that one I used the regular sitemap page as an example.
But I will certainly try this module sooner or later.  

/Jasper

[Pete]

That's actually how I began this module - as a separate template - but then I thought it would be quicker as a module and then there's no need for an actual page or any templates and it's all in one file.

Plus I really wanted to have that optional sitemap_ignore field that I'd used in the previous CMS I worked with.

I'm glad I did start creating it as a template and page though, else I'd have had more hassle working out why it wasn't outputting XML (I needed to specify that XML was being outputted by using a PHP header).

[ryan]

Pete, nice job with this module, it looks very well put together and provides a helpful function. I like the simplicity of it being a module and how easy that makes installation. But there are a couple potential issues with this approach I wanted to mention.

First is that it's taking the place of the 404 page and a 404 header is getting sent before the sitemap.xml output is displayed. This will probably be an issue for any search engines that hit it. You can avoid this by moving everything from your generateSitemap() function into your init() function. You don't need to use any hooks. Of course, you won't have a $page to check at the init() stage, but I don't think you need it–just get rid of the $page->template != 'admin' check... your strpos() below it is likely just as fast.

Next concern is scalability. Generating this sitemap could be a slow thing on a large site. Anything that's slow to generate can be a DDOS hole. Because it's in a module, you can't as easily cache the output with a template setting. However, you could use the MarkupCache module to perform your own caching, and that's something I'd probably recommend here.

Last thing is that I'd suggest renaming the module since it falls in the Markup group of modules. Perhaps the name MarkupSitemapXML?

Other than that, I think it looks great.

[Pete]

Thanks ryan - I was a bit worried about the 404 so this is a good solution and something I'll definitely bear in mind for future modules. I enjoy writing these modules as every one teaches me something new about how PW works behind the scenes.

I've implemented your suggestions and replaced the file in the first post with the modified version with the new name (if anyone has this installed already, simply uninstall the old module, delete the module file and install the new one).

I also implemented caching as you suggested and cached it for an hour (for most sites a day or more would probably be fine, but if you're writing articles or running a blog you want search engines to index your content as soon as possible so that seemed like a good period to set it at thoguh I've no idea how often search engines actually check a sitemap).

I agree that there are quite a few potential issues on larger sites and not just because of the sitemap's size. Google doesn't always index everything on larger sites, and I was just reading about how someone tested this by telling Google that things like news posts and forum posts (individual posts, not threads) should on;y be indexed once as they're unlikely to ever change. This apparently frees up the search engine crawlers to check the new content rather than go over the same content each visit.

I can see a few places that this would be useful in PW - for example a news section would only need each article to be indexed once (if you ever went back and edited a page, I believe the last modified date would force a re-index) and various other similar examples.

There's a good list of tags for sitemaps here: http://support.googl...n&answer=183668 and the tag to use would be <changefreq> , however that could get a bit tiresome if you had to have it on every page. A potential solution for a future version of this module would be to have such a field and simply have all child pages inherit the parent value if they don't have one set themselves.

Another option as a possible alternative to caching would be to run the module once on the first time the page is called, then only re-generate the sitemap once a page is edited/created/deleted as those are the only three times a change to the sitemap would technically be required.

I'll leave it as it is for now though.

[Pete]

I forgot to ask - is there a better way of having a module run when an admin-only page is loaded other than this:

<?php
if ($page->template != 'admin') {
  // Do stuff
}
?>

It's no longer relevant for this module as it now runs before the page data is available, but when I had it in the first version I gave myself a pat on the back for figuring I could check for the admin template like this. I can see how such a check would be good for other modules though so just wondering if there's a better way for checking if we're in the admin.

[formmailer]

You also could use a Sitemap Index (<sitemapindex>) which allows you to have multiple sitemaps per site.
This allows you to break your sitemap up into several smaller sitemaps. You could even have different cache times per branch, eg. 5 minutes for the news section and 1 day for the other pages.

/Jasper

[Pete]

Very good point - I'd completely forgotten about that!

One of the forum applications I use has this though I'm quite far behind on the versions. I believe they had one for forums, one for posts, one for calendars etc. It would have made more sense for them to split up posts by forum though as it gets a bit silly if it tries to put a million posts in one file (I don't have that problem fortunately ).

So thinking about this a bit more, it would make sense to have some template settings for this module too in a future version and specify cache times and re-index periods for all pages there. It could then create separate sitemaps on a per-template basis as you say. I think that would cover most eventualities there.

My only gripe would be that caching per-template wouldn't help if you were running a large blog/news site as one main template would apply to most of the content. Perhaps splitting it per year, or simply having it split the sitemap at X thousand pages if you have a huge amount of articles? I think per-year sitemaps for larger article sections would be best thinking about it. Presumably if a page from 2009 is modified and then ends up in the 2012 sitemap it's not a big issue - Google will be told in 2012 sitemap to index it again and it's not like you're going to modify old articles particularly often so I wouldn't see a need in cleaning up the 2009 cached sitemap in this case.

It does look like you can easily have a master sitemap linking to sub-sitemaps though so that part is pretty straightforward at least (and it looks like 50,00 pages per sitemap is the maximum allowed): http://googlewebmast...-directory.html

Anyway, this is one for when I next get a few free hours

[ryan]

Great update, thanks Pete!

What do you think about putting this on GitHub? (whether now or in the future)?

For the cache time, you could always make it configurable with the module if you wanted to. Let me know if I can assist.

I also like your alternative for time based caching, though I'm guessing time based caching is adequate for most. But if you want to pursue that alternative, you'd use the CacheFile class directly and have a Pages::save hook clear the cache file (or maybe just Pages::added and Pages::deleted hooks).

I wasn't aware of the <sitemapindex>, this sounds like a good idea for the large sites. But also sounds like a much more complex module.

[Pete]

Cheers ryan

Forgot I had a Github account for a sec there. Added, updated the link in the first thread and added it to the growing modules spreadsheet on Google Docs

Yup - I'll probably make the time configurable at some point in the future as it seems like an easy interim update before doing anything more complicated.

[ryan]

Nice job Pete. It's easier to follow on GitHub just because we can pull in updates automatically without downloading, unzipping, etc. So many great new modules lately. I need to make a lot of additions to the modules directory.

[theSeekerr]

Mine is throwing an error:

Exception: Unable to create path: /MarkupSitemapXML/ (in /home/theseeke/public_html/wire/core/CacheFile.php line 62)
This error message was shown because you are logged in as a Superuser. Error has been logged.

From a quick read of the relevant modules, it's not apparent to me where it's trying to create that directory.

[Pete]

It sounds like your site/assets/cache directory might not be writeable (it needs to be in order to be able to cache the sitemap). Hopefully making that writeable (CHMOD 644 probably) will fix that.

The cache folder itself isn't solely related to this module, so I'm sure you would have come across that message sooner or later.

Hope that fixes it for you

[theSeekerr]

It sounds like your site/assets/cache directory might not be writeable (it needs to be in order to be able to cache the sitemap). Hopefully making that writeable (CHMOD 644 probably) will fix that.

The cache folder itself isn't solely related to this module, so I'm sure you would have come across that message sooner or later.

Hope that fixes it for you

No such luck - still didn't work. Also tried 755 and 777 on the off chance, and recursed it through that whole tree to be sure.

Incidentally, file uploads and caching of size()'d images are working fine.

[Pete]

Hmm... that's odd, I'll take a look at the module. Cheers for checking that though.

[apeisa]

Looks like it tries to create /MarkupSitemapXML/ folder in the root. There should be full path to cache folder visible on error msg.

[Pete]

I worked it out - you have to install the Cache module as well, which is present in the default PW installation, just not installed by default (I already ahd it switched on on my test account!).

That will make it work, but I do need to put some sort of check into my module to make it a bit easier (need to read the posts around here on module dependencies).

[theSeekerr]

I worked it out - you have to install the Cache module as well, which is present in the default PW installation, just not installed by default (I already ahd it switched on on my test account!).

That will make it work, but I do need to put some sort of check into my module to make it a bit easier (need to read the posts around here on module dependencies).

Still doesn't seem to work, same error msg, damned if I know why?

http://theseekerr.com/sitemap.xml - there it is, if staring at my error provides any sort of motivation.

[Pete]

Could you try uninstalling both modules and then reinstalling the cache one first and see if that helps please?