Jump to content

Recommended Posts

I haven't had a chance to play with this yet, but I know it will be used on an upcoming site - just wanted to say how great it looks and most importantly how impressive the documentation looks to be - love the use of Github wiki!

  • Like 1

Share this post


Link to post
Share on other sites

You were probably going to have countless issues if you'd played with it before yesterday as I didn't test across multiple PHP/MySQL versions. (I'm lazy like that.)

But all seems to be good now - lemme know if you bump into any issues.

Was going to host the docs myself... but the tools are there, so use them - hehe!

:)

Share this post


Link to post
Share on other sites

The mapping collection API has been modified:

  1. Method has changed from addCollection() to collection() due to:
  2. the fact that it now picks up if a collection already exists so that it can add data to it.

Docs updated.

(Thanks Dave.)

Share this post


Link to post
Share on other sites

Just fixed up a little issue regarding the first TIMESTAMP column being auto-updated.

Basically swapped the created_at and updated_at columns around, and removed the updated_at = CURRENT_TIMESTAMP bit from the SQL template used for updating mapping collections.

I could have just defaulted to NULL for both of these timestamps, but I think this is better. Who cares about column order, anyway?

Share this post


Link to post
Share on other sites

Okay, so after all those fixes, my testing seems to show that everything is stable. Everyone agree? I'd like to set this to stable in GH and in the directory.

  • Like 1

Share this post


Link to post
Share on other sites

Are we ready to go ahead and make this stable? I haven't encountered any further issues...

Hell yeah. I didn't encounter any further problems, but I haven't done the big test yet. 

  • Like 1

Share this post


Link to post
Share on other sites

I've just installed the module, but it seems the redirect is to late and I get a "Cannot modify header information - headers already sent by" error.

Edit:

Changing the hook from addHook() to addHookBefore() solved the issue.

Share this post


Link to post
Share on other sites

I've just installed the module, but it seems the redirect is to late and I get a "Cannot modify header information - headers already sent by" error.

Edit:

Changing the hook from addHook() to addHookBefore() solved the issue.

What sent headers first?

Share this post


Link to post
Share on other sites

My templates _init.php, but even as I removed that part the rendering of mustache in a appended TemplateFile was earlier than Jumplinks.

Share this post


Link to post
Share on other sites

I see. So there could be a lot of scenarios involved. Think it would be worth it to change the hook to something way early, and then check to see if a page representing the request exists? We could also add a configuration option that defaults the hook to pageNotFound, but allows you to specify if something is rendering output before the 404. Would be a simple checkbox that says, "Check Jumplinks in an early event - this prevents interruptions from other hooks/templates/etc."

What do you think?

Side note: my Redirects module for Bolt ties into a very early app event. Sure, the caveat is that pages that exist with the request uri are ignored, but we could add a simple check. Perhaps it would also perform redirects faster, as less things boot up?

Share this post


Link to post
Share on other sites

I think the hook is the right one, just addHookBefore does force template rendering to wait for your hooked function to finish, while addHook doesn't seem to do this.

Share this post


Link to post
Share on other sites

I think we're ready for stable. I'm first going to switch over to prepared statements - silly me for not doing this first. Once done, I'll switch over to stable.

Share this post


Link to post
Share on other sites

Version Bump to 1.1.0

Module is now stable (it looks to be, at least).

  1. Now using PDO Prepared Statements
  2. Tables honour responsiveness now - there was an issue with tfoot, so I just hid it from mobile...
  3. Various bug fixes
  4. No schema changes

Let me know if you bump into anything weird.  ;)

Oh, and there's this issue - anyone have any input on that? (Personally, I prefer to have full control... Don't really like modules making decisions for me.)

  • Like 3

Share this post


Link to post
Share on other sites

Version Bump to 1.1.1

  1. Using minified JS (manual call)
  2. Refactor SQL object
  3. Various other changes/fixes
  4. No schema changes

(And GitHub is under attack - boy, how I battled to commit the changes... Finally slipped through after about 20 minutes of trying.)

  • Like 2

Share this post


Link to post
Share on other sites

Version Bump to 1.1.2

  1. Correct page-check behaviour (was using name, now using URI)
  2. Use commitJumplink in CSV importer
  3. No schema changes
  • Like 2

Share this post


Link to post
Share on other sites

I actually had to uninstall the module - it was causing excessive mysql database connections (not usage) and my webserver nearly stalled.

Maybe I run into a loop or something?

I was redirecting from an old Drupal website to PW and used about 70 simple type redirects, such as sources  /drupal/page1/   

Got this (on the latest PW dev)

Error:

Exception: SQLSTATE[HY000]: General error: 1116 Too many tables; MySQL can only use 61 tables in a join (in /wire/core/PageFinder.php line 300)

Error:

Exception: DB connect error 1203 - User already has more than 'max_user_connections' active connections (in /wire/core/Database.php line 68)

I cannot say 100% that this was Jumplinks. I just noted that the performance was back to normal after I uninstalled the module.

So this is just for information in case anyone else can confirm this.

Share this post


Link to post
Share on other sites

Thanks for your post. :-)

Looks like another module is doing that. Jumplinks only creates two tables (one for jumplinks, and another for mapping collections).

In terms of performance, I'm unable to test that sort of thing. Are you saying that those errors go away when you uninstall Jumplinks? Do you have the same issue if you use ProcessRedirects?

If you (or anyone else) could provide me with more information, that would be great. Otherwise, I can't determine what's going on.

Share this post


Link to post
Share on other sites

On the topic of performance, I'm now wondering if I should set up a cache system for Jumplinks. It was mentioned by Antti a while back that Jumplinks is already feature-rich, but I think that caching redirects will actually be a life-saver for some users with large sites. At the end of the day, running the regex engine for every incoming request is sure to be a big performance hit on any server (the way I see it).

I'm sure everyone agrees this should be added?

There are also a few other fixes and enhancements in the pipeline, the most important one involves optional query-strings (much like the QSA flag for mod_rewrite). At the moment, if you want to match something.php and something.php?foo is requested, the redirect will not occur. In order to get it to work, you'd need to add {all} on the end of the source URI, which is, quite frankly, not the best way of doing it.

  • Like 3

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory (alpha version only available via GitHub) SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
    • By gebeer
      Hello all,
      sharing my new module FieldtypeImageReference. It provides a configurable input field for choosing any type of image from selectable sources. Sources can be: 
      a predefined folder in site/templates/ and/or a  page (and optionally its children) and/or the page being edited and/or any page on the site CAUTION: this module is under development and not quite yet in a production-ready state. So please test it carefully.
      UPDATE: the new version v2.0.0 introduces a breaking change due to renaming the module. If you have an older version already installed, you need to uninstall it and install the latest master version.
      Module and full description can be found on github https://github.com/gebeer/FieldtypeImageReference
      Install from URL: https://github.com/gebeer/FieldtypeImageReference/archive/master.zip
      Read on for features and use cases.
      Features
      Images can be loaded from a folder inside site/templates/ or site/assets Images in that folder can be uploaded and deleted from within the inputfield Images can be loaded from other pages defined in the field settings Images can be organized into categories. Child pages of the main 'image source page' serve as categories mages can be loaded from any page on the site From the API side, images can be manipulated like native ProcessWire images (resizing, cropping etc.), even the images from a folder Image thumbnails are loaded into inputfield by ajax on demand Source images on other pages can be edited from within this field. Markup of SVG images can be rendered inline with `echo $image->svgcontent` Image names are fully searchable through the API $pages->find('fieldname.filename=xyz.png'); $pages->find('fieldname.filename%=xy.png'); Accidental image deletion is prevented. When you want to delete an image from one of the pages that hold your site-wide images, the module searches all pages that use that image. If any page contains a reference to the image you are trying to delete, deletion will be prevented. You will get an error message with links to help you edit those pages and remove references there before you can finally delete the image. This field type can be used with marcrura's Settings Factory module to store images on settings pages, which was not possible with other image field types When to use ?
      If you want to let editors choose an image from a set of images that is being used site-wide. Ideal for images that are being re-used across the site (e.g. icons, but not limited to that).
      Other than the native ProcessWire images field, the images here are not stored per page. Only references to images that live on other pages or inside a folder are stored. This has several advantages:
      one central place to organize images when images change, you only have to update them in one place. All references will be updated, too. (Provided the name of the image that has changed stays the same) Installation and setup instructions can be found on github.
      Here's how the input field looks like in the page editor:

      If you like to give it a try, I'm happy to hear your comments or suggestions for improvement. Install from URL: https://github.com/gebeer/FieldtypeImageReference/archive/master.zip
      Eventually this will go in the module directory, too. But it needs some more testing before I submit it. So I'd really appreciate your assistance.
      Thanks to all who contributed their feedback and suggestions which made this module what it is now.
       
×
×
  • Create New...