Notice: Undefined index: searchFields after update to 2.5 dev

[gebeer]

Hi,

I upgraded a site in development from 2.5 stable to 2.5.7 dev by copying /wire/, index.php and .htaccess over.

After the upgrade, I get a notice on frontend and before login to the admin, when $config->debug = true

Notice: Undefined index: searchFields in /var/www/pwbootstrap3/wire/modules/System/SystemUpdater/SystemUpdate5.php on line 128

After login there is no admin page visible, only debug info.

I can see in the Variables on local scope that $admin returns a nullpage.

When I switch debug to false, I can see and use the admin.

Couldn't find anything related here in the forum.

Any pointers how I can fix this? Thank you.

[Raymond Geerts]

You could fix this by modifying the given line from

if($data['searchFields'] == 'title body') {

to

if(isset($data['searchFields']) && $data['searchFields'] == 'title body') {

Seems that $data['searchFields'] is undefined, thats causing it to throw a notification.

In general notifications are not much of a problem, altough if it occurs a lot the error.log file can grow tremendously large.

I remember having to look at a site suffering from undefined variables in a loop, causing it to write 5 lines to the log file for every visitor to the page, by the time the problem was noted the log file was over 2 GB.

Not that the specific notification you mention will do that, as far i know that SystemUpdate script is only run once.

[gebeer]

Thank you. This helped partially. But it is only a temporary fix because with the next upgrade it will be overridden. I would consider this a bug.

Now when I login, I can see the admin but all update messages are persistent

When I click them away, they always reappear on the next page load.

When I try and edit a page I get a notice but can edit the page.

Notice: Undefined index: limit in /var/www/pwbootstrap3/wire/modules/Process/ProcessPageEdit/ProcessPageEdit.module on line 994

That line says

$limit = $pageListConfig['limit'];

So things seem a bit messy overall after the upgrade and I would really like to be able to fix this.

[Raymond Geerts]

The first issue was fixed and will be available in the dev branch.

You mention that you see the System Updater messages on each page load in the admin section, this is something Ryan might have to take a look at since it actualy has to run only once, so it seems its not applying the system updates in the database.

On PW 2.5.6 and 2.5.7 i do not see these notifications when $config->debug = true;

edit: forgot the not in "i do not see"

Edited November 3, 2014 by Raymond Geerts

[gebeer]

Thank you Raymond. Will update soon to the latest dev branch and try again.

About those SysUp messages, they are even there when I switch $config->debug to false.

[Raymond Geerts]

Most likely your php.ini file has set error_reporting to some value that contains E_NOTICE

Setting $config->debug = true; will do the same and show E_NOTICE.

In a devlopment environment this can be desirable. On a live server i would change this to something like E_ALL & ~E_NOTICE

See the following page for more information on error reporting.

http://php.net/manual/en/function.error-reporting.php

If you want to hide the notices when $config->debug = false; you should change error_reporting to E_ALL & ~E_NOTICE if you have access to the php.ini file.

[gebeer]

OK, I see.

But what worries me more is the system messages (screenshot in post #3) that are persistent no matter whether I set debug to true or false.

[Martijn Geerts]

I doubt that using php.ini will help here as error_reporting and ini_set is set in the index.php

[gebeer]

So this is overwriting the php.ini settings then, I guess.

Good to know I don't have to fiddle with php.ini settings

[Raymond Geerts]

I doubt that using php.ini will help here as error_reporting and ini_set is set in the index.php

Not all servers let you set error_reporting from inside a php script. Gebeer mentioned that he saw notices even with $config->debug = false; So i presumed that on his server this is the case.

[gebeer]

Gebeer mentioned that he saw notices even with $config->debug = false;

My post about that might be a little confusing.

I do not get any error messages when I set debug to false. I was referring to the system messages from my screenshot in post #3 that are persistent.

Sorry if this has caused you additional work.

[horst]

I use the central .htaccess file with php_value settings for controlling error reporting and some others. php.ini settings affects all virtual hosts on my dev machine.

[owzim]

I have the same problems, see https://processwire.com/talk/topic/8534-admin-update-messages-wont-disappear-after-update-to-2510/

With the notifications AND the limit index thingy. Any updates on that?