Jump to content

adrian

PW-Moderators
  • Posts

    11,097
  • Joined

  • Last visited

  • Days Won

    365

Everything posted by adrian

  1. I am not certainly exactly what isis.pw uses, but I think it looks for things like a response from ?it and /assets/files paths to images. Maybe also ProcessWire in the header. Hopefully teppo will chime in.
  2. Hey @Guy Verville - great writeup and a great looking site! This is a question for both you and @teppo - I am wondering what is unusual about your site that is causing isit.pw to not be able to detect it as a PW site? Or maybe isit.pw is caching an old lookup for your site?
  3. Hey @bernhard - this looks really fantastic - thank you! I have a few comments re code styling to match the rest of Tracy, but I can clean that up after accepting the PR. What I am wondering is if it might be useful to add a $page->getWebHookData() method so that you don't need to know the ID of the hook. Obviously the data that is stored would need to include a pageid (I see you already store that) so this new method could grab an array of objects just for this page. I think it would also be great to be able to do: $page->getWebHookData()->last() to get the last one. Not sure how useful first() and eq() would be in this case. Maybe eq() could be in reverse order so you could get eq(0) as the last received, eq(1) as second last, etc - what do you think? I'll take a better look tomorrow and do some testing, but really excited to start using this!
  4. Thanks for the debugging. That actually makes sense because I have a check to not rename files with "-n" extensions because PW's automatic adding of "-n" when there is already a file of the same name. I'll have to see if I can sort out a workaround for this, but I won't be able to look until tomorrow.
  5. Couldn't CustumUploadNames be modified to handle this need?
  6. Strange - it seems to be working here. Is there something in your setup that differs from this?
  7. Not really sure that could be dealt with without maintaining a database of filename changes and associated page ids and checking against them whenever a page is changed. If you have a simple approach I am not thinking of, I'd be happy to implement.
  8. Good point. I am attaching a new version here for you to test. I don't have much time this morning to test it properly, but hopefully this will also handle that. @simonsays - could also please test this version? ProcessCustomUploadNames.zip
  9. Thanks @Robin S - I see that adding the tabbed interface was a significant amount of work - I think it's awesome though so thank you ? One small thing - it needs a fallback to tab_name if there is no label set. This should be an unlikely scenario, but without it, you can't get to the other tabs. $markup .= "<li class='tfw-tab{$active}' data-tab='tfw-{$tab_name}'>" . ($tab_data['label'] ?: $tab_name) . "</li>";
  10. @PWaddict - it should now work in the latest version. @simonsays - I think all your repeater issues should also now be fixed - sorry again for the huge delay on this.
  11. Oh sorry, I missed that distinction. I'll see what I can do about supporting that situation.
  12. Are you in a repeater or anything else unusual?
  13. Any chance you are inserting into a multi-language textarea field? If so, then it should be fixed in the latest version. If not, please let me know and I can investigate further.
  14. Of course - sorry, I didn't realize that was a goal. I guess I thought it would be ok to use the mouse to activate the other tab. Perhaps an alternative would be to just separate out other tabs below the main Content tab so they are separate. I just think this would help with visualizing the layout better, because at the moment it looks like the fields in other tabs are all part of the one form, which of course they are not, visually speaking. Anyway, not a big deal ?
  15. Tabbing works find in the PW admin when editing a page - you can use the tab key to move between fields in any of the WireTabs - Content, Custom tabs, Settings, etc. Maybe I am not understanding the issue you are referring though ?
  16. New links from the Debug Mode panel's "Cache" section to edit it in Adminer: Adminer DB icon links to where you can easily review the cache content, edit, change the expires datetime, or delete it. Also note that Adminer now has @bernhard's request for a PW icon link back to the site's PW admin backend. Let me know if you guys have any suggestions for other direct links to Adminer - I am finding these very handy.
  17. Sorry, I haven't forgotten - just had other priorities get in the way - I'll try to take a look soon.
  18. @lenoir - I think all those old themes should be removed from the modules directory - hopefully with the imminent site rebuild they will be. I think the problem with PW's admin theming approach is that new functionality doesn't make it into 3rd party themes. I have always said that we need a skinning approach, rather than (or perhaps in addition to) theming. That said, the approach that AdminThemeBoss takes is in effect a skin, rather than a separate theme and I think this is great and is perhaps a model for others to follow.
  19. @ryan - this issue still exists on 3.0.119 - any chance of a fix please?
  20. Yep, that seems to fix it.
  21. @kongondo's approach is definitely the best for PW, but just for extra info in case you ever need to do this with a standard PHP array, you can simply do: The ugly way is rarely useful, but I suppose there might be more flexibility depending on your needs.
  22. Hey @tpr - no big deal, but the most recent version of PW has broken the layout slightly when using AOS's compact header option.
  23. I've added a note to the README
  24. Probably, but honestly as a user I think I might go back from uBlock to ABP to get this feature ? I actually really hate these cookie banners - who of us out there actually bother to use them to decline setting cookies anyway?
  25. What do you think about having fieldsetTabs actually separated out into tabs in the editing interface - I think this would be a really helpful addition.
×
×
  • Create New...