adrian
-
Posts
11,150 -
Joined
-
Last visited
-
Days Won
368
Everything posted by adrian
-
Yes, I always stick with the default (Uikit theme). You're correct that things don't change that much in the theme files, so long as you're happy keeping track of those and updating then you should be fine - it's just an extra hassle that I am not willing to deal with, but that doesn't mean others shouldn't change themes if they're willing to deal with the possible downsides.
-
Does this help? https://github.com/fusonic/opengraph#retrieve-open-graph-data-from-a-url You could try without a library, but something like: https://stackoverflow.com/questions/7454644/how-to-get-open-graph-protocol-of-a-webpage-by-php may not not be very reliable. There is also this: https://www.opengraph.io/examples/php-open-graph-example/ / https://github.com/primeobsession/opengraph-io-php but it hasn't been updated in years so not sure this is a great way to go but might be a useful resource nonetheless.
-
I'm going to make you google that ? Remember that DirectoryIterator's skip_dots only detects . and .. and not hidden files that start with a dot, so you need to use some kind of substring or regex to detect if the filename starts with a dot and implement that in the foreach in the execute method.
-
If it's finding a .DS_Store file, then it muse be there. You could add an exception to exclude files starting with a dot if you want though. I still don't know what that has to do with each image being added twice though.
-
Thanks, that helps a lot. Should now be all sorted, along with a couple of other settings savings issues I just noticed. I have also included the fix I added for @helin's issue. Let me know how it goes for you.
-
@PWaddict - I am not having any problems deleting a rule. Can you please investigate the error further - is it specific to a particular browser? Are you running the regular Uikit theme? Can you try debugging the deleteRow function in the module's js file to see if you can prevent the error?
-
Likely $this is not an image object - you need to figure out what is being passed to the install method, but likely it's not a valid path to an image.
-
@fruid - not sure about the error, but I am not using your version - add some debug code in Pageimage.php around line 1644 to see the value of the image that is trying to be installed - that should help you debug. Regarding the deleteFolder option, "false" in quotes won't work. Because this is a checkbox field, you want: 0 Look at the code in the executeAction method and you can see it casts the value as bool so 0 ends up as false, but a proper false, rather than the string "false". Hope that solves that part at least.
-
I don't honestly know if there are enough things hookable to make the changes you have implemented. tpr has changed a lot of functionality with the AOS module, so lots can be done, but I don't think it's necessarily easy. I expect it might be more JS than PHP to achieve what you want which seems a bit inefficient for this.
-
@jploch - this really does look very nice - much cleaner and more professional. I really appreciate the hard work that's gone into it and I would love to use it, but unfortunately for me it always comes back to the fact that themes in PW tend to end up out of date when Ryan applies fixes and new features so I find it's just not worth the risk. Am I the only one that feels this way?
-
Try: selectLocation.count=0
-
Perhaps you can remove them from showing up in the PWUpgrades module, because it's pretty confusing as it is and it's a new thing seeing them there.
-
Would you be ok with accepting a PR that allows an option to simply provide a solid font color? Also still curious about the $forceRecreation boolean not working - am I doing that wrong? Thanks.
-
Hi @horst - my first time using this, so sorry if this is a dumb question, but why is the text outlined rather than solid? I don't understand how to get it more legible. Is it also possible to specify the font color and perhaps also the font itself (also this is less important). Also, the "true" after the prefix doesn't seem to work - I need to keep changing the name "watermark" to something else to get it to update the image with my new settings. Am I doing that correctly? Thanks.
-
@bernhard - this might also be useful for getting PW's $config->ajax to work and also make Tracy capture the errors. Not sure how to do it within uikit requests. It's automatic with jquery.
-
Module: Video embed for YouTube/Vimeo (TextformatterVideoEmbed)
adrian replied to ryan's topic in Modules/Plugins
@Christophe - did you see the options for this that I posted above: https://processwire.com/talk/topic/1536-module-video-embed-for-youtubevimeo-textformattervideoembed/?do=findComment&comment=206840 ? -
7 months and 41 commits old ?
-
What version were you on? Must have been pretty old ?
-
Hi @MarkE - I don't think there is anything I can do at my end to fix this, but I am curious what "multi install" setup you are using. I wonder if you could confirm that you are having issues with $session / $page with AJAX calls in general and see if you can figure out a solution for that.
-
Those all are asking for $session via AJAX, so it looks like for some reason that is not passing through. Is it just on one PW install, or are you seeing this more widely? Can you narrow it down to something that might be server specific?
-
I don't think it is possible - that's the main problem - I think it should be possible to tag these modules as such. It's the main reason why my ModuleToolkit module was never officially released because there were things I just couldn't do because of this lack of properly defined relationship between modules.
-
That "Check for updates" option is a PW core thing - in my opinion this shouldn't show for child/helper modules that are shipped with a module, but that's a PW core issue and nothing I can change I'm afraid.
-
@ryan - I see that the PW Upgrades module is now seeing pro modules, which is awesome, but I wondering if you and @netcarver could work together so that his awesome ModuleReleaseNotes module can read the processwire.com git host so we don't get this error: Sorry, ModuleReleaseNotes doesn't know how to connect to the git hosting service at processwire.com. Also, PW Upgrades is reporting that FieldtypeTable has a new version: 1.0.0 but when I go to the downloads post for Profields, it still has 0.1.9 as the latest download. And, if I try to upgrade to 1.0.0, then I get this error: ProcessModuleInstall: Unable to open ZIP file, error code: 19
-
Oh awesome - thanks for pointing that out. I have updated the module to use this and it seems to be working fine.
-
Hi Ryan, Looks like a great start. First thing I noticed is that pagination doesn't work. I'll let you know if I come across anything else. I also think it's probably time to remove modules that don't support PW 3 from the sorted lists - highly liked modules that don't work with v3 will be confusing to new users.
