-
Posts
10,898 -
Joined
-
Last visited
-
Days Won
348
Everything posted by adrian
-
@tpr - can you live with this? I overrode the dotted border in the module's css file and obviously reduced the padding on the tabs again. styles.css
-
Thanks - I like the darker hover (instead of white). I am not sure about the increased size of the tabs though - they take up a lot of space and I think they look a bit weird when you have added a title - see how they are taller than the title element. Good catch - thanks. Did you do this in the core Tracy files? If we're going to take this approach, I'd rather override if possible, rather than hacking the core. Did you try that and have problems? Thanks again - always super-appreciative of your skill with this stuff.
-
I just tried all browser and they of course all have the logo issue. The src looks like this: <img id="color" alt="Centura logo" src=""> Of course I see the issues with location/language selection ?
-
Of course - that is a good reason to not use it. It was on Ryan's roadmap to allow it to work over http, but not sure when/if that will happen.
-
Nice looking site - just a quick FYI that until you have defined your region/language, the logo doesn't display. Also, I wonder if it' worth selecting these automatically based on IP address first and letting the user change if they want rather than being forced to do this straight up?
-
Ok, new version just committed with the tabbed debugInfo / Full Object interface for dumps and barDumps. Please test and let me know if you notice any problems or have ideas for improvements. Don't forget to do a hard reload to get the new css/js that this feature requires. Thanks to everyone for your feedback on this - it's made it significantly better!
-
The dotted style is what the Tracy core wraps around dumps. I suppose we could override it completely. The brown - do you mean the non-active tab color? That is the color that you chose for the title header bar for all the panels. It looks browner than it really is when I do a copy/paste screenshot on my Mac - never bothered to find out why. Do you want me to send you a copy before I commit that you can mess with, or are you happy enough?
-
Thanks @tpr and @bernhard for the feedback - here is the new version with white tab as selected and also with no bottom border. I am going to go ahead and get this version ready for committing. If you guys want to tweak after that you can send me a PR. I was also playing with a version where both tabs are white, but I think it's a little less clear when it's so small like this:
-
Hi @Beluga - do your changes break any existing workflows? In other words, could I incorporate your changes without any issues? Thanks for the link to the updated parsecsv - I am curious what wasn't working when you tried to update? BTW - I am using the old version with PHP 7.2 and I don't think I have come across any issues yet - did you? I did look at thephpleague/csv, but at the time it wasn't working as I needed, although I don't remember what the issue was.
-
Would the problems be solved though? I don't use the multi-language stuff enough to know exactly how these settings would be handled when used on the frontend like this. If someone feels like experimenting with this, that would be great!
-
Thanks @gebeer - I forgot about that. I have pushed a new version that uses wireRenderFile instead. It definitely wasn't available in older versions of PW.
-
Just in case you don't know, you can do this directly via the API: https://processwire.com/blog/posts/multi-instance-pw3/
-
@szabesz - this isn't the count of a PageArray that you were looking for, but it does return the ID of each page and is linked to the edit interface for the page. Is this at all useful? I think this is simple and clean enough not to be too messy
-
Ok @bernhard - here's a try a tabs. I think this works ok and looks ok, although I am sure someone out there will want to tweak the look of it - looking at you @tpr ? - and happy for your thoughts! Is everyone happy enough with this so I can finish it up and commit?
-
I tend to use wireHttp. Here's a recent example: https://github.com/adrianbj/CookieManagementBanner/blob/a8e66127bdcbd80e10ac797ad5cbb143644c7857/CookieManagementBanner.module#L38-L39 $http = new WireHttp(); $userLocation = $http->getJSON('https://extreme-ip-lookup.com/json/'.$this->get_user_ip_addr());
-
I don't disagree with you, but I also don't want to pollute the dump output with lots of extra stuff. It could easily look quite messy with several object dumps, all of which have text / button links to the debugInfo and Full Object versions.
-
It's not really that simple though - a page object doesn't have count. In the case of count(), it is relevant to PageArray, PageFiles, PageImages objects, but also to field types with multiple values. Then there are template, field, module etc objects - what should be displayed for those?
-
I tried both. Here is left which is fine and does prevent the scrollbar jumping, I didn't like the way it affected left alignment compared to other dumps like the "test" one above, but maybe it's ok? I see where you're headed, and I like the idea but I am a little worried about going down a huge rabbit hole. Maybe if you can put together a list of PW objects and the data you think should be automatically displayed in this way, maybe we can come up with a solution. I am actually thinking that this might need to be another element that sits between the title (if defined) and the object dump. That's the plan - I haven't coded it yet so not sure - there could be some complications, but hopefully solvable.
-
Here's a screencast of the icon based switching in action. Is everyone happy with this approach? Any ideas for improvements? Back to @szabesz's idea of the page ID being shown - I have removed that from the recent screenshots/casts, but here it is again with the new icon toggles in place. What does everyone think about these automatic titles - useful, or unnecessary - I am not sure.
-
I've been using Licecap on MacOS as well - seems to work pretty well, but honestly haven't investigated what else is out there.
-
Playing with this idea where the toggles are icons floated to the right of dumps that have both debugInfo and regular object versions. Notice that the currently selected version of the dump results in the highlighted icon color. I think I need some help figuring out the most useful / cleanest looking option for this. Any ideas?
-
Ok, here is a really quick and dirty demo. Obviously the links need to look nicer and the selected one needs to be highlighted, but hopefully you get the idea. Any thoughts before I clean it up?
-
Morning ? Thanks for the thoughtful discussion @szabesz and @bernhard - I think I like Bernhard's idea of a toggle, although I think it belongs below the title, just before the dumped objects. I think I'll go with debugInfo and Full Object as the labels for the toggle though - I'd rather this was more explicit and helps to educate new developers about what they are actually seeing. I tried blending the debugInfo version into the main object and it works but it gets added to the data property, so you have to dig down to find it and it gives an incorrect impression of how the object is actually constructed. This would certainly be the simplest approach, but I'll take a look at implementing the toggle idea - I think if that works it will be the cleanest and most useful.
-
If you go with the dynamic roles module, please read this critical issue: https://github.com/ryancramerdesign/DynamicRoles/issues/14 You can apply the fix I have there, or perhaps use @matjazp's fork.