-
Posts
105 -
Joined
-
Last visited
-
Days Won
1
Posts posted by Richard Jedlička
-
-
I see, you have the old version. Update to the latest one (2.0.0).
- 2
-
1 minute ago, kalimati said:
I don't see the ImageMagick settings (advanced) in my installation.
It is in the field settings (Details tab) not the module settings.
-
@kalimati Also this looks useful https://imagemagick.org/discourse-server/viewtopic.php?p=80210&sid=88e589266091f18cef53b8adc6a4d0b1#p80210 Try to identify the colorspace, this way it would be useful to detect the colorspace in the code if possible.
-
Hi @kalimati, not exactly sure, but I guess it will be related to the colorspace the PDF is in? 🤔 I am no expert on this area and don't know if PDF can have different colorspace, but the field has an option to set the colorspace to be used for the image generating (on Details tab), so you can experiment with it.
You can also check https://github.com/uiii/ProcessWire-FieldtypePDF/blob/9f07314883cd281e09851f149b8889c1a3e8daa0/FieldtypePDF/PDFConverter.php#L149 where is the code to generate the image, and you can find a way how to use ImageMagick to generate image for your PDF, we may reflect it in the code after.
-
Merged into new version 1.1.8. Haven't tried to install so if someone can check if it's ok.
- 2
-
@sz-ligatur Perfect, thank you, I'll merge it.
-
25 minutes ago, cpx3 said:
YESSSSSS... A million thanks, also for the quick response!
Actually the response wasn't quick at all ? you were just 4th person in a row who complained ?
-
Hi @bernhard , yes I agree, we can leave it as it is. And in the case if there are more issues in the future we can consider the transition ?.
- 1
-
@Stefanowitsch @szabesz @bernhard @cpx3 All right, the issue should be fixed, haven't tested it, please check it.
EDIT: fixed version 1.1.7- 1
-
@bernhard Sorry guys, this is difficult to me, because I don't use PW actively, only occasionally, so other priorities takes my time. I any of you will be interested I can give you access to the repo.
-
Hi @bernhard, you are right the change is simple, I can do it. I was thinking about it. But I think it is not only about the change but also about testing the module if it really works. I don't have set up the dev environment for it yet. So this was the reason for PR. I don't like throwing the change in to the wild and realizing later it doesn't work because I forgot something like increasing the module's version etc. ?
-
Hi guys, feel free to make PR. Unfortunately, I'm not able to find a time for this now.
- 1
-
Maybe some PW API changed so it broke it. I'll try to check it soon.
- 1
-
Hi @Stefanowitsch, is this the whole error message? Looks like the stack trace only.
- 1
-
Ok, found the issue. I am using composer and I has an installation of the processwire/processwire package of different version and the composer's autoloader loads the files from the vendor folder first. Fixed by either removing or upgrading the composer package.
- 1
-
-
-
@bernhard @szabesz Hi gyus, sorry for very late reply. I don't have much to time work on these features right now, but I am open to PRs, so feel free to make one.
On 10/17/2022 at 11:24 AM, szabesz said:When editing the pages of users, the module does not add its icons/links to the inputfields, in other words it does not work for user pages. Would it be possible to also make the module work there?
Can you explain it a little bit more? I am not sure what you mean. Show me please some example (screenshots).
-
@bernhard Hi, I'm happy to hear that ☺️.
Sorry, I still haven't fixed the labelless fields. I'm in a focus on other projects right now (non pw-related).
- 1
-
4 minutes ago, bernhard said:
Would it be possible to add icons to fields that have no label?
Hi @bernhard, yes, I have it already in my backlog ? Hope I will find a time for it soon.
- 1
- 1
-
1 hour ago, bernhard said:
there's one slash too much on line 134
Ah ok, will fix it, does it make any problems (just curious)?
1 hour ago, bernhard said:If it is easy to implement a "save + reload" button would be nice to have in the modal
You mean to reload the page edit after you update the field? Yeah it will be useful.
If you have time PR's are welcomed ?
-
@dotnetic Hi I use docker containers everywhere. I my localhost develepoment environment I have docker stack yaml defining the containers and also the environment variables (can be included from external file). And in production I use AWS ECS, where you can specify env vars in many ways. If need more details just ask.
- 1
-
New version 1.1.5
I've fixed issue with editing in repeater's template context https://github.com/uiii/AdminHelperLinks/issues/1 and disable focus on tab press (was annoying when switching focus between inputs).
- 2
-
I didn't read the whole topic, so hope I guess corretly what is it about. I add my approach to having different configs for each environment. I did it very simple, just used environment variables, so I have one configurable config for all ?
(I am using docker on localhost so it is easy to work with environment variables)
<?php namespace ProcessWire; /** * ProcessWire Configuration File * * Site-specific configuration for ProcessWire * * Please see the file /wire/config.php which contains all configuration options you may * specify here. Simply copy any of the configuration options from that file and paste * them into this file in order to modify them. * * SECURITY NOTICE * In non-dedicated environments, you should lock down the permissions of this file so * that it cannot be seen by other users on the system. For more information, please * see the config.php section at: https://processwire.com/docs/security/file-permissions/ * * This file is licensed under the MIT license * https://processwire.com/about/license/mit/ * * ProcessWire 3.x, Copyright 2019 by Ryan Cramer * https://processwire.com * */ if(!defined("PROCESSWIRE")) die(); /*** SITE CONFIG *************************************************************************/ /** @var Config $config */ /** * Allow core API variables to also be accessed as functions? * * Recommended. This enables API varibles like $pages to also be accessed as pages(), * as an example. And so on for most other core variables. * * Benefits are better type hinting, always in scope, and potentially shorter API calls. * See the file /wire/core/FunctionsAPI.php for details on these functions. * * @var bool * */ $config->useFunctionsAPI = true; /*** INSTALLER CONFIG ********************************************************************/ /** * Installer: Database Configuration * */ $config->dbHost = getenv("DB_HOST"); $config->dbName = getenv("DB_NAME"); $config->dbUser = getenv("DB_USER"); $config->dbPass = getenv("DB_PASS"); $config->dbPort = getenv("DB_PORT"); $config->dbEngine = 'InnoDB'; /** * Installer: User Authentication Salt * * This value was randomly generated for your system on 2021/12/14. * This should be kept as private as a password and never stored in the database. * Must be retained if you migrate your site from one server to another. * Do not change this value, or user passwords will no longer work. * */ $config->userAuthSalt = getenv("USER_AUTH_SALT"); /** * Installer: Table Salt (General Purpose) * * Use this rather than userAuthSalt when a hashing salt is needed for non user * authentication purposes. Like with userAuthSalt, you should never change * this value or it may break internal system comparisons that use it. * */ $config->tableSalt = getenv("TABLE_SALT"); /** * Installer: File Permission Configuration * */ $config->chmodDir = '0755'; // permission for directories created by ProcessWire $config->chmodFile = '0644'; // permission for files created by ProcessWire /** * Installer: Time zone setting * */ $config->timezone = 'Europe/Prague'; /** * Installer: Admin theme * */ $config->defaultAdminTheme = 'AdminThemeUikit'; /** * Installer: Unix timestamp of date/time installed * * This is used to detect which when certain behaviors must be backwards compatible. * Please leave this value as-is. * */ $config->installed = 1639521804; /** * Installer: HTTP Hosts Whitelist * */ $config->httpHosts = preg_split('/\s*,\s*/', getenv('HTTP_HOSTS')); /** * Installer: Debug mode? * * When debug mode is true, errors and exceptions are visible. * When false, they are not visible except to superuser and in logs. * Should be true for development sites and false for live/production sites. * */ $config->debug = filter_var(getenv("DEBUG"), FILTER_VALIDATE_BOOLEAN); $config->advanced = true;
- 2
PDF Fieldtype/Inputfield
in Modules/Plugins
Posted
@kalimati It means it was fixed by the new version so you didn't have to deal with the colorspace?