Jump to content

matjazp

Members
  • Posts

    711
  • Joined

  • Last visited

  • Days Won

    6

Everything posted by matjazp

  1. My intention with this option was to prevent running the hooks in template files to maintain backward compatibility, currently hooks are applyed only in admin interface - don't want to change that as someone might use size() in template files but don't want to optimize images? So, by checking "Optimize on resize", you want images to be optimized in admin interface, and if you also check "Optimize in API" that means that optimize would happen in template files too. I'm not sure if this is how this new version is working actually, no time to test. But I see your point of view... Don't know what would be the best solution...
  2. @sivsy would you mind sharing your configuration? Mapped drives are in the user context, somewhere in the registry and your IIS knows nothing about that. PM me if you do not want to disclose information.
  3. @PWaddict please try this version. @adrian Don't know why hooks were only allowed inside admin template... I found it that way and just left it ? Uploaded version supports this, but you have to enable it, to maintain backward compatibility. Don't have much time to test, but it should be possible to do something like this: echo $page->images->first()->width(400)->url; and file should get optimized. More testing is needed... AutoSmush.module
  4. If I understand correctly: you would like that images created by CI3 (eg. yourimage.-thumbnail.jpg) also get optimized on upload? Currently, they are not since Horst is not using pageimage size method() so the hook is not triggered. I could optimize in imagesizer::resize(), but then you couldn't differentiate between CI3 and "normal" image, also I would have to rewrite some methods in Autosmush. On top of that, CI3 is executing resize() even if you cancel crop from the modal (if you press escape), there are some js errors... @horst
  5. In my testing I don't get tiny variation 48x. I have set portrait,200,600 in filed settings. To be honest, I don't use CI3 ...
  6. What do you mean by: Currently CI3 variations are not optimized in auto mode, they only get optimized when you manually crop.
  7. This is actually most likely a problem with allowPath() method in WireFileTools.php, introduced in an attempt to fix some issues with temp directory (if I remember correctly). All backslashes are replaced with forward slashes so your UNC notation \\host-name\share-name\file_path becomes //host-name/share-name/file_path. Double forward slashes are recognized as URL or some extra slashes, and an exception is thrown. The solution would be not to use UNC notation but rather map a drive to your share and use a drive letter.
  8. @PWaddict please tr y an attached version, let me know if optimize on resize is working and if double optimization of thumbnails is fixed. AutoSmush.zip
  9. I tested this line as the first one in ready() and no errors were shown. But I forgot on this: $config = $this->wire('config'); - put it just after $this->configData... I'm getting just one log when an image is uploaded and the thumbnail is generated... Are you also using size() methods? I don't use CI3, bu t will check.
  10. Can't test right now, but looking at the source code - could you move this line: $this->configData = $this->wire('modules')->getModuleConfigData($this); in AutoSmush.module, line 1217, up a few lines, to be the first line in ready() method? I guess I changed something from v 1.1.1 to 1.1.2 and didn't test (I can't remember what was it).
  11. On mobile so I cant test. Are you sure its not optimised? What log file says?
  12. Hooks are applied only in admin template...
  13. How are you resizing images? In admin (backend) or in template file via API?
  14. 1.2.1 is working fine, thanks @David Karich . I'm testing reset page views and putting template=basic-page in the selector, it returns a wrong number of pages. Or perhaps you are showing the number of pages that have counter different (larger) than 0?
  15. Hi, Thanks for this module. Nice and organized code! is there an option to disable session lifetime, like set it to 0? The minimal value is 1 due to how you check for 0. I see you are sending ajax requests to location.pathname.substring(1) + "/phcv1" but at least on my localhost location.pathname is /somepage/ so ajax is sent to http://localhost/mypage/mypage//phcv1 Shouldn't you use just location.pathname + "phcv1" ? Counter on the home page isn't working as you are passing an int to ctype_digit() function which expects a string. What I find odd is that ctype_digit(1) returns false while ctype_digit(1054) returns true. I'm not sure if ctype_digit is actually needed. The downside of this script is that sending ajax request put some load to the server itself and at least one findOne(). I'm not sure I like counters on the page list, would prefer table layout somewhere else.
  16. But are those locales available on your server?
  17. @bernhard thx for this. I'm playing with it, looks fine. But when I select to use default uikit theme in /wire/modules, not in /site/modules, I get this in Chrome: Refused to apply style from 'http://localhost/site/assets/RockSkinUikit/theme.less' because its MIME type ('text/ html') is not a supported stylesheet MIME type, and strict MIME checking is enabled. Because of that the look of the admin was, well...I had to uninstall RockSkinUikit to get admin theme back.
  18. Buttons should have some bottom margin (on mobile view).
  19. It looks like that's the problem of pagefinder and not DynamicRoles. Please try reversing the selectors, first has_parent and then id (has_parent|id=1631).
  20. Please see the attached screenshot, Business to Consumer is written over the Blog. But not a big deal... There are still two prev posts in the footer (see attached screenshot from @gmclelland). We all agree on that. I think the examples on the site should have run button (like Codepen) so that users can run the examples and play with them, I think Tracy could fit here (I think Adrian already suggested something in that regard). @ryan While an example is good, for newbies this is odd. What is "output formating"??? I think we should use simple examples that just work. Mixing $pages and pages() is confusing too. Why don't we just stick to one notation, at least in examples, and have a special page where all these options are explained in details?
  21. Don't be done, please. We need your valuable opinions.
  22. I agree if that helps ? I also find it confusing why there are multiple options and what is the benefit of each...
  23. Could you provide information on how to duplicate?
  24. I have to agree here. While I'm ok with any font (either system or non-system) for text, I think we are losing the brand with system fonts for the logo. I think that we should keep the original logo with icon and text together. I also don't like iMac picture. For me, it doesn't make me think that this CMS is for developers, but rather "O, this software only works on Apple device, I'll pass that one". As I understand, this is just temporary?
  25. Did you try this version: https://github.com/matjazpotocnik/DynamicRoles ?
×
×
  • Create New...