Pete

@ryan I can confirm this on latest PW dev - having "tags" on an images field with extra custom fields, then removing tags from that field, then trying to upload images shows this error. For now I just re-enabled tags on that field.

I think I've actually already spotted some workflow flaws that mean I couldn't use it for this project actually, but the offer of access/managing the repo still stands.

@MarkE I may finally be using this module on a project many years after last being involved with it. Did you want access to the main repo to merge your changes into it? My needs may be somewhat different - updating a trip diary (single page, many entries) over the course of a trip - so I'd likely be using a modified version anyway but whilst I'm looking back at this topic I thought I'd ask ?

Thank you very much!

Done, thanks ?

Aha, I managed to get this to happen again. Step 1: delete two PageAutoComplete entries and save the page - the empty rows remain (I really wish empty rows wouldn't get saved but that's another story): Step 2: Typing into the fields in the two existing empty rows you can enter the same value twice (so below I just entered the Parkland Resort extra into the first of the two empty rows, and am able to add it again in the second of the empty rows) It respects the once-per-table setting when you add a new row, but not for empty existing rows. I do wonder if another belt-and-braces solution here is to simply check for and delete duplicate rows on save too?

Okay so I resolved this by chance - it won't work in PageAutocomplete UNLESS you give it a "normal" field as an alternative, so here is what you need in the config for that field in the table: labelField=myFooLabel|title I suspect what is happening is the AJAX request doesn't know what myFooLabel is for some part of the request but this makes the items appear in the list using myFooLabel which was a nice surprise! Not really sure why it makes it work, just guessing above but it does work and that's the main thing ?

You're right, it is working. I think I fell foul of having changed the table schema and sometimes it can get itself a bit mixed up. When I stripped out some extra settings from when my first column was a different fieldtype and re-saved it started behaving itself just fine. Thanks for checking!

That's great, thank you ? The only tiny thing missing is being able to change the "replace image" label, but only because I changed the other labels to say "photo". I feel like I'm being picky now.

This is a great approach, thanks @bernhard One place it doesn't work, and I don't know why, is using it as a labelField in a Profields Table using PageAutocomplete. When you select something and save it works fine, but the list of suggestions returned is blank. What I mean is this - there's a result for those 4 letters, but using this hook it doesn't display. As you can see from the Everest row though, I've used it to stitch the page title and a price field together so when you select the blank item from the list it's selected, but the label doesn't appear until the page is saved. If anyone smarter than me can figure out how to get it to work with PageAutocomplete in a Profields Table you would be my hero ?

There's an issue with autocomplete - until you save you can still enter the same thing in multiple rows. Once saved they are indeed removed from the autocomplete the next time you try to add them but not before saving.

Hiya, loving this dashboard for a few more complex projects. I have a request for the number panel - since I often add a link in the "detail", if the number is zero then the link isn't shown. It would be great if there was a way to show it regardless. Actually it's hard to tell if it's a bug or intentional. In DashboardPanelNumber.module if I wrap the number in is_numeric it works when zero is passed as the number as below: public function setup() { parent::setup(); $this->locale = $this->data['locale'] ?? setlocale(LC_ALL, 0); $this->detail = $this->data['detail'] ?? ''; $this->number = is_numeric($this->data['number']) ? $this->data['number'] : null; if (is_int($this->number) || is_float($this->number)) { $this->number = $this->formatNumber($this->number); } }

@Robin S thank you for fixing the issue I reported so quickly on Github - I've not looked at new modules in a while and several of yours are going to be real time-savers for me on a current project. I have a feature request but I'm not sure how difficult it would be. When you have the field limited to only one item, I'd like to be able to just click on the image rather than have to delete it via trash icon to select a different image. I think in terms of UI, instead of seeing the "drag handle" icon on hover for a single image it could show some other symbol and a tooltip perhaps stating that it would replace it? My use case is for a website where they are selecting an image to use in search results and categories on the site and it's just a nice easy visual field to do that with, but if they want to play around selecting the best one they need two clicks to delete and select a different photo instead of one, and there are >100 pages where they might want to do this.

I don't think you can rely on Omnipay for all but it may be okay for some. A warning sign for me is the age of some of the open issues in the Omnipay PayPal repo: https://github.com/thephpleague/omnipay-paypal/issues and the date of the last commit being quite a while back. A few other Omnipay modules have similar issue lists. PayPal and Stripe I imagine are going to be the two most common and have pretty good docs and vaguely similar interfaces (they both suggest the JS checkout - PayPal are starting to direct developers that way and are using wording suggesting the old ways of initiating the payment are becoming legacy though I can't remember the exact docs). Both have the PHP libraries for manipulating payments after the transaction is in their systems which is fine as I believe they're all trying to make the PCI server compliance issue go away by the card data never being on your server. Even Worldpay has gone JS + PHP now with a similar implementation from what I've briefly seen of their docs. I would think that if any were to be officially supported as part of the project it would be PayPal and Stripe as the two most common. PayPal is still going to be more common than Stripe sadly so probably that as the first one. I do agree with the Omnipay approach of a common interface, so perhaps if these were the first two and @kongondo you took inspiration from how they've done it in terms of the common interface, then those devs capable of writing additional payment modules can use the same approach. Or perhaps because this is such a critical piece of the puzzle it needs collaboration right from the start with those with a lot of experience with payment libraries - I'm not sure - but that wouldn't be me (I just follow the provider docs and if it works it works ? ).

I still use it. I do have one workflow thing I do where I add a "keyword list" textarea field below the keywords as the SEO tool we use to generate lists of keywords for subjects spits them out one per line, so we copy and paste that into that textarea and on save I turn it into a CSV string and put it in the proper keywords field. Sounds a bit lazy but one site had hundreds of articles. I may also need to build a Y0ast-like page score module at some point soon too, though I think those things can be misleading as much as they can be helpful.

Yes my colleague tested the demo site and Apple watch worked as did iPhone ? I may get rid of my Yubikey in future as fingerprint auth on phone is as good in my opinion, and I'll have my phone closer than my keys usually. My face is also usually nearby when I'm on my laptop ?

It's worth noting, on Windows where I have Windows Hello set up, it was setup with my face to login, but also allows the other connected options such as my Windows pin and hardware key though I've only had to set it up with my face - so any linked login methods under the same umbrella become available which is great if I'm wearing a balaclava during the usual cold British weather ?

Perfect - works on live. This is so good ? I had my phone plugged into my computer, so added Windows Hello (face recognition/pin) then added my Pixel phone and I can login with my fingerprint on that and face on my laptop. Absolutely awesome - love it! I'll point it out to Ryan but so far it works great!

Ah I'm willing to bet it's because I'm in a local dev environment or something - will try on a live site shortly.

Oh wow, thanks Adam! I'm stumbling at the first hurdle it seems:

I'll admit to not having looked at the PW auth modules in terms of code at all. I might ping Ryan and see what he thinks. Can't hurt to have more brains on the case and his is bigger than mine ? I think for all my logins, since I use a laptop, I would use Windows Hello... though actually then if I want to check something on my mobile without grabbing my laptop I can't can I? ? I see the problem now. Perhaps multiple instances of the same module somehow and it lets you choose on the login page? Otherwise as you say it just uses the one you set it up with by default.

Thanks for looking at this Adam. I just got a colleague who uses Apple for everything to test and it allowed tapping her Apple watch to login and Face ID. She's got another device to try later with fingerprint but it does sound like it does all devices which is nice, and gives plenty of options, so seems like where things are going in the future. If there are changes required to the base TFA class to help in any way let me know and I can ask Ryan ? Sometimes things won't be hookable that it would be helpful to be hookable etc. I think with WebAuthn It would be more useful if the base class allowed for more keys to be stored per module right, so then per-website I could set it to allow login via facial recognition and fingerprint on the same app - that sort of thing - rather than just allowing one key per module which I think is how it works now? Also happy to help/test in any way I can on this one. As I say for me it's not a huge thing the current module stopping working as I have alternatives, but WebAuthn has me a little excited as it seems like a more natural way to allow people to login.

@Adam this looks like a good potential option - it's one I'd noticed a while back: https://github.com/lbuchs/WebAuthn?ref=https://githubhelp.com but it may also be the one you're referring to with the long example code ? There's a good demo - I was impressed. On my laptop it allowed facial recognition via Windows, PIN via Windows and I had my Google phone plugged in so that was a third option using the fingerprint scanner! It says it supports the physical keys like Yubikeys too and is a PHP/JS library that's been updated reasonably recently. I may look into it myself at some point but like you I wouldn't be able to soon.

@kongondo can you remind me on Monday and I'll get a forum set up? Not sure if we should call it Padloper Pre-Sales or something and have a pinned topic at the top saying for paid support to request access to the other forum or something like that?

Ah nuts, well Chrome is here to stay and Edge is based on it too, so for business environments where this is more likely to be used I'll most likely be one of those two browsers. It's not a big issue for me - I can switch to one of the other auth options for now so whenever you get time. Hopefully now this new standard is out it won't change again for a long time after that.