Jump to content
Xonox

[Solved] API image upload I need to replace instead of adding

Recommended Posts

Hi,

 

I'm trying to upload images from a folder into a page. I need to replace the images instead of adding. The image field already has the replace existing images turned on, but it doesn't seem to be enough.

 

My code:

foreach($files as $file) {

	if(substr($file, 0, 1) != '.' && $file != '.' && $file != '..') {

		// Get SKU
		$file_sku = substr($file, 0, 9);

		// Check for book
		$book = $pages->get('sku=' . $file_sku);
		if(!$book->id) {

			// Book doesn't exist

		}
		else {

			// Upload image into book !!! THIS CODE ADDS FILE INSTEAD OF REPLACING. HOW CAN I REPLACE?
			$book->book_images->add($upload_directory . '/' . $file);

			// Delete file
			unlink($upload_directory . '/' . $file);

		}

		// Save book
		if($book->id) $book->save();

	}

}

 

What am I missing?

Share this post


Link to post
Share on other sites

Just put in a $book->book_images->deleteAll() before the "add"

I don't think that replace setting is honored by the API.

Share this post


Link to post
Share on other sites
5 hours ago, adrian said:

I don't think that replace setting is honored by the API.

I don't think any of the image field settings are honoured by $pageimages->add(). Not "valid file extensions", not "maximum files allowed", not min/max width/height, etc. It's a shame as it means you have to do a lot of manual validation if using add().

  • Like 1

Share this post


Link to post
Share on other sites
7 minutes ago, Robin S said:

I don't think any of the image field settings are honoured by $pageimages->add(). Not "valid file extensions", not "maximum files allowed", not min/max width/height, etc. It's a shame as it means you have to do a lot of manual validation if using add().

Yeah, pretty sure you're right. 

Here's an old discussion about it in case you want to read some of Ryan's thoughts on the matter:
https://github.com/ryancramerdesign/ProcessWire/issues/1122

  • Like 1

Share this post


Link to post
Share on other sites
24 minutes ago, Robin S said:

It's a shame as it means you have to do a lot of manual validation if using add().

I had to handle this kind of validation in my AddImageUrls module, so the code there might be useful for anyone else needing to do the same: https://github.com/Toutouwai/AddImageUrls/blob/f67ebe9729fc54d629fe939be2f9d3e9c7f68c16/AddImageUrls.module#L118-L170

  • Like 2

Share this post


Link to post
Share on other sites

Hi,

Thank you for your help.

Here's what I've got so far and working:

foreach($files as $file) {

	if(substr($file, 0, 1) != '.' && $file != '.' && $file != '..') {

		// Get SKU
		$file_sku = substr($file, 0, 9);

		// Check for book
		$book = $pages->get('sku=' . $file_sku);
		if(!$book->id) {

			// Book doesn't exist

		}
		else {

			// Check if image already exists
			foreach($book->book_images as $image){

				// Remove existing image
				if($file == $image) {
					$book->book_images->remove($image);
					$book->save();
				}

			}

			// Add new image
			$book->book_images->add($upload_directory . '/' . $file);

		}

		// Save book
		if($book->id) $book->save();

	}

}

The only problem with this code, is that the new image doesn't keep the same order. It's always added at the end. Is there any way to make it load into the same position?

Share this post


Link to post
Share on other sites
27 minutes ago, adrian said:

Note the mention of the new ->replace() method as well

@adrian thank you very much for your help, so far. However, it doesn't seems to be working:

$book->book_images->replace($book->book_images->path . $image, $upload_directory . '/' . $file);

Doesn't return any error but it doesn't replace the image! 😞

Share this post


Link to post
Share on other sites
2 hours ago, Xonox said:

Doesn't return any error but it doesn't replace the image!

Ryan's example using insertAfter works for me - just add in the missing: $page->of(false); line at the top.

Did you try that?

Share this post


Link to post
Share on other sites

@adrian, thanks for your help. The examples given weren't really helping because the file name wasn't kept. For each time de file was replace it would add "-1", "-2" etc. to the file name. I managed to make it work and I am posting the code, in case someone needs something like this.

foreach($files as $file) {

	if(substr($file, 0, 1) != '.' && $file != '.' && $file != '..') {

		// Get SKU
		$file_sku = substr($file, 0, 9);

		// Check for book
		$book = $pages->get('sku=' . $file_sku);
		if(!$book->id) {

			// Book doesn't exist

		}
		else {

			// Check if image already exists
			$replace = false;
			foreach($book->book_images as $image){

				// Replace image
				if($file == $image) {
					$book->book_images->delete($image);
					$book->save();
					$book->book_images->add($upload_directory . '/' . $file);
					$book->save();

					// Place image in the right position: after previous or as first
					if(isset($previous_image)) {
						$old_item = $book->book_images->get($previous_image);
						$new_item = $book->book_images->last();
						$book->book_images->insertAfter($new_item, $old_item);
					}
					else {
						$old_item = $book->book_images->first(); 
						$new_item = $book->book_images->last();
						$book->book_images->insertBefore($new_item, $old_item); 
					}
					$replace = true;

				}

				$previous_image = $image;

			}

			// Add image to book
			if(!$replace) {
				$book->book_images->add($upload_directory . '/' . $file);
			}

			// Save book
			$book->save();

			// Delete processed file
			unlink($upload_directory . '/' . $file);

		}

	}

}

 

  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By SwimToWin
      As an admin I want to use the API to ask if a page is published - using the $page->isPublished() method - so that I know it's published - as opposed to unpublished or trashed pages. That includes hidden pages.
      This method will correspond to Settings -> Status when editing pages:

      (Published is also mentioned explicitly where the edit page says "Published on [?]".)
      I would expect the API - and specifically the $page->hasStatus() method - to ask if a page has status published.
      But as I can see, it's only possible to ask for exceptions such as isUnpublished() and isHidden().
      <?php // This fails with "Fatal Error: Uncaught Error: Undefined class constant 'statusPublished'" if($page->hasStatus(Page::statusPublished)) { echo 1; } ?> PS: My current use case is that I want to count number of published vs. unpublished pages. I can only do that by getting all pages (include=all), then subtract any unpublished pages.
    • By ngrmm
      My clients wants a modal to show up on every page. But when a user clicks inside the modal -> a session-cookie is set and the modal gets a class.
      // user clicks on modal button $('.modal_button').click(function(){ // 1. set PW session cookie // 2. toggle class $('.modal').toggleClass('off'); }); I know how to set a cookie on page-load via PW-API. But the click on the modal button does not force a page-load. So i have to set the cookie through javascript. Is there a way to do that?
    • By VeiJari
      Hello,
      I'm trying to create a page via api and populate values to it. I can populate everything except user pages to a page reference array.
      Code: 
      $dataUsers = $data->project->users; foreach($dataUsers as $dataUser) { $newProject->projectUsers->add(wire()->pages->find('template=user, id=' . $dataUser->id)); } I'm receiving my data via JSON.
      Is there something I'm missing?
      Thanks for help
    • By VeiJari
      Hi, this is the first we are trying to make a page that has only one type of user that has access to every page. 
      The other users should only have a given access to specific pages, not to the whole template.
      My structure
      -Field -Organisation -Project -Report I want that the "measurer" role only has access to "project x" and it's children, but no view access to every project, organisation or field. I've tried to do this with https://modules.processwire.com/modules/page-edit-per-user/ but it still needs a view access to the whole tree to see the "project x" page. Or is there something I haven't figured out?
      Maybe I have to make it via the API: a select field in the "organisation" template where the admins could add the users and then I use hook to update the privileges?
      Have you done something like this and how did you accomplish it?
      Any help would be appreciated.
       
    • By cosmicsafari
      Hi all,
      Before I go potentially wasting time trying to achieve the impossible.
      Can anyone confirm if its possible to have a Page Reference field on a modules config page?
      I'm wanting to essentially just output a list of select able pages based on the a given selector (likely by template at this stage), wherein the select is the pages that the module should apply to etc. I was thinking a simple checkbox list would suffice is asmSelect isn't available.
      Essentially have it display the same way a Page Reference field would display on a template, where you can easily select a bunch of them.
      public function getInputfields() { $inputfields = parent::getInputfields(); $f = $this->modules->get('InputfieldPage'); $f->attr('name', 'testSelect'); $f->setAttribute('multiple', 'checkboxes'); $f->setAttribute('findPagesSelector', 'template=development'); $f->label = 'Test'; $inputfields->add($f); return $inputfields; } Figured something akin to the above would work but can't seem to get rid of this warning on the modules config screen though.

×
×
  • Create New...