-
Posts
11,180 -
Joined
-
Last visited
-
Days Won
372
Everything posted by adrian
-
Custom fields support for file and image fields: misinformation?
adrian replied to Mike-it's topic in General Support
Sounds like you need to double check the name of the "option_type" field and check that it is set to support multiple values. Debugging this stuff is much easier with the Tracy Console because you can dump at each step of the process to figure out where the problem actually is. -
Custom fields support for file and image fields: misinformation?
adrian replied to Mike-it's topic in General Support
Not sure @Mike-it - it's working here like this: What exactly are you seeing when you say it doesn't work? -
Weird, adding a long comment and calling from the Console still breaks things for me: It is truncating somewhat - you can see the ... in the middle, but it's still overflowing. I don't have a pure Tracy instance running anywhere - maybe I should install your PW standalone and try it there. It might be hard to post this as Tracy core issue at the moment - I'll test more and see exactly why it's failing.
-
Hi @bernhard - I think it's worth posting this to the Tracy core repo because from what I can tell, it's only an issue when you have a comment on the same line as the bd call. If the contents on the call itself are long, it is properly truncated. PS - you might be better off posting a screenshot using Tracy in your PW standalone project where it's just Tracy core CSS because I have moved things around so much.
-
@Violet - just a reminder that with AOS as I mentioned, point #2 is also possible - you edited your post to note that #1 is possible, but I want to make sure you understood that #2 also is (even if it does require a module). AOS is essential on all installs in my opinion - I don't use many of its features, but there are a few I really appreciate.
-
Just in case you don't know, you can do this via the parent page template's Family tab > Sort settings for children This is possible with the AdminOnSteroids module's AddNewChildFirst option which allows you to maintain manual sorting, but automatically putting new pages on top. BTW - not suggesting that something like this shouldn't be in the core - just hoping to help you out with a solution now.
-
URL character limit is 128 - how to increase this?
adrian replied to formulate's topic in General Support
This bit me today so I created a feature request: https://github.com/processwire/processwire-requests/issues/382 Would you guys mind giving it a thumbs up to get Ryan's attention? Thanks. -
Exactly my thoughts!
-
Yeah thanks. I am already using his latest release (with that fix) here. I'll commit the changes sometime soon. I just need to spend a bit of time revisiting the changes I made for Pete, and also revisit everyone's suggestions for improving the settings page, and also Robin's "Shortcuts" panel idea. I'll probably commit all these things together - maybe on the weekend or early next week.
-
@Erik - it doesn't look like @Pete is maintaining this module anymore. Give https://processwire.com/modules/protected-mode/ a go - it also has the advantage of optionally sending proper 503 headers when you're using it for blocking access during maintenance downtime.
-
Hi @flydev ?? - yeah, @Robin S and I have been discussing this one. As @bernhard mentioned to you, this is a change in the Tracy core. I have mixed feelings about the change - it is kinda nice seeing the actual bd() call that was made, I do find myself hovering to see the file/line quite often. Unfortunately I think to change this behavior, I'll probably need to hack the Tracy core. Note that I am already moving the position of that element compared to the core because they had it top right which is really messy if the bd() call is long. Curious what others think of this - do we need to revert this, or do you like seeing the bd() call next to each dump? Would it be better if both the bd() and the file/number were visible?
-
@ryan - any reason why Soma's PageEditSoftLock has been removed from the modules directory? I still install that on all my sites so it would be great to have it back please. Thanks!
-
@bernhard - that css always works for me. I see that you just started an issue with the Tracy core which is great, but I can also just add that locally to the css that I package with the module. Seems like a good solution me although I am still unsure how much benefit actually showing the \n is in the first place. Note that the code for adding these, is all here: https://github.com/nette/tracy/blob/cf7d278957bd4301a409aa689159a9700459ff86/src/Tracy/Helpers.php#L343-L376 If there are strong opinions on this, I could potentially hack this file to remove these things, or it might be possible to convert back again in the module's code.
-
@bernhard - this is something that was added to the Tracy core. Remember that you can use be() - barEcho() - to echo out a string to the dumps panel in the Tracy bar. Does that work OK for you?
-
Yeah exactly - it may not be an issue for you, but if someone was setting things up, it could be confusing - not saying it's not a possibility to get things right, but I know that Ryan had concerns when we've talked through this issue.
-
I think the key issue with admin view access is how the tree handles showing pages/branches below pages that are not viewable. It would break the hierarchy. Admin Restrict Branch is limited in what it does, but I think it does it well. But it's always only going to work with one branch, although for many use cases that is all you need. That said, I'd love to see a core way of hiding pages from view, but again there's that hierarchy problem to solve, or maybe those situations just need to be prevented from happening.
-
@mtwebit - I think the bootstrap line in the runByCron.php file should be: require_once(__DIR__ . '/../../../index.php'); It didn't work for me the way you had it. Unfortunately I am also having issues with wanting to create and execute a task via my AdminActions module - because the method that is being called belong to the action's class and not the ProcessAdminActions parent class, things aren't working. I think I'll end up building a custom approach to doing what I need but just wanted to let you know of a possible issue that others might also have.
-
I was just playing around with the module and this feature - I am correct in assuming it's still broken? I wasn't sure if I was doing something wrong. I started fixing things, but no real luck yet - it just keeps reporting a failure. And when I tried to emulate the PDF module's approach of redirecting to the tasker admin page, it seems like it never actually executes. Anyway, I'll go try the cron approach and see if that works.
-
Inconsistent breadcrumbs for process sub pages
adrian replied to Richard Jedlička's topic in Module/Plugin Development
A couple of real world examples, just in case they help in addition to @Zeka's answer. https://github.com/adrianbj/ProcessAdminActions/blob/5d77e86ae20f016d3b9ce1abd791b1af9e82451e/ProcessAdminActions.module.php#L683 https://github.com/adrianbj/AdminRestrictBranch/blob/4964a3f5b83338f7313f7c6daeefe6c6793640b0/AdminRestrictBranch.module.php#L131-L144 -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
Looks like that is happening because you are turning off outputformatting after doing the deleteAll(). Do it beforehand and things should be fine. -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
Sorry, I'm not sure then - it's working here. I think perhaps you need to do some debugging at your end to make sure the unlink call is actually being made and also clarify that $file->filename contains the full path to the csv file. Also, try: $this->wire('files')->unlink('/fullpath/site/assets/files/1443/file.csv'); in the Tracy console just to test this in isolation. If that doesn't work, try a regular php unlink and if that doesn't work, check to make sure there aren't any file permission issues. -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
@fruid - this works: $this->wire('files')->unlink($file->filename); but the problem is that in your example, your code never gets here because you have "return true" or "return false" in the if/else above this point. I simplified things right down so obviously this doesn't handle the processing of the CSV file, but this is basically what you want so that you are unlinking before returning true. protected function executeAction($options) { $parent = ''; $parent_title = ''; $url = config()->paths->assets.'cache/AdminActions/'; if(count($options['csv_upload'])) { $n = 0; $file = $options['csv_upload']->first(); $fp = fopen($file->filename, 'r'); fclose($fp); $this->wire('files')->unlink($file->filename); return true; } else { $this->failureMessage = 'Please upload a CSV file'; return false; } } -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
@fruid - can you please post the entire code for your action - should be an easy fix, but will be simpler if I have everything to test things. -
We sort of have this already - take a look at the Custom Links section of the settings for the Processwire Info panel. You can add links to any page on the site, including items under Admin > Setup. Of course this doesn't allow for external links. For external links, I could add an additional settings field for storing these, or we could go with a separate Shortcuts Panel. Semantically it would be strange having external links under the PW Info panel, but maybe that's OK? Any thoughts? Also, just to let you know, that these links are actually stored as relative paths, rather than page IDs so that you can copy/paste Tracy's settings via my ModuleSettingsImportExport module and have them work on another site. Also, the appropriate icon is also automatically used. Note I have teppo's Changlelog, MikeRocketts's Jumplinks and ryan's Upgrades linked to, in addition to the default links which are added when Tracy is installed.