Mike Rockett
-
Posts
1,452 -
Joined
-
Last visited
-
Days Won
9
Everything posted by Mike Rockett
-
Hi Phillip – I'm so incredibly sorry for neglecting this. I noted in the merge requests that I'd get to it, and then never did. I'm going to go ahead and accept both and release, however I have no reliable way to test without configuring dev-environments for it. So if there are any issues, we can deal with them on an as-and-when-needed basis. Edit: Managed to test. Very strange. Seems like something that would need to be fixed in the underlying package. Updating to v6.6 now as part of the above merge request at least. ?
-
New Maintainer Needed Sitemap is in need of developer to take over the project. There are a few minor issues with it, but for the most part, most scenarios, it works, and it works well. However, I'm unable to commit to further development, and would appreciate it if someone could take it over. If you're interested, please send me a private message and we can take it from there. Thanks! ?
-
New Maintainer Needed Jumplinks is in need of a new maintainer, as I’m simply unable to commit to continued development. As it is, Jumplinks v2 has been in the pipeline for around four years now. Whilst v1 is stable (after so long, excluding a few minor issues here and there), there are features that people would like in v2 that are not in v1, and so the idea is that a capable maintainer takes over and breathes some life back into the project as I'm unable to due to work commitments. Current state of v2: backend is mostly functional, and the frontend was being re-written in Svelte (though whomever takes over is free to change this) after having been partially done in jQuery (I no longer use it for anything). As discussed previously, the backend side of things is powered by some Illuminate (Laravel) components, making it easier to interact with the DB and perform tasks on different models. Again, whomever takes over the project is free to change this, or even start from scratch if necessary. If you are reading this message and are interested in taking over the development of Jumplinks, please pop me a private message and we can take it from there. Thanks all! ?
-
PW 3.0.173 – Core updates, new hook type
Mike Rockett replied to ryan's topic in News & Announcements
JL2 uses FastRoute to do what's being done here, although it obviously needs to hook into the 404 process in order to work. The reason I picked FastRoute was because, at the time, I simply didn't like the approach in current v1, and wanted something a little more robust, feature reach, and fast. JL2 could use this new feature (which is a great addition to PW), though some additional work would need to be done to make the URIs transform to the regex approach being used here, which is quite different. That aside, I'm afraid JL2 on hold, once again. Simply don't have the time to take it on right now, and doubtful that I will any time soon. In all honesty, I would be much happier if someone were to take the project over and give it new life. It's been in the pipeline for a long time now, and it's really come down to me making promises I uninentionally couldn't keep, much as I wanted to be able to. So, if anyone is able and willing to take it over, please feel free to pop me a DM. -
Apologies guys, I seem to have skipped 0.6.0, which was sitting on develop for quite some time. That's fine though, because if there are no issues, I'd like to bump it to v1.0. Given that it's not there yet, I've marked the module as Beta. If anyone does bump into funny stuff, let me know and I'll get it sorted as soon as I can.
-
I'm about to release 0.7.0, which has the following changes: Bumps PHP minimum version to 7.1 (should be 7.2, but I'll do that next year) Bumps PW minimum version to 3.0.16 Fixes an issue with regards to null configs Sitemap cache policies Sets the correct installer directory for Composer
-
@Sascha Nos You're very welcome! ?
-
@bbeer – if you are getting URLs with the encoded %23, then I think that htaccess would be your best bet until JL2 is ready (working on it as I write this). It must be that the CRM is encoding the hash when storing the URL (bad move, CRM), which the browser then sends to the server, which sees it as part of the actual URI. The browser will never send it if it is not encoded. If htaccess is too messy, then you could perhaps append the source with {all}, which would catch everything after the last 'segment' – the destination could then just ignore this. Not the best solution I know, but seems like it could work for the time being…
-
@teppo @Jason Huck – In JL1, this unfortunately requires two jumplinks – one for including the query string, and the other for excluding it. I know, it really sucks, but JL2 solves this problem by using optional parameters and a little bit of internal trickery. I do still need to add in a boolean flag on jumplinks to indicate whether or not they should even care about the query string. I would prefer to not implement this flag, but sometimes it's useful when you don't care about it so much that you'd rather not even make mention of it in the source.
-
Hi @Marco Ro – Thanks, I'll need to look into this. It isn't the first time it's happened. Internally, I use a package that generates the sitemap using a 'fluent' interface, and this issue has crept up with that package a few times in the past.
-
@gebeer It'll likely be executeCommit as executeEntity returns the view. However, the 'routes' will be split out in v2 (namely, executeStore, executeUpdate, executeDisable, executeEnable, the first two of which will probably be used to trigger a cleanup).
-
@PWaddict – Sorry for the delay in getting back to you. From looking at the lines affected there, it seems like the sitemap configuration saved for each page vanished. Note entirely sure what could have caused that, though. Will give it a look-see on Sunday.
-
@gebeer – Thanks ? This hasn't been addressed in v1, as the plan was to carry the behaviour into v2 (sorry it's taken so long…) by way of the separate module. I picked up the project again recently and was giving it some thought. I might just include the 404 logger in JL v2, but am still 50/50 on it. @teppo @adrian – You know, I should have truncated that alongside truncation of the request_uri. Going to see if I can squeeze this in over the weekend while I work on v2’s frontend.
-
@xportde Hi Thomas, I'm quite sure it's possible, but I don't quite know how useful that will be as Google will likely find the page and index it anyway…
-
Progress Update: I'd like to drop debug mode in favor of a testing tab that I'm quite sure has been brought up before. The idea is to not have to throw your entire site in to JL debug mode just to test one thing in production. I've added this tab now, seems to work well.
-
I have indeed – and I dig it from the perspective of rapid development. As I understand it though, it comes with a runtime that contains things that may or may not be used. Sure, the Alpine runtime is small, but the build file I have in Svelte is looking a bit smaller (so far). That aside, enjoying Svelte so far – this is the first time I'm exploring all of its features.
-
Progress update: Have managed to throw in a few hours on v2. The frontend is being rebuilt in Svelte, because I simply don't use jQuery/Datatables anymore. By not using any of these, I'm free to code this thing the way I want, without having to use a bunch of dependencies that are simply frustrating to build things with. Datatables in particular is hell to work with. (As an aside, I primarily work with Vue, but Svelte is a little more suited here. No runtime, much smaller bundle.) Anyways, here's a preview of the redesigned jumplinks list. Newly built styles, consistent in both the default and UIKit themes (should be fine in custom themes too) and scoped to the Svelte container. Have carried over the behaviours, however instead of fetching all jumplinks, they're now fetched as a paginated collection. I'm sure there are a few sites out there with many jumplinks, and fetching them all is just too much. As mentioned in a previous preview post (such a long time ago!), you'll be able to turn off the colour helpers if you don't like/need them.
-
Super sorry for missing your post! If my-page exists, then Jumplinks will not take effect. It only responds to 404 events within ProcessWire.
-
@a-ok Jumplinks 1 doesn't have built in support for automatically dealing with query strings. This is planned for Jumplinks 2, but I simply haven't had the time to complete it. For the time being, I'd be inclined to use the {all} wildcard on the end. Source: chance-to-dance[/]{all} Destination: somewhere/{all} or {!all} to skip wildcard cleaning
-
@uiui Ah you're quite right. Unfortunately, I don't have enough time to implement this right now... If you (or anyone else) would like to take a stab at it, please feel free to submit a PR to the repo. If I find some time, I'll take a look. ?
-
Thanks @teppo – looks good, so I'll merge it in and push a release. Thanks for spotting that as well – evidently didn't cross my mind ?
-
@joe_ma – Apologies for not getting back to you, I didn't see your post until now ? I'm not quite sure why you're getting those errors, though it seems like something else is interfering with the module output and or your pages. Could you share a list of the other modules you are using and perhaps any custom code/hooks that are at play? That might help me find out what the problem is, which is important as this issue hasn't come up before and I'd like to ensure it doesn't happen to others too. Thanks! @uiui – The module supports sites with the multisite and language support modules installed. I haven't tested it it in a while, so if you have any issues, please let me know. ?
-
@2hoch11 - Thanks. So the reason for the redirect is to take the page away from index.php so that it isn't seen as the home page. You simply need to change the source to index_php/{id}.
-
@Andi – interesting… I'm sure this could be achieved with a hook that gets triggered when iterating pages. Haven't worked with the hook system in a while, but I guess that adding support for addHookBefore('Sitemap::page') would be a decent idea. Unfortunately though, I don't have the time to get to this right now. If you or anyone else is willing to look into implementing this, please feel free to sumit a PR. If that hasn't happened and I find some time in the next week or so, then I'll jump on it. As a last resort, there's always the getAdditionalPages hook that was recently added. It would mean that you exclude your posts from the sitemap and use that hook to add all your posts with the correct paths.
-
@2hoch11 – please could you share your jumplink source and destination, the htaccess code, and the debug log (debug mode is in the module config)?
