Jump to content

David Karich

Members
  • Posts

    156
  • Joined

  • Last visited

  • Days Won

    4

Everything posted by David Karich

  1. Unfortunately I cannot reproduce an issue here. I have used the module in several productive multilingual environments. No matter from which language version (even for me the default is not english) it is counted. Maybe you have "URL segments" in use? I have written an info about this in the readme. A separate counter function for each language version is not planned. All hits are summed up, no matter from which language. Maybe in the future, when I have more time for it. Sorry.
  2. Honestly, I think that for this particular case, implementing a hook is a bit too much. Since you can easily access the counter value via "$page->phits" at any time, you can modify and build your labels in the PageTree yourself. In the module configurations you can simply specify the templates for which the counter will not be automatically output as a label under "Exclude templates for page tree counter". Or disable it completely if you build all your labels yourself. ? Or have I missed something? ?
  3. Version Update 2.0.1 The current version has got a bug fix. Thanks to @ngrmm I could discover a bug which causes that the module cannot be loaded if the MatrixRepeater field ends with the name "repeater". The code was adjusted and information about the problem was provided. All information and downloads are updated in the first post.
  4. @ngrmm I could identify the problem in your installation and have provided a fix in version 2.0.1 The problem was that your repeater field ended with the name "repeater". I have provided more information about this in the readme. For testing I have updated version 2.0.1 on your provided test environment and now it works. ?
  5. Sorry @eydun, I only saw your question now. I already brought the Floating Buttons into the game in 2018 as a proof of concept. You can find the code for them here: Or directly on GitHub: https://github.com/processwire/processwire-requests/issues/177
  6. Unfortunately I cannot reproduce the problem at all. Please try the new version. Otherwise I can only imagine that the module collides with the JS code of another module. Maybe you can give me access to a test system so I can have a look at it.
  7. Version Update 2.0.0 The current version has got some improvements, bug fixes and new features. Many thanks to @Autofahrn, who created the idea and code base for copying multiple items at once! Amazing feature! Also, there is now the option to disable the copy and paste dialogs. Last but not least, thanks to @joshua, for suggesting a bug-fix in context with normal repeater fields. All information and downloads are updated in the first post.
  8. By the way, here's a filter I often use to enrich the path for files or images directly with the corresponding pageID, so that you only have to prefix the file path. <?php namespace RockFinder3Column; /** * Column type for multi-value fields like options, page reference, etc */ class FileWithID extends \RockFinder3\Column { public function applyTo($finder) { $finder->query->leftjoin("`{$this->table}` AS `{$this->tableAlias}` ON `{$this->tableAlias}`.`pages_id` = `pages`.`id`"); $finder->query->select("GROUP_CONCAT(CONCAT(`{$this->tableAlias}`.`pages_id`, '/', `{$this->tableAlias}`.`data`) ORDER BY `{$this->tableAlias}`.`sort` SEPARATOR ',') AS `{$this->alias}`"); } } This results in the string for example: "1234/myfile.jpg" and now just prepend with "$config->urls->files" in the output and you have the full path to the file. Maybe it helps somebody and is looking for exactly that. ?
  9. On the one hand, I was more or less forced to switch to RF3 because RF2 no longer worked with the new PW-Master 3.0.164. Somehow the bindValues in the selectors were not processed correctly anymore, so that no PageIDs and paths were resolved correctly in the SQL statement. For this reason I have migrated completely to RF3. That was not a big problem either. In general, not much has changed from the public functions. In addition, it is also much more comfortable in RF3 to create and manage your own filters. Well done! I also wrote my own table aliases in the SQLs in RF2 quick and dirty, which RF3 now handles very cleanly itself. My application case has not changed. I continue to use RF3 to load masses of fieldset pages within repeater items, which contain lots of fields with design options for the repeater item. As already described in the RF2 thread below: In this context, once again many thanks for this module and the further development! ?
  10. @bernhard, RF3 works like a charm and rock solid! After RF2 I can only thank you again for the clean code and documentation for RF3! ??
  11. Hey @OllieMackJames thank you, also for the donation. I think it came from you? ? I'm not able to reproduce the problem with the prompt. Does the DeveloperConsole give you any JS Errors? I had tried to implement the multiselect function before. But I failed on some points because it was not stable and reliable and in the end there were too many dirty JS hacks. Originally, this module was just a proof of concept, with the hope that @ryan would implement this function cleanly into the core of RepeaterMatrix. The needs for this feature are already quite high for the users.
  12. I can only thank @bernhard again for this module and for the support he provided, for example in finding a solution for option fields. RockFinder2 can not only be used to load masses of pages faster, it can also be used at field level. For example, I used it to load about 40 to 60 fields per repeater matrix type, which are also further nested in FieldsetPages (for design settings) in one query. This amount of fields caused 700 or more single SQL queries to be executed and up to 140 PW-Page objects to be loaded into RAM. This caused a significant loading delay. By using RockFinder2 the SQL queries could be reduced to 200 on average. About 60 page objects less are loaded in RAM, the CPU is also happy and the loading time for pages without cache was also reduced on average to 700 ms to 1 second. Good job Bernhard! ?
  13. Hey @Robin S, you're right about your modifications for the repeater. Regarding the float conversion, I have described the problem in detail on GitHub. I suggested another solution. I also added support for CKEditor inline images in a new PR. All info and changes can be read here: https://github.com/Toutouwai/ImageCropRatios/pull/3 ?
  14. @Robin S Awesome module. I never understood why this functionality is not in the core. ?‍♂️ Thank you for implementing this feature! I sent you a pull request on GitHub, with a bugfix regarding multilanguage setups and float conversion, small performance tweaks, and support for repeaters! Best regards. https://github.com/Toutouwai/ImageCropRatios/pull/2
  15. @MoritzLost Nice work! Tested: the page cache is deleted, but not the compiled assets (js, css) of ProCache. PW DEV 3.0.153, ProCache latest, Win and Linux, PHP 7.3, PHP 7.4
  16. Hey Erik, here's a suggestion how you can do it manually, at least for those templates that have an AMP version. But I haven't tested it. Remove the specific template from the "Templates for automatic tracking" configuration and Add this specific template in the "Templates for allowed API tracking" configuration In the non-AMP version of the template, you add the following data atrribute to the body tag, with the ID of the current page which should be tracked. For example: <body data-phc="<?php echo $page->id; ?>"> Now manually add the tracking script for the non-AMP version before the closing body tag. <!-- For debugging use PageHitCounter.js --> <script defer src="<?php echo $config->urls->PageHitCounter; ?>PageHitCounter.min.js"></script> That's it.
  17. Version 1.2.6 as new master version available All information about the changelog and bug fixings in the first post.
  18. @horst Sorry for the later feedback, but here's the summary. PW Version: 3.0.143 (dev, from 28. October 2019) IMagick Image Sizer: 0.0.3 PHP imagick: 3.4.3 PHP: 7.2.x and 7.3.x Otherwise no other image modules activated. I think that problem with PNG8 has occurred since the change in the module from 7.6.2019 or 6.7.2019. However you formatted the comment. I deactivate the ImageSizerEngineIMagick, and GD takes over, I have no problems. In the attachment two test PNGs, one without compression (which works) and one compressed with tinypng.com (this one will change from a transparent background to a black background when resizing). test-PNGs.zip
  19. Thank you, I'm glad it's useful to you and thank you for your donation. ? Unfortunately, cross-copying is not possible because at the point where you initialize the copy, the module does not know the name of the other field. So it can only read the current name of the matrix field and use this name when copying to the target. I'll think about whether you can introduce an option to select the target field before copying. But I think there is a lot of potential for errors when copying. So first of all, unfortunately not possible at the moment. BTW, @ryan, the module has been in checking for the module directory for several months now and has not yet been released. Does this module bother you in the context of a free extension for your ProModule?
  20. I've had this problem for quite some time, even without WebP. Somewhere I think there is a bug in the ImageSizers. This happens with compressed PNGs, which were previously compressed via tinypng.com, for example.
  21. Welcome to the forum ? Maybe this solves your problem. If there are multiple paginations or API calls, you must also set the "start=0" selector so that other page arrays are not paginated. See under "Are there any side effects?".
  22. I can also tell you what bothered her the most, besides the visual component. My customers like to think in folders. They would like to click through a tree and categorize the data into folders. As PW itself is structured. Because the biggest problem here again is laziness itself. If you upload a picture and don't immediately describe and tag it properly, later searching becomes difficult. And my customers are all hectic and have no time for that. ?
  23. To be fair, the last version I worked with is 011. Of course there have been some changes with the new version, but optically I see some deficits as well. Apropos: I never received a download link for the update to 012 by mail. Or do I have to buy a new license?
  24. I can only speak for myself. But I feel the same way. I bought the Media Manager, but never used it. Once I used it in a customer project, I had feedback from the customers that the visualization and usability was not good for them. Personally, I'm also a little bothered by that. Why have I never submitted this as a suggestion for improvement? You know: laziness. I always had the hope that others would do it and that there would be an update at some point. ?
×
×
  • Create New...