Jump to content

David Karich

Members
  • Posts

    180
  • Joined

  • Last visited

  • Days Won

    4

Everything posted by David Karich

  1. Horst, a very helpful module! Thank you. However, I miss a feature that would be helpful: cropFromCenter(width, height); - Resizing and cropping in the original aspect ratio The image is reduced first to the width or the height. If it does not fit into the new format, the image is automatically cropped from the middle of the image. Regards, David
  2. The generated code can be incorrect if your code is not written cleanly. A missing semicolon can already generate faulty code. Please inspect your script, for example, with jslint.com.
  3. Oh, no. This library has not yet come under my eyes. I'll be looking at this a bit more detail when I have more time again. Thanks for the tip. Yes, check again and let me know, because it is the identical function that is called. If there should be a bug, CSS should not work as well. If you were able to find something, then just open a ticket on Github.
  4. Hi adrian, for sure. JSMin is a little bit outdated and generates not the best compression result, but it is the only stable php port without any conditions to third party libraries. Some other minifications libraries destroyed the compressed js code and JSMin is the only one, with which I never had such a problem. Anyway, i'm thinking about, to integret the google closure compiler as an alternative third party service.
  5. The new version of our @processwire module AIOM+ has reached the stable state! Update to version 3.1.3 on http://mods.pw/5q

  6. Hey guys, i have released a new version of AIOM+. The update to version 3.1.3 includes a few improvements in the LESS parser and CSS minification. Also, I have set the status from AIOM+ to stable.
  7. The same here. Get the module not to work. The feed is loaded and cached, then crashes the Apache (WAMP environment, PHP 5.3.8 + Apache 2.2.22). In the error log (PHP, PW or Apache) there is no entry. Very kurrios. On the production server I have not tried it yet.
  8. I'm not really familiar with Node.js and I have no test environment. You're welcome to implement an alternative and send a pull request on GitHub. I think it requires only an option in the backend more and instead of PHP-based LESS parser an exec-command-line function call. The question is rather, the detour via PHP is really faster? Because you can embed the LESS files directly into the template and can render there via LESS.js or over the Node.js package. The Node.js package has a minimization option on board.
  9. I have the new version of AIOM+ uploaded (3.1.2). From this version it is now possible to disable the directory traversal filter. Also, the LESS parser was updated. Now compatible with the official LESS version 1.7.
  10. The easiest way is by infected third-party applications. Also on Bower or Composer, its possible, that compromised packages can be delivered. I have currently identified no scenario targeted at Process Wire, rather it is one of my personal programming rules. Just do not make it possible. Asset files belong in the template folder. This approach I have always in development, regardless of platform or environment. I have some clients who work with sensitive data, and the safety requirements are very high. Therefore, this is my natural data schizophrenia.
  11. Hi pwFoo, AIOM+ monitors each asset file on the modifikation time and generates a hash for the comparsion with the already cached files. If there exist no cached file, the first function call will trigger that process, but only for files, that are needed (first page load). The average overhead of an average webproject on shared hosting with 128 MB php_memory_limit are round 500 ms for generating, minimization, parsing and writing the cached files. That's at least my experience. The complete Bootstrap 3 source as LESS files is generated in under 3 seconds.
  12. Hi Jonathan , yes, in this function paths are filtered to prevent directory traversal attacks. AIOM+ loads only allowed files that are located in the template folder. I think about it, in one of the upcoming versions, introduce a whitelist for asset folder. For a workaround change the following line (749) in AllInOneMinify.module: $_path = str_ireplace(array('../', './', '%2e%2e%2f', '..%2F'), '', (wire('config')->paths->templates.$_file)); to $_path = wire('config')->paths->templates.$_file; I have not tested it and I can not recommend it too.
  13. Hi ceberlin, no, there is no option, because this ist not the target of a minimization. Every browser has an inspector or dev-tools in which you or your client can see the restructured DOM.
  14. Our @ProcessWire module AIOM+ has reached Version 3.1.1. with new feature: Conditional loading based on API selector. http://mods.pw/5q

  15. So, just before the weekend, I've uploaded a new version (3.1.1) that supports a new feature: Conditional loading. You can now assign CSS, LESS or JS files with an API-selector a condition at which they should be loaded. For example: <?php $stylesheets = array('css/reset.css', 'css/main.less', array('loadOn' => 'id|template=1002|1004|sitemap', // PW API selector 'files' => array('css/special.css', 'css/special-theme.less'))); ?> <link rel="stylesheet" type="text/css" href="<?php echo AIOM::CSS($stylesheets); ?>" />
  16. Thank you guys, for all the discussion and info, that either-or is coming and currently not supported. It has me in the morning at 4:00 clock a bit confused if I was just too tired, or it really does not work.
  17. Hey Pierre, I'm not really happy with Assetic for several reasons: Too many dependencies. Java-based YUI integeration. Many shared hosting do not offer Java support. Depending on the Google Closure API. I don't wanted to integrate any third party service. Node.js for LESS parser, because the PHP-ported version in Asettic is outdated and is no longer developed and supported. In summary, you could not just use AIOM+ as it is now – install and use. AIOM+ requires only PHP and is not dependent on another service or special server requirements.
  18. With all the other selectors I have no problems. Only with this special OR selector.
  19. Thank you Adrian, but I get the same error with this module. Respectively, if I adjust the selector (id|path%=1001|about): Error: Exception: Operator '%=' is not supported for 'id'
  20. Is that right, i can't select the path as an OR-option in find() or get()? For example: $_pages = wire('pages')->find('id|path=1001|/about/'); produce following error: Error: Exception: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'pages.path' in 'where clause' (in C:\wamp\www\Development\Processwire-Modules\PW-TESTING\wire\core\DatabaseQuery.php line 86) Same with ->get(); PHP: 5.3 and 5.5, PW version: 2.4
  21. AIOM+ now in Version 3.0.1 with a little but recommended fix in the Less parser. If a large LESS file is split by the parser, the following error occurs: Error: Class 'Less_Exception_Parser' not found (line 8795 of /site/modules/AllInOneMinify/lib/Less/Less.php) Issue found and submited by Ryan Pierce. Thanks.
  22. A truly inspiring work. I love the AJAX implementation.
  23. Good work! I like the color scheme for the classical theme.
  24. I think for websites and applications that are designed for desktop systems, domain sharding is still acute and helpful. For mobile-optimized sites, it is counterproductive. The DNS overhead, is however, in my experience, not in comparison with the cookie data. For large news portals I continued domain sharding in use.
  25. Thank you guys, for this great feedback. That make me happy. I do not think it's the best way, to integrate Autoprefixer in AIOM+. I think it's not good when the module changes the generated code, which can be difficult to understand. Makes it difficult for the troubleshooting. But I'll be looking at Autoprefixer. Maybe I can port the code to PHP. Currently i use LESS for that: .transition(@style) { -webkit-transition: @style; -moz-transition: @style; -o-transition: @style; -ms-transition: @style; transition: @style; } #element { .transition(all 0.2s ease); } Excellent suggestion! I'm still thinking about the syntax, but definitely write this function on the To-Do. Thank you.
×
×
  • Create New...