Module Inputfield ACE Extended

[bernhard]

hi @owzim i want to include your module in my kickstart module and found this issue on the uikit admin theme (full width font size input), would be great to get a fix for it  thanks

[bernhard]

hi @owzim me again with a more important request 

i opened a PR on github to trigger an "loaded" event after acefy() is done. would be great to include this in your module, thanks

 

[owzim]

On 1/3/2018 at 3:30 PM, bernhard said:

hi @owzim i want to include your module in my kickstart module and found this issue on the uikit admin theme (full width font size input), would be great to get a fix for it  thanks

Hi, unfortunately I currently have little resources for that. You are welcome to open a PR though.

[netcarver]

@owzim

Great to hear from you in the forums again. I think Bernhard already opened a PR for you.

[bernhard]

21 hours ago, netcarver said:

I think Bernhard already opened a PR for you.

nope, this was a pr for another thing and is already merged  

[netcarver]

Oops, I stand corrected.

[Autofahrn]

Just in case I am not the only one trying to use this great (thanks @owzim!) module inside a repeater with dynamic (AJAX) load of items, it indeed works using the "current" (Oct 2017) dev version along with a tiny fix in ace-extended.js:

The issue is, that acefy is invoked multiple times for the same inputfield, which finally seems to trash the JS engine. Just add two lines of code right before $textarea.each (in acefy):

		:
		//Fix: Avoid duplicate and recursive invocation of acefy
        if($textarea.hasClass(ACE_INITIALIZED_CLASS))
            return;
        $textarea.addClass(ACE_INITIALIZED_CLASS);    // Mark wrapper as initialized
        //FixEnd
        
        $textarea.each(function() {
		:

and add an appropriate initialization for ACE_INITIALIZED_CLASS at the head of the module:

        ACE_INITIALIZED_CLASS        = 'AceInitialized'

[pmichaelis]

Hey,

there is a deprecation notice when running php 8.3 🥸

Deprecated: Calling get_class() without arguments is deprecated in .../cache/FileCompiler/site/modules/InputfieldAceExtended/InputfieldAceExtended.module on line 499

The error "Deprecated: Calling get_class() without arguments is deprecated" occurs when using PHP 8.3 or later to call the get_class() function without providing an argument. 
This is because the function's arguments are now required. 

Call get_called_class(), which works similarly to get_class() but doesn't require arguments. 

public static function getStatic($name)
{
  $class  = get_called_class();
  return isset($class::$$name) ? $class::$$name : array();
}

[Macrura]

@pmichaelis thanks for the report.

ok let me see if i can make this change and commit soon, might take a couple of days.