Jump to content

Recommended Posts

Posted

I already said I liked it on Twitter.  :P

Teeny-tiny thing about the icons (I'm glad I'm not the last person on earth who uses icon fonts, BTW) – you could make the icon font icons a wee bit nicer for screen readers if you replace i.e.

<i class="icon-search"></i>

with

<span class="icon-search" aria-hidden="true"></span>

The i element is “text in an alternate voice” in HTML5, I'm not sure if screen readers react on that. The aria-hidden makes screen readers not read out the glyph used for the icon. However, if you use aria-hidden, you should also add a fallback text for screen readers to actually read …

<span class="icon-search" aria-hidden="true"></span><span class="screen-reader-text">Search</span>

… and hide that for visual browsers.

While I'm poking at the search, why not use type="search" for the input? Also, the search input is missing a label (again, just for screen readers, and it should probably be hidden for visual browsers as well.)

  • Like 1
Posted

very nice as always!

please correct me if i'm wrong, but i think it's not the best for SEO to have 2 domains showing exactly the same website (.com without /en = .de). maybe you could add a canonical link?

any opinions of the experts here? :)

Posted
please correct me if i'm wrong, but i think it's not the best for SEO to have 2 domains showing exactly the same website (.com without /en = .de). maybe you could add a canonical link?

You are right. But instead relying on a canonical I just used a PW solution:

if($config->httpHost == "aureliusinvest.com"){
    $english = $languages->get("en");
    if($page->viewable($english) && $page->url != $page->localUrl($english)){
        $session->redirect($page->localUrl($english));
    }
}

Basically: If user accesses the site with the .com domain I check if there is an english version of that site and redirect to that one. Only if the current page isn't already the right one. Since session redirects are 301 by default, Google should index correctly.

  • Like 3
Posted

Great Work.

Nice design. Clean, simple, but not boring at all.

Even it's when "just" content, I think the handling with all the data isn't done in a few minutes. ;)

  • Like 1
Posted

Very nice, bookmarked as best-practice example.

Did you do the whole thing, design, coding, ia etc.? Or is this the work of a team?

  • Like 1

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...