Jump to content

adrian

PW-Moderators
 View Profile  See their activity

  • Posts

    10,902

  • Joined

  • Last visited

  • Days Won

    349

 Content Type 

Everything posted by adrian

  1. adrian

    Client Login

    adrian replied to kaz's topic in General Support

    These might help: https://processwire.com/modules/password-force-change/ https://processwire.com/modules/email-new-user/
  2. adrian
    Would you mind adding this to the Github requests repo? I'd do it, but I feel like I've added so many requests and issue lately that Ryan is starting to tune me out ?
  3. adrian
    Yeah, I understand the reasons - it's a shame PW doesn't have a dedicated endpoint that is automatically available on all installs so we don't have to deal with hacking into 404. I have wished for something like this many times - I wonder if maybe it should be a feature request?
  4. adrian
    Sure, that works, but I am talking about direct affiliate links - sites often have mysite.com/davidk without any preceding segment to define what it is. I kinda find this practice a bit weird, but it seems pretty common.
  5. adrian
    @David Karich - defining URL segments does seem to fix all the issues. However, I am concerned about setups where the definition would allow matching "phcv1" - mine are specific enough at the moment, but I can see it being an issue, especially if you have a segment for catching incoming affiliate links, or something similar with one segment that allows any alphanumeric characters.
  6. adrian
    Hi @David Karich - thanks for all the follow up. I tried uninstalling / reinstalling again here, this time on my local dev setup, rather than my production server and no errors this time - I'll put this down to a random PW glitch. I see your point of view about the AJAX approach, although I still feel like it is less efficient than a direct call during page render, but I'm not too concerned about it. Now, regarding the important stuff - you're correct that the page's HTML is not returned when debug mode is off, but I'd still consider this a bug - I am pretty sure that it being returned is not your intention ? and it's annoying to deal with it when debug mode is on. Perhaps this module shouldn't be installed while a site is still in development (when debug mode is likely to be on), but I still think this should be fixed. I don't really understand your point about non-AJAX based requests not being processed further. I think you'll need to setup urlsegments with a required trailing slash and you'll see my point about the unnecessary 301 redirect - could be easily fixed by appending a trailing slash (if required) to your call to the /phcv1 path.
  7. adrian
    Sorry, on a related note, if the template's urlsegment trailing slash is set to "yes" to force a trailing slash, you end up with two calls, so the module needs to check this setting and adjust the path accordingly. FYI - the reason I have that setting forcing the trailing slash is because I have urlsegments and pagination both turned on, and without it, URLs can end up broken.
  8. adrian
    @David Karich - on the issue of the AJAX call from the js file - turns out if you have url segments enabled for a template, when you view a page, the entire page's html is included in the response and sent to the browser along with the "Page Hit Counter: Tracked". I can workaround it by adding: if($config->ajax && $input->urlSegment1 == 'phcv1') exit; to _init.php, but I think there needs to be a more elegant solution ? I have read your section about "Notice: Tracking with URL segments", but I don't think that is really the issue here. I haven't defined my urlsegments yet (I will before the site goes live), but I don't think that will prevent this issue, will it? Any thoughts?
  9. adrian
    @Macrura - I haven't used this before, but just tried on a PW latest dev install and I am seeing this browser error: selectize.js:2230 Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'. at Selectize.refreshOptions (selectize.js:2230) at Selectize.onFocus (selectize.js:1752) at selectize.js:2088 Please let me know if you have problems reproducing and I'll dig a little deeper. Thanks.
  10. adrian
    Hi @David Karich - thanks very much for this. I just noticed that if you uninstall and reinstall, you get an SQL error because it's trying to create a table that already exists, so either the uninstall didn't clean things up properly (if that is the intention), or the install process needs to check to see if it already exists. Also, just wondering if the AJAX approach could be reserved for sites running ProCache? Is there a need otherwise for doing it this way, rather than hooking on page render? There's a good chance I am overlooking something, but just thought I'd ask. Another thought - have you considered a way for us to easily extend this to log click events to track users viewing PDFs etc? Maybe this really doesn't belong within this module and should be kept as something we implement on a case-by-case basis?
  11. adrian
    @teppo - your first description is all I am really looking for. Obviously the second would be great, but I expect impossible with PW selectors.
  12. adrian
    Thanks @teppo - looking forward to seeing all these new features. I have another one for you ? Whenever I build a search engine I emulate Google's "search phrase" use of double quotes to effectively switch from ~= to *= Would you be willing to support something like that also?
  13. adrian
    @Robin S - I have been using this module since it was released and always thought it was a necessary tool for inserting Hanna codes, but I just starting using some of its other features like: linked_page__pagelistselect which makes it an entirely new beast - amazing. Thanks!
  14. adrian
    Running Firefox Developer version on MACOS here and can't seem to make it fail - tried multiple pages, multiple times. Maybe you could debug for me? When the single click scroll doesn't work, does the double-click to open settings also fail? I wonder if the JS that hacks into that button isn't loading at the right time after the button is rendered? I'll make the gear icons lighter in the next version.
  15. adrian
    @szabesz - I've taken care of most of your requests. The only ones I haven't done are the separate front/back end visibility for the various server type indicators - this will actually be quite a bit of work which I don't have time for at the moment. The other thing I didn't change is making those checkboxes into columns for those panels you mentioned - the problem is not just the responsive issues, but more importantly, it's that it messes with the order of checkboxes - they end up going across the rows, rather than down the columns which is actually pretty awful. Anyway, let me know if all the other stuff works as you'd hoped, including the scroll to top ?
  16. adrian
    @szabesz - thanks for your thoughts on the settings. One problem with setting those checkboxes to use columns is this: https://github.com/processwire/processwire-issues/issues/1327 Regarding the quicklinks being in alphabetical order. I kinda agree with you, but I @Robin S thought the matching the order of the settings was better. I'd be willing to change, but given that this is his feature, I'd like his OK first. There are direct links to settings at the bottom left of each panel. I think that is probably enough, but I could consider adding them to the Panel Selector as well if you still think it would be helpful. Not sure about the scroll to top button - it feels a bit out of place in Tracy, but I'll think it over. I'll also have a think about the server type indicator frontend/backend changes - that seems like a good idea.
  17. adrian
    @salmiak - did you see my suggestion above for incorporating monolog into Tracy? It might be the simplest option. If you go with a separate module, perhaps hooking into Wire::trackException might be of use?
  18. adrian
    Yep, it's Tracy - it's designed to give you a visual indicator as to whether you're working on a live, local, dev, staging etc version of the site. It is configurable to work with subdomains or TLDs. Take a look at the "Server Type Indicator" section in Tracy's settings. I find this really invaluable, but I know that @kongondo hates it ? Anyway, you can easily disable it if you want, but note that of course it's only visible to users with Tracy permissions, so visitors to the site won't see it.
  19. adrian
    Sorry, one more thought on the template search priority order. I think it would be great to have an option so that the template of the current page (and it's child page's template) were automatically given higher priority over the order set in the config settings. Or some other way to specify the order of priority depending on the page being searched from.
  20. adrian
    Just to give you a simple example of why I think this is a must-have feature. I am working on a site where the staff are mentioned in blog posts, but obviously if a user types in the person's name, the first result they want to see is the staff member's info page, rather than the blog posts that mention them. Awesome - I'll hold off on doing this myself.
  21. adrian
    Thanks for the explanation @teppo - I started to realize how it works as I played around with things. I like your initial thinking, although I do think it's slightly confusing, but I also don't think it's worth your time to reconfigure. I have another feature request for you ? I know I could do this if I went with the json rendering of results and then manipulating and rendering myself, but I think it would be great if the "Indexed Templates" config setting was an ASM Select field so we could choose template order. I'd love to see this template order used to group and order the rendered search results. I think it would be nice to have the option for using the template label to add group headings to the results. It would also be good to have an option for presenting these template grouped results into different tabs - a bit like the PW website's search results. Actually, speaking of the PW website search functionality, maybe adding an automatic option for AJAX rendering of results below the search box would also be nice. I know all of these are possible with manual rendering, but I think we could all benefit from an inbuilt implementation. BTW, this module really is awesome - thank you!
  22. adrian
    Yeah, I agree - I was confused by that when I was setting that stuff up in Tracy.
  23. adrian
    Sorry @teppo - another question / request for you - what do you think about being able to store theme folders in /site/templates/SearchEngine/themes to avoid any issues with overwriting during updates, and also so it's cleaner for version control?
  24. adrian
    Sorry if I'm being dumb, but when I went to set the 'form_action' argument, I assumed it needed to be an element within the 'render_args' array, but if I do that, it doesn't work. It does work if I set it at the top level of the args/options array that I am passing to the renderForm() method though. If I dump $args without setting this, I see it is at the top level. Did you change something intentionally since writing the docs, or am I just confused ?
  25. adrian
    Weird thing is that I don't think I have seen those errors in Tracy which uses getQuery() and getDebugQuery() https://github.com/adrianbj/TracyDebugger/blob/116324264c3d566c1cece8c53cc3a1075ca82862/panels/DebugModePanel.php#L232-L239
×
×
  • Create New...