Jump to content

adrian

PW-Moderators
  • Posts

    11,213
  • Joined

  • Last visited

  • Days Won

    373

Everything posted by adrian

  1. Thanks for the report @Macrura - I have a fix in place here and I'll commit later today or tomorrow - just in the middle of some much larger changes.
  2. Hi @Lutz Heckelmann - welcome to the forums! Thanks for a useful first post I have taken care of the first two thing locally (slightly different solution for #2), but I am having trouble reproducing #3. Any chance you could do a field export on the table field and also send me an example file to import so I can test. I understand what you are getting at, but I thought that the if($fieldValue != '') check was taking care of it. I can kinda see why it wouldn't but I'd still really like to reproduce the problem so I can be certain of the solution. Thanks.
  3. PS - I decided to see what Ryan thinks: https://github.com/processwire/processwire-issues/issues/459
  4. Hi @matjazp - I discovered a bug when you have blank lines at the top of your file. Because you are using a PW InputfieldTextarea, the blank lines at the top are trimmed, here: https://github.com/processwire/processwire/blob/aa1f7dbd4718532896e209d694db0340c2d30067/wire/modules/Inputfield/InputfieldTextarea.module#L119 The problem is that when you save, these lines are removed. This probably won't ever cause any issues, but I don't think it's polite behavior for this to happen unexpectedly. The other issue relates to my new feature in Tracy which allows opening up errors/files to an exact line number - the line number can be off because of this bug. I actually wonder whether maybe the PW textarea shouldn't do that in the first place. What do you think? I think blank lines at the top should be valid? If you think this is a PW bug, or if you think there should be an option to not remove them, I'll file it with Ryan. Otherwise, maybe ProcessFileEdit needs to use a standard manually coded textarea. Any thoughts?
  5. I think it's an oversight that should be fixed - I think you should post a Github issue for Ryan to think about. He may not agree but I think that is the best way forward.
  6. I agree that it should sort this out itself, but just so you know, a Modules > Refresh is the correct way to fix this. As for clearing caches in general, take a look at: https://github.com/somatonic/ClearCacheAdmin - much more elegant than just deleting that table.
  7. Do you have the config setting for the snippet runner pointing to the correct folder - remember there are two options?
  8. Hey @tpr - I just noticed that AOS removes the 3px border radius on Page List Action buttons. Is there a particular reason for this? Is it just a stylistic choice on your part, or a remnant of some old code? No big deal, just thought I'd ask
  9. I am tempted to add this to Tracy
  10. I know this post is ancient, but I went to use Migrator today and experienced the same problem. I have committed a fix that seems to be working fine. If you or anyone else is still interested in this module, please let me know how the new version goes. I am still not certain about the future of this module, especially now that the PW core has template, field, and page export/import, but to be honest I think Migrator currently handles more field types and of course has the added benefit of dealing with field, templates, and pages as one entity and takes care of them all for you. I am curious if others have used the core import/export features and how successful they've been and whether you'd still prefer and all-in-one solution like Migrator and whether you'd consider paying for it. I think I would want to do a considerable rewrite if I went this route, but I am really not sure what the demand is.
  11. Not sure how to handle this (or how important it is), but if a repo has commits that are not tagged with a release, they don't show up anywhere in the "What's Changed". For example I have committed several updates to Tracy that are all about documentation and none of these commits are listed even though they will be included in the user's download if they upgrade. In this case it's fine because none of these affect functionality. What if a dev committed a breaking change but forgot to tag the commit? Should there simply be a warning that there are untagged commits since the last tagged one so you know to take a look on Github, or should those commit log entries be listed above the tagged commits? Any thoughts?
  12. @heldercervantes https://github.com/simple-icons/simple-icons/blob/develop/icons/processwire.svg
  13. Minor change of plan. The ReadMe was going to be too long for the entry in the modules directory and also the TOC links didn't work there, so I have moved the docs into DOCUMENTATION.md and @netcarver has committed a change to ModuleReleaseNotes (which if you don't have, you should get) so that this DOCUMENTATION.md will now be displayed in the module settings, like this: I think I am really happy with this approach! Once the docs are more comprehensively populated, I will adjust the links from the Selector panel info icons to point to the appropriate panel info here, rather than the old blog post.
  14. I thought about that, but I think without a way to link from one file to another it would actually be a poorer experience in my use case, but I'll keep it in mind as the docs start to flesh out - they could end up quite large
  15. Ok, @szabesz, @bernhard and anyone else who is interested I have started populating the ReadMe with documentation (https://github.com/adrianbj/TracyDebugger). I have made a start on the Table of Contents (TOC) and done a quick population of some content for Captain Hook and the Console. Basically just copied from the original Tracy blog post at the moment. The TOC links work on Github, but unfortunately they don't work in @netcarver's Module Release Notes, but I doubt there is anything that can be done about that. CTRL/CMD+F always works fine though. I might spend some more time today fleshing things out a little more, but I would really love some help populating these docs if anyone feels motivated - PR's gratefully accepted
  16. Let's take this to PM to avoid spamming all the followers here
  17. You still haven't clicked on the Network tab. I still think you should try the 0777 because I think that's very likely the problem.
  18. Ok, sorry, I jumped to a quick conclusion there I think the key error in the console is the 403 - I think that is likely the file permission issue. If you go to the Network tab and reload the page, hopefully you can see the file that is not being loaded. This comes back to my file permission request. Can you temporarily set all files in /site/modules/TracyDebugger to 0777 so we can see if that is the issue. Obviously we'll sort out properly after that.
  19. What happens when you click the icon to maximize it
  20. That setting doesn't affect Tracy's behavior, but if Tracy isn't working it will provide info that you wouldn't have otherwise. Let me know how you go with reinstalling, or looking at those bullet points.
  21. @ryanC Do you have PW's debug mode on? Any php errors being displayed or logged? Any errors on the dev console's Network tab regarding Tracy files not being loaded? Any issues with file permissions on the files within the Tracy folder after moving to new site? Any files missing from the Tracy folder? Can you replace with a fresh set from Github?
  22. Try the purify() sanitizer. Also, in the Tracy Console, check out the testAll() sanitizer - very handy! d($sanitizer->testAll($str)):
  23. @bernhard - the problem with the wiki is that you can't do a PR, which is why I went with Github pages (as discussed in the Tracy thread). The problem with Guthub pages is that don't support custom jekyll templates so you can't have a sidebar, which is really annoying. I could code up a page from scratch, but then we're getting into more work again. Honestly I am thinking about just putting all the docs in the ReadMe - that way they would also be available via @netcarver's module release notes. I would store the screenshot images in the /docs/ folder because I have that excluded via .gitattributes so the download would still be light, but the ReadMe within PW would looks really nice. Also, really easy to accept PRs for changes to the ReadMe file.
  24. I think it's probably just because the changelog file for wireMailSMTP uses + 0.3.0 fixed code that broke backward compatibility for PW 2.4 and 2.5, brought in with the config cosmetics (0.2.6) + 0.2.7 @abdus fixed smtp password not saving whereas other modules seem to use: ### 1.7.0 (2017-12-12) - fix suppressing the "required" icon in the template editor (by reported by Robin S) ### 1.6.9 (2017-12-12) - PR merge: Different size buttons when editing a page #80 (by gmclelland) Yep, looks great now - thanks!
  25. Absolutely - the best way to learn something is when you have to teach it to someone else!
×
×
  • Create New...