Jump to content

adrian

PW-Moderators
 View Profile  See their activity

  • Posts

    11,213

  • Joined

  • Last visited

  • Days Won

    373

 Content Type 

Everything posted by adrian

  1. adrian
    @Robin S - I don't want to hijack @horst's thread here much more, but I think we are basically in agreement. My desire for custom permissions for superusers wouldn't be needed if we could assign some currently superuser only permissions to other roles. I think basically there is a level of control here that is currently missing and there are different ways of tackling it - the problem is that the one option we had (adding permissions to the superuser role) is now gone. I guess the workaround is to change these custom "permissions" to "roles". So for ALIF, horst could require a user has the "alif-user-account-switcher" role.
  2. adrian
    @horst - this is the issue that led to that change: https://github.com/processwire/processwire-issues/issues/371 I actually don't like the result - I think it's a reasonable scenario to add additional permissions to the superuser role and do an actual check for these. I use the same technique in Tracy, which I guess is also broken now.
  3. adrian
    Just an FYI, that a recent change to the core might make this impossible to do via the admin: https://github.com/processwire/processwire/commit/7943aa1064204db5415d661312037f1dd4199249
  4. adrian
    I just tested like this (clicked on the "Child Tab" link in the console results) and it works fine so long as I am not already on the page that is linked to.
  5. adrian
    Latest available on Github (and what you'll get if you upgrade), but not actually the latest, necessarily. I am actually confused by the changelog in AOS - the dates for 1.6.71 a 1.6.7.2 are out of order - but again, this really is an unusual situation. Anyway, I really wouldn't worry too much about any of this - it was really just meant as an example of things to look out for - I don't really think anything needs changing.
  6. adrian
    Not sure it's quite right, but what about "Upgrade to:" as the label? Or some other way to highlight it as what you'll be upgrading to, rather than it being the latest available?
  7. adrian
    Maybe the "Latest" tag isn't needed? Perhaps all that is relevant is the "Installed" tag. The issue with AOS is a mistaken version number 1.6.71 (I think @tpr intended 1.6.7.1). The more likely scenario is what you described where you might have a version that is newer, but not published yet - that can happen relatively often.
  8. adrian
    You're right, it was Tracy (not ModuleSettingsImportExport) that was the problem - I knew I had fixed that issue recently, but forgot in which module Again, sorry for the hassle with this!
  9. adrian
    I don't remember how it was before, but is this what you are expecting in this scenario? I actually think it probably is the right way to go, but just wanting to make sure you had seen this issue with AOS.
  10. adrian
    @flydev - are you running the latest version of ModuleSetttingsImportExport? There was a bug that caused this in older version - sorry about that!
  11. adrian
    Have you tried without the trailing comma?
  12. adrian
    Hey @Macrura - it might be worth describing how you are defining the matches and if it's the custom PHP code option, then post that. I have used this module without any problems, but I haven't pushed it with complex matching.
  13. adrian
    This forum is just an IPBoard forum - no PW code or use of this module. Good thought though
  14. adrian
    I haven't tested, but youtube.be should work: https://github.com/ryancramerdesign/TextformatterVideoEmbed/blob/7c8e4ddce22dc4970c17d0f63ce3d53679e7e3a8/TextformatterVideoEmbed.module#L163 Here's it working as expected: https://regex101.com/r/aEcLl2/1
  15. adrian
    Hi @mel47 - thanks for raising the issue here, but let's continue it in the FormBuilder thread where we will get more of Ryan's input
  16. adrian
    Here's the code block: https://github.com/processwire/processwire/blob/57b297fd1d828961b20ef29782012f75957d6886/wire/modules/Process/ProcessModule/ProcessModule.module#L309-L327 In case you don't know, it is called when you do a Modules > Refresh
  17. adrian
    Looks like this should be fixed now: https://github.com/processwire/processwire/commit/337e59663ba17af1083bd91edbb9a3a051da8994
  18. adrian
    Hi @rick - maybe take a look at ProcessAdminActions which uses tabs. See how I add the wireTabs class to an InputfieldWrapper https://github.com/adrianbj/ProcessAdminActions/blob/f85e537f72fdfce299cf0c2c22366a290049f664/ProcessAdminActions.module#L337-L340
  19. adrian
    Great looking site, but clicking the images doesn't work for me:
  20. adrian
    I haven't looked into why, but it's weird to me that the first option doesn't work. Maybe it would be ok with !== but that would make it more strict, so not sure. But glad you have it working
  21. adrian
    Good suggestion - I have actually used this module (slightly modified) on the frontend - works great!
  22. adrian
    For reference for other who come across this and don't see the github issue: https://github.com/processwire/processwire-issues/issues/434#issuecomment-345437293 Ryan talks about the uncacheAll issue and how to deal with it.
  23. adrian
    Makes sense - tricky because you are adding a repeater item. I am sure there is a fix, but really have to go now Have a read of this: https://processwire.com/talk/topic/315-run-code-after-page-save/?do=findComment&comment=2206 - might put you on the right track!
  24. adrian
    I haven't followed closely, but please try: $p->save('text'); Or something like that depending on what field(s) you are trying to save. Sorry, I should probably look at this more thoroughly, but not enough time Saving the entire page in a save hook will always cause problems because of recursion.
  25. adrian
    Some discussion on this and using listable() https://github.com/ryancramerdesign/ProcessWire/issues/302
×
×
  • Create New...