Jump to content

Imagemarker positioning off after update to latest WP Core (3.0.200)


cosmicsafari
 Share

Recommended Posts

Hi all,

Not sure if this is the correct place for this question but as it pertains to the Image Marker module, I thought this might make sense.

For some context, we had been using the module with a few custom changes for a couple years at this point. However for our needs we had to remove the int casting within the code, and updated the DB columns for the X & Y coordinates to be more precise.

This was working fine up until recently when we noticed that the pins where moving slightly after having been positioned and then saved.

The only thing we have changed in that time was upgrading the WP Core, and im curious if anyone is aware of any changes that would effect the rounding in this scenario?

I could be wrong but from, sticking in a bunch of custom logging, I was able to follow the process to see at which point the rounding is occuring.

If im understanding things correctly, it looks its occuring between sleepValue() and wakeupValue() based on this logging output.

I have looked through the module files and can find no more instances of int casting or rounding, so im at the point now where im wondering if its actually the updated core thats contributting to this rounding, as sleepValue and wakeupValue are extendable if I understand things correctly, so presumably theres some element of the core coming into play with them?

I should also mention, that I have tried changing the DB columns to use DECIMAL, FLOAT & DOUBLE datatypes but all result in the same odd rounding down to the nearest whole number.

I'm convinced its not mysql doing the rounding, as I can manually enter the values no problem using Sequel Pro, but it always rounds down when saved via the CMS.

Any thoughts or ideas would be much appreciated.

image.thumb.png.aa54b523681b1916d9856928f327b3e2.png

 

 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...