solved Multi-Language support broken in dev-branch

[interrobang]

I just installed the latest dev branch from github on my local mamp server and wanted to add the german language pack to the default language. The files uploaded, but no translated phrases are detected.

This just happens with the dev branch, with the master branch everything works like expected.

[ryan]

I tried it out here (with the German language pack) and found a notice being thrown with the parser (when in debug mode). I went ahead and fixed that, but kind of doubt this would prevent it from working since the parser is only involved in the interactive translation process. German seems to be working on the dev branch here. Just in case, do you want to try and grab the latest version of the dev branch and try again?

[interrobang]

I tried again with the latest dev branch, but it still doesn't seem to work. When I try to edit any of the json files in the backend I get this error:

TemplateFile: Unable to load textdomain

#0 [internal function]: ProcessLanguageTranslator->___executeEdit()

#1 /htdocs/wire/core/Wire.php(271): call_user_func_array(Array, Array)

#2 /htdocs/wire/core/Wire.php(229): Wire->runHooks('executeEdit', Array)

#3 /htdocs/wire/core/ProcessController.php(194): Wire->__call('executeEdit', Array)

#4 /htdocs/wire/core/ProcessController.php(194): ProcessLanguageTranslator->executeEdit()

#5 [internal function]: ProcessController->___execute()

#6 /htdocs/wire/core/Wire.php(271): call_user_func_array(Array, Array)

#7 /htdocs/wire/core/Wire.php(229): Wire->runHooks('execute', Array)

#8 /htdocs/wire/core/admin.php(45): Wire->__call('execute', Array)

#9 /htdocs/wire/core/admin.php(45): ProcessController->execute()

#10 /htdocs/wire/templates-admin/controller.php(13): require('/Users/philipp/...')

#11 /htdocs/site/templates/admin.php(13): require('/Users/philipp/...')

#12 /htdocs/wire/core/TemplateFile.php(92): require('/Users/philipp/...')

#13 [internal function]: TemplateFile->___render()

#14 /htdocs/wire/core/Wire.php(271): call_user_func_array(Array, Array)

#15 /htdocs/wire/core/Wire.php(229): Wire->runHooks('render', Array)

#16 /htdocs/wire/modules/PageRender.module(240): Wire->__call('render', Array)

#17 /htdocs/wire/modules/PageRender.module(240): TemplateFile->render()

#18 [internal function]: PageRender->___renderPage(Object(HookEvent))

#19 /htdocs/wire/core/Wire.php(271): call_user_func_array(Array, Array)

#20 /htdocs/wire/core/Wire.php(229): Wire->runHooks('renderPage', Array)

#21 /htdocs/wire/core/Wire.php(293): Wire->__call('renderPage', Array)

#22 /htdocs/wire/core/Wire.php(293): PageRender->renderPage(Object(HookEvent))

#23 /htdocs/wire/core/Wire.php(229): Wire->runHooks('render', Array)

#24 /htdocs/wire/modules/Process/ProcessPageView.module(98): Wire->__call('render', Array)

#25 /htdocs/wire/modules/Process/ProcessPageView.module(98): Page->render()

#26 [internal function]: ProcessPageView->___execute()

#27 /htdocs/wire/core/Wire.php(271): call_user_func_array(Array, Array)

#28 /htdocs/wire/core/Wire.php(229): Wire->runHooks('execute', Array)

#29 /htdocs/index.php(192): Wire->__call('execute', Array)

#30 /htdocs/index.php(192): ProcessPageView->execute()

#31 {main}

EDIT:

If I first install the master branch and install the language pack there, and update to the dev branch by replacing the wire folder everything seems to work. I can even add new languages.

EDIT 2:

It seems to be related to pagefileSecure. If I set this setting to false, uploading languages works without problems.

[ryan]

Thanks! That helped me to track it down. It should be fixed now in the latest commit to the dev branch.

[interrobang]

I tested it again with the latest dev branch and it works here like expected. Thanks for the quick fix.

And the previously overlaying icons in the debug accordion headers are gone too!