Page::changed hook not called

[gebeer]

Hello,

I read about conditional hooks and wanted to utilize them. In the process of trying to implement them I found that they do not get called.

So I reduced my hook to a minimum

wire()->addHookAfter('Page::changed', function($event) {

	die('changed');

});

And nothing happens at all. Also with Page::changed(title) or Page(template=basic-page)::changed(title) no luck.

In the code comment in Wire.php it says: "Hookable method that is called whenever a property has changed while change tracking is enabled"

I see that change tracking is enabled as

wire()->addHookAfter('Pages::saveReady', function($event) {

	if($event->arguments[0]->isChanged('title')) die('changed');

});

is working.

The hookable method ___changed() in Wire.php is empty.

I tried this on 2 different installs PW 3.0.61 and 3.0.62

Can anyone please confirm or let me know if I'm doing anything wrong here. Thank you.

[Robin S]

It looks to me like there is a typo in the core code that means the Wire::changed method is never called.

See here...

if(($hooks && $hooks->isHooked('changed')) || !$hooks) {

But the phpDoc comments for WireHooks::isHooked say...

* If checking for a hooked method, it should be in the form `Class::method()` or `method()` (with parenthesis).

So it should have been...

if(($hooks && $hooks->isHooked('changed()')) || !$hooks) {

...and if you change to that then the hook starts firing.

@gebeer, will you open a GitHub issue for this?

[gebeer]

@Robin S thank you for looking into this. I can confirm that after making the change to Wir.php the hook fires. I will open an issue.

EDIT: added issue on github