-
Posts
10,896 -
Joined
-
Last visited
-
Days Won
348
Everything posted by adrian
-
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
Looks like that is happening because you are turning off outputformatting after doing the deleteAll(). Do it beforehand and things should be fine. -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
Sorry, I'm not sure then - it's working here. I think perhaps you need to do some debugging at your end to make sure the unlink call is actually being made and also clarify that $file->filename contains the full path to the csv file. Also, try: $this->wire('files')->unlink('/fullpath/site/assets/files/1443/file.csv'); in the Tracy console just to test this in isolation. If that doesn't work, try a regular php unlink and if that doesn't work, check to make sure there aren't any file permission issues. -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
@fruid - this works: $this->wire('files')->unlink($file->filename); but the problem is that in your example, your code never gets here because you have "return true" or "return false" in the if/else above this point. I simplified things right down so obviously this doesn't handle the processing of the CSV file, but this is basically what you want so that you are unlinking before returning true. protected function executeAction($options) { $parent = ''; $parent_title = ''; $url = config()->paths->assets.'cache/AdminActions/'; if(count($options['csv_upload'])) { $n = 0; $file = $options['csv_upload']->first(); $fp = fopen($file->filename, 'r'); fclose($fp); $this->wire('files')->unlink($file->filename); return true; } else { $this->failureMessage = 'Please upload a CSV file'; return false; } } -
admin action: loop through .csv file rows but when done unlink this file
adrian replied to froot's topic in API & Templates
@fruid - can you please post the entire code for your action - should be an easy fix, but will be simpler if I have everything to test things. -
We sort of have this already - take a look at the Custom Links section of the settings for the Processwire Info panel. You can add links to any page on the site, including items under Admin > Setup. Of course this doesn't allow for external links. For external links, I could add an additional settings field for storing these, or we could go with a separate Shortcuts Panel. Semantically it would be strange having external links under the PW Info panel, but maybe that's OK? Any thoughts? Also, just to let you know, that these links are actually stored as relative paths, rather than page IDs so that you can copy/paste Tracy's settings via my ModuleSettingsImportExport module and have them work on another site. Also, the appropriate icon is also automatically used. Note I have teppo's Changlelog, MikeRocketts's Jumplinks and ryan's Upgrades linked to, in addition to the default links which are added when Tracy is installed.
-
Hi @Robin S - thanks for your work on that - I really like that actually. I wonder if that's enough on its own, or whether we should combine with the @Pixrael's option for integrating the search/filter box as well? What does everyone think? What do you think about the Perfmon Debug Toolbar that @netcarver mentioned. I just installed it again to take a look. Note that you'll need to fix the order of the arguments in the implode() on line 187 to get things working, but otherwise it seems like everything is still OK. Does it do what you are looking for, or is there other / different info you'd like to see? Even with this, I'd still be willing to add something similar to Tracy. There is also of course Ryan's ProDevTools Profiler.
-
Chances are you already have too many browser extensions installed to fit - the last one on the right will let you access the hidden ones.
-
@Pixrael - that actually seems to work really nicely - thank you. You've probably noticed that I have implemented @tpr's excellent Filterbox (https://github.com/rolandtoth/FilterBox) in several of the panels in Tracy and I had been wondering how well it might work for the module settings. I might still take a look at that first (since I am already using it), but Jetbox does seem pretty slick and your Tampermonkey example worked a treat. I wonder if @Robin S and @szabesz would mind testing with it as well to get their thoughts on whether this would be a good approach. At the moment I only tested with the current layout with all fieldsets opened, but I feel like it might be more useful if it also works when the fieldsets are loaded in a collapsed state - this is where things could really be cleaned up. Anyone else have any thoughts?
-
Custom fields support for file and image fields: misinformation?
adrian replied to Mike-it's topic in General Support
As @Robin S noted in the post that @3fingers linked to - that example is a Page reference field. I just recreated that here and it works as expected: A little OT, but creating Page Reference fields is really quick and easy with: https://processwire.com/modules/process-page-field-select-creator/ -
Hi @Robin S and @szabesz - thanks for your input on this. This is going to be an interesting one because I actually don't like AOS's jumplinks for the reason that I can't use CTRL/CMD +F to find the setting I am looking for - I often have to enable/disable several sections before I find the one where the setting I am looking for is hiding. A tabbed interface would have the same issue. I feel like Tracy's approach to having everything open and displayed with those quick links (that are at the top of the settings) together with CTRL/CMD +F is actually pretty effective. There are also of course the direct settings links at the bottom of each debug bar panel which further helps to get you where you want to go. Of course this might be my bias because I already know the names of the settings so I know what to search for. With my thoughts out of the way, I have had enough comments over the years about how overwhelming the settings are that obviously I need to listen to you guys and improve things ? Robin - I have used tabs in module settings with AdminActions - I think it can be a nice interface, but in addition to my noted concerns above and your noted point about the tabs ending up over more than one line, some of the fieldset names (labels) are quite long - I can probably shorten many of these, but it is another issue to consider when using tabs. Stepping back a little - I wonder if we can solve some of the confusion by eliminating some settings - I have probably overdone things with settings that no-one will ever change. To be honest, I almost never change any settings beyond those in the first couple of fieldsets and the email address for error notifications on live sites. Maybe it would be best to have all the settings that are likely to be used by most people, open and up top and everything else in a collapsed "Advanced settings" fieldset. Maybe we need to do a bit of a survey to figure out what most users find themselves regularly changing and use that as a guide. On a side note, I often make use of https://processwire.com/modules/module-settings-import-export/ for copying settings between sites - maybe promoting that approach would also help? Any other approaches we should be thinking about? OT, but I am thinking that maybe this settings improvement feature request deserves to be split into its own thread. PS - Robin - I completely agree about the need to improve the styling of inactive tabs in th Uikit theme.
-
Great - thanks. One thing to note here is that it is of course possible for one of these superusers to go to Tracy's settings and uncheck that "Restrict superusers" checkbox, or even give themselves the "tracy-debugger" setting. I am guessing you don't really mind that because it's not that they aren't trusted, but rather you just don't want to confuse them with Tracy. Anyway, just something to be aware of in case you hadn't thought about it. That "tracy-debugger" permission has been around forever and already allows you to give non-superusers access to Tracy. The only restrictions by default are that they don't have access to these panels: Console, FileEditor, Adminer, Terminal, AdminTools. You can also restrict them further with the "Disabled panels for restricted users" setting.
-
Sorry if you already know this, but it's simple enough to point a subdomain to a different host / server so you can keep the current live site running on its existing host but point the dev subdomain to the new server. I am not saying this is the only or best way, but it's what I have always used and means no additional temporary domain costs. Remember I am talking about a "dev." subdomain and not a ".dev" TLD. I rely on Tracy's "Server type indicator" to give me a visual cue for which version of the site I am on - I find the favicon badge option really useful - I am sure it has saved me from making a mistake on several occasions.
-
Hi everyone, I have always wondered how you folks use Tracy. This will help me to focus in on future improvements and it might also highlight features to other users that they might have overlooked. In that spirit, feel free to add a second list of your favorite hidden gems - maybe you don't these very often but you still value them when the need arises. Thanks for your thoughts.
-
@Markus Thomas - I just tried on 3.0.170 and it worked fine. Not sure if there was a bug there for a while that was fixed, but it might be worth upgrading and trying again.
- 1 reply
-
- 2
-
Hi @Pete It was actually a bit fiddlier than I expected so I am going to hold off on committing the changes just yet, but can you please test the attached version for me? There is a new "Restrict superusers" checkbox in the settings. Check this and it will mean that you need to set up a new role with the "tracy-debugger" permission and add that role to your admin superuser account. All other superusers without this won't have access to Tracy. Please let me know how it goes. TracyDebugger.zip
-
Hi everyone, Thought I'd kick off this new dedicated support forum with a feature requests thread. Feel free to post your ideas for consideration. Cheers, Adrian
-
@Spiria - I am not certain, but it looks like you might be either using an older version of PW or of the SVG sanitizer module. Make sure you are using this version of the module: https://github.com/ryancramerdesign/FileValidatorSvgSanitizer and PW 3.0.167+
-
Thanks again for the report @Robin S - should be fixed now.
-
I expect you are trying to use $files inside a function or there is some other reason for it to be out of scope. Try: wire('files')->find()
-
I am talking about using dev as a subdomain, eg dev.mysite.com
-
I haven't registered either yet, but I am curious why you don't just use a "dev" subdomain for the development version of a site?
-
You're very welcome. Thanks for letting me know.
-
elseif ($today >= $start AND $today <= $end) echo " <span class='editor-label' style='margin: -7px 0 0 -7px;background-color:#db152e;'><span style='font-size: 10px;'>" . html_entity_decode(__('UNTIL')) . $end . "</span></span> "; You've got PHP shorttags inside an echo which is breaking things.
-
Hey @bernhard - that error comes from updating really, really old version of Tracy so it's not something anyone will normally see ?