-
Posts
2,321 -
Joined
-
Last visited
-
Days Won
44
Everything posted by tpr
-
Are you logged in with the same user? If you disable AOS it turns out, but here all the icons are showing up (Firefox, Chrome).
-
Thanks - actually the screenshot helped, you have debug mode on and that adds an extra item there. Replace line 45 in Hotkeys.js with this: $('#breadcrumbs a:not(.pw-panel):not([href="#"])').each(function (i) { @adrian I'm just generating the editurl/url for the current page and add the data-attributes with jQuery, which is not the smartest way I admit. Maybe this thing needs to be revised some day.
-
It works here in both themes - this is the snippet responsible for it (in Hotkeys.js): $('#breadcrumbs').on('click', 'a', function (e) { if ((e.metaKey || e.ctrlKey) && $(this).attr('data-editurl')) { e.preventDefault(); var url = $(this).attr('data-editurl'); window.location = url; } }); Do you see something wrong with it? If you type "ProcessWire.config.AOS_breadcrumbs" to the console and execute, you can see the array of objects for the breadcrumbs, perhaps there's something failing here.
-
Sometimes I feel I write the readme in vain Add long-click and ctrl+click actions to breadcrumbs: if enabled, long-click on a breadcrumb item will open the corresponding front-end page in a new tab/window, and holding the Ctrl key when clicking on them will navigate to their edit screen. I know it's not too user-friendly but it's there and working
-
Thanks - I guess you may run into issues because of the other closures, I'll refactor soon.
-
PagefieldPairs - Synchronize Pagefields between two different Pages
tpr replied to bernhard's topic in Modules/Plugins
Never mind! Practice makes perfect -
Just uploaded v104 that adds ctrl+u source mode toggle to CKEditors (CKEaddons keystrokes), plus a new CKEditor plugin Keep TextSelection. The latter works with the non-dialog source mode only (plugin limitation). Also contains bernhard's request to allow field edit links on non-pageedit pages, and a possible fix for the PHP 5.3.8 issue reported by @Noboru which is probably due to the missing support for closures - if so, I'll rewrite all of them in the module.
-
The edit field link is failing because I use a CSS selector "#ProcessPageEdit .aos_hasTooltip .title", so it is not applied to non-processpageedit type pages. I guess I can remove this limitation. The extra top seems to come from the Sticky CKEditor toolbar setting ON, but I couldn't reproduce. Could you find what CSS rule is causing this?
-
No idea why is that - could you replace "$this->config" to "wire('config')" in that line? Also what is the version of PW? If you can, could you check with a newer PHP? (eg if you can switch PHP version on the server via cPanel or other)
-
Could you show the exact line? In different versions the line could be other than in the latest.
-
I can't reproduce - are they still in the DOM or are they just invisible? Could you narrow it down to a certain submodule?
-
v102 contains the remove notice on ESC feature, now I'm experimenting with a grid view of asmLists: I think this could come handy on long lists, what do you think? I could add a button to toggle full width/grid view.
-
I've added a small tweak to close the notifications using the ESC key. This works on the very first keyup event only so it's for power users who want to close the notifications right after page load I used the admin only for a few minutes with this setting but I found it a very handy.
-
@Macrura Please check the latest version (v101) if that fixes it. I couldn't reproduce though but I saw it once in an earlier version. I tried it on reinstalling the module too (without the restore settings option).
-
Thanks, just updated a few Js files on GitHub/modules directory (no version change).
-
I would start with adding echo and exit() in site root index.php or (admin.php?) on various lines to see where it starts failing. If the echoes are shown and you reach the end of the file, move on to the next php file. Another issue could be htaccess. I would try to uncomment sections and see what happens.
-
v100 is up with the recent fixes/suggestions/requests: moved AdminLangSwitcher, noAnim, HoverDropdown, LangTabHotkeySwitcher, AdminColumns, AutosizeTextareas, TabIndex submodules into Misc submodule moved PageListUnselect submodule into PageListTweaks submodule added e.metaKey besides e.ctrlKey (suggested by adrian) separate CSS/JS for AOS configuration page (suggested by matjazp) do not load module CSS/JS when module is disabled flatModules: make "Add new module" section visible when clicking on "Add new" from sidebar/top menu (reported by adrian) force loading of longclick.js for moduleModal (reported by gmclelland) fix for invisible AsmList items on drag (reported by adrian) added hash navigation for module config page I moved non-configurable submodules into other submodules (mostly into Misc). You'll need to re-set them if you used them before. Hash navigation is not exactly working as expected so it may be removed later.
-
It seems that overflow-y: scroll; on the "body" causes this, interesting. It was there to avoid page jumps but as I see it's OK to add this to the "html" tag. Add new module: thanks, I've fixed that.
-
v0999 is up containing the requests posted above. - RenoTweak: fixed position of branding if sticky sidebar is on but sticky header is not - autofocus filterboxes only on module/template/field/translator list pages - do not add filter box for InputfieldTable (ProFields) - filter box: always show search icon - removed tap shift to focus main search (Hotkeys) @adrian Certainly it could, be where would the buttons (Save, etc) and the search field go then (in case of compact header)? Or do you meant it for non-compact-header mode only? Something like this could work, but there's a lot of combination that should be taken care of. I think if you need a compact header, then well... use the compact header I kinda like the header H1 as it is, it would be too compact this way.
-
Ok, I think the autofocus is could be easily added only to module/field/template edit pages. Sorry about the Reno search focus - it's the double shift (tap shift) that I have already planned to remove. At first it seemed a good idea but often failed when shift was kept pressed. The shortcut that triggers the focus is alt+d btw (Hotkeys).
-
@adrian I'll remove the filterbox or Tables then. Just tried and it doesn't work for me inside an ajax-loaded repeater, the Find link is there but does nothing. Just for the record AOS filter works neither As for the Lister I think filterbox is useful even if it filters the current set only. Btw, you can use the ctrl-right, ctrl-left buttons to go to the next set, and it will be filtered too. I know it's just a workaround but still better than nothing.
-
Oh, just looked at it more closer - I thought the branding means the logo only. I'll set it fixed.
-
I'm talking about this - the sticky branding won't help too much here I think. Anyway, it's not a big deal at all.
-
Thanks, its looking almost good, the tabs are also in a "compact" format if compactHeader is on. But it's in the wrong position, it's fixed in v0998. The new "real-time" tweak preview made it possible to quickly see the different combinations and find out what's wrong. Beforehands I had to save the module and check, then modify+re-check, it's much faster. I'm thinking to remove the sticky sidebar option but use it implicitly if sticky header is on. If sticky header is on but sticky sidebar is not, there's an extra space on top of the sidebar (reserved for the header when the page is scrolled to the top, not to cover the sidebar items).